[issue40852] Dictionary created with dict.fromkeys have issues (all explained in the file)

2020-06-03 Thread Jim Fasarakis-Hilliard


New submission from Jim Fasarakis-Hilliard :

This isn't an issue, `value` (that is, `{}` here) is shared among all keys. 
Since you've added a mutable value, when you mutate it this change is seen for 
all keys holding the value. 

This is documented in dict.fromkeys 
https://docs.python.org/3/library/stdtypes.html#dict.fromkeys

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker 
<https://bugs.python.org/issue40852>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40846] Misleading line in documentation

2020-06-02 Thread Jim Fasarakis-Hilliard


Jim Fasarakis-Hilliard  added the comment:

A simple substitution of 'types' with 'kind' should do it. This aligns with the 
terminology [1] used in the glossary.

[1] https://docs.python.org/3/glossary.html#term-parameter

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker 
<https://bugs.python.org/issue40846>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40838] inspect.getsourcefile documentation doesn't mention it can return None

2020-06-01 Thread Jim Fasarakis-Hilliard


Jim Fasarakis-Hilliard  added the comment:

For a more comprehensive list, we currently have for `get*` functions in 
`inspect`:

`inspect.getdoc`: Returns `None` if the documentation string isn't present, 
either directly on the object or through it mro. This *isn't* documented.

`inspect.getfile`: Explicitly seems to handle None cases. After peeking a bit 
in the `PyCode_*` interface, it doesn't seem to be possible to assign `None` to 
the `co_filename` so the returning the `object.co_filename` in the function 
appears to not be able to return `None`.

`inspect.getmodule`: Returns None in a number of cases. This *isn't* documented.

`inspect.getsourcefile`: Returns None if the filename indicates an extension 
module or when none of the ifs are matched. This *isn't* documented.

Some (getmodulename, getcomments) do document this. Agreed that the rest of the 
cases where `None`s might be returned should be documented.

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker 
<https://bugs.python.org/issue40838>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17005] Add a topological sort algorithm

2020-05-31 Thread Jim Fasarakis-Hilliard


Jim Fasarakis-Hilliard  added the comment:

Another option, `graphlib`[1], does exist on PyPI but is not maintained and 
currently read-only by the author. Other flavors[2][3] of the same name also 
don't seem to have much adoption so they shouldn't confuse if a name like 
`graphlib` was chosen.

[1] https://github.com/bruth/graphlib/
[2] https://github.com/MengLiuPurdue/graph_lib
[3] https://github.com/EmileTrotignon/GraphLib

--

___
Python tracker 
<https://bugs.python.org/issue17005>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17005] Add a topological sort algorithm

2020-05-31 Thread Jim Fasarakis-Hilliard


Jim Fasarakis-Hilliard  added the comment:

The downside I see with any graph prefixed names is the fact that it implies a 
larger collection of graph operations.

Add that to the fact that people might be more tempted to propose many  graph 
related algorithms/utilities to a module with the same name.

A more localized name solves that.

--

___
Python tracker 
<https://bugs.python.org/issue17005>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17005] Add a topological sort algorithm

2020-05-31 Thread Jim Fasarakis-Hilliard


Jim Fasarakis-Hilliard  added the comment:

It does seem out of place in functools, intensified by it's odd interjection 
among the other functools objects.

Considering heapq and bisect exist as standalone modules, the idea that 
topological sorting could go in its own module wouldn't be without precedent.

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker 
<https://bugs.python.org/issue17005>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38938] Possible performance improvement for heapq.merge()

2020-05-31 Thread Jim Fasarakis-Hilliard


Change by Jim Fasarakis-Hilliard :


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker 
<https://bugs.python.org/issue38938>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1635741] Py_Finalize() doesn't clear all Python objects at exit

2020-05-31 Thread Jim Fasarakis-Hilliard


Change by Jim Fasarakis-Hilliard :


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker 
<https://bugs.python.org/issue1635741>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5996] abstract class instantiable when subclassing built-in types

2020-05-01 Thread Jim Fasarakis-Hilliard


Change by Jim Fasarakis-Hilliard :


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker 
<https://bugs.python.org/issue5996>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10544] yield expression inside generator expression does nothing

2017-07-20 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue10544>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30600] Error message incorrect when index is called with keyword argument ("[].index(x=2)")

2017-06-09 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30600>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30570] issubclass segfaults on objects with weird __getattr__

2017-06-09 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30570>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30507] Elements reports it is a list on Element.remove

2017-05-31 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Thanks for the feedback, Raymond. I'll try to shift my focus on more pressing 
issues. (Closing as rejected)

--
resolution:  -> rejected
stage:  -> resolved
status: open -> closed

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30507>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26098] PEP 510: Specialize functions with guards

2017-05-29 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26098>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30507] Elements reports it is a list on Element.remove

2017-05-29 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +eli.bendersky, scoder

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30507>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30507] Elements reports it is a list on Element.remove

2017-05-29 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

Another splinter issue from issue13349. Currently, Element reports it's a list 
when remove is called on it:

from xml.etree.ElementTree import Element
Element('').remove(Element('')) 

ValueError: list.remove(x): x not in list

>From what I understand, this was done in order for it to conform with the 
>error reporting performed from the pure python implementation of Element. 
>(side note: These also differ regarding the type of value supplied to .remove, 
>the C implementation only wants instances of Element)

The message, imo, is confusing and should be changed to Element.remove(x): x 
not in Element.

--
components: Library (Lib)
messages: 294697
nosy: Jim Fasarakis-Hilliard
priority: normal
severity: normal
status: open
title: Elements reports it is a list on Element.remove
type: behavior
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30507>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30506] Replace 'list' with 'array' in array.remove and array.index

2017-05-29 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +1938

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30506>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30506] Replace 'list' with 'array' in array.remove and array.index

2017-05-29 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

Changes the error message for array.remove and array.index to say 
'array.(x): x not in array' instead of 'array.(x): x not 
in list'. 

This is a splinter issue of issue13349.

--
components: Library (Lib)
messages: 294689
nosy: Jim Fasarakis-Hilliard
priority: normal
severity: normal
status: open
title: Replace 'list' with 'array' in array.remove and array.index
type: behavior
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30506>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13349] Non-informative error message in index() and remove() functions

2017-05-28 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Thanks, I understand why this isn't the best idea now.

> shouldn't we change error messages that contains the repr of not found value? 

That is what I was thinking too, apart from removing the repr from other 
messages it will also unify reporting for all these methods.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13349>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30486] Allow setting cell value

2017-05-26 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30486>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

2017-05-26 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26280>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26219] implement per-opcode cache in ceval

2017-05-25 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26219>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30416] constant folding opens compiler to quadratic time hashing

2017-05-21 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30416>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9850] obsolete macpath module dangerously broken and should be removed

2017-05-15 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Great! Also, as Mariatta mentioned in a previous message, shouldn't an entry in 
PEP-4 be made?

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9850>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29950] Rename SlotWrapperType to WrapperDescriptorType

2017-05-13 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
stage:  -> resolved
status: open -> closed

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29950>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30178] Indent methods and attributes of MimeTypes class

2017-05-13 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

bump

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30178>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30230] Move quick test in PyObject_IsSubClass outside of PyType_CheckExact guard

2017-05-10 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

> he said, "I'm not sure if this was placed inside there due to some wild 
> edge-case,"

As a new contributor, I'll always lean on the side of me not seeing something 
rather than confidently stating that something is definitely wrong. I'm new, 
the code-base is 20 years old and worked on by a dozen of experienced devs :-)

>  Does a "Not-A-Class" class which is not a subclass of itself (issubclass(C, 
> C) returns False) makes any sense?

I'm not sure. Apart from the performance impact, there's a behavioral 
discrepancy between isinstance and issubclass as you also stated. 

In isinstance, __instancecheck__ doesn't *always* get a chance to override the 
behavior. The `if type(inst) == Cls` [1] stops it before it gets a chance. 
In issubclass, __subclasscheck__ does override it:

class Meta(type):
def __instancecheck__(self, other):
print("invoked")
return False
def __subclasscheck__(self, other):
print("invoked")
return False

class Cls(metaclass=Meta):
pass

isinstance(Cls(), Cls)
True

issubclass(Cls, Cls)
invoked
False

So, I guess the question might be re-framed to: Is it guaranteed that 
__instancecheck__ and __subclasscheck__ are *always* called?

If yes: PyObject_IsInstance should be tweaked.
If no:  PyObject_IsSubclass should be tweaked.

p.s Should I maybe move this to python-dev?

[1]: https://github.com/python/cpython/blob/master/Objects/abstract.c#L2338

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30230>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9850] obsolete macpath module dangerously broken and should be removed

2017-05-10 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Bump, any update on what to do with this issue?

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9850>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30335] Document deprecated alias of assertNotRegex

2017-05-10 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +1635

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30335>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30335] Document deprecated alias of assertNotRegex

2017-05-10 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

The assertNotRegexpMatches name was deprecated in 3.2 in favor of 
assertNotRegex [1]. This is currently not documented in unittest.rst.

[1]: 
https://github.com/python/cpython/commit/ed3a7d2d601ce1e65b0bacf24676440631158ec8

--
components: Tests
messages: 293430
nosy: Jim Fasarakis-Hilliard
priority: normal
severity: normal
status: open
title: Document deprecated alias of assertNotRegex
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30335>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30230] Move quick test in PyObject_IsSubClass outside of PyType_CheckExact guard

2017-05-08 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Additional question, are tests required to check this behavior? (Also, bumping)

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30230>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12857] Expose called function on frame object

2017-05-04 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue12857>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30234] Remove duplicate checks in test_isinstance

2017-05-02 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30234>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30234] Remove duplicate checks in test_isinstance

2017-05-02 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +1500

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30234>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30234] Remove duplicate checks in test_isinstance

2017-05-02 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

The test file duplicates some isinstance and issubclass checks due to the  
distinction of classes in Python 2. 

Proposed PR removes duplicate asserts.

--
components: Tests
messages: 292784
nosy: Jim Fasarakis-Hilliard
priority: normal
severity: normal
status: open
title: Remove duplicate checks in test_isinstance
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30234>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30230] Move quick test in PyObject_IsSubClass outside if PyType_CheckExact guard

2017-05-02 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

Currently the first lines in PyObject_IsSubClass are:

/* We know what type's __subclasscheck__ does. */
if (PyType_CheckExact(cls)) {
/* Quick test for an exact match */
if (derived == cls)
return 1;
return recursive_issubclass(derived, cls);
}

The if (derived == cls) runs only if PyType_CheckExact is True which doesn't 
hold for any classes with a custom metaclass. As a result, a check of the form 
issubclass(Sequence, Sequence) will take a slow path that invokes 
__subclasscheck__.

I'm not sure if this was placed inside there due to some wild edge-case, 
though. PyObject_IsInstance uses the same trick and does so outside the if 
(PyType_CheckExact(cls)) check.

I'll gladly submit a PR if this indeed needs fixing and not by design.

--
components: Interpreter Core
messages: 292764
nosy: Jim Fasarakis-Hilliard
priority: normal
severity: normal
status: open
title: Move quick test in PyObject_IsSubClass outside if PyType_CheckExact guard
type: behavior
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30230>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30196] Add __matmul__ to collections.Counter

2017-04-28 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
versions:  -Python 3.3, Python 3.4, Python 3.5, Python 3.6

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30196>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30196] Add __matmul__ to collections.Counter

2017-04-28 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30196>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30178] Indent methods and attributes of MimeTypes class

2017-04-26 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +1413

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30178>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30178] Indent methods and attributes of MimeTypes class

2017-04-26 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

Similar to #30168 opened earlier. The MimeTypes class's methods and attributes 
aren't indented and the resulting documentation is not indented and duplicates 
the class name. 

Didn't find anything that might indicate this was intentional when trying to 
blame this change. It seems to have happened at some point between 2.6 [1] and 
2.7 [2], though, where the class directive was moved to the MimeTypes Objects 
section. Also didn't find an expert for this module in the index. 

Proposed change just indents these. 

[1]: https://github.com/python/cpython/blame/2.6/Doc/library/mimetypes.rst
[2]: https://github.com/python/cpython/blame/2.7/Doc/library/mimetypes.rst

--
assignee: docs@python
components: Documentation
messages: 292374
nosy: Jim Fasarakis-Hilliard, docs@python
priority: normal
severity: normal
status: open
title: Indent methods and attributes of MimeTypes class
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30178>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30168] Class Logger is unindented in the documentation.

2017-04-26 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +1402

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30168>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30168] Class Logger is unindented in the documentation.

2017-04-26 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

Currently, `Logger` in `logging.rst` doesn't have an indent after `.. class:: 
Logger`. This causes the formatting for the specific section to look somewhat 
unexpected [1]. 

I've already created a PR that indents the methods/attributes accordingly. 

After @bitdancer's request, created this issue to get feedback from vinay if 
this was done on purpose.

[1]: https://docs.python.org/3/library/logging.html#logging.Logger

--
assignee: docs@python
components: Documentation
messages: 292336
nosy: Jim Fasarakis-Hilliard, docs@python, vinay.sajip
priority: normal
severity: normal
status: open
title: Class Logger is unindented in the documentation.
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30168>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29950] Rename SlotWrapperType to WrapperDescriptorType

2017-04-21 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

This was added in python/typing just a couple of days ago, so I'm bumping to 
maybe get the PR to python/cpython merged too.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29950>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30130] array.array is not an instance of collections.MutableSequence

2017-04-21 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Thanks for the bug report, Alexander. This is related, if not a superseder, of: 
https://bugs.python.org/issue29727

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30130>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30094] PDB enhancement

2017-04-18 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Dunno, if I wanted to see a nice formatted output of the internals I'd run `pp 
vars(obj)`. 

That, though, suffers a bit from the fact that `vars` is not the most known of 
the builtins.

--
nosy: +Jim Fasarakis-Hilliard
versions: +Python 3.7 -Python 3.5

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30094>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29950] Rename SlotWrapperType to WrapperDescriptorType

2017-04-18 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Dong-hee, I apologize. I had made a silly mistake in the title of my PR and, as 
such, it didn't appear here on bpo. 

Thanks for the PR, though! :-)

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29950>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29950] Rename SlotWrapperType to WrapperDescriptorType

2017-04-18 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +1299

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29950>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30076] Opcode names BUILD_MAP_UNPACK_WITH_CALL and BUILD_TUPLE_UNPACK_WITH_CALL are too long

2017-04-17 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30076>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29957] unnecessary LBYL for key contained in defaultdict, lib2to3/btm_matcher

2017-04-08 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

bump to close issue now that PR was merged

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29957>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29963] Remove obsolete declaration PyTokenizer_RestoreEncoding in tokenizer.h

2017-04-08 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29963>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29944] Argumentless super() fails in classes constructed with type()

2017-04-08 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29944>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29905] TypeErrors not formatting values correctly

2017-04-04 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +1166

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29905>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7659] Attribute assignment on object() instances raises wrong exception

2017-04-04 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

I don't think a change is actually needed here (bumping to decide the fate of 
this issue)

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue7659>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28681] About function renaming in the tutorial

2017-04-04 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28681>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29905] TypeErrors not formatting values correctly

2017-04-04 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

As per #issue25002 and, specifically #msg250151, the TypeError in `asynchat` 
should probably not be included, I'll just make a PR for the TypeError in 
asyncio/proactor_events

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29905>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13290] get vars for object with __slots__

2017-04-04 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13290>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29968] Document that no characters are allowed to proceed \ in explicit line joining

2017-04-04 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Gotcha, thanks for the input, David. I'll leave it to you to decide if the 
sentence on the trailing comments warrants removal.

--
resolution:  -> rejected
stage:  -> resolved
status: open -> closed

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29968>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29968] Document that no characters are allowed to proceed \ in explicit line joining

2017-04-04 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Ah, yes, the Ref. Manual, not the devguide, silly mistake.

It definitely isn't a documentation bug (the documentation doesn't state 
something wrong) as much as I think it might be a slight omission. I really 
wasn't aware of how strict the tokenizer is with any characters after `\`.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29968>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29968] Document that no characters are allowed to proceed \ in explicit line joining

2017-04-03 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Alternatively, stripping all white-space that proceed `\` could be considered 
if it seems like a good idea.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29968>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29968] Document that no characters are allowed to proceed \ in explicit line joining

2017-04-03 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

After looking through the code, the tokenizer only allows a new line character 
to proceed `\` in explicit line joining [1].

The Devguide section on it [2] actually states many of the limitations of using 
`\` but not directly that nothing is allowed after it (it does have a remark on 
comments). 

Would it be a good idea to amend it to state that no characters are allowed 
after `\`?

[1]: 
https://github.com/python/cpython/blob/734125938d4653459593ebd28a0aec086efb1f27/Parser/tokenizer.c#L1847
[2]: 
https://docs.python.org/3/reference/lexical_analysis.html#explicit-line-joining

--
assignee: docs@python
components: Documentation
messages: 291067
nosy: Jim Fasarakis-Hilliard, docs@python
priority: normal
severity: normal
status: open
title: Document that no characters are allowed to proceed \ in explicit line 
joining

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29968>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29966] typing.get_type_hints doesn't really work for classes with ForwardRefs

2017-04-03 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
components: +Library (Lib)
type:  -> behavior

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29966>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29963] Remove obsolete declaration PyTokenizer_RestoreEncoding in tokenizer.h

2017-04-02 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +1141

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29963>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29963] Remove obsolete declaration PyTokenizer_RestoreEncoding in tokenizer.h

2017-04-02 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

Couldn't trace exactly when it was removed from tokenizer.c but the 
corresponding declaration in the header file survived.

I'm not sure how to tag this small clean-up.

--
messages: 291033
nosy: Jim Fasarakis-Hilliard
priority: normal
severity: normal
status: open
title: Remove obsolete declaration PyTokenizer_RestoreEncoding in tokenizer.h
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29963>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29377] Add the 'wrapper_descriptor' type to the types module

2017-03-31 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +823

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29377>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29950] Rename SlotWrapperType to WrapperDescriptorType

2017-03-30 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

The name SlotWrapperType was added in #29377 but it added the type based on the 
repr of the object instead of it's type as `type(object.__init__)` results in. 

I proposed this be named to WrapperDescriptorType to avoid and any unecessary 
confusion down the line.

--
components: Library (Lib)
messages: 290883
nosy: Jim Fasarakis-Hilliard
priority: normal
severity: normal
status: open
title: Rename SlotWrapperType to WrapperDescriptorType
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29950>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29251] Class __dict__ is only a mapping proxy

2017-03-30 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

I believe the docs defined that, usually using a bold "CPython implementation 
detail" sentence.

It seems like it's something that would be considered an implementation detail, 
though, according to Raymond's answer here: 
http://stackoverflow.com/questions/32720492/why-is-a-class-dict-a-mappingproxy

Changing it to just state it's a mapping definitely looks like the safest 
option.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29251>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29928] Add f-strings to Glossary

2017-03-28 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Completely agree, Mariatta. I just wanted to clarify my initial position :-)

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29928>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29928] Add f-strings to Glossary

2017-03-28 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

I was probably misunderstood, too, in hindsight, it's my fault for not being 
more clear :-). 

In my first sentence I was merely pointing out the oddity of -string 
not being a very popular term until f-string came along.

As for my second sentence (adding the other prefixed strings to the glossary) I 
was thinking of using the names people currently use. Entries for 
(byte|raw|unicode)-strings, seeing as they don't already exist, might be a good 
addition now that f-strings are up for inclusion.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29928>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13349] Non-informative error message in index() and remove() functions

2017-03-28 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Could use `%.100S` instead of `%.100R` but I'm not sure of the downsides that 
might entail.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13349>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13349] Non-informative error message in index() and remove() functions

2017-03-28 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Yes, that does look like too much. My rationale for adding quotes around the 
value was in order to make it more clear in cases where the repr exceeds 100 
characters. 

Instead of:

   Traceback (most recent call last):
 File "", line 1, in 
   ValueError: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 
18, 19, 20, 21, 22, 23, 24, 25, 26, 2 not in list

Have it clearly distinguished by using "":

   Traceback (most recent call last):
 File "", line 1, in 
   ValueError: "[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 
18, 19, 20, 21, 22, 23, 24, 25, 26, 2" not in list

I'm not sure if there's a trivial way to not display so many quotes in the case 
you supplied, you're better suited to decide if this can be done somehow.

--
versions: +Python 3.7 -Python 3.3

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13349>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29935] list and tuple index methods should accept None parameters

2017-03-28 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
components: +Interpreter Core
versions: +Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29935>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13349] Non-informative error message in index() and remove() functions

2017-03-28 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +775

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13349>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29904] Fix a number of error message typos

2017-03-28 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29904>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29932] Missing word ("be") in error message ("first argument must a type object")

2017-03-28 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

..and another one here 
https://github.com/python/cpython/blob/master/Modules/arraymodule.c#L2145:

"__reduce_ex__ argument should an integer" -> ".. should be .."

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29932>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29932] Missing word ("be") in error message ("first argument must a type object")

2017-03-28 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Indeed, quickly glancing over the error messages there's another small typo in 
https://github.com/python/cpython/blob/master/Modules/arraymodule.c#L2371:

"array indices must be integer" -> "array indices must be integers"

might as well fix that in your PR too (maybe also change the title to: "Fix 
small error message typos in arraymodule.c"?)

------
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29932>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29928] Add f-strings to Glossary

2017-03-28 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

It's odd how 'f-string' just caught on when byte, raw and unicode strings never 
really did (at least I personally don't see many people using b-string, 
r-string and u-string respectively).

Shouldn't an entry for them be made too if 'f-string' would be added?

As for the name used by everyone, you can't blame them, f-string is a term used 
throughout PEP 498.

I guess a a new discussion might be warranted where people can decide if a new 
term should be thought of or if the negative effects of using the current 
aren't all that bad.

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29928>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29251] Class __dict__ is only a mapping proxy

2017-03-27 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Isn't the fact that it's read-only a CPython implementation detail? That is, 
shouldn't that just read: 

"gives a :term:`mapping` object representing the class's namespace"

so as to not enforce anything on any other implementations?

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29251>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29912] Overlapping tests between list_tests and seq_tests

2017-03-27 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +745

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29912>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29912] Overlapping tests between list_tests and seq_tests

2017-03-27 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Correction: test_index *partially* duplicates the base class method. It too can 
be modified to use super like test_imul.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29912>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29912] Overlapping tests between list_tests and seq_tests

2017-03-26 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

Seems the CommonTests class defined in list_tests duplicates the testing 
performed by seq_tests.CommonTests in the following functions:

test_index, test_count

Additionally, a part of test_imul from list_tests.CommonTests can be moved to 
seq_tests.CommonTests. (specifically, up until `self.assertEqual(u, 
self.type2test([]))`).

Am I missing some non-obvious thing here or can I safely remove the two test 
functions in list_tests.CommonTests and move (while also adding a super call) 
part of test_imul from list_tests.CommonTests to test_imul in 
seq_tests.CommonTests?

Some links:

[1a] seq_tests test_index: 
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/seq_tests.py#L363
[1b] list_tests test_index:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/list_tests.py#L376

[2a] seq_tests test_count:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/seq_tests.py#L344
[2b] list_tests test_count:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/list_tests.py#L357

[3a] seq_tests test_imul:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/seq_tests.py#L300
[3b] list_tests test_imul:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/list_tests.py#L550

--
components: Tests
messages: 290550
nosy: Jim Fasarakis-Hilliard
priority: normal
severity: normal
status: open
title: Overlapping tests between list_tests and seq_tests
type: behavior

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29912>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29905] TypeErrors not formatting values correctly

2017-03-25 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +725

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29905>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29905] TypeErrors not formatting values correctly

2017-03-25 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

Specifically, in both Lib/async/proactor_events.py and asynchat.py there's a 
comma where a % should be thereby not formatting the value correctly:

TypeError('data argument must be byte-ish (%r)', type(data))
TypeError('data argument must be byte-ish (%r)', type(data))

proposed fix is to change them to:

TypeError('data argument must be a bytes-like object, not %r' % 
type(data).__name__)
TypeError('data argument must be a bytes-like object, not %r' % 
type(data).__name__)

--
components: Library (Lib)
messages: 290499
nosy: Jim Fasarakis-Hilliard
priority: normal
severity: normal
status: open
title: TypeErrors not formatting values correctly
type: behavior
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29905>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29904] Fix a number of error message typos

2017-03-25 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +724

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29904>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29904] Fix a number of error message typos

2017-03-25 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Sure, Serhiy, I'll make a PR in a bit.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29904>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13349] Non-informative error message in index() and remove() functions

2017-03-25 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Additional instances of this:

 - function indexOf of operator.py.
 - function _PySequence_IterSearch of abstract.c

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13349>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29904] Fix a number of error message typos

2017-03-25 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

Specifically, the list I've currently found in .py files:

- _pyio.py:

ValueError("flush of closed file")
ValueError("flush of closed file")

"of" -> "on" for both.

- configparser.py:

ValueError("Required argument `source' not given.")
ValueError("Cannot specify both `filename' and `source'. "

fix ` on the quotes on argument names.

- windows_utils.py

ValueError("I/O operatioon on closed pipe")

"operatioon" -> "operation"

- proactor_events.py, asynchat.py:

TypeError('data argument must be byte-ish (%r)',
raise TypeError('data argument must be byte-ish (%r)',

AFAIK, "byte-ish" isn't used elsewhere, the author probably mean to go for 
"bytes-like object".

- _header_value_parser.py:

errors.HeaderParseError("expected atom at a start of "

"at a start of " -> "at the start of "

- http/cookiejar.py:

raise ValueError("filename must be string-like")

I think "must be a str" was intended.

--
messages: 290491
nosy: Jim Fasarakis-Hilliard
priority: normal
severity: normal
status: open
title: Fix a number of error message typos
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29904>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29892] change statement for open() is splited into two part in middle of sentence.

2017-03-23 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Indeed, nice catch! Submit a PR for it if you want to (if not, someone else 
will pick it up soon :-)

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29892>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29882] Add an efficient popcount method for integers

2017-03-22 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29882>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29879] typing.Text not available in python 3.5.1

2017-03-22 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

That's great, make sure you also take a look at the quick start section of the 
devguide [1] if you need help in any steps :-)

[1]: https://docs.python.org/devguide/#quick-start

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29879>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29866] Added datetime_diff to datetime.py.

2017-03-22 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Without stating an opinion on the change, I'd suggest first posting to 
python-ideas (unless you already did so and I missed it :-) to get an initial 
reaction from folks on your idea before coming to b.p.o.

If you have the backing of python-ideas you might have a good chance of having 
your change accepted.

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29866>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29879] typing.Text not available in python 3.5.1

2017-03-22 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Ah I see now, yes, neither are Reversible, Type, NewType, TYPE_CHECKING and 
DefaultDict. 

Why don't you go ahead an submit a PR for this? :-)

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29879>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29879] typing.Text not available in python 3.5.1

2017-03-22 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

I'm guessing you might of missed it, `Text` is documented in the docs for 
Python 3.5 https://docs.python.org/3.5/library/typing.html#typing.Text :-)

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29879>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14003] __self__ on built-in functions is not as documented

2017-03-20 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue14003>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29847] Path takes and ignores **kwargs

2017-03-19 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29847>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29855] The traceback compounding of RecursionError fails to work with __get__

2017-03-19 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

I'm pretty sure this is by design; the change introduced in [1] tried to keep 
things simple by only trimming the output when the lines were identical. More 
complicated scenarios are trickier to implement.

It should be interesting to see if the core-devs believe a change like this is 
warranted, though.

[1]: https://bugs.python.org/issue26823

--
components: +Interpreter Core
nosy: +Jim Fasarakis-Hilliard
versions: +Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29855>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29856] curses online documentation typo

2017-03-19 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

Nice catch, that's a typo indeed. If you'd like, submit a PR [see 
https://docs.python.org/devguide/#quick-start] to address this.

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29856>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13349] Non-informative error message in index() and remove() functions

2017-03-19 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

@Sean Ochoa, do you want to make this into a PR? The only tweak I would suggest 
would be to change all error messages to either be:

"object.method(repr(x)): element not in object" 

or:

"repr(x) not in object"

also, this probably needs to be changed to version 3.7 now.

--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13349>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29853] Improve exception messages for remove and index methods

2017-03-19 Thread Jim Fasarakis-Hilliard

Jim Fasarakis-Hilliard added the comment:

I'd be happy to supply a PR for this if the change seems reasonable.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29853>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29853] Improve exception messages for remove and index methods

2017-03-19 Thread Jim Fasarakis-Hilliard

New submission from Jim Fasarakis-Hilliard:

Currently, there's a discrepancy in the exception reporting for the `.index` 
and `.remove` methods of many objects:

For arrays:

array.remove(val) -> ValueError: array.remove(x): x not in list 
array.index(val)  -> ValueError: array.index(x): x not in list

not only is always printing `x` not in list not informative, it's wrong since 
it isn't a list.

For tuples:

tuple.index(val)  -> ValueError: tuple.index(x): x not in tuple

For lists:

list.remove(val)  -> ValueError: list.remove(x): x not in list

list.index(val) produces a more informative message: ValueError:  is not 
in list

For deques:

deque.remove(val) -> ValueError: deque.remove(x): x not in deque

similarly to lists, `deque.index(val)` prints the actual argument supplied.

I'm not sure if there's valid reasoning behind not providing the repr of the 
arguments in all `remove` methods but, if there isn't, I'd like to suggest 
changing all of them to use PyErr_Format and produce more informative messages:

array.remove(val) -> ValueError:  is not in array 
array.index(val)  -> ValueError:  is not in array
tuple.index(val)  -> ValueError:  is not in tuple
list.remove(val)  -> ValueError:  is not in list
deque.remove(val) -> ValueError:  is not in deque

------
messages: 289854
nosy: Jim Fasarakis-Hilliard
priority: normal
severity: normal
status: open
title: Improve exception messages for remove and index methods
type: enhancement
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29853>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29836] Remove nturl2path from test_sundry and amend its docstring

2017-03-17 Thread Jim Fasarakis-Hilliard

Changes by Jim Fasarakis-Hilliard <d.f.hilli...@gmail.com>:


--
pull_requests: +568

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29836>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >