[issue23883] __all__ lists are incomplete

2015-04-16 Thread Joel Taddei

Joel Taddei added the comment:

Woops just noticed above in the issue someone else picked up the Calendar 
__all__.  I am genuinely sorry I didn't intend to duplicate the effort.

--

___
Python tracker 
<http://bugs.python.org/issue23883>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23883] __all__ lists are incomplete

2015-04-16 Thread Joel Taddei

Joel Taddei added the comment:

I took a stab at the calendar module.  Found a few items in the documentation 
which weren't listed in the above list:

LocaleTextCalendar, LocaleHTMLCalendar, and weekheader.

I was curious though about week and prweek as month and prmonth are documented 
and exported should we add week and prweek to the export & docs?

--
Added file: http://bugs.python.org/file39067/Issue23883_calendar_all.patch

___
Python tracker 
<http://bugs.python.org/issue23883>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei

Joel Taddei added the comment:

Put HeaderError back in and removed the extra XHDTYPE.

We can get more input on the type constants as well as the undocumented but 
exported items.  Could just be cleared up with some edits to documentation.

--
Added file: http://bugs.python.org/file39065/Issue23883_tarfile_all.patch

___
Python tracker 
<http://bugs.python.org/issue23883>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei

Changes by Joel Taddei :


Removed file: http://bugs.python.org/file39064/Issue23883_tarfile_all.patch

___
Python tracker 
<http://bugs.python.org/issue23883>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei

Joel Taddei added the comment:

Thanks for the feedback.  I was unsure how to proceed with the undocumented 
items that seemed to be categorized as exported.  Thanks for catching ENCODING 
& *_FORMAT.

--
Added file: http://bugs.python.org/file39064/Issue23883_tarfile_all.patch

___
Python tracker 
<http://bugs.python.org/issue23883>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei

Changes by Joel Taddei :


Removed file: http://bugs.python.org/file39051/Issue23883_tarfile_all.patch

___
Python tracker 
<http://bugs.python.org/issue23883>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei

Joel Taddei added the comment:

I took care of the tarfile module.

Added the following according to the first message:

tarfile.CompressionError
tarfile.HeaderError
tarfile.ReadError
tarfile.open


The following were included in __all__ that were not explicitly mentioned in 
the first message but were denoted as an exported function, exported class, or 
an exported error.

tarfile.main
tarfile.TarIter
tarfile.StreamError
tarfile.ExtractError
tarfile.SubsequentHeaderError
tarfile.InvalidHeaderError
tarfile.EmptyHeaderError
tarfile.EOFHeaderError
tarfile.TruncatedHeaderError

This is my first patch so feedback is highly appreciated.

--
keywords: +patch
nosy: +taddeimania
Added file: http://bugs.python.org/file39051/Issue23883_tarfile_all.patch

___
Python tracker 
<http://bugs.python.org/issue23883>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com