[issue44687] io.BufferedReader:peek() closes underlying file, breaking peek/read expectations

2021-09-24 Thread Jun De
Jun De added the comment: Awesome! To be honest I was very inclined to add test cases for this edge case, but while some existing test cases use native objects like io.BytesIO, the one that our edge case uses is HTTPResponse from `urllib3.response.py`. Should I still go ahead with writing

[issue44687] io.BufferedReader:peek() closes underlying file, breaking peek/read expectations

2021-09-24 Thread Jun De
Jun De added the comment: Yeap Steve, I was thinking the same thing. I've taken the buffered data into consideration when checking if the file is closed in my fix, feel free to take a look and let me know what you think :) -- ___ Python tracker

[issue44687] io.BufferedReader:peek() closes underlying file, breaking peek/read expectations

2021-09-19 Thread Jun De
Change by Jun De : -- keywords: +patch nosy: +AngstyDuck nosy_count: 1.0 -> 2.0 pull_requests: +26859 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28457 ___ Python tracker <https://bugs.python.org/i

[issue44155] Race condition when using multiprocessing BaseManager and Pool in Python3

2021-05-24 Thread Jun
Change by Jun : -- keywords: +patch nosy: +junnplus nosy_count: 1.0 -> 2.0 pull_requests: +24924 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26332 ___ Python tracker <https://bugs.python.org/i

[issue43207] InspectLoader.is_package is not an abstract method

2021-02-12 Thread Jun
New submission from Jun : In the documentation of importlib: https://docs.python.org/3/library/importlib.html#importlib.abc.InspectLoader It says InspectLoader.is_package is an abstract method while it is not in the implementation. @abc.abstractmethod decorator was removed with this commit

[issue38507] Improve the documentation of the nested list initialization

2019-10-17 Thread JUN-WEI SONG
JUN-WEI SONG added the comment: sorry that I did not notice it already documented -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38507] Improve the documentation of the nested list initialization

2019-10-17 Thread JUN-WEI SONG
New submission from JUN-WEI SONG : When I used the nested list, I need to initialize the nested list, so I used this expression: >>> nested_list = [[]] * 5 see also: https://stackoverflow.com/questions/12791501/python-initializing-a-list-of-lists So I later learned that such an e

[issue36988] zipfile: string IndexError on extract

2019-05-21 Thread JUN-WEI SONG
JUN-WEI SONG added the comment: The following output throws error when using unzip -t $ unzip -t file0.zip Output: Archive: file0.zip : mismatching "local" filename (zipfile_extract.pyUT^I), continuing with "central" filename version testing:

[issue36260] Zip Bomb vulnerability

2019-05-17 Thread JUN-WEI SONG
JUN-WEI SONG added the comment: Dear friends, We moved a little bit forward to improve the writing. :) -- ___ Python tracker <https://bugs.python.org/issue36

[issue36260] Zip Bomb vulnerability

2019-05-17 Thread JUN-WEI SONG
Change by JUN-WEI SONG : -- keywords: +patch pull_requests: +13288 stage: resolved -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue34509] Starting to use gcc-8 on CI

2019-05-16 Thread Jun Aruga
Jun Aruga added the comment: Sure, alright. Thanks for informing me. On Thu, 16 May 2019 at 00:08, Zachary Ware wrote: > > > Zachary Ware added the comment: > > We do now have at least one builder using GCC 8 (ware-gentoo-x86) and one > using GCC 9 (cstratak-fedor

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-05-02 Thread JUN-WEI SONG
JUN-WEI SONG added the comment: Thank you very much for your reply. Based on discussions above, consensuses are improving the zipfile documentation. And we (JUN-WEI SONG & KunYu Chen) would like to work on this. With opinions of Serhiy Storchaka, Christian Heimes and the idea

[issue36502] The behavior of str.isspace() for U+00A0 and U+202F is different from what is documented

2019-04-02 Thread Jun
New submission from Jun : I was looking for a list of Unicode codepoints that str.isspace() returns true. According to https://docs.python.org/3/library/stdtypes.html#str.isspace, it's "Whitespace characters are those characters defined in the Unicode character database as “

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-04-02 Thread JUN-WEI SONG
JUN-WEI SONG added the comment: Hello Python community, With Christian Heimes’ suggestion, we manipulate appropriate warning to inform users that they may encounter zip bomb issues when using the zipfile module. The warning we would like to add in the zipfile documentation is shown below

[issue36462] CVE-2019-9674 : zip bomb vulnerability in Lib/zipfile.py

2019-03-28 Thread JUN-WEI SONG
JUN-WEI SONG added the comment: Thanks to the python community, both of these issues are the same. I also think it's a good thing to make related documentation to reduce this type of problem rather than implementing it on a low-level zipfile module. Perhaps we can customize

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-03-28 Thread JUN-WEI SONG
JUN-WEI SONG added the comment: Thank you python community, these two issues are indeed the same problem. I also think that it is good to make a related document to reduce such problems. -- stage: -> resolved status: -> closed ___ Python t

[issue36462] CVE-2019-9674 : zip bomb vulnerability in Lib/zipfile.py

2019-03-28 Thread JUN-WEI SONG
New submission from JUN-WEI SONG : Dear Python Community, we found a python module vulnerability during these days and we got a CVE number, CVE-2019-9674 after reported it to cve.mitre.org. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-9674 The reserved information of CVE-2019

[issue34509] Starting to use gcc-8 on CI

2018-08-26 Thread Jun Aruga
Jun Aruga added the comment: > it would be better to set up a buildbot running GCC 8, or switching one of > our existing workers to it. We want to keep the pre-merge CI as stable as > possible, and using a bleeding-edge compiler doesn't strike me as > particularly stable.

[issue34509] Starting to use gcc-8 on CI

2018-08-26 Thread Jun Aruga
Change by Jun Aruga : -- keywords: +patch pull_requests: +8418 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue34509> ___ ___ Python-

[issue34509] Starting to use gcc-8 on CI

2018-08-26 Thread Jun Aruga
New submission from Jun Aruga : This ticket is from below conversation on python-dev mailing list. https://mail.python.org/pipermail/python-dev/2018-August/155011.html Right now the Python project Travis CI is running on gcc-4.8.4 for coverage testing. I want to replace it or add the latest

[issue31865] html.unescape does not work as per documentation

2017-10-24 Thread Jun Hui Lee
New submission from Jun Hui Lee <cardinle...@gmail.com>: html.unescape(s) Convert all named and numeric character references (e.g. , , ) But running this gives: >>> html.unescape(', , ') '>, >, ' -- assignee: docs@python components: Documentation messages: 304

[issue1633941] for line in sys.stdin: doesn't notice EOF the first time

2016-11-15 Thread Jun Wu
Jun Wu added the comment: haypo: The file.__iter__ EINTR issue may be better discussed as a separate bug report. It's not related to stdin or EOF or Windows. Since we have some EINTR fixes for Python 2.7.4, I think it's reasonable to fix the remaining EINTR issues for 2.7.13+. If I have read

[issue25634] Add a dedicated subclass for attribute missing errors

2015-11-19 Thread Jun Wang
Jun Wang added the comment: I think this is a common problem while using both __getattr__ and descriptor/property. A descriptor example: class Descriptor(): def __get__(self, instance, owner=None): raise AttributeError('Implicitly suppressed') class A(): d

[issue25634] Add a dedicated subclass for attribute missing errors

2015-11-16 Thread Jun Wang
New submission from Jun Wang: See this simple example: class A(): def __init__(self, x=None): self.x = x @property def t(self): return self.x.t def __getattr__(self, name): return 'default' print(A().t