Laura Rupprecht added the comment:
I've updated the patch from Terry with Berker's suggestion.
--
nosy: +laura
Added file: http://bugs.python.org/file43162/issue17888_2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
Laura Rupprecht added the comment:
Can anyone provide feedback on this patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9858
___
___
Python
Laura Rupprecht added the comment:
There were originally three methods present in RawIOBase that were not present
in PyRawIOBase_Type:
1. readinto
2. write
3. __weakref__
I've created a patch that adds the first two to PyRawIOBase_Type. The python
class readinto and write methods raise
Laura Rupprecht added the comment:
Created a patch to check whether classes define the same attributes.
This adds a test for RawIOBase, where Python and and C implementations are out
of sync, but skips one of the tests as the issue (issue9858) is still
outstanding.
--
keywords
Laura Rupprecht added the comment:
Thanks Berker!
I've added some updates to the patch taking your suggestions into account.
There is also a change from using detect_module_matches to
detect_api_mismatch, as it is a more general (and accurate) description.
Also, adding tests
Laura Rupprecht added the comment:
Related item: Added a helper function to verify API match of two modules,
addressing issue9859.
It checks for a closer match but mentioned this ticket from the thread.
--
nosy: +laura
___
Python tracker rep