[issue47129] Improve errors messages in f-string syntax errors

2022-03-27 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I like the newest suggestion by @Jelle better as well. -- ___ Python tracker <https://bugs.python.org/issue47129> ___ ___

[issue46289] AST: FomattedValue conversion's default value should be -1

2022-01-07 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I agree that A is probably the way to go. -- ___ Python tracker <https://bugs.python.org/issue46289> ___ ___ Python-bug

[issue44838] SyntaxError: New message "expected 'else' after 'if' expression" wrongly shown

2021-08-05 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Oh, this is a difficult one. It's caused by GH-27506 that was recently added to produce better errors for things like `print('hello' if something)`, where the correct syntax is `print('hello' if something else 'hi'). This is going to have a lot

[issue44385] Some target-related rules are unreachable in the grammar

2021-06-10 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44385] Some target-related rules are unreachable in the grammar

2021-06-10 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +25245 pull_request: https://github.com/python/cpython/pull/26659 ___ Python tracker <https://bugs.python.org/issue44

[issue44385] Some target-related rules are unreachable in the grammar

2021-06-10 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- keywords: +patch pull_requests: +25241 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26655 ___ Python tracker <https://bugs.python.org/issu

[issue44385] Some target-related rules are unreachable in the grammar

2021-06-10 Thread Lysandros Nikolaou
New submission from Lysandros Nikolaou : Three rules (targets, target and t_atom) in the grammar are unreachable. We were using them at some point in the past, but we never removed them when we replaced them with other rules. -- assignee: lys.nikolaou components: Parser messages

[issue44345] The first line (comment) of the parser.c is incorrect.

2021-06-09 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44345] The first line (comment) of the parser.c is incorrect.

2021-06-09 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset aef1b58dc8889e1bebaddf1e30f67b63a1b20f90 by Akira Nonaka in branch 'main': bpo-44345: Fix 'generated by' comment in parser.c (GH-26615) https://github.com/python/cpython/commit/aef1b58dc8889e1bebaddf1e30f67b63a1b20f90 -- nosy

[issue44122] let linter allow defining attribute outside __init__ if called in __init__

2021-05-13 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Hi Ohad and thanks for filing a report. This is not a problem with CPython and outside of our control. You'd have to ask this question to the PyCharm linter team (unfortunately I don't know where exactly you would be able to do that). Closing

[issue43798] Add position metadata to alias AST type

2021-04-10 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43798] Add position metadata to alias AST type

2021-04-10 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset 75a06f067bd0a2687312e5f8e78f9075be76ad3a by Matthew Suozzo in branch 'master': bpo-43798: Add source location attributes to alias (GH-25324) https://github.com/python/cpython/commit/75a06f067bd0a2687312e5f8e78f9075be76ad3a

[issue43798] Add position metadata to alias AST type

2021-04-09 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I'm okay with this, unless someone has any input on why the alias node should not have line/column info (and did not have it in the first place). -- nosy: +BTaskaya, gvanrossum, lys.nikolaou, pablogsal

[issue43748] Inconsistent grammar in new error message (introduced in 3.10.0a7)

2021-04-06 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: We can change the wording to `cannot` in order for all of the error messages to be consistent. Would you like to propose a PR, Andre? -- ___ Python tracker <https://bugs.python.org/issue43

[issue34013] Inconsistent SyntaxError for print

2021-02-20 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- nosy: +lys.nikolaou ___ Python tracker <https://bugs.python.org/issue34013> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42128] Structural Pattern Matching (PEP 634)

2021-02-09 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: The grammar is indeed auto-generated by reading the actual Grammar file, python.gram. Here's the lexer Pablo had developed for doing the syntax-highlighting. https://github.com/python/cpython/blob/master/Doc/tools/extensions/peg_highlight.py

[issue42918] Nested multi-line expression will lead to "compile()" fails

2021-02-05 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Thanks a lot for the report, Xinmeng! This is a bug in how we're checking for bad single statements in bad_single_statement and it's not trivial to fix due to the string shenanigans we're doing there in newline_in_string, which does not account for many

[issue42919] Blank in multiline “if expressions” will lead to EOF errors

2021-02-05 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I can't really understand if this should be considered a bug or not. It's definitely consistent with 3.8 and my inclination that it is not. -- nosy: +pablogsal ___ Python tracker <https://bugs.python.

[issue42997] Improve error message for missing : before suites

2021-01-26 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > Yeah, but the cut is "absolute" (because of the syntax Error). IIRC the > normal cut only affects that rule, no? Right. -- ___ Python tracker <https://bugs.py

[issue42997] Improve error message for missing : before suites

2021-01-26 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I propose to go with the first approach. I really like that and I can see us using it in various place in the future. It's basically a positive lookahead with a cut, but the extra feature that it raises a SyntaxError, right? I'll have a look at the PR

[issue42827] pegen parser: Multiline eval with assignment to function call: assertion failed

2021-01-14 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: This is now fixed. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42860] Incompatible types in Python grammar

2021-01-07 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: This is now fixed, Tobias! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42860] Incompatible types in Python grammar

2021-01-07 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- keywords: +patch pull_requests: +22984 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24156 ___ Python tracker <https://bugs.python.org/issu

[issue42860] Incompatible types in Python grammar

2021-01-07 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- nosy: +lys.nikolaou ___ Python tracker <https://bugs.python.org/issue42860> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42827] pegen parser: Multiline eval with assignment to function call: assertion failed

2021-01-06 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +22969 pull_request: https://github.com/python/cpython/pull/24140 ___ Python tracker <https://bugs.python.org/issue42

[issue42827] pegen parser: Multiline eval with assignment to function call: assertion failed

2021-01-05 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +22954 pull_request: https://github.com/python/cpython/pull/24124 ___ Python tracker <https://bugs.python.org/issue42

[issue42827] pegen parser: Multiline eval with assignment to function call: assertion failed

2021-01-04 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Thanks for letting us know, Julien! I've identified the bug and where it comes from and I'll probably work on it tomorrow. -- ___ Python tracker <https://bugs.python.org/issue42

[issue40631] PEG Parser: Cannot used starred expression in parenthesised expr

2021-01-02 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +22901 pull_request: https://github.com/python/cpython/pull/24068 ___ Python tracker <https://bugs.python.org/issue40

[issue40631] PEG Parser: Cannot used starred expression in parenthesised expr

2021-01-02 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset 2ea320553298038bb7d6789e50e199332f66 by Lysandros Nikolaou in branch 'master': bpo-40631: Disallow single parenthesized star target (GH-24027) https://github.com/python/cpython/commit/2ea320553298038bb7d6789e50e199332f66

[issue40631] PEG Parser: Cannot used starred expression in parenthesised expr

2020-12-31 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +22867 pull_request: https://github.com/python/cpython/pull/24027 ___ Python tracker <https://bugs.python.org/issue40

[issue40631] PEG Parser: Cannot used starred expression in parenthesised expr

2020-12-30 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Yup, this all sounds much more reasonable. Thanks for the explanation, Guido. > Also the current behavior allows `(*x), y = 1` assignment. If `(*x)` is to be > totally disallowed, `(*x), y = 1` should also be rejected. This is allowed in

[issue40631] PEG Parser: Cannot used starred expression in parenthesised expr

2020-12-30 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: It makes sense to me to be able to do `(*a), b` if I can do `*a, b`, but I don't really have a strong opinion on it. -- ___ Python tracker <https://bugs.python.org/issue40

[issue42729] tokenize, ast: No direct way to parse tokens into AST, a gap in the language processing pipiline

2020-12-24 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: The thing is that the parser itself does not get a stream of tokens as input. It only accepts either a file or a string and it lazily converts its input to tokens. As for the PR attached to this patch, I'm -1 on that. I don't think the usecase

[issue42725] PEP 563: Should the behavior change for yield/yield from's

2020-12-24 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I concur with Guido. I feel that making this an error is the best alternative we have. -- ___ Python tracker <https://bugs.python.org/issue42

[issue42577] Unhelpful syntax error when expression spans multiple lines

2020-12-14 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Thanks for opening an issue here, Christoph. This is the right place to discuss this. Indeed the parser is pretty dumb when reporting errors. In the technical sense the colon is the right thing to point to, since it's the first token that's

[issue30858] Keyword can't be an expression?

2020-12-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I like the current error message. What bugs me a little is the position of the caret, which I think is a bit misleading. Guido, Pablo, should we move the caret to point at the `=` sign or whatever comes after it? I think I prefer the former

[issue42521] Debug (-d) mode not working in 3.9

2020-12-01 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Hi Anthony, could it be that your 3.9 is not a debug build, while the others are? We only enable parser debug ouput when Python has been build --with-pydebug. Building the 3.9.0 tag --with-pydebug works fine for me

[issue42381] Allow unparenthesized walrus in set comprehensions

2020-11-18 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42381] Allow unparenthesized walrus in set comprehensions

2020-11-18 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +22274 pull_request: https://github.com/python/cpython/pull/23382 ___ Python tracker <https://bugs.python.org/issue42

[issue42381] Allow unparenthesized walrus in set comprehensions

2020-11-16 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: While {(a:='a'): (b:=1)} looks somewhat cleaner to me. -- ___ Python tracker <https://bugs.python.org/issue42381> ___ ___

[issue42381] Allow unparenthesized walrus in set comprehensions

2020-11-16 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > dict comprehension FWIW, unparenthesized walruses are still disallowed in dictcomps and to be honest, I'm not sure if we should allow them or not. I feel that allowing too many colons there would be too noisy. {a:='a': b:=1} doesn't really look

[issue42374] Unparenthesized walrus is not allowed in genexps

2020-11-16 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset 2b800ef809eefbc96a536e4b43a8285f2353f64d by Lysandros Nikolaou in branch '3.9': bpo-42374: Allow unparenthesized walrus in genexps (GH-23319) (GH-23329) https://github.com/python/cpython/commit/2b800ef809eefbc96a536e4b43a8285f2353f64d

[issue42374] Unparenthesized walrus is not allowed in genexps

2020-11-16 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42374] Unparenthesized walrus is not allowed in genexps

2020-11-16 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +22217 pull_request: https://github.com/python/cpython/pull/23329 ___ Python tracker <https://bugs.python.org/issue42

[issue42316] Walrus Operator in list index

2020-11-16 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset cae60187cf7a7b26281d012e1952fafe4e2e97e9 by Lysandros Nikolaou in branch 'master': bpo-42316: Allow unparenthesized walrus operator in indexes (GH-23317) https://github.com/python/cpython/commit/cae60187cf7a7b26281d012e1952fafe4e2e97e9

[issue42381] Allow unparenthesized walrus in set comprehensions

2020-11-16 Thread Lysandros Nikolaou
New submission from Lysandros Nikolaou : Since unparenthesized walruses are allowed in list comprehensions and in generator expressions, should we maybe allow them in set comprehensions as well? -- components: Interpreter Core messages: 381173 nosy: gvanrossum, lys.nikolaou, pablogsal

[issue40939] Remove the old parser

2020-11-16 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Victor, Miro, both removal of the parser module and of all the C API functions are now documented in the 3.10 whatsnew document. Do you feel that this is enough for us to close this issue again? -- ___ Python

[issue40939] Remove the old parser

2020-11-16 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +22212 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/23321 ___ Python tracker <https://bugs.python.org/issu

[issue40939] Remove the old parser

2020-11-16 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Pablo, have you already started on this? I didn't see your comment earlier and I've got a PR ready. -- ___ Python tracker <https://bugs.python.org/issue40

[issue42374] Unparenthesized walrus is not allowed in genexps

2020-11-16 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- keywords: +patch pull_requests: +22210 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23319 ___ Python tracker <https://bugs.python.org/issu

[issue42374] Unparenthesized walrus is not allowed in genexps

2020-11-16 Thread Lysandros Nikolaou
New submission from Lysandros Nikolaou : While a walrus is valid withing generator expressions in 3.8, it's not in 3.9 and onward. ➜ cpython git:(master) ✗ python3.8 Python 3.8.6 (default, Oct 3 2020, 16:26:47) [GCC 9.3.0] on linux Type "help", "copyright", &

[issue42316] Walrus Operator in list index

2020-11-16 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- nosy: +lys.nikolaou nosy_count: 3.0 -> 4.0 pull_requests: +22208 pull_request: https://github.com/python/cpython/pull/23317 ___ Python tracker <https://bugs.python.org/issu

[issue42224] test_format:test_locale fails when locale does not set grouping in thousands

2020-11-02 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42224] test_format:test_locale fails when locale does not set grouping in thousands

2020-11-02 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset 723e21a8e79815ae77474d1f21b9847b9c9bdbeb by Lysandros Nikolaou in branch '3.9': bpo-42224: Fix test_format when locale does not expect number grouping (GH-23067) https://github.com/python/cpython/commit

[issue42224] test_format:test_locale fails when locale does not set grouping in thousands

2020-11-02 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +22028 pull_request: https://github.com/python/cpython/pull/23111 ___ Python tracker <https://bugs.python.org/issue42

[issue42224] test_format:test_locale fails when locale does not set grouping in thousands

2020-11-02 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset 301822859b3fc34801a06f1090d62f9f2ee5b092 by Lysandros Nikolaou in branch 'master': bpo-42224: Fix test_format when locale does not expect number grouping (GH-23067) https://github.com/python/cpython/commit

[issue42224] test_format:test_locale fails when locale does not set grouping in thousands

2020-10-31 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- keywords: +patch pull_requests: +21986 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23067 ___ Python tracker <https://bugs.python.org/issu

[issue42224] test_format:test_locale fails when locale does not set grouping in thousands

2020-10-31 Thread Lysandros Nikolaou
New submission from Lysandros Nikolaou : test_format:test_locale tests for the existence of the thousands separator in a formatted number. However, my locale does not expect/enforce (not sure what the correct term is) grouping the number in thousands, which leads to the test (and consequently

[issue42218] SystemError in compile builtin function

2020-10-31 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42218] SystemError in compile builtin function

2020-10-31 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +21985 pull_request: https://github.com/python/cpython/pull/23066 ___ Python tracker <https://bugs.python.org/issue42

[issue42218] SystemError in compile builtin function

2020-10-31 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset 02cdfc93f82fecdb7eae97a868d4ee222b9875d9 by Lysandros Nikolaou in branch 'master': bpo-42218: Correctly handle errors in left-recursive rules (GH-23065) https://github.com/python/cpython/commit/02cdfc93f82fecdb7eae97a868d4ee222b9875d9

[issue42218] SystemError in compile builtin function

2020-10-31 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- nosy: +lys.nikolaou nosy_count: 3.0 -> 4.0 pull_requests: +21984 pull_request: https://github.com/python/cpython/pull/23065 ___ Python tracker <https://bugs.python.org/issu

[issue42123] Run parser twice; enable invalid_* rules only on the second run

2020-10-27 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset 24a7c298d47658295673dc04d1b6d59f2b200a7c by Lysandros Nikolaou in branch '3.9': [3.9] bpo-42123: Run the parser two times and only enable invalid rules on the second run (GH-22111) (GH-23011) https://github.com/python/cpython/commit

[issue42123] Run parser twice; enable invalid_* rules only on the second run

2020-10-27 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +21927 pull_request: https://github.com/python/cpython/pull/23011 ___ Python tracker <https://bugs.python.org/issue42

[issue41659] PEG discrepancy on 'if {x} {a}: pass'

2020-10-27 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue41659] PEG discrepancy on 'if {x} {a}: pass'

2020-10-27 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset c4b58cea4771afc0ddfdb857b0fb5115b9f4bc9f by Lysandros Nikolaou in branch '3.9': [3.9] bpo-41659: Disallow curly brace directly after primary (GH-22996) (#23006) https://github.com/python/cpython/commit

[issue41659] PEG discrepancy on 'if {x} {a}: pass'

2020-10-27 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +21921 pull_request: https://github.com/python/cpython/pull/23006 ___ Python tracker <https://bugs.python.org/issue41

[issue41659] PEG discrepancy on 'if {x} {a}: pass'

2020-10-27 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset 15acc4eaba8519d7d5f2acaffde65446b44dcf79 by Lysandros Nikolaou in branch 'master': bpo-41659: Disallow curly brace directly after primary (GH-22996) https://github.com/python/cpython/commit/15acc4eaba8519d7d5f2acaffde65446b44dcf79

[issue41659] PEG discrepancy on 'if {x} {a}: pass'

2020-10-26 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +21910 pull_request: https://github.com/python/cpython/pull/22996 ___ Python tracker <https://bugs.python.org/issue41

[issue41659] PEG discrepancy on 'if {x} {a}: pass'

2020-10-26 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: -21195 ___ Python tracker <https://bugs.python.org/issue41659> ___ ___ Python-bugs-list mailing list Unsub

[issue42123] Run parser twice; enable invalid_* rules only on the second run

2020-10-26 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42123] Run parser twice; enable invalid_* rules only on the second run

2020-10-26 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset bca701403253379409dece03053dbd739c0bd059 by Lysandros Nikolaou in branch 'master': bpo-42123: Run the parser two times and only enable invalid rules on the second run (GH-22111) https://github.com/python/cpython/commit

[issue42123] Run parser twice; enable invalid_* rules only on the second run

2020-10-26 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: We do not have a big corpus of SyntaxErrors to test against, but some manual testing of running a file with a SyntaxError after a long complex line 1000 times shows no slowdown. We keep the token stream for the second run, so we don't need to run

[issue42123] Run the two times, only enable invalid_* rules on the second run

2020-10-22 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- keywords: +patch pull_requests: +21835 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22111 ___ Python tracker <https://bugs.python.org/issu

[issue42123] Run the two times, only enable invalid_* rules on the second run

2020-10-22 Thread Lysandros Nikolaou
New submission from Lysandros Nikolaou : We can avoid having to go through all the invalid rules (which might be a significant performance boost, since these may call expensive rules like primary or others), if we run the parser two times. On the first run, all the invalid rules are disabled

[issue41746] Add optional type information to asdl_seq objects

2020-10-21 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Last bit of work is now done. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue41746] Add optional type information to asdl_seq objects

2020-10-21 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset 2e5ca9e3f68b33abb7d2c66d22ffc18dec40641a by Lysandros Nikolaou in branch 'master': bpo-41746: Cast to typed seqs in CHECK macros to avoid type erasure (GH-22864) https://github.com/python/cpython/commit

[issue41746] Add optional type information to asdl_seq objects

2020-10-21 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +21806 pull_request: https://github.com/python/cpython/pull/22864 ___ Python tracker <https://bugs.python.org/issue41

[issue33754] f-strings should be part of the Grammar

2020-10-20 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- nosy: +lys.nikolaou ___ Python tracker <https://bugs.python.org/issue33754> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41746] Add optional type information to asdl_seq objects

2020-10-19 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +21743 pull_request: https://github.com/python/cpython/pull/22786 ___ Python tracker <https://bugs.python.org/issue41

[issue42082] Eliminate test_peg_generator redundant output

2020-10-19 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Let me look into that. -- assignee: -> lys.nikolaou nosy: +lys.nikolaou ___ Python tracker <https://bugs.python.org/issu

[issue40335] [PEP 617 new parser] Regression in multiline SyntaxError offsets

2020-10-19 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I'm closing this since this specific issue seems to be fixed both in master and in 3.9. Anthony, feel free to re-open it, in case I've missed something. -- ___ Python tracker <https://bugs.python.

[issue40335] [PEP 617 new parser] Regression in multiline SyntaxError offsets

2020-10-19 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- resolution: -> fixed status: open -> closed ___ Python tracker <https://bugs.python.org/issue40335> ___ ___ Python-bugs-

[issue41667] The python PEG generator incorrectly handles empty sequences in gather rules

2020-10-19 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- Removed message: https://bugs.python.org/msg378963 ___ Python tracker <https://bugs.python.org/issue41667> ___ ___ Python-bug

[issue41667] The python PEG generator incorrectly handles empty sequences in gather rules

2020-10-19 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: This c -- nosy: +lys.nikolaou resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue41746] Add optional type information to asdl_seq objects

2020-10-19 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Pablo, can this be closed now that PR3 is merged? -- ___ Python tracker <https://bugs.python.org/issue41746> ___ ___

[issue41979] PEG parser doesn't accept extended unpacking in with statement

2020-10-09 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue41826] test_peg_generator compilation warnings

2020-10-03 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset c111355480ff51b50a671679c5099f534cb01cae by Pablo Galindo in branch 'master': bpo-41826: Fix compiler warnings in test_peg_generator (GH-22455) https://github.com/python/cpython/commit/c111355480ff51b50a671679c5099f534cb01cae

[issue41659] PEG discrepancy on 'if {x} {a}: pass'

2020-09-05 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- keywords: +patch pull_requests: +21195 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/22111 ___ Python tracker <https://bugs.python.org/issu

[issue41659] PEG discrepancy on 'if {x} {a}: pass'

2020-08-29 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I had a look at this. I have been testing with the input a{x}, which faces the same problem. It's actually because of an invalid_* rule. The call stack looks like this: ... invalid_comprehension_rule(Parser * p) (/home/lysnikolaou/repos/cpython/Parser

[issue33337] Provide a supported Concrete Syntax Tree implementation in the standard library

2020-08-28 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- nosy: +lys.nikolaou ___ Python tracker <https://bugs.python.org/issue7> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41059] Large number of Coverity reports for parser.c

2020-08-28 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I propose that we take no further action and close this. -- ___ Python tracker <https://bugs.python.org/issue41

[issue40939] Remove the old parser

2020-07-27 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +20783 pull_request: https://github.com/python/cpython/pull/21642 ___ Python tracker <https://bugs.python.org/issue40

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

2020-07-06 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: New changeset 782f44b8fb07ec33cee148b2b6b4cf53024fe0cd by Lysandros Nikolaou in branch 'master': bpo-41215: Make assertion in the new parser more strict (GH-21364) https://github.com/python/cpython/commit/782f44b8fb07ec33cee148b2b6b4cf53024fe0cd

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

2020-07-06 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > Can you prepare a PR? Done. -- ___ Python tracker <https://bugs.python.org/issue41215> ___ ___ Python-bugs-list mai

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

2020-07-06 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +20509 pull_request: https://github.com/python/cpython/pull/21364 ___ Python tracker <https://bugs.python.org/issue41

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

2020-07-06 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Pablo, on second thought, should we maybe change the assertion to `assert(name_len > 0)`? -- ___ Python tracker <https://bugs.python.org/issu

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

2020-07-06 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Pablo, I can do that as well, if you don't have the time. -- ___ Python tracker <https://bugs.python.org/issue41

[issue37458] ast: Different FormattedValue expressions have same col_offset information

2020-07-04 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > I still see this problem with 3.10, which I thought might have fixed this. Nope, that's still true in 3.10. >I'm working on overhauling how these are calculated. But it's complex, and is >taking a while. In short, the FormattedValue nodes

[issue19335] codeop misclassifies incomplete code with 'nonlocal'

2020-06-30 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: some -> same -- ___ Python tracker <https://bugs.python.org/issue19335> ___ ___ Python-bugs-list mailing list Unsubscrib

  1   2   3   4   >