[issue9517] Make test.script_helper more comprehensive, and use it in the test suite
Michael McFadden added the comment: @Christie - Nope. This patch can stand on it's own, simply moving the package to where it belongs. In fact, I'd recommend applying the patch first. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9517] Make test.script_helper more comprehensive, and use it in the test suite
Michael McFadden added the comment: Yes, I did miss that. (Root cause: `git diff` instead of `git diff --staging`) Sorry. I'm learning, and decided to take the git path - might not have been the best choice. I'll submit a new patch shortly. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9517] Make test.script_helper more comprehensive, and use it in the test suite
Michael McFadden added the comment: I'm thinking also, maybe instead of putting script_helper into the test.support namespace, we could move the individual methods and helpers from script_helper into test.support, e.g.: test.support.run_python_until_end vs. test.support.script_helper.run_python_until_end1 Yes, I also agree that this looks better. But as this was first humble patch submission to CPython, I followed David Murry's instructions during my review - which was to move the entire module. I would be opposed to adding the methods directly into __init__.py, I would recommend still moving script_helper into test.support , and adding a list of symbols from script_helper.py into __init__ eg: test/support/__init__.py: from script_helper import run_python_until_end test/some_test.py: from test.support import run_python_until_end I am currently in the PyCon CPython sprint room if you are also here. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9517] Make test.script_helper more comprehensive, and use it in the test suite
Michael McFadden added the comment: Uploading new patch that includes the creation of Lib/test/support/script_helper.py -- Added file: http://bugs.python.org/file39038/iss9517_move_script_helpers_py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19907] gettext - Non ascii chars in header
Michael McFadden added the comment: This might be fixed by issue17156, which would explain why I can't recreate it. https://github.com/python/cpython/commit/f4273cfd16fa502f0eb8a0a8fd1c537ec63e47db -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19907 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19907] gettext - Non ascii chars in header
Michael McFadden added the comment: issue18128 is not related methinks. This ticket: POT-Creation-Date issue18128: PO-Revision-Date -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19907 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17156] Tools/i18n/pygettext.py doesn't parse unicode string.
Michael McFadden added the comment: Also fixes 19907? -- nosy: +flipmcf ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17156 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18128] pygettext: non-standard timestamp format in POT-Creation-Date
Michael McFadden added the comment: Post-review - new patch -- Added file: http://bugs.python.org/file39050/issue18128.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18128 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9517] Make test.script_helper more comprehensive, and use it in the test suite
Michael McFadden added the comment: namespaces are a honkin' great idea I don't have enough information to say that 'script_helper' is the right name for the namespace, tho. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9517] Make test.script_helper more comprehensive, and use it in the test suite
Michael McFadden added the comment: I have a patch for moving script_helper as R. David suggested. Here it is. -- nosy: +flipmcf Added file: http://bugs.python.org/file39003/iss9517_move_script_helpers_py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9517] Make test.script_helper more comprehensive, and use it in the test suite
Michael McFadden added the comment: bobcatfish: Sorry, I didn't refresh and see your comment before submitting my patch. It only moves script_helpers, but doesn't address the original OP. Hopefully I made your life easier, not harder. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9517] Make test.script_helper more comprehensive, and use it in the test suite
Michael McFadden added the comment: re: test.test_tools.py - should this also move into test.support ? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9517 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18128] pygettext: non-standard timestamp format in POT-Creation-Date
Michael McFadden added the comment: I'm going to be adding some tests around pygettext tool and then tackling this. -- nosy: +flipmcf ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18128 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18128] pygettext: non-standard timestamp format in POT-Creation-Date
Michael McFadden added the comment: Patch File iss18128.patch adds test_i18n to start testing the entire Tools/i18n package, and has a very simple fix. -- keywords: +patch Added file: http://bugs.python.org/file39024/iss18128.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18128 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19907] gettext - Non ascii chars in header
Michael McFadden added the comment:
I'm having no luck reproducing this issue.
Regarding pygettext.py generating .po files:
I've used the messages.po file provided by the OP, and also using a generated
.po file from pygettext.py with the offending header PO-Revision-Date:
As a side note, I'm not quite sure how you can get pygettext.py to generate
anything but PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE in python 3.3+, because
it's a static line.
Regarding gettext.py
1: Tools/msgfmt.py -o locales/testlang/LC_MESSAGES/messages.mo
locales/testlang/LC_MESSAGES/messages.po
(all is good)
2: Run this simple script:
import gettext
t = gettext.translation('messages',
localedir='mytests/locales',
languages=['testlang'], )
_ = t.gettext
print('')
print(_('TestMe'))
print('')
Works without exceptions.
The only way I can recreate this issue is by saving my po file in a non-utf8
format (latin-1) and running the above code. It fails perfectly.
Can you help me recreate your issue?
--
nosy: +flipmcf
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19907
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
