Michael Vogt added the comment:
Anything I can do to help moving this issue forward?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Michael Vogt added the comment:
Thanks everyone for the comments and feedback!
Attached is a updated patch with tests and a documentation update.
Feedback is very welcome. I decided to skip the test on systems where root is
not uid,gid=0. I could also mock that of course if you prefer
Michael Vogt added the comment:
Thanks SilentGhost for your feedback and sorry for my slow reply.
I looked into this some more and attached a updated patch with a more complete
test. It also covers a crash now that happens when there is a symlink cycle in
the tar and on disk.
My fix
New submission from Michael Vogt:
The tarfile.makelink() code crashes with a maximum recursion error when it
unpacks a tarfile that contains a symlink into a directory that already
contains this symlink.
Attached is a standalone testcase (that probably better explains whats going
Michael Vogt added the comment:
A possible fix that works with the previous testcase for this bug. It does not
break a tarfile tests.
--
keywords: +patch
Added file: http://bugs.python.org/file37689/possible-fix-37688.diff
___
Python tracker rep
Michael Vogt added the comment:
This patch contains a regression test as well.
--
Added file: http://bugs.python.org/file37690/possible-fix-23228-with-test.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23228
New submission from Michael Vogt:
Please consider adding a option to extract a tarfile with the uid/gid instead
of the lookup for uname/gname in the tarheader (i.e. what tar --numeric-owner
provides).
One use-case is if you unpack a chroot tarfile that contains a
/etc/{passwd,group} file
Michael Vogt added the comment:
Thanks for this detailed explaination! I will workaround this outside of python
(that is easy ;) - I just thought that it would be a good idea to be able to
change the fsencoding (and therefore send the patch), but in the light of e.g.
sys.path it seems
New submission from Michael Vogt:
The Py_FileSystemDefaultEncoding is very static right now and only set on
interpreter statup AFAICT. There appears to be no way to switch that later.
I think that Py_FileSystemDefaultEncoding should get updated when
locale.setlocale() is run automatically
