[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: > I'm not sure that we can break the compatibility with old browser I agree with this. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: Let's me disagree because Python 2.7 is a very special case. One can easily update a browser — they are perfectly compatible. But one cannot just update Python 2.7 because Python 3 is rather a different language that requires a lot of porting effort. So I can imagine Python 2.7 with new browser on the same computer. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: Then I don't have any objections. But I also couldn't test the change — I only use Firefox (and sometimes Chrome). -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: I'd rather rename the new class to something like Firefox. So there will be 3 classes — Netscape, Mozilla and Firefox. Firefox only for firefox executable. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: Done. -- versions: -Python 2.7 Added file: http://bugs.python.org/file45228/webbrowser.py-3.5.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Changes by Oleg Broytman <p...@phdru.name>: Removed file: http://bugs.python.org/file45025/webbrowser.py-3.4-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Changes by Oleg Broytman <p...@phdru.name>: Removed file: http://bugs.python.org/file45216/webbrowser.py-3.5-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Changes by Oleg Broytman <p...@phdru.name>: Removed file: http://bugs.python.org/file45027/webbrowser.py-2.7-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Changes by Oleg Broytman <p...@phdru.name>: Removed file: http://bugs.python.org/file45218/test_webbrowser.py-3.5-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: Oops, yes, mea culpa, sorry. Patch for the test added. -- Added file: http://bugs.python.org/file45218/test_webbrowser.py-3.5-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: What's the error? Buildbot URL? -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: Ah, I see. Ok then, see the new patch. -- Added file: http://bugs.python.org/file45216/webbrowser.py-3.5-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: I don't think Firefox versions <36 are too old to be dropped. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Changes by Oleg Broytman <p...@phdru.name>: Removed file: http://bugs.python.org/file45024/webbrowser.py-2.7-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: Remove empty args (backported from 3.4). -- Added file: http://bugs.python.org/file45027/webbrowser.py-2.7-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: Add NewFox class to webbrowser for Py 3.4 (added raise_opts — Mozilla no longer supports autoraise). -- Added file: http://bugs.python.org/file45025/webbrowser.py-3.4-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: Add NewFox class to webbrowser for Py 2.7 (added raise_opts — Mozilla no longer supports autoraise). -- Added file: http://bugs.python.org/file45024/webbrowser.py-2.7-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Changes by Oleg Broytman <p...@phdru.name>: Removed file: http://bugs.python.org/file43752/webbrowser.py-3.4-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Changes by Oleg Broytman <p...@phdru.name>: Removed file: http://bugs.python.org/file43751/webbrowser.py-2.7-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Changes by Oleg Broytman <p...@phdru.name>: Removed file: http://bugs.python.org/file43749/webbrowser.py-3.4-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Changes by Oleg Broytman <p...@phdru.name>: Removed file: http://bugs.python.org/file43748/webbrowser.py-2.7-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Changes by Oleg Broytman <p...@phdru.name>: Removed file: http://bugs.python.org/file38227/new_firefox.py ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: I am on Debian 8 "jessie" that only has Python 3.4, so I want to patch webbrowser.py in a backward-compatible way. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: Updated patch for Python 2.7 with subprocess.check_output(). -- Added file: http://bugs.python.org/file43751/webbrowser.py-2.7-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: Updated patch for Python 3.4+ with subprocess.check_output(). -- Added file: http://bugs.python.org/file43752/webbrowser.py-3.4-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: Not subprocess.run() as I'm aiming to Python 2.7. Perhaps subprocess.check_output(). I'll try it. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: Patch for Python 3.4 and 3.5 to support Firefox >= 36.0, with version test. -- Added file: http://bugs.python.org/file43749/webbrowser.py-3.4-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: Patch for Python 2.7 to support Firefox >= 36.0, with version test. -- keywords: +patch Added file: http://bugs.python.org/file43748/webbrowser.py-2.7-newfox.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23262] webbrowser module broken with Firefox 36+
Oleg Broytman added the comment: I created the attached module to work with new FF in Python 2.7. You can convert it to proper patch for webbrowser.py. -- nosy: +phd Added file: http://bugs.python.org/file38227/new_firefox.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23262 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18068] pickle + weakref.proxy(self)
New submission from Oleg Broytman: Hello! I've found a problematic behaviour of pickle when it pickles (direct or indirect) weak proxies to self. I suspect pickle cannot detect reference loops with weak proxies. I managed to narrow the case to the following example: import pickle, weakref class TestPickle(object): def __init__(self): self.recursive = weakref.proxy(self) def __getstate__(self): print __getstate__, id(self) return self.__dict__.copy() def __setstate__(self, d): print __setstate__, id(self) self.__dict__.update(d) print - 1 - test = TestPickle() print - 2 - data = pickle.dumps(test, pickle.HIGHEST_PROTOCOL) print - 3 - test2 = pickle.loads(data) print - 4 - print Result:, id(test2) print - 5 - It prints: - 1 - - 2 - __getstate__ 3075348620 __getstate__ 3075348620 - 3 - __setstate__ 3075348844 __setstate__ 3075349004 - 4 - Result: 3075349004 - 5 - That is, __getstate__ is called twice for the same object. And what is worse, __setstate__ is called twice for different objects. The resulting unpickled object is the last one, but in the library that I have been debugging creation of two different objects during unpickling is a bug. I can fix it by avoiding pickling the proxy and recreating the proxy on unpickling: import pickle, weakref class TestPickle(object): def __init__(self): self.recursive = weakref.proxy(self) def __getstate__(self): print __getstate__, id(self) d = self.__dict__.copy() del d['recursive'] return d def __setstate__(self, d): print __setstate__, id(self) self.__dict__.update(d) self.recursive = weakref.proxy(self) print - 1 - test = TestPickle() print - 2 - data = pickle.dumps(test, pickle.HIGHEST_PROTOCOL) print - 3 - test2 = pickle.loads(data) print - 4 - print Result:, id(test2) print - 5 - - 1 - - 2 - __getstate__ 3075070092 - 3 - __setstate__ 3075070188 - 4 - Result: 3075070188 - 5 - But I wonder if it's a bug that should be fixed? If it's an expected behaviour it perhaps should be documented as a warning in docs for pickle or weakref or both. -- components: Library (Lib) messages: 190105 nosy: phd priority: normal severity: normal status: open title: pickle + weakref.proxy(self) type: behavior versions: Python 2.6, Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18068 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13620] Support Chrome in webbrowser.py
Changes by Oleg Broytman p...@phdru.name: Removed file: http://bugs.python.org/file23986/webbrowser.py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13620 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13620] Support Chrome in webbrowser.py
Oleg Broytman p...@phdru.name added the comment: I updated the patch. Thank you for reviewing! -- keywords: +patch Added file: http://bugs.python.org/file24055/webbrowser.py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13620 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13620] Support Chrome in webbrowser.py
Changes by Oleg Broytman p...@phdru.name: Removed file: http://bugs.python.org/file24055/webbrowser.py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13620 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13620] Support Chrome in webbrowser.py
Oleg Broytman p...@phdru.name added the comment: I'm fine with that version. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13620 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13620] Support Chrome in webbrowser.py
New submission from Oleg Broytman p...@phdru.name: Support Google Chrome/Chromium browsers in webbrowser.py. The attached patch is against Python 2.7, but it should be applied cleanly to Python 3+. -- components: Library (Lib) files: webbrowser.py.patch keywords: patch messages: 149666 nosy: phd priority: normal severity: normal status: open title: Support Chrome in webbrowser.py type: enhancement Added file: http://bugs.python.org/file23986/webbrowser.py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13620 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
