[issue44441] Malformed PyImport_Inittab after re-initialization

2021-06-17 Thread Petr Viktorin
Change by Petr Viktorin : -- nosy: +vstinner ___ Python tracker <https://bugs.python.org/issue1> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-06-16 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 7cad9cb51bdae2144cbab330f13a607ba3471742 by Petr Viktorin in branch 'main': bpo-43795: Don't list private names in the limited API (GH-26740) https://github.com/python/cpython/commit/7cad9cb51bdae2144cbab330f13a607ba3471742

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-06-15 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +25326 pull_request: https://github.com/python/cpython/pull/26740 ___ Python tracker <https://bugs.python.org/issue43

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-06-15 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 10a5c806d4dec6c342dcc9888fbe4fa1fa9b7a1f by Erlend Egeberg Aasland in branch 'main': bpo-42064: Move sqlite3 types to global state (GH-26537) https://github.com/python/cpython/commit/10a5c806d4dec6c342dcc9888fbe4fa1fa9b7a1f -- nosy

[issue44351] distutils.sysconfig.parse_makefile() regression in Python 3.10

2021-06-15 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 2f2ea96c4429b81f491aa1cdc4219ef2fd6d37fb by Miss Islington (bot) in branch '3.10': bpo-44351: Restore back parse_makefile in distutils.sysconfig (GH-26637) (GH-26673) https://github.com/python/cpython/commit

[issue44392] Py_GenericAlias is not documented

2021-06-14 Thread Petr Viktorin
Petr Viktorin added the comment: > Can we remove this from the stable API during beta? It was added (to PC/python3.def) in 3.9, so removing in 3.10 beta wouldn't be good. It can be deprecated; should it? -- ___ Python tracker <

[issue44351] distutils.sysconfig.parse_makefile() regression in Python 3.10

2021-06-11 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset fc98266ff627ba0f56f8ae241245b66bc983baa3 by Lumír 'Frenzy' Balhar in branch 'main': bpo-44351: Restore back parse_makefile in distutils.sysconfig (GH-26637) https://github.com/python/cpython/commit/fc98266ff627ba0f56f8ae241245b66bc983baa3

[issue44351] distutils.sysconfig.parse_makefile() regression in Python 3.10

2021-06-09 Thread Petr Viktorin
Petr Viktorin added the comment: IMO, the functionality should only be preserved until distutils is removed. So: - distutils.sysconfig.parse_makefile should use TextFile as before, so projects that use it aren't broken *yet* - nothing else should call distutils.sysconfig.parse_makefile, so

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-06-08 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 75185561a9a3b6dede3ad87bd83bab66847bd425 by Miss Islington (bot) in branch '3.10': bpo-43795: Note Stable ABI PEP in What's New (GH-26479) (GH-26603) https://github.com/python/cpython/commit/75185561a9a3b6dede3ad87bd83bab66847bd425

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-06-08 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 257e400a19b34c7da6e2aa500d80b54e4c4dbf6f by Petr Viktorin in branch 'main': bpo-43795: Note Stable ABI PEP in What's New (GH-26479) https://github.com/python/cpython/commit/257e400a19b34c7da6e2aa500d80b54e4c4dbf6f

[issue44285] Coverity scan: Modules/getpath.c. "calculate_open_pyenv" allocates memory that is stored into "env_file".

2021-06-02 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset bdb56902a3bfe12b10f85a941d5dd0eae739f1a8 by stratakis in branch 'main': bpo-44285: getpath.c: Assert that env_file is NULL during an error check (GH-26486) https://github.com/python/cpython/commit/bdb56902a3bfe12b10f85a941d5dd0eae739f1a8

[issue44285] Coverity scan: Modules/getpath.c. "calculate_open_pyenv" allocates memory that is stored into "env_file".

2021-06-02 Thread Petr Viktorin
Petr Viktorin added the comment: +1, for adding the assertion. It's not trivial to see that env_file must be NULL here, even for me (a human). -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue44

[issue29086] Document C API that is not part of the limited API

2021-06-01 Thread Petr Viktorin
Petr Viktorin added the comment: PEP 652 is now in, and with it a list of everything that *is* in the stable ABI: https://docs.python.org/3.10/c-api/stable.html#contents-of-limited-api I'm closing the issue. -- resolution: -> fixed stage: patch review -> resolved status

[issue23903] Generate PC/python3.def by scraping headers

2021-06-01 Thread Petr Viktorin
Petr Viktorin added the comment: PEP 652 (bpo-43795) is now in; I'm closing this issue. A cross-platform C parser/checker would still be an improvement, but the constraints (no external dependencies in CPython) and benefits (not many compared to the goal of strict separation of internal

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-06-01 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +25074 pull_request: https://github.com/python/cpython/pull/26479 ___ Python tracker <https://bugs.python.org/issue43

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-05-25 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +24946 pull_request: https://github.com/python/cpython/pull/26354 ___ Python tracker <https://bugs.python.org/issue43

[issue44230] lookup extensions with the stable ABI under a platform specific name

2021-05-25 Thread Petr Viktorin
Petr Viktorin added the comment: How will these filenames be generated? Won't build tools like setuptools need to be changed as well? -- ___ Python tracker <https://bugs.python.org/issue44

[issue41282] Deprecate and remove distutils

2021-05-25 Thread Petr Viktorin
Petr Viktorin added the comment: Thank you for doing the hard part, Ned! -- ___ Python tracker <https://bugs.python.org/issue41282> ___ ___ Python-bugs-list m

[issue41282] Deprecate and remove distutils

2021-05-24 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +24921 pull_request: https://github.com/python/cpython/pull/26329 ___ Python tracker <https://bugs.python.org/issue41

[issue41282] Deprecate and remove distutils

2021-05-24 Thread Petr Viktorin
Petr Viktorin added the comment: When building Python, we need two distinct "include" directories: - source .h files - install target for .h files Note that this doesn't matter except when building Python from source. Historically: - source .h files were in the sysconfig sc

[issue44099] [C API] Introduce a new slot in PyModuleDef to hold the classes

2021-05-19 Thread Petr Viktorin
Petr Viktorin added the comment: First off, note that you can use PyModule_AddType rather than PyModule_AddObject to avoid repeating the name. Adding this *correctly* will be somewhat involved: slots take function pointers, not data pointers which are incompatible according to standard C

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-05-19 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +24856 pull_request: https://github.com/python/cpython/pull/26241 ___ Python tracker <https://bugs.python.org/issue43

[issue42591] Method Py_FrozenMain missing in libpython3.9

2021-05-19 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +24857 pull_request: https://github.com/python/cpython/pull/26241 ___ Python tracker <https://bugs.python.org/issue42

[issue44131] [C API] Add tests on Py_FrozenMain()

2021-05-19 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +24858 pull_request: https://github.com/python/cpython/pull/26241 ___ Python tracker <https://bugs.python.org/issue44

[issue42591] Method Py_FrozenMain missing in libpython3.9

2021-05-18 Thread Petr Viktorin
Petr Viktorin added the comment: Is this function actually usable in Windows? ISTM that you need to define three more functions, PyWinFreeze_ExeInit, PyWinFreeze_ExeTerm and PyInitFrozenExtensions. Was adding this undocumented function to the Windows stable ABI deliberate? I see

[issue44131] [C API] Add tests on Py_FrozenMain()

2021-05-18 Thread Petr Viktorin
Petr Viktorin added the comment: The tests are now skipped on Windows. It might be better to use a feature check: hasattr(ctypes.pythonapi, 'Py_FrozenMain') IMO, Py_FrozenMain is quite specific: it's OK if it's exported, but also OK if it's missing. (Unless you're compiling a special build

[issue41111] [C API] Convert a few stdlib extensions to the limited C API (PEP 384)

2021-05-14 Thread Petr Viktorin
Petr Viktorin added the comment: METH_VARARGS and METH_KEYWORDS are part of the stable ABI. -- ___ Python tracker <https://bugs.python.org/issue4> ___ ___

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-05-13 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +24742 pull_request: https://github.com/python/cpython/pull/26101 ___ Python tracker <https://bugs.python.org/issue43

[issue44116] The _csv module can't be garbage-collected after _csv.register_dialect is called

2021-05-12 Thread Petr Viktorin
Petr Viktorin added the comment: Changes to _csv.Error should not be necessary, there everything is handled by the superclass. -- stage: patch review -> ___ Python tracker <https://bugs.python.org/issu

[issue44116] The _csv module can't be garbage-collected after _csv.register_dialect is called

2021-05-12 Thread Petr Viktorin
Petr Viktorin added the comment: The urllib.request one was caused by _hashlib, see GH-26072. -- stage: patch review -> ___ Python tracker <https://bugs.python.org/issu

[issue40645] Use OpenSSL's HMAC API

2021-05-12 Thread Petr Viktorin
Change by Petr Viktorin : -- nosy: +petr.viktorin nosy_count: 5.0 -> 6.0 pull_requests: +24712 pull_request: https://github.com/python/cpython/pull/26072 ___ Python tracker <https://bugs.python.org/issu

[issue44116] The _csv module can't be garbage-collected after _csv.register_dialect is called

2021-05-12 Thread Petr Viktorin
Petr Viktorin added the comment: *facepalm* Yes, that's it. If you have the time now, could you send he PR? -- ___ Python tracker <https://bugs.python.org/issue44

[issue44116] The _csv module can't be garbage-collected after _csv.register_dialect is called

2021-05-12 Thread Petr Viktorin
Change by Petr Viktorin : -- keywords: +patch pull_requests: +24709 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26068 ___ Python tracker <https://bugs.python.org/issu

[issue44116] The _csv module can't be garbage-collected after _csv.register_dialect is called

2021-05-12 Thread Petr Viktorin
Petr Viktorin added the comment: Hm, a similar thing apparently happens with urllib.request. -- ___ Python tracker <https://bugs.python.org/issue44116> ___ ___

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-05-12 Thread Petr Viktorin
Petr Viktorin added the comment: I opened https://bugs.python.org/issue44116 for the leak when trying to unload _csv. Looks like investigating that will take a while, so I'll send a small PR to unblock the buildbots. -- ___ Python tracker <ht

[issue44116] The _csv module can't be garbage-collected after _csv.register_dialect is called

2021-05-12 Thread Petr Viktorin
New submission from Petr Viktorin : After `_csv.register_dialect` is called, the csv module is alive even after it's removed from sys.modules. It should be garbage-collected. (It's not that big a deal: unloading _csv isn't something users should do. But it might be hiding a deeper issue

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-05-12 Thread Petr Viktorin
Petr Viktorin added the comment: Thanks for the note! This is due to `csv`. Adding a script in Tools/scripts that imports csv will also make the refleak check fail. I'll investigate further. -- ___ Python tracker <https://bugs.python.

[issue40222] "Zero cost" exception handling

2021-05-11 Thread Petr Viktorin
Petr Viktorin added the comment: Then, according to PEP 387, "The steering council may grant exceptions to this policy." I think API breaks like this do need coordination at the project level. -- ___ Python tracker <https://bu

[issue40222] "Zero cost" exception handling

2021-05-11 Thread Petr Viktorin
Petr Viktorin added the comment: PyCode_NewWithPosOnlyArgs is not part of the stable ABI. It is OK to break its ABI in a minor version (i.e. 3.11). The PyAPI_FUNC makes it part of the public *API*. It needs to be source- compatible; the number of arguments can't change. Could yo u add a new

[issue43760] The DISPATCH() macro is not as efficient as it could be.

2021-05-10 Thread Petr Viktorin
Petr Viktorin added the comment: PEP 0497 is rejected; the active one is PEP 387, which says "backwards incompatibility" means preexisting code ceases to comparatively function after a change. So, this does look like a backwards-incompatible change. Unfortunately, not all of

[issue23903] Generate PC/python3.def by scraping headers

2021-05-06 Thread Petr Viktorin
Petr Viktorin added the comment: The symbols exported by python3.dll are now generated from Misc/stable_abi.txt as per PEP 652. See the devguide for more details: https://devguide.python.org/c-api/ This is slightly more work than generating the list fully automatically, but the extra work

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-05-05 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +24588 pull_request: https://github.com/python/cpython/pull/25920 ___ Python tracker <https://bugs.python.org/issue43

[issue42083] PyStructSequence_NewType broken in 3.8

2021-05-04 Thread Petr Viktorin
Petr Viktorin added the comment: Changing PyType_FromSpec* to accept NULL has an issue: extensions built and tested with 3.9.5 would not work with the earlier 3.9s. I'll send a PR to fix just PyStructSequence_NewType. -- ___ Python tracker

[issue42083] PyStructSequence_NewType broken in 3.8

2021-05-04 Thread Petr Viktorin
Change by Petr Viktorin : -- nosy: +petr.viktorin nosy_count: 5.0 -> 6.0 pull_requests: +24568 pull_request: https://github.com/python/cpython/pull/25896 ___ Python tracker <https://bugs.python.org/issu

[issue43976] Allow Python distributors to add custom site install schemes

2021-05-04 Thread Petr Viktorin
Petr Viktorin added the comment: Sorry for not getting to this sooner, but 5 days is really tight for such a change. With -S/-I, It would be great if sys.path only included packages installed as part of the OS, and not those installed by `sudo pip`. (Or `pip --user`, but that's covered

[issue28254] Add C API for gc.enable, gc.disable, and gc.isenabled

2021-04-29 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 14fc2bdfab857718429029e53ceffca456178827 by Petr Viktorin in branch 'master': bpo-28254: Add PyGC_ functions to the stable ABI manifest (GH-25720) https://github.com/python/cpython/commit/14fc2bdfab857718429029e53ceffca456178827

[issue28254] Add C API for gc.enable, gc.disable, and gc.isenabled

2021-04-29 Thread Petr Viktorin
Change by Petr Viktorin : -- nosy: +petr.viktorin nosy_count: 5.0 -> 6.0 pull_requests: +24411 pull_request: https://github.com/python/cpython/pull/25720 ___ Python tracker <https://bugs.python.org/issu

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-29 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset f6ee4dad589c0953283dacb577a2d808fda7aae9 by Petr Viktorin in branch 'master': bpo-43795: Generate python3dll.c and doc data from manifest (PEP 652) (GH-25315) https://github.com/python/cpython/commit/f6ee4dad589c0953283dacb577a2d808fda7aae9

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-28 Thread Petr Viktorin
Petr Viktorin added the comment: I hope the PR fixes that. I plan to merge tomorrow if there ar no objections to it. On April 28, 2021 5:15:19 PM GMT+02:00, STINNER Victor wrote: > >STINNER Victor added the comment: > >Right now, running "make regen-limited-abi" adds

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-27 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +24357 pull_request: https://github.com/python/cpython/pull/25668 ___ Python tracker <https://bugs.python.org/issue43

[issue43933] Regression in python3.10 with traceback frame having lineno of -1

2021-04-27 Thread Petr Viktorin
Petr Viktorin added the comment: Please don't lose the big picture here. Previously, the reported line number was *somewhere close* to the currently executing code. That's typically all I need from a traceback: the fix for a bug often needs to go a few lines above/below where it's reported

[issue43868] Remove PyOS_ReadlineFunctionPointer from the stable ABI list

2021-04-23 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 91b69b77cf5f78de6d35dea23098df34b6fd9e53 by Petr Viktorin in branch 'master': bpo-43868: Remove PyOS_ReadlineFunctionPointer from the stable ABI list (GH-25442) https://github.com/python/cpython/commit/91b69b77cf5f78de6d35dea23098df34b6fd9e53

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-23 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 9d6a2d0ee7e55402656e1dec46400591b62db331 by Petr Viktorin in branch 'master': bpo-43795: PEP-652: Clean up the stable ABI/limited API (GH-25482) https://github.com/python/cpython/commit/9d6a2d0ee7e55402656e1dec46400591b62db331

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-23 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset e7cc64e297001cc79b9afab80f71d9e6d1267cb7 by Petr Viktorin in branch 'master': bpo-43795: PEP-652: Simplify headers for easier static analysis (GH-25483) https://github.com/python/cpython/commit/e7cc64e297001cc79b9afab80f71d9e6d1267cb7

[issue41282] Deprecate and remove distutils

2021-04-23 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 90d02e5e63e2cb8f66a2c0dd2ea8d7d4f45f4ebf by Lumír 'Frenzy' Balhar in branch 'master': bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP) (GH-23142) https://github.com/python/cpython/commit

[issue37578] Change Glob: Allow Recursion for Hidden Files

2021-04-22 Thread Petr Viktorin
Petr Viktorin added the comment: I wonder if it would be worth it to add a new option to include hidden files (except . and ..) For the record, setuptools' fork of glob does this unconditionally: https://github.com/pypa/setuptools/blob/main/setuptools/glob.py -- nosy: +petr.viktorin

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-20 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +24208 pull_request: https://github.com/python/cpython/pull/25483 ___ Python tracker <https://bugs.python.org/issue43

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-20 Thread Petr Viktorin
Petr Viktorin added the comment: > Should we mention PEP 652 in Include/README.rst, now that the PEP is accepted? No, we should link to the documentation (when it's written). The PEP is a design document; it'll become outdated. -- ___ Pyt

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-20 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +24207 pull_request: https://github.com/python/cpython/pull/25482 ___ Python tracker <https://bugs.python.org/issue43

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-20 Thread Petr Viktorin
Petr Viktorin added the comment: Thanks for linking to the issues/documentation! I see that Py_GetArgcArgv it was exported in python3.def (i.e. stable ABI) in bpo-40910, which got backported to 3.9. And the removal of PyThreadState_DeleteCurrent was reverted: bpo-38266 While we would like

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-16 Thread Petr Viktorin
Petr Viktorin added the comment: Thanks! I'll send PRs later. -- ___ Python tracker <https://bugs.python.org/issue43795> ___ ___ Python-bugs-list mailin

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-16 Thread Petr Viktorin
Petr Viktorin added the comment: I unsure about the following symbols. Victor, do you think they should be part of the stable ABI? - PyThreadState_DeleteCurrent - Py_GetArgcArgv - PyInterpreterState_GetID -- nosy: +vstinner ___ Python tracker

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-16 Thread Petr Viktorin
Petr Viktorin added the comment: Opened as a separate issue: bpo-43868, Remove PyOS_ReadlineFunctionPointer from the stable ABI list -- ___ Python tracker <https://bugs.python.org/issue43

[issue43868] Remove PyOS_ReadlineFunctionPointer from the stable ABI list

2021-04-16 Thread Petr Viktorin
Change by Petr Viktorin : -- keywords: +patch pull_requests: +24172 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25442 ___ Python tracker <https://bugs.python.org/issu

[issue43868] Remove PyOS_ReadlineFunctionPointer from the stable ABI list

2021-04-16 Thread Petr Viktorin
New submission from Petr Viktorin : The inclusion of PyOS_ReadlineFunctionPointer in python3dll.c (*) was a mistake. According to PEP 384: > functions expecting FILE* are not part of the ABI, to avoid depending on a > specific version of the Microsoft C runtime DLL on Windows. The sit

[issue41282] Deprecate and remove distutils

2021-04-14 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 341e8a939aca6e9f59ffb0e6daee5888933694ed by Lumír 'Frenzy' Balhar in branch 'master': bpo-41282: (PEP 632) Load install schemes from sysconfig (GH-24549) https://github.com/python/cpython/commit/341e8a939aca6e9f59ffb0e6daee5888933694ed

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-14 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 92eebf6dd20c541ca5883d010a575fb6ea4a245c by Petr Viktorin in branch 'master': bpo-43795: Sort PC/python3dll.c (GH-25312) https://github.com/python/cpython/commit/92eebf6dd20c541ca5883d010a575fb6ea4a245c

[issue43831] sqlite: convert_timestamp raises ValueError for empty columns

2021-04-14 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue43831> ___ ___

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-09 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +24050 pull_request: https://github.com/python/cpython/pull/25315 ___ Python tracker <https://bugs.python.org/issue43

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-09 Thread Petr Viktorin
Change by Petr Viktorin : -- keywords: +patch pull_requests: +24047 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25312 ___ Python tracker <https://bugs.python.org/issu

[issue43795] Implement PEP 652 -- Maintaining the Stable ABI

2021-04-09 Thread Petr Viktorin
New submission from Petr Viktorin : This issue tracks implementation of PEP 652. CPython's Limited C-API and Stable ABI, introduced in PEP 384, will be formalized in a single definitive file, tested, and documented. -- messages: 390638 nosy: petr.viktorin priority: normal severity

[issue43725] Create a release branch ABI stability regression test

2021-04-06 Thread Petr Viktorin
Petr Viktorin added the comment: Not sure what platforms libabigail works on, but the set of stable ABI symbols is platform-specific. Currently it's affected by the MS_WINDOWS and HAVE_FORK defines. -- ___ Python tracker <https://bugs.python.

[issue43688] [C API] Support the limited C API in debug mode (Py_INCREF and Py_DECREF)

2021-04-01 Thread Petr Viktorin
Petr Viktorin added the comment: If you do this, please check the performance impact. Py_INCREF/Py_DECREF are very common. -- ___ Python tracker <https://bugs.python.org/issue43

[issue33164] Blake 2 module update

2021-03-25 Thread Petr Viktorin
Petr Viktorin added the comment: This reverted commit 5940c535b06805960d008bcafec7260dae74d9b9 -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue33

[issue43543] stupid download

2021-03-18 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue43543> ___ ___

[issue43503] [subinterpreters] PyObject statics exposed in the limited API break isolation.

2021-03-16 Thread Petr Viktorin
Petr Viktorin added the comment: There seems to be much confusion here. Maybe on my side? PEP 489 is *very much* part of the limited API. -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue43

[issue42967] [CVE-2021-23336] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-03-11 Thread Petr Viktorin
Petr Viktorin added the comment: There's another part of the new implementation that looks a bit fishy: the `separator` argument now allows multi-character strings, so you can parse 'a=1b=2' with separator=''. Was this intentional? -- ___ Python

[issue42967] [CVE-2021-23336] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-03-10 Thread Petr Viktorin
Petr Viktorin added the comment: With the fix, parse_qs[l] doesn't handle bytes separators correctly. There is an explicit type check for str/bytes: if not separator or (not isinstance(separator, (str, bytes))): raise ValueError("Separator must be of type string or

[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

2021-02-23 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 7bb1cafa4e3d648669212ea4c6d11d6eafc6da23 by Petr Viktorin in branch 'master': bpo-43239: Export PyCFunction_New with PyAPI_FUNC (GH-24551) https://github.com/python/cpython/commit/7bb1cafa4e3d648669212ea4c6d11d6eafc6da23

[issue28429] ctypes fails to import with grsecurity's TPE

2021-02-18 Thread Petr Viktorin
Petr Viktorin added the comment: Glandos, thank you for the report and fix, and apologies that it wasn't seen by the right set of eyes. -- nosy: +petr.viktorin resolution: -> fixed stage: patch review -> resolved status: open -> closed _

[issue29086] Document C API that is not part of the limited API

2021-02-18 Thread Petr Viktorin
Petr Viktorin added the comment: PEP 652 is currently draft & it's discussed at https://discuss.python.org/t/pep-652-maintaining-the-stable-abi/6986 -- ___ Python tracker <https://bugs.python.org/iss

[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

2021-02-16 Thread Petr Viktorin
Petr Viktorin added the comment: > By the way, I would suggest to move "#define PyCFunction_New(ML, SELF) > PyCFunction_NewEx((ML), (SELF), NULL)" to Include/cpython/methodobject.h Wait no, I wrote too soon. PyCFunction_NewEx is part of the limited API as well,

[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

2021-02-16 Thread Petr Viktorin
Petr Viktorin added the comment: > By the way, I would suggest to move "#define PyCFunction_New(ML, SELF) > PyCFunction_NewEx((ML), (SELF), NULL)" to Include/cpython/methodobject.h OK, I'll add that move to the PR. > Oh, it's not listed by Doc/data/stable_abi.dat

[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

2021-02-16 Thread Petr Viktorin
Change by Petr Viktorin : -- keywords: +patch pull_requests: +23334 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24551 ___ Python tracker <https://bugs.python.org/issu

[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

2021-02-16 Thread Petr Viktorin
New submission from Petr Viktorin : PyCFunction_New is part of the Stable ABI (see bpo-21354), but it is not declared as PyAPI_FUNC, and thus not exported with GCC's -fvisibility=hidden. To match Windows, it should be declared. (I don't think this has any real impact, I just want to fix

[issue23903] Generate PC/python3.def by scraping headers

2021-02-16 Thread Petr Viktorin
Petr Viktorin added the comment: I plan to do this slightly differently, see PEP 652. -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue23

[issue43235] Tools/scripts/stable_abi.py should also check PC/python3dll.c (Windows stable ABI)

2021-02-15 Thread Petr Viktorin
Petr Viktorin added the comment: I want to address this in PEP 652. -- ___ Python tracker <https://bugs.python.org/issue43235> ___ ___ Python-bugs-list mailin

[issue43155] PyCMethod_New not defined in python3.lib

2021-02-12 Thread Petr Viktorin
Petr Viktorin added the comment: > Is there a test suite that checks that the limited API functions can all be > linked against? Not yet. There's not even consensus about exactly what functions are part of the limited API. I plan to address both issues in PEP 652 (currently in Draft

[issue29086] Document C API that is not part of the limited API

2021-02-02 Thread Petr Viktorin
Petr Viktorin added the comment: The bigger problem is that currently, it's not clear what is limited API and what is not. I am working to propose a PEP to fix this. It will also cover documentation: https://discuss.python.org/t/pre-pep-maintaining-the-stable-abi/6986 -- nosy

[issue40601] [C API] Hide static types from the limited C API

2021-02-02 Thread Petr Viktorin
Petr Viktorin added the comment: Sorry, I lost this bug in my TODO list :( > > I don't think it's necessary here. > > Did you read my rationale (first message)? Do you mean that per-interpreter > GIL is not worth it? Right, I mean that it it is not worth breaking the C-API f

[issue43054] What does the existence of a struct in a header file imply about the C-API

2021-01-28 Thread Petr Viktorin
Petr Viktorin added the comment: When we're talking just about API, not the stable ABI (which contains only a few structs), reordering and additions should be fair game. > Rather than go through this tortuous analysis for all headers, it might be > better to document which structs ar

[issue42035] [C API] PyType_GetSlot cannot get tp_name

2021-01-19 Thread Petr Viktorin
Petr Viktorin added the comment: Now that I see the implementation (and now that I'm spending a lot of time trying to formalize what is good stable API), I see a problem with PyType_GetName: it effectively returns a borrowed reference. The proposed docs say: Callers can hold [the retuned

[issue41713] _signal module leak: test_interpreters leaked [1424, 1422, 1424] references

2021-01-19 Thread Petr Viktorin
Petr Viktorin added the comment: The PyOS_InitInterrupts function is still listed in PC/python3dll.c. -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue41

[issue41818] Lib/pty.py major revision

2021-01-19 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 65cf1ad6723b6b4489fa7dda04283bb2466be531 by Petr Viktorin in branch 'master': bpo-41818: Close file descriptors in test_openpty (#GH-24119) https://github.com/python/cpython/commit/65cf1ad6723b6b4489fa7dda04283bb2466be531

[issue41701] Buildbot web page: connection lost after 1 minute, then display "Connection restored" popup

2021-01-19 Thread Petr Viktorin
Change by Petr Viktorin : -- keywords: +patch pull_requests: +23077 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24119 ___ Python tracker <https://bugs.python.org/issu

[issue41701] Buildbot web page: connection lost after 1 minute, then display "Connection restored" popup

2021-01-19 Thread Petr Viktorin
Petr Viktorin added the comment: Is there anything I can help with to move this forward? Investigating buildbot failures continues to be very annoying. -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue41

[issue42962] Windows: SystemError during os.kill(..., signal.CTRL_C_EVENT)

2021-01-18 Thread Petr Viktorin
Change by Petr Viktorin : -- nosy: -petr.viktorin ___ Python tracker <https://bugs.python.org/issue42962> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40052] Incorrect pointer alignment in _PyVectorcall_Function() of cpython/abstract.h

2021-01-14 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue1635741] Py_Finalize() doesn't clear all Python objects at exit

2021-01-12 Thread Petr Viktorin
Petr Viktorin added the comment: In GH-23598, PyModule_AddObjectRef was added as EXPORT_DATA. Shouldn't it be EXPORT_FUNC? -- ___ Python tracker <https://bugs.python.org/issue1635

[issue40052] Incorrect pointer alignment in _PyVectorcall_Function() of cpython/abstract.h

2021-01-12 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 187f76def8a5bd0af7ab512575cad30cfe624b05 by Petr Viktorin in branch '3.8': [3.8] bpo-40052: Fix alignment issue in PyVectorcall_Function() (GH-23999) (GH-24120) https://github.com/python/cpython/commit/187f76def8a5bd0af7ab512575cad30cfe624b05

  1   2   3   4   5   6   7   >