[issue11218] pattern=None when following documentation for load_tests and unittest.main()

2012-04-13 Thread Rik Poggi
Rik Poggi poggi.ri...@gmail.com added the comment: I wasn't trying to make any argument, just thinking that such particular signature was intentional. Also notice that there might be code that doesn't pass the pattern argument, and fall back on the default value. So a signature change

[issue11060] distutils2 sdist does not complain about version that is not PEP 386 compliant

2012-04-09 Thread Rik Poggi
Rik Poggi poggi.ri...@gmail.com added the comment: Moving on, I've understood what the bug is about. I've made a couple of tests for this issue. I'm waiting for a review before adding others (if necessary). The fix is not going to be easy, because I'm not sure about the Metadata design. I

[issue11218] pattern=None when following documentation for load_tests and unittest.main()

2012-04-09 Thread Rik Poggi
Rik Poggi poggi.ri...@gmail.com added the comment: I think the doc should be improved (http://docs.python.org/library/unittest.html#load-tests-protocol), it's not clear how pattern in the example (last one) could not be None. Changing the discover signature doesn't seem to be an option since

[issue11060] distutils2 sdist does not complain about version that is not PEP 386 compliant

2012-04-06 Thread Rik Poggi
Rik Poggi poggi.ri...@gmail.com added the comment: Thanks, I'll wait! In the meanwhile I couldn't help to dig a little deeper and found that the Metadata class is currently logging a warning. Should the commands raise something when there's a warning in strict mode? I was playing

[issue11060] distutils2 sdist does not complain about version that is not PEP 386 compliant

2012-04-06 Thread Rik Poggi
Rik Poggi poggi.ri...@gmail.com added the comment: My assumption that the random log message was related to this bug seems to be completely wrong. It seems, instead, related to a starstar call of create_dist in the support module that will loose the order (of an OrderedDict obviously

[issue11060] distutils2 sdist does not complain about version that is not PEP 386 compliant

2012-04-05 Thread Rik Poggi
Rik Poggi poggi.ri...@gmail.com added the comment: Hi, I'd like to contribute to this bug if it's possible. I would've directly started, but it seems the situation has moved/changed a bit, so I'm not sure where the tests are needed. There's a try/except, like the one mentioned above, in pypi

[issue11060] distutils2 sdist does not complain about version that is not PEP 386 compliant

2012-04-05 Thread Rik Poggi
Rik Poggi poggi.ri...@gmail.com added the comment: Strictly related or not to this bug, a bit more test coverage shouldn't hurt. So while waiting for a reply I started writing a couple of tests for pypi/dist.py, hope they look good. -- Added file: http://bugs.python.org/file25134