[issue45804] IDLE - faster shell writing

2021-11-14 Thread Roger Serwy


Roger Serwy  added the comment:

All good questions, Terry! I do have a git clone of the cpython repo, but I 
haven't worked through the new commit/patch process since Mercurial. I'm a bit 
rusty.

The buffering provided is for calls to `write`. It does not do any line 
buffering. Calls to `isatty` will behave the same. The negative side effect is 
that the subprocess will proceed as if writes have been committed to the 
PyShell window, so any pending transfers can be lost if the subprocess 
terminates unexpectedly.

I used a separate OS thread to handle the transfer of the writes rather than 
using the Tcl/Tk event loop. The Tcl/Tk loop runs on the main thread, so any 
long-running processes will prevent a `.after` callback function from being 
called.

The base class was not changed. I haven't followed all the changes to the 
stream class (and its implications) since 3.5, so the code subclasses the newer 
`StdOutputFile` class to minimize disruption.

--

___
Python tracker 
<https://bugs.python.org/issue45804>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45804] IDLE - faster shell writing

2021-11-13 Thread Roger Serwy


New submission from Roger Serwy :

The shell provided by IDLE uses synchronous sys.stdout.write() calls between 
the subprocess and the front-end, leading to very slow writes. The provided 
patch proposes buffering the stdout/stderr streams in the subprocess and then 
sending a single update after 50ms. The patch also provides back pressure on 
the buffer so that it doesn't grow without bound.

When trying the behavior of the patch, disable the squeezer extension, or set 
its limit to 1000. Then in the shell, run:

for i in range(500): print(i)

The output will instantly appear in the shell.

--
files: idlelib_buffer_output.patch
keywords: patch
messages: 406306
nosy: roger.serwy, terry.reedy
priority: normal
severity: normal
stage: patch review
status: open
title: IDLE - faster shell writing
type: enhancement
versions: Python 3.10
Added file: https://bugs.python.org/file50438/idlelib_buffer_output.patch

___
Python tracker 
<https://bugs.python.org/issue45804>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31880] subprocess process interaction with IDLEX GUI causes pygnuplot silent failures

2018-11-01 Thread Roger Serwy


Roger Serwy  added the comment:

I am closing this issue. For future reference, IDLEX is a separate project from 
IDLE. Please refer IDLEX bugs to the project developer (me).

--
assignee:  -> terry.reedy
components: +IDLE -Interpreter Core, Windows
nosy: +roger.serwy, terry.reedy
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue31880>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33000] IDLE Doc: Text consumes unlimited RAM, consoles likely not

2018-11-01 Thread Roger Serwy


Roger Serwy  added the comment:

Big Stone: Yes, IDLEX does have a slow memory leak. Please check if this bug is 
happening with IDLE itself.

Terry: Thanks for responding to this. I suggest this issue can be closed.

--
nosy: +roger.serwy

___
Python tracker 
<https://bugs.python.org/issue33000>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

2014-08-28 Thread Roger Serwy

Roger Serwy added the comment:

When it comes to the checkmark next to Code Context in the menu, be aware of 
issue13179. You can launch IDLE, open two separate editors, enable Code Context 
in one, and the other will have its menu entry checked as well when it is not 
enabled.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17535
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6143] IDLE - an extension to clear the shell window

2014-02-11 Thread Roger Serwy

Roger Serwy added the comment:


 Removing text before iomark can be done by using the underlying Text widget 
 directly. See how the Squeezer extension does this in issue1529353. This 
 should simplify the implementation significantly.

I agree that the underlying .delete can be called directly, bypassing 
the ModifiedUndoDelegator in the percolator chain. I have mixed opinions 
about the Percolator, but that's another issue.


 1. Is there a reason that text.dump() isn't called inside 
 ClearWindowDeleteCommand.do()?

There is no compelling reason. I agree that it should be moved to .do()

 2. What is the purpose of strip_ansi()?

That's an artifact from earlier code for IPython compatibility. The 
colored text prompts in IPython use ANSI escape codes, and the older 
undo code reinserted the text without restoring tags.

Using text.dump() and the restore routine in undo() now restore the tags 
and eliminates the need for strip_ansi(). I haven't removed that old 
code yet.

 3. Does IDLE support multi-line prompts, or is that just IdleX? As a side 
 note, it seems that in IDLE the debugger will override the prompt with ' ' 
 whenever it is shut down (see PyShell.close_debugger); perhaps this is a bug?

IDLE itself does support multi-line prompts. The debugger is a whole 
other can of worms.

 4. I see ClearWindowDeleteCommand just calls text.delete() and text.insert to 
 modify text before the iomark. Will this work on regular IDLE as well, or 
 this is possible only in IdleX?

It should work on regular IDLE. IdleX wraps the existing CPython IDLE.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6143
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18988] Tab key doesn't work sometimes.

2013-09-09 Thread Roger Serwy

Roger Serwy added the comment:

LGTM. I manually tested it by assigning a = 1 and then pressing tab at 
after a, aa,  aaa, and a, and then pressing tab afterwards. Tab 
works to complete the name, and then afterwards when it has been replaced with 
a.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18988
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18226] IDLE Unit test for FormatParagrah.py

2013-07-17 Thread Roger Serwy

Changes by Roger Serwy roger.se...@gmail.com:


--
nosy: +roger.serwy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18226
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18288] Idle 2.7: Run Module does not set __file__

2013-06-30 Thread Roger Serwy

Roger Serwy added the comment:

See issue8515. The patch was not applied to 2.7.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18288
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18318] Idle: stop depending on console output

2013-06-30 Thread Roger Serwy

Roger Serwy added the comment:

This looks similar to issue13582 with the patch to redirect console writes to a 
GUI text box.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18318
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17838] Can't assign a different value for sys.stdin in IDLE

2013-06-11 Thread Roger Serwy

Roger Serwy added the comment:

I'm closing this issue as the original problem reported has been resolved.

--
stage: needs patch - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17838
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5492] Error on leaving IDLE with quit() or exit() under Linux

2013-06-11 Thread Roger Serwy

Roger Serwy added the comment:

I noticed that the tracebacks didn't occur in 2.7 due to 872a3aca2120, but that 
patch was not grafted onto the 3.x branches. I'll take care of that.

With #13495 fixed, the two errors mentioned in msg187323 do not occur with the 
_rev1 patch applied.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5492
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5492] Error on leaving IDLE with quit() or exit() under Linux

2013-06-11 Thread Roger Serwy

Roger Serwy added the comment:

This issue is now fixed. Thank you everyone for helping!

--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5492
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18196] IDLE: forward apply patch for handling SystemExit

2013-06-11 Thread Roger Serwy

New submission from Roger Serwy:

As a formality, I opened this issue to apply 872a3aca2120 to the 3.x branch. 
This addresses a concern brought up by Terry in msg187323 from issue5492. 
Here's the relevant part of the message:


Without or with patch, quit() or exit brings up TK box
(?) The program is still running!
Do you want to kill it?
[OK]  [Cancel]
Did this always happen?

[Cancel] causes traceback (not good, regression?)
Traceback (most recent call last):
  File pyshell#0, line 1, in module
quit()
  File D:\Python\dev\cpython\lib\site.py, line 356, in __call__
raise SystemExit(code)
SystemExit: None


--
assignee: roger.serwy
components: IDLE
files: catch_exit.patch
keywords: patch
messages: 191007
nosy: rhettinger, roger.serwy, terry.reedy
priority: low
severity: normal
stage: patch review
status: open
title: IDLE: forward apply patch for handling SystemExit
type: behavior
versions: Python 3.3, Python 3.4
Added file: http://bugs.python.org/file30551/catch_exit.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18196
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18196] IDLE: forward apply patch for handling SystemExit

2013-06-11 Thread Roger Serwy

Roger Serwy added the comment:

And it's applied.

--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18196
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17511] Idle find function closes after each find operation

2013-06-10 Thread Roger Serwy

Roger Serwy added the comment:

I'm closing this issue as fixed. Thank you for the patch, Sarah.

--
resolution:  - fixed
stage: commit review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17511
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16809] Tk 8.6.0 introduces TypeError. (Tk 8.5.13 works)

2013-05-29 Thread Roger Serwy

Roger Serwy added the comment:

The problem I'm encountering is that tk.splitlist() is now being given a 
Tcl_Obj instead of a str type. Since everything is Tcl is a string, 
explicitly casting a Tcl_Obj to a string seems reasonable. Attached is some 
proof-of-concept code to work around the issue.


Serhiy's patch against 3.4 gives this traceback:

[python@saturn 3.4]$ ./python tk_86_error.py 
8.6
Traceback (most recent call last):
  File tk_86_error.py, line 6, in module
label.pack_info()
  File /home/python/python/3.4/Lib/tkinter/__init__.py, line 1924, in 
pack_info
if value[:1] == '.':
TypeError: '_tkinter.Tcl_Obj' object is not subscriptable

--
stage: patch review - needs patch
Added file: http://bugs.python.org/file30421/tk_86_workaround.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16809
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7136] Idle File Menu Option Improvement

2013-05-29 Thread Roger Serwy

Roger Serwy added the comment:

LGTM. Thanks Todd!

--
assignee:  - roger.serwy
stage: needs patch - commit review
versions: +Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7136
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18052] IDLE 3.3.2 Windows taskbar icon regression

2013-05-29 Thread Roger Serwy

Roger Serwy added the comment:

I'm running Win7 64-bit in a VM. The steps for me was to start with a system 
without any Python version installed. Install 3.3.1 32-bit, and then install 
3.3.2 32-bit. IDLE launches with a red Tk icon and pinning it to the task bar 
does not actually pin IDLE. A reboot does fix the issue, as Terry observed.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18052
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18052] IDLE 3.3.2 Windows taskbar icon regression

2013-05-28 Thread Roger Serwy

Roger Serwy added the comment:

For me, 3.3.2 32-bit won't pin to the taskbar, but 3.3.1 can. Running 
lnk-parser on the .lnk files for IDLE reveal no obvious differences.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18052
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17511] Idle find function closes after each find operation

2013-05-28 Thread Roger Serwy

Roger Serwy added the comment:

I debated whether or not to leave #14146 as pending or to close it out 
altogether. I'd rather not let the design decisions of Tk dictate inconsistent 
cross-platform behavior for IDLE, but I'm willing to hear Tk's rationale and 
possible fix for that problem.

I would like to commit the current patch and close this issue.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17511
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5124] IDLE - pasting text doesn't delete selection

2013-05-26 Thread Roger Serwy

Roger Serwy added the comment:

There are many X11 applications that replace the selection with pasted text. 
GTK and Qt widgets behave that way. Here's a brief list: gedit (GTK), gummi 
(GTK), kate (Qt), texmaker (Qt).

Tkinter, for me, has become increasingly frustrating due to these subtle 
platform differences. (See #14146, #13582, and many more that deal with Tk on 
Mac.) For IDLE, I consider these behavior differences bugs.

The attached patch fixes this issue.

--
keywords: +patch
Added file: http://bugs.python.org/file30385/issue5124.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5124
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18055] Stop using imp in IDLE

2013-05-25 Thread Roger Serwy

Roger Serwy added the comment:

@Brett, I agree that IDLE should not be using deprecated modules. I don't know 
all the ins and outs of the import machinery of Python, so I'll defer to your 
expertise in that area. :-) 

@Terry, I have never used this IDLE feature before, so I don't know all it's 
corner cases or expected behavior.

The patch works when opening os but fails with sys. Without the patch, a 
dialog box appears saying No source for module sys. With the patch, I get 
not a source-based module and then another dialog loader does not support 
get_filename, and then this exception raises:

Exception in Tkinter callback
Traceback (most recent call last):
  File /home/python/python/3.4/Lib/tkinter/__init__.py, line 1475, in __call__
return self.func(*args)
  File /home/python/python/3.4/Lib/idlelib/EditorWindow.py, line 680, in 
open_module
self.flist.open(file_path)
UnboundLocalError: local variable 'file_path' referenced before assignment

Serhiy's review comments on the patch about adding return in those three 
places does fix that problem.

Attached is a revision to include Serhiy's suggestions.

--
Added file: http://bugs.python.org/file30376/imp_remove_rev1.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18055
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17658] pythonw.exe crashes on opening IDLE

2013-05-25 Thread Roger Serwy

Roger Serwy added the comment:

I'm closing this issue due since it's root problem is a misconfigured 
environment variable.

--
resolution:  - works for me
status: pending - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17658
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17658] pythonw.exe crashes on opening IDLE

2013-05-25 Thread Roger Serwy

Roger Serwy added the comment:

s/it's/its

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17658
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14146] IDLE: source line in editor doesn't highlight when debugging

2013-05-20 Thread Roger Serwy

Roger Serwy added the comment:

I committed the Tk workaround for the Windows platform. I'm leaving this issue 
as pending with a resolution of later in case Tk developers address the bug 
report mentioned in msg185632.

If anyone else wishes to close it, feel free.

--
resolution:  - later
stage: commit review - committed/rejected
status: open - pending

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14146
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17511] Idle find function closes after each find operation

2013-05-20 Thread Roger Serwy

Roger Serwy added the comment:

issue_17511_FindNext_rev1.patch keeps the find dialog open and changes the 
button from Find to Find Next. The applied patch from #14146 corrects the 
selection tag highlighting issue.

--
Added file: http://bugs.python.org/file30329/issue_17511_FindNext_rev1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17511
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17658] pythonw.exe crashes on opening IDLE

2013-05-20 Thread Roger Serwy

Roger Serwy added the comment:

Patrick, does removing PYTHONPATH from your environment variables fix this 
problem?

--
nosy: +roger.serwy
status: open - pending

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17658
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3559] Pasted \n not same as typed \n

2013-05-19 Thread Roger Serwy

Roger Serwy added the comment:

The core problem is that IDLE only executes the shell buffer when the 
newline-and-indent virtual event gets sent by physically pressing the Enter 
key. Pasting the clipboard contents with \n will not trigger the enter_callback 
function in Lib/idlelib/PyShell.py.

The MultiLineRun.py extension as part of IdleX intercepts the pasted text and 
splits the buffer on '\n' and then runs each line.

Mark, what you are suggesting is adding something like a Paste and Execute 
option for the shell and its right-click menu which mimics the %paste magic 
from IPython. That's doable.

--
nosy: +roger.serwy
versions: +Python 2.7, Python 3.3, Python 3.4 -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3559
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14146] IDLE: source line in editor doesn't highlight when debugging

2013-05-13 Thread Roger Serwy

Roger Serwy added the comment:

It won't make it in 2.7.5. Benjamin tagged the 2.7.5 release a couple of days 
ago.

I'll apply this later tonight.

--
stage: patch review - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14146
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14146] IDLE: source line in editor doesn't highlight when debugging

2013-05-13 Thread Roger Serwy

Roger Serwy added the comment:

On second thought, I'll wait until after the releases so that Misc/NEWS gets 
populated properly.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14146
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13657] IDLE doesn't support sys.ps1 and sys.ps2.

2013-05-13 Thread Roger Serwy

Roger Serwy added the comment:

Adding 16123 as a dependency. Resolving sys.ps1 and sys.ps2 will likely be 
simpler when only considering one execution mode.

--
dependencies: +IDLE - deprecate running without a subprocess
nosy: +roger.serwy
versions: +Python 2.7, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13657
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17642] IDLE add font resizing hot keys

2013-05-13 Thread Roger Serwy

Roger Serwy added the comment:

@Abhishek: I'd rather not require extensions to have a new method for resetting 
font sizes. Instead, a virtual event can be bound to a callback by the 
extension if it needs to know about a font change.

@Alejandro: It looks like there's a bug in ZoomFont.py where the cursor can go 
off screen which has propagated into these patches. That's my fault.

I'll take a look at these points later this week.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17838] Can't assign a different value for sys.stdin in IDLE

2013-05-12 Thread Roger Serwy

Roger Serwy added the comment:

Georg, I need to clarify what I meant in msg188301. Issue9290 was applied to 
3.2 which introduced the bug addressed in issue17585, whose fix then introduced 
issue17838.

IDLE on the 3.2 branch doesn't handle exit() or quit() correctly. It needs both 
#17585 and #17838 to be applied, as Serhiy said.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17838
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14146] IDLE: source line in editor doesn't highlight when debugging

2013-05-12 Thread Roger Serwy

Roger Serwy added the comment:

I'm waiting until after the next wave of maitenance releases before I apply 
this patch. If anyone feels strongly that it should be applied now, let me know.

I applied the patch to the latest 2.7.4 64-bit release version of Python and it 
worked.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14146
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2704] IDLE: Patch to make PyShell behave more like a Terminal interface

2013-05-09 Thread Roger Serwy

Roger Serwy added the comment:

Welcome Phil! Your patch looks good and applied cleanly to the default branch 
and behaves as you specified. Your submission mechanics are good!

You might want to look into signing a contributor's agreement: 
http://docs.python.org/devguide/coredev.html#sign-a-contributor-agreement

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2704
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14146] IDLE: source line in editor doesn't highlight when debugging

2013-05-07 Thread Roger Serwy

Roger Serwy added the comment:

I'm pinging this issue to see if anyone has had any problems with the 
Windows-specific workaround for highlighting the selection tags. Issue17511 
depends on this fix.

--
assignee:  - roger.serwy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14146
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17798] IDLE: can not edit new file names when using -e

2013-05-05 Thread Roger Serwy

Roger Serwy added the comment:

I'm closing this issue as fixed.

--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17798
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13495] IDLE: Regressions - Two ColorDelegator instances loaded

2013-05-05 Thread Roger Serwy

Roger Serwy added the comment:

I'm closing this issue as fixed.

--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13495
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5492] Error on leaving IDLE with quit() or exit() under Linux

2013-05-05 Thread Roger Serwy

Roger Serwy added the comment:

Terry, the SystemExit traceback from clicking cancel is expected given how 
Lib/site.py's Quitter first closes sys.stdin and then raises SystemExit. 
Closing sys.stdin causes the dialog, the raised exception just gets printed.

We could change the behavior such that when IDLE's internals catch SystemExit, 
then the close dialog appears. This avoids having to rely on closing sys.stdin 
to signal IDLE to close. See issue17838 for the patch to do just that.

(It looks like #17838, #17585, and this issue are converging.)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5492
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15809] IDLE console uses incorrect encoding.

2013-05-04 Thread Roger Serwy

Roger Serwy added the comment:

There is a problem. Adding the encoding comment to the top of the source causes 
off-by-one line errors in the traceback.

Take as an example:

 1/0

Traceback (most recent call last):
  File pyshell#0, line 2, in module
ZeroDivisionError: integer division or modulo by zero


--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15809
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17838] Can't assign a different value for sys.stdin in IDLE

2013-05-03 Thread Roger Serwy

Roger Serwy added the comment:

3.2 still has the problem fixed in issue17585 for 3.3 and 3.4. This only 
applies if issue17585 patch gets applied to 3.2.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17838
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17838] Can't assign a different value for sys.stdin in IDLE

2013-05-02 Thread Roger Serwy

Roger Serwy added the comment:

Keeping the sys.stdin reference alive and then reassigning sys.stdin prevents 
exit() and quit() from actually closing IDLE since site.py's code closes 
sys.stdin which then does not trigger PyShell's close() method. I updated 
Terry's patch to explicitly call the close method when SystemExit gets raised.

IDLE's subprocess clears atexit handlers before shutdown so they never get 
called. See exit() from Lib/idlelib/run.py.

The debugger can not handle stepping through a raise SystemExit from the 
shell, even long before any sys.std* patches got applied. That's a separate 
issue that should be opened. I mention that so that if anyone manually tests 
with the debugger that this behavior is expected.

--
Added file: http://bugs.python.org/file30112/Terry17838_rev1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17838
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17721] Help button on preference window doesn't work

2013-04-30 Thread Roger Serwy

Roger Serwy added the comment:

LGTM.

--
stage:  - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17721
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17864] IDLE won't run

2013-04-29 Thread Roger Serwy

Roger Serwy added the comment:

This looks like a duplicate of issue8231.

--
nosy: +roger.serwy
type: crash - behavior

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17864
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17642] IDLE add font resizing hot keys

2013-04-29 Thread Roger Serwy

Roger Serwy added the comment:

Abhishek, Alejandro, welcome to IDLE development! If you can, please sign a 
contributor agreement.

We have two patches to create this enhancement, both are good. I suggest that 
we figure out how to merge the solutions.

The zoom-out binding should also include Ctrl-Equal, so that holding shift is 
no longer necessary. There's also a corner case where the zooming in on the 
editor may cause the cursor to go outside of viewing window.

Using idleConf to query the font information is not strictly necessary since 
the font configuration in the text widget contains the font size already.

In the future, please be careful with licensing. The top part of the 
ZoomFont.py extension places it under the NCSA license. Fortunately UIUC has 
allowed me to relicense parts IdleX for the Python Software Foundation.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17838] Can't assign a different value for sys.stdin in IDLE

2013-04-28 Thread Roger Serwy

Roger Serwy added the comment:

I agree with Serhiy that the patch should be updated to better explain why the 
extra reference to stdin was being held. The attached patch provides that 
update in case anyone considers applying it in the future.

Terry, are you suggesting that the code should read like sys.__stdin__ = 
sys.stdin within MyHandler in Lib/idlelib/run.py ?

--
Added file: http://bugs.python.org/file30042/hold_stdin_rev1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17838
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17838] Can't assign a different value for sys.stdin in IDLE

2013-04-26 Thread Roger Serwy

Roger Serwy added the comment:

If we remove .close() then we'll need to then have an alternative way to allow 
exit() and quit() to actually close IDLE. The RPC proxy already transfers 
exceptions between the subprocess and the front-end, so we could catch the 
SystemExit exception and handle it by calling close(). That's perfectably 
doable, and likely the right way to do it. If anyone wants to write that patch, 
I'll gladly offer guidance if necessary.

Here's a dirty hack that also solves the issue. Garbage collection on the 
PseudoInputFile for sys.stdin calls .close(). As long as we hold an extra 
reference to it, it won't close. The attached patch holds an extra reference to 
sys.stdin in Lib/idlelib/run.py.

--
keywords: +patch
Added file: http://bugs.python.org/file30027/hold_stdin.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17838
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17721] Help button on preference window doesn't work

2013-04-26 Thread Roger Serwy

Changes by Roger Serwy roger.se...@gmail.com:


--
nosy: +terry.reedy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17721
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17838] Can't assign a different value for sys.stdin in IDLE

2013-04-25 Thread Roger Serwy

Roger Serwy added the comment:

Are you running with or without a subprocess?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17838
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17822] Save on Close windows (IDLE)

2013-04-23 Thread Roger Serwy

Roger Serwy added the comment:

IDLE crashing is due to issue13582. We should maybe focus on that issue in the 
near future as it has become a common theme in many bug reports.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17822
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17822] Save on Close windows (IDLE)

2013-04-23 Thread Roger Serwy

Roger Serwy added the comment:

I clicked submit too soon. The attached patch inhibits closing of the Editor 
when the dialog box appears. It also sets the parent argument so that Tkinter 
on Windows actually presents a modal dialog box.

What's happening is the the dialog box enters a nested Tk eventloop which 
allows the editor window to be closed by the window manager via clicking X. 
That re-enters the maybesave dialog. The first one unwinds and closes the 
editor window, setting its internal references to None. The initial maybesave 
resumes execution with the rug pulled out from beneath its feet and raises 
errors.

--
keywords: +patch
type: crash - behavior
Added file: http://bugs.python.org/file29997/inhibit_close.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17822
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17532] IDLE: Always include Options menu on MacOSX

2013-04-23 Thread Roger Serwy

Roger Serwy added the comment:

The Options menu will become populated as soon as other extensions get included 
into IDLE, such as issue6143.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17532
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17817] ÂżBug Python 2.7.4 and version 3.3.1?

2013-04-22 Thread Roger Serwy

Roger Serwy added the comment:

Ricardo, you are correct that 2.7.4 and 3.3.1 have these bugs but they have 
been fixed, as shown by Serhiy. Unfortunately, these fixes won't be released 
for a while but they exist as patches and in version control.

I am closing this issue as a duplicate of #17585.

--
resolution:  - duplicate
status: open - closed
superseder:  - IDLE - regression with exit() and quit()

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17817
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15809] IDLE console uses incorrect encoding.

2013-04-22 Thread Roger Serwy

Roger Serwy added the comment:

Here's a tangentially related issue: #14326

IDLE doesn't handle pasting multi-line code properly (issue3559), IDLE2 will 
silently ignore code after the first executable statement. IDLE3 may give an 
error.

Can't we just make IDLE's shell default to UTF-8?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15809
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5492] Error on leaving IDLE with quit() or exit() under Linux

2013-04-19 Thread Roger Serwy

Roger Serwy added the comment:

Good catch Terry! I've been testing using python -m idlelib.idle instead of 
importing it from an interactive prompt. I'll need to remember to consider that 
test vector in the future.

I figured out why those messages are popping up. The Tk event loop remains 
running when in the interactive Python REPL due to a PyOS_InputHook driving the 
Tk loop periodically. Some .after callbacks expire and Tcl tries calling into a 
Python function that no longer exists. The ColorDelegator's recolorize() and 
PyShell's poll_subprocess() are the callbacks. (Adding a print(name, func) to 
the after() function in Lib/tkinter/__init__.py revealed the link between the 
Tcl reference name and the Python reference name.)

The extra ColorDelegator call is actually a bug, related to #13495. (I need to 
expand it that issue to include this new problem.) Two ColorDelegators get 
loaded, and only one gets its close() method called which properly cancels the 
.after callback into recolorize. The orphaned ColorDelegator still exists in 
the delegator chain with an active .after callback.

Once both those .after callbacks are canceled, then the error messages Terry 
sees are no longer shown.

The rev1 patch includes extra code to handle cancellation of the 
poll_subprocess .after callback. I'll be posting the multi-color delegator fix 
to #13495.

--
dependencies: +IDLE: Regressions - Two ColorDelegator instances loaded and -e 
no longer edits new files.
Added file: http://bugs.python.org/file29945/issue5492_rev1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5492
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13495] IDLE: Regressions - Two ColorDelegator instances loaded

2013-04-19 Thread Roger Serwy

Roger Serwy added the comment:

I will split the good_load flag bug into its own issue.

While addressing a bug in #5492, another doubled-up ColorDelegator problem 
appeared, tracing back to #1586.

The dual_delagators patch removes the code which loads the extra color 
delegators as well as ensures that ResetColorizer loads a color delegator since 
ispythonsource() now always returns True in a PyShell instance.

--
assignee:  - roger.serwy
title: IDLE: Regressions - Two ColorDelegator instances loaded and -e no longer 
edits new files. - IDLE: Regressions - Two ColorDelegator instances loaded
versions: +Python 3.4 -Python 3.2
Added file: http://bugs.python.org/file29946/dual_delegators.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13495
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17798] IDLE: can not edit new file names when using -e

2013-04-19 Thread Roger Serwy

New submission from Roger Serwy:

This is a split from #13495 as it is truly a separate issue. Here's a partial 
quote from msg151278:


IDLE 3 no longer allows for editing of new files from the command line. 

For example:

   idle -e /tmp/newfile.py 

will momentarily flash an editor window before it is closed. This is due to 
good_load not being set. What's worse is that the IDLE process will continue 
running without having any visible windows open. 


Rather than remove the good_load behavior as was done in an earlier patch in 
#13495, I added an extra line in the initialization logic so that the editor 
can edit newly named files while still rejecting files that didn't load 
properly.

--
assignee: roger.serwy
components: IDLE
files: goodload.patch
keywords: patch
messages: 187399
nosy: roger.serwy, terry.reedy
priority: normal
severity: normal
stage: patch review
status: open
title: IDLE: can not edit new file names when using -e
type: behavior
versions: Python 3.3, Python 3.4
Added file: http://bugs.python.org/file29947/goodload.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17798
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13262] IDLE opens partially hidden

2013-04-19 Thread Roger Serwy

Roger Serwy added the comment:

Why not change the initial window size from 80x40 to 80x38?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13262
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17776] IDLE Internationalization

2013-04-18 Thread Roger Serwy

Roger Serwy added the comment:

Extensions would need to be modified to use the gettext module.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17776
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17532] IDLE: Always include Options menu on MacOSX

2013-04-17 Thread Roger Serwy

Roger Serwy added the comment:

Hi Guilherme, 

Have you signed the contributor agreement? It can be found at: 
http://www.python.org/psf/contrib/contrib-form/

Your patch looks good to me, but I don't have a Mac to test against. I trust 
Todd's test that it works on the latest MacOSX version. Hopefully it works on 
earlier OSX versions as well. (I think it should, but Tk on Mac has been 
problematic.)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17532
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17721] Help button on preference window doesn't work

2013-04-17 Thread Roger Serwy

Roger Serwy added the comment:

This falls under annoyance #11 from issue13504. I'll cross-reference it there.

--
nosy: +roger.serwy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17721
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13504] Meta-issue for Invent with Python IDLE feedback

2013-04-17 Thread Roger Serwy

Roger Serwy added the comment:

Issue17721 addresses part of point 11) And am I the only person who noticed 
that the Help button doesn’t actually do anything?

--
dependencies: +Help button on preference window doesn't work

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13504
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5492] Error on leaving IDLE with quit() or exit() under Linux

2013-04-17 Thread Roger Serwy

Roger Serwy added the comment:

Hello Ger,

Sure, I can explain. IDLE is driven by the Tk event loop. Calls to .update() 
flushes all pending events and expired .after callbacks. 

When close() gets called in PyShell, it places the finalization of the close 
(using close2()) into the Tk event queue as a .after callback. Now, when the 
error message arrives over RPC to the PyShell, it is written to the .text 
widget using the write() method. Here's a snippet from PyShell.py:

self.text.mark_gravity(iomark, right)
count = OutputWindow.write(self, s, tags, iomark)
self.text.mark_gravity(iomark, left)

The OutputWindow.write() command eventually calls .update() before returning. 
That .update() call may flush the close2() callback if the timer expired. If 
so, then .text gets set to None. The next line to restore the gravity to the 
left is doing an attribute lookup for mark_gravity on None which causes the 
error.

I hope that clarifies why the patch works.

Can someone verify that the patch works? I've managed to convince myself of its 
validity, but it is always good to get another set of eyes on it in case I 
missed something.

--
assignee:  - roger.serwy
stage: test needed - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5492
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14735] Version 3.2.3 IDLE CTRL-Z plus Carriage Return to end does not work

2013-04-16 Thread Roger Serwy

Roger Serwy added the comment:

I am closing this issue as fixed since the documentation now matches the 
behavior of IDLE.

--
resolution:  - fixed
stage: patch review - committed/rejected

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14735
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14735] Version 3.2.3 IDLE CTRL-Z plus Carriage Return to end does not work

2013-04-16 Thread Roger Serwy

Changes by Roger Serwy roger.se...@gmail.com:


--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14735
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4630] IDLE: add cursor noblink option

2013-04-12 Thread Roger Serwy

Roger Serwy added the comment:

Attached is an updated version of the patch against the latest 2.7 code.

--
nosy: +roger.serwy
Added file: http://bugs.python.org/file29787/issue4630_refreshed.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4630
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17585] IDLE - regression with exit() and quit()

2013-04-11 Thread Roger Serwy

Roger Serwy added the comment:

Thanks, Antoine.

I am closing this issue as fixed.

--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17585
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14146] IDLE: source line in editor doesn't highlight when debugging

2013-04-11 Thread Roger Serwy

Roger Serwy added the comment:

Todd, thank you for being proactive with the Tcl/Tk community. Hopefully they 
will offer a fix in their next version.

In the meanwhile, here's a patch that works around the problem on Windows. The 
purpose of getting the highlight configuration at each FocusOut event is in 
case the current theme changes.

--
keywords: +patch
stage:  - patch review
versions: +Python 2.7 -Python 3.2
Added file: http://bugs.python.org/file29786/win_highlighting.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14146
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17511] Idle find function closes after each find operation

2013-04-11 Thread Roger Serwy

Roger Serwy added the comment:

I submitted a patch to #14146 that would work around the selection highlighting 
issue on Windows. It is based on Sarah's idea of replacing the sel tags with 
a tag that remains visible.

There are a lot of ideas floating here about improving the search dialog. Maybe 
we should take the discussion to idle-dev?

In order to avoid rapidly expanding the issue, I suggest that we limit this 
issue to the find window remaining open with a Find Next button. Does that 
sound reasonable?

--
dependencies: +IDLE: source line in editor doesn't highlight when debugging

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17511
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14146] IDLE: source line in editor doesn't highlight when debugging

2013-04-11 Thread Roger Serwy

Roger Serwy added the comment:

I forgot to mention that the idea for replacing the sel tags is based on an 
idea from Sarah's patch from #17511.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14146
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15964] SyntaxError in asdl when building 2.7 with system Python 3

2013-04-10 Thread Roger Serwy

Roger Serwy added the comment:

Attached is the updated patch to include Ezio's review. Thanks Ezio!

--
Added file: http://bugs.python.org/file29773/patch_2and3_rev1.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com




[issue17670] expandtabs() weirdness

2013-04-10 Thread Roger Serwy

Roger Serwy added the comment:

LGTM.

--
nosy: +roger.serwy
stage: patch review - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17585] IDLE - regression with exit() and quit()

2013-04-10 Thread Roger Serwy

Roger Serwy added the comment:

Serhiy, don't worry. There's still plenty of broken found in IDLE.

Antoine, may I modify site.py with site_reversion.patch? If not, then I can 
include a workaround in IDLE.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17585
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14735] Version 3.2.3 IDLE CTRL-Z plus Carriage Return to end does not work

2013-04-10 Thread Roger Serwy

Roger Serwy added the comment:

Attached is a refreshed patch for tip.

Supporting Ctrl+Z and Enter on Windows would be problematic as I discussed 
earlier. We could introduce a timer to make sure Enter is pressed within a 
short window after Ctrl+Z. 

If someone wants to make a patch for that, I'll gladly review it. In the 
meantime, changing the docs to reflect the actual behavior of IDLE would be 
simpler.

--
stage:  - patch review
type: behavior - enhancement
versions: +Python 3.4 -Python 3.2
Added file: http://bugs.python.org/file29774/ctrl_z_doc_rev1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14735
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17657] IDLE: about dialog should report the full version of TK

2013-04-08 Thread Roger Serwy

Roger Serwy added the comment:

Let's discuss improving the about dialog on idle-dev or in a new issue.

Thanks for the patch, Todd!

--
resolution:  - fixed
stage: commit review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17657
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17511] Idle find function closes after each find operation

2013-04-08 Thread Roger Serwy

Roger Serwy added the comment:

I tried the patch against 2.7 and it appears to work, but might introduce 
another interface problem. 

The search dialog opens up as a modal window which disallows the user from 
changing the text. This may or may not be desirable. The technique of using the 
hit tag for highlighting the search results depends on this modal behavior, 
otherwise one can edit the text and spread the hit tag around. 

If you comment out the grab_set in Lib/idlelib/SearchDialogBase.py and then 
disable the colorizer in the editor window by pressing Ctrl+/ then you can 
spread the hit tag. (You can also disable the colorizer by saving to a file 
without a .py or .pyw extension).

Should the Search Dialog be modal?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17511
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17390] display python version on idle title bar

2013-04-07 Thread Roger Serwy

Roger Serwy added the comment:

Issue10747 is tangentially related. It is about adding the python version to 
the short cuts on Windows.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17390
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17613] IDLE AttributeError: 'NoneType' object has no attribute 'index' from Delegator.py

2013-04-07 Thread Roger Serwy

Roger Serwy added the comment:

Thank you everyone for your patience. I am closing this issue as fixed.

--
assignee:  - roger.serwy
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17613
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1207589] IDLE: Right Click Context Menu

2013-04-07 Thread Roger Serwy

Roger Serwy added the comment:

Please do open a separate issue. We'll resolve it there.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1207589
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17511] Idle find function closes after each find operation

2013-04-07 Thread Roger Serwy

Roger Serwy added the comment:

Update for what I wrote in msg185101: The behavior introduced in #13052 which 
kept the replace dialog open has been reverted by #17625. 

There ought to be consistency across the different find/replace dialogs. The 
replace dialog closes when clicking close or replace all if there are 
replacements to be made. Otherwise, clicking find in the replace dialog keeps 
it open.

Other editors, such as Geany, Eclipse, Window's Notepad, and Wordpad, keep 
their find dialogs open when clicking Find (Next). Some of those programs 
still have a find next menu item.

I am in support of letting the find dialog remain open, and possibly relabeling 
the button to say find next instead.

--
nosy: +terry.reedy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17511
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17657] IDLE: about dialog should report the full version of TK

2013-04-07 Thread Roger Serwy

Roger Serwy added the comment:

LGTM. The patch works on Arch Linux, returning 8.5.13 which is what I have 
installed.

--
stage:  - patch review
type: behavior - enhancement
versions: +Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17657
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17642] IDLE add font resizing hot keys

2013-04-06 Thread Roger Serwy

Roger Serwy added the comment:

IdleX provides this with the ZoomFont.py extension. (See 
http://idlex.sourceforge.net/extensions.html#Misc) It is useful for showing 
code on a projector so that students can easily read the screen.

The implementation in ZoomFont.py does not change the font size found in IDLE's 
configuration. Instead it queries the font size in the text widget and scales 
accordingly with a relative offset. 

IDLE needs a better way to broadcast font configuration changes. Right now, the 
Code Context extension uses polling every second to check for font changes. I 
bring this point up because properly incorporating font zooming may require 
refactoring some code. Incorporating Line Numbers, from #17535 would likely 
need to rely on this font size broadcasting as well.

--
nosy: +roger.serwy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16887] IDLE - tabify/untabify applied when clicking Cancel

2013-04-06 Thread Roger Serwy

Roger Serwy added the comment:

Closing the issue as fixed.

--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16887
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17238] IDLE: Enhance import statement completion

2013-04-06 Thread Roger Serwy

Changes by Roger Serwy roger.se...@gmail.com:


--
nosy: +roger.serwy
title: Enhance import statement completion - IDLE: Enhance import statement 
completion

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17238
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6699] IDLE: Warn user about overwriting a file that has a newer version on filesystem

2013-04-04 Thread Roger Serwy

Changes by Roger Serwy roger.se...@gmail.com:


--
assignee:  - roger.serwy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6699
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1721083] Add File - Reload

2013-04-04 Thread Roger Serwy

Roger Serwy added the comment:

Raymond, I can pick this up. I might as well work on #6699 at the same time.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1721083
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17632] IDLE: Add clear-window option to the Shell menu.

2013-04-04 Thread Roger Serwy

Roger Serwy added the comment:

This is a different spin on issue6143. Here the suggestion is to combine the 
clear function with the restart option for a new menu option.

I am closing this one as a duplicate of #6143, but adding the Shell restart 
and clear suggestion.

--
nosy: +roger.serwy
resolution:  - duplicate
status: open - closed
superseder:  - IDLE - an extension to clear the shell window

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17632
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6143] IDLE - an extension to clear the shell window

2013-04-04 Thread Roger Serwy

Roger Serwy added the comment:

In #17632, Raymond suggests adding a Restart and Clear menu item under the 
Shell menu.

--
nosy: +rhettinger

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14576] IDLE: resolving home directory for configuration uses HOMEDRIVE, HOMEPATH, and USERPROFILE inconsistently on Windows.

2013-04-03 Thread Roger Serwy

Roger Serwy added the comment:

This issue triggers the problem described in #13582. It points out problems 
with IDLE's configuration manager w.r.t. determining the home directory. I 
changed the title so that it reflects that point.

--
title: IDLE: closes when writing warnings on Windows - IDLE: resolving home 
directory for configuration uses HOMEDRIVE, HOMEPATH, and USERPROFILE 
inconsistently on Windows.

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14576
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-03 Thread Roger Serwy

Roger Serwy added the comment:

That behavior was introduced as part of the patch I wrote a long time ago for 
#13052. In retrospect that extra functionality went beyond the scope of that 
issue and should not have been included.

Does anyone else think that the new behavior ought to be reverted? I don't mind 
reverting it.

A related issue is #17511 which wants to keep the Find dialog open instead of 
closing.

--
stage:  - needs patch
type:  - behavior
versions: +Python 3.3, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-03 Thread Roger Serwy

Roger Serwy added the comment:

The attached patch restores the original behavior.

--
keywords: +patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file29674/issue17625.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1442493] IDLE shell window gets very slow when displaying long lines

2013-04-03 Thread Roger Serwy

Roger Serwy added the comment:

The only reason that the IDLE shell is slow is due to the shell's text widget 
being configured to have wrap=char. If we manually wrapped the output then 
the shell responds very quickly to rendering really long strings.

The attached proof-of-concept patch (against 2.7 tip) implements manual 
wrapping. You can type print('a' * 10**6) and the shell responds almost 
instantly when using no-subprocess mode. (The RPC overhead becomes readily 
apparent when using a subprocess, introducing a large uninteruptable delay. 
That's another issue.)

I left text wrapping enabled in the shell since the user may be using a 
variable-spaced font. A possible compromise would be to increase the wrap_index 
to a large number, like 32768, before IDLE inserts a '\n' into the output. This 
would mimic the wrapping behavior of the original shell, but keep the shell 
responsive when you write a very long string to the output.

--
keywords: +patch
versions:  -Python 3.2
Added file: http://bugs.python.org/file29675/manual_wrap.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1442493
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-03 Thread Roger Serwy

Roger Serwy added the comment:

If students are having trouble, then it should be changed. This behavior is 
also in 3.2. 

Do applied patches in 2.7 tip go toward 2.7.4 or 2.7.5? (I don't know the 
mechanics of the release candidate process just yet.)

--
stage: patch review - commit review
versions: +Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15964] SyntaxError in asdl when building 2.7 with system Python 3

2013-04-03 Thread Roger Serwy

Roger Serwy added the comment:

The attached patch allows the same parser code to run under Python 2 and Python 
3. I'm not sure how to test it other than by running the test suite which 
passed.

--
Added file: http://bugs.python.org/file29677/patch_2and3.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17613] IDLE AttributeError: 'NoneType' object has no attribute 'index' from Delegator.py

2013-04-02 Thread Roger Serwy

Roger Serwy added the comment:

On 04/02/2013 12:57 AM, Ned Deily wrote:
 2. Roger, is this issue new to 2.7.4, 3.2.4, or 3.3.1?
No, this bug has been baked into IDLE since the beginning. See line 215 
http://hg.python.org/cpython/file/30713d5288df/Lib/idlelib/ColorDelegator.py
   How likely do you think it will be seen by users?
For Windows users using pythonw.exe, it would cause IDLE to immediately 
terminate due to issue13582. On Linux and Mac, the errors would write to 
stderr, though not likely be visible to the end user. On Linux and Mac 
the error is not harmful since IDLE still remains perfectly usable. 
The error does not leave IDLE in an inconsistent state.
   And what is your recommendation to the release managers about including the 
 patch in any or all of the pending maintenance releases, understanding that 
 the options are to cherry-pick into the final and hope for the best, 
 cherry-pick it and do an RC2, or defer the fix to the next maintenance 
 releases?
I'm ok with cherry-picking it into the final, but in the interest of 
simplicity, I'd recommend deferring it to the next maintenance release. 
There are other bugs, like #8900 that are easier to trigger than this one.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17613
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17614] IDLE - quickly closing a large file triggers a traceback

2013-04-02 Thread Roger Serwy

Roger Serwy added the comment:

Updated patch based on Ezio's comments. Thank you, Ezio!

Senthil, I wish I had a Mac to test against. I am able to trigger the bug on 
Win7 with 3.3.

Without objection, I will commit the patch in the upcoming hours.

--
assignee:  - roger.serwy
Added file: http://bugs.python.org/file29659/issue17614_rev1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17614
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17614] IDLE - quickly closing a large file triggers a traceback

2013-04-02 Thread Roger Serwy

Changes by Roger Serwy roger.se...@gmail.com:


--
resolution:  - fixed
stage: commit review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17614
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17060] IDLE -- jump to home should not go past the PS1 and PS2 prompts

2013-04-02 Thread Roger Serwy

Roger Serwy added the comment:

When using the IDLE Classic OSX key set, the beginning-of-line virtual event 
gets bound to Control-Key-Left. Using this key set I can repeat the behavior 
that Raymond observed.

The .home_callback() in Lib/idlelib/EditorWindow.py contains the logic from 
#3851 for placing the cursor at the beginning of the prompt, but it requires 
that a key combination be bound to the beginning-of-line virtual event.

Should we append Key-Home Control-Key-a to the begining-of-line config in 
Lib/idlelib/config-keys.def ?

--
nosy: +roger.serwy
type: behavior - enhancement
versions: +Python 3.4 -Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17060
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14254] IDLE - shell restart or closing during readline does not exit nested event loop

2013-04-02 Thread Roger Serwy

Roger Serwy added the comment:

Ned, I was reading the dev guide more closely about the meaning of the commit 
review stage. Would it be ok to place this issue into that stage with your 
test result?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14254
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   3   4   5   6   >