[issue17552] socket.sendfile()

2013-03-27 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue17552>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17428] replace readdir to readdir_r in function posix_listdir

2013-03-15 Thread Ross Lagerwall

Ross Lagerwall added the comment:

That text was from the POSIX 2008 spec:
http://pubs.opengroup.org/onlinepubs/9699919799/functions/readdir.html

The following text from my copy of the readdir manpage gives an indication of 
how you *should* allocate struct dirent when using readdir_r:
"""
Since  POSIX.1 does not specify the size of the d_name field, and other 
nonstandard fields may precede that field within the dirent structure, portable 
applications that use readdir_r() should allocate the buffer whose address is 
passed in entry as follows:

   name_max = pathconf(dirpath, _PC_NAME_MAX);
   if (name_max == -1) /* Limit not defined, or error */
   name_max = 255; /* Take a guess */
   len = offsetof(struct dirent, d_name) + name_max + 1;
   entryp = malloc(len);

(POSIX.1 requires that d_name is the last field in a struct dirent.)
"""

I hope that helps

--

___
Python tracker 
<http://bugs.python.org/issue17428>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17428] replace readdir to readdir_r in function posix_listdir

2013-03-15 Thread Ross Lagerwall

Ross Lagerwall added the comment:

Hi,

There shouldn't be a problem with the existing implementation since, according 
to posix:
"""
The pointer returned by readdir() points to data which may be overwritten by 
another call to readdir() on the same directory stream. This data is not 
overwritten by another call to readdir() on a different directory stream.
"""

Since each call to listdir() opens a different directory stream, this shouldn't 
be a problem.

Also, when using readdir_r(), struct dirent should not be allocated on the 
stack since the last field may be an unspecified size.
See the following for further reading about this:
http://elliotth.blogspot.co.uk/2012/10/how-not-to-use-readdirr3.html
http://womble.decadent.org.uk/readdir_r-advisory.html

Regards

--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue17428>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16853] add a Selector to the select module

2013-01-04 Thread Ross Lagerwall

Ross Lagerwall added the comment:

> Ross, the select() result for a large number of ready FDs was
> completely skewed because of a bug spotted by Antoine (complexity
> was much worse than it ought to be).

Ah, that makes a little more sense now.

--

___
Python tracker 
<http://bugs.python.org/issue16853>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16853] add a Selector to the select module

2013-01-04 Thread Ross Lagerwall

Ross Lagerwall added the comment:

Interesting benchmark. There is no gain for epoll with a large number of
ready fds (as expected) but at least it is no worse than poll. Poll offers
a large improvement on select, in this case.

$ ./python selector_bench.py -r 2 -m 1000 -t pipe
Trying with 2 ready FDs out of 1000, type pipe

0.004317363000154728

0.08897221900042496

0.155811747055

$ ./python selector_bench.py -r 100 -m 1000 -t pipe
Trying with 100 ready FDs out of 1000, type pipe

0.1106707402169

0.18777027299984184

0.3015780589866

$ ./python selector_bench.py -r 1000 -m 1000 -t pipe
Trying with 1000 ready FDs out of 1000, type pipe

1.08963231099915

1.69247998987

8.283167362000313

--

___
Python tracker 
<http://bugs.python.org/issue16853>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16853] add a Selector to the select module

2013-01-03 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue16853>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16850] Atomic open + close-and-exec

2013-01-03 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue16850>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16698] test_posix.test_getgroups fails on some systems

2012-12-16 Thread Ross Lagerwall

New submission from Ross Lagerwall:

test_posix.test_getgroups() fails on some systems:

http://buildbot.python.org/all/builders/AMD64%20Mountain%20Lion%20%5BSB%5D%203.2

This could be related to #16661.

--
components: Tests
messages: 177601
nosy: rosslagerwall
priority: normal
severity: normal
stage: needs patch
status: open
title: test_posix.test_getgroups fails on some systems
type: behavior
versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4

___
Python tracker 
<http://bugs.python.org/issue16698>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16661] test_posix.test_getgrouplist fails on some systems - incorrectly comparing getgroups and getgrouplist results

2012-12-16 Thread Ross Lagerwall

Ross Lagerwall added the comment:

getgrouplist() is new in 3.3. Those failures are from getgroups() failing. I'll 
open a separate issue for that.

--
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue16661>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16661] test_posix.test_getgrouplist fails on some systems - incorrectly comparing getgroups and getgrouplist results

2012-12-15 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
assignee:  -> rosslagerwall
resolution:  -> fixed
stage: needs patch -> committed/rejected
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue16661>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16661] test_posix.test_getgrouplist fails on some systems - incorrectly comparing getgroups and getgrouplist results

2012-12-13 Thread Ross Lagerwall

Ross Lagerwall added the comment:

Is that fixed now? I simplified the test to check for a non-empty list being 
returned.

--

___
Python tracker 
<http://bugs.python.org/issue16661>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16661] test_posix.test_getgrouplist fails on some systems - incorrectly comparing getgroups and getgrouplist results

2012-12-10 Thread Ross Lagerwall

Ross Lagerwall added the comment:

I wouldn't think so. A call to setgroups can add or remove groups for
the calling process. If it removes groups, then getgrouplist() won't
return a subset of getgroups().

--

___
Python tracker 
<http://bugs.python.org/issue16661>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16661] test_posix.test_getgrouplist fails on some systems - incorrectly comparing getgroups and getgrouplist results

2012-12-10 Thread Ross Lagerwall

Ross Lagerwall added the comment:

It seems like getgrouplist returns the information from the system
database whereas getgroups (and consequently id -G) returns the
supplementary groups for the calling process.

I'm not exactly sure how getgrouplist() can be effectively tested then.

--
nosy: +rosslagerwall
title: test_posix.test_getgrouplist fails on some systems - incorrectly 
comparing getgroups and getgrouplist results -> test_posix.test_getgrouplist 
fails on some systems -incorrectly comparing getgroups and getgrouplist 
results

___
Python tracker 
<http://bugs.python.org/issue16661>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16639] not your all issuse send

2012-12-07 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
resolution:  -> invalid
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue16639>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16262] srcdir != builddir builds fail, if hg is not installed

2012-10-29 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
assignee:  -> rosslagerwall
nosy: +rosslagerwall
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed
versions: +Python 3.2, Python 3.4

___
Python tracker 
<http://bugs.python.org/issue16262>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16140] subprocess.Popen the os.close calls in _execute_child can raise an EBADF exception

2012-10-05 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue16140>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15876] test_curses refleak

2012-09-07 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue15876>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15876] test_curses refleak

2012-09-06 Thread Ross Lagerwall

Ross Lagerwall added the comment:

This didn't get picked up by Antoine's daily refleak test run because test 
curses only runs when stdout is a TTY.

--

___
Python tracker 
<http://bugs.python.org/issue15876>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15876] test_curses refleak

2012-09-06 Thread Ross Lagerwall

New submission from Ross Lagerwall:

[1/1] test_curses
beginning 6 repetitions
123456
.
test_curses leaked [1, 1, 1] references, sum=3
1 test failed:
test_curses
[154814 refs]

--
assignee: rosslagerwall
messages: 169973
nosy: rosslagerwall
priority: low
severity: normal
status: open
title: test_curses refleak
type: resource usage

___
Python tracker 
<http://bugs.python.org/issue15876>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15798] subprocess.Popen() fails if 0, 1 or 2 descriptor is closed

2012-08-29 Thread Ross Lagerwall

Ross Lagerwall added the comment:

I sent a review through on rietveld; I'm attaching a patch with the changes so 
that it compiles and passes the tests.

--
Added file: http://bugs.python.org/file27053/issue15798_v2.patch

___
Python tracker 
<http://bugs.python.org/issue15798>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15798] subprocess.Popen() fails if 0, 1 or 2 descriptor is closed

2012-08-29 Thread Ross Lagerwall

Ross Lagerwall added the comment:

The attached patch + test seems to fix the issue.

It's not very elegant.

--
keywords: +patch
Added file: http://bugs.python.org/file27042/issue15798.patch

___
Python tracker 
<http://bugs.python.org/issue15798>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15798] subprocess.Popen() fails if 0, 1 or 2 descriptor is closed

2012-08-28 Thread Ross Lagerwall

Ross Lagerwall added the comment:

It's caused by the following check in _posixsubprocess.c:
if (close_fds && errpipe_write < 3) {  /* precondition */
PyErr_SetString(PyExc_ValueError, "errpipe_write must be >= 3");
return NULL;
}

which was written by Gregory P. Smith in 2010 (adding to nosy list).

I'm not entirely sure why this check is here, presumably its due to the way 
close_fds=True is handled.

The close fds logic is also hardcoded to close fds from 3 upwards,.

--
nosy: +gregory.p.smith

___
Python tracker 
<http://bugs.python.org/issue15798>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15777] test_capi refleak

2012-08-24 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
resolution:  -> fixed
stage: needs patch -> committed/rejected
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue15777>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15777] test_capi refleak

2012-08-24 Thread Ross Lagerwall

New submission from Ross Lagerwall:

results for fa745ed89b7a on branch "default"


test_capi leaked [2, 2, 2] references, sum=6


Command line was: ['./python', '-m', 'test.regrtest', '-uall', '-R', 
'3:3:/home/antoine/cpython/refleaks/reflogEr4Oyp', '-x']


A fix is in progress...

--
assignee: rosslagerwall
messages: 168993
nosy: rosslagerwall
priority: normal
severity: normal
stage: needs patch
status: open
title: test_capi refleak
type: resource usage
versions: Python 3.2, Python 3.3

___
Python tracker 
<http://bugs.python.org/issue15777>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15739] Python crashes with "Bus error: 10"

2012-08-20 Thread Ross Lagerwall

Ross Lagerwall added the comment:

Sorry, I didn't mean that it's impossible; I meant that it shouldn't happen and 
it should be fixed :-)

Unfortunately I don't have access to an OS X box to test.

--

___
Python tracker 
<http://bugs.python.org/issue15739>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15739] Python crashes with "Bus error: 10"

2012-08-20 Thread Ross Lagerwall

Ross Lagerwall added the comment:

Well the app has an infinite recursion.

This shows on Fedora Linux 17:
"""
Request Method: GET
Request URL:http://127.0.0.1:8000/
Django Version: 1.4
Exception Type: RuntimeError
Exception Value:

maximum recursion depth exceeded while calling a Python object

Exception Location: /tmp/dg/django_select2/fields.py in __init__, line 146
Python Executable:  /home/ross/src/python/2.7/python
Python Version: 2.7.1
...
"""

Of course, this shouldn't cause a bus error in Python. Perhaps try a different 
build of Python or try building it yourself?

--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue15739>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15548] Mention all new os functions in What's New in Python 3.3

2012-08-03 Thread Ross Lagerwall

Ross Lagerwall added the comment:

Attached is a diff between dir(os) in 3.2 and 3.3

--
keywords: +patch
nosy: +rosslagerwall
Added file: http://bugs.python.org/file26676/oschanges.diff

___
Python tracker 
<http://bugs.python.org/issue15548>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10812] Add some posix functions

2012-07-31 Thread Ross Lagerwall

Ross Lagerwall added the comment:

I can't actually remember why I disabled waitid for OS X - that was message was 
rather a long time ago :-(

Unfortunately, I don't currently have access to an OS X machine to test it.

A google search shows the following comment in the v8 javascript engine:
// We're disabling usage of waitid in Mac OS X because it doens't work for us:
// a parent process hangs on waiting while a child process is already a zombie.
// See http://code.google.com/p/v8/issues/detail?id=401.

Do you have access to test an older release like Leopard?

--

___
Python tracker 
<http://bugs.python.org/issue10812>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7996] concurrency problem in regrtest -jX

2012-07-26 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
resolution:  -> duplicate
status: open -> closed
superseder:  -> thread-safety issue in regrtest.main()

___
Python tracker 
<http://bugs.python.org/issue7996>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15447] A file is not properly closed by webbrowser._invoke

2012-07-25 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Are there any webbrowser unit tests?

(this could probably use the new subprocess.DEVNULL constant in 3.3)

--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue15447>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14826] urllib2.urlopen fails to load URL

2012-07-07 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

It looks like this broke the build bots:
http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%202.7/builds/66/steps/test/logs/stdio

--
assignee:  -> orsenthil
nosy: +rosslagerwall
status: closed -> open

___
Python tracker 
<http://bugs.python.org/issue14826>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15277] Fix resource leak in support.py:_is_ipv6_enabled

2012-07-07 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Ah, I see you've already opened a new issue for that (issue15284).

--

___
Python tracker 
<http://bugs.python.org/issue15277>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15277] Fix resource leak in support.py:_is_ipv6_enabled

2012-07-07 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Thanks.

test_socket seems to be broken in all branches when running with 
net.ipv6.conf.all.disable_ipv6 = 1 but I'll open a new issue for that.

--
assignee:  -> rosslagerwall
nosy: +rosslagerwall
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed
versions: +Python 3.3 -Python 3.4

___
Python tracker 
<http://bugs.python.org/issue15277>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15200] Faster os.walk

2012-06-27 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

This looks like the kind of optimization that depends hugely on what kernel 
you're using. Maybe on FreeBSD/Solaris/whatever, standard os.walk() is faster?

If this micro-optimization were to be accepted, someone would have to be keen 
enough to test it is different ways on many different versions of every 
platform to conclusively prove that it is faster in general.

--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue15200>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15044] _dbm not building on Fedora 17

2012-06-17 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Yeah, after I submitted the patch, I was unsure if that was a good idea or if 
it should try and use gdbm in native mode if possible.

--

___
Python tracker 
<http://bugs.python.org/issue15044>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15044] _dbm not building on Fedora 17

2012-06-12 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Attached is a patch which fixes the issue on Fedora 17.

If this doesn't break other OSes I'll commit it for 2.7, 3.2 and 3.3.

--
keywords: +patch
versions: +Python 2.7, Python 3.2
Added file: http://bugs.python.org/file25943/gdbm.patch

___
Python tracker 
<http://bugs.python.org/issue15044>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15044] _dbm not building on Fedora 17

2012-06-12 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

The gdbm provided with Fedora 17 provides /usr/include/ndbm.h.

This makes setup.py think that it should try link with -lndbm when it actually 
requires -lgdbm_compat.

A workaround is to specify --with-dbmliborder=gdbm to force gdbm to be used.

I'll try and make a patch for this.

--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue15044>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14443] Distutils test_bdist_rpm failure

2012-05-28 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Unfortunately, it seems like it's still failing on the RHEL 6 buildbot.

--
status: pending -> open

___
Python tracker 
<http://bugs.python.org/issue14443>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14890] typo in difflib

2012-05-23 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Yeah, I'm pretty sure it means if and only if.

--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue14890>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1191964] asynchronous Subprocess

2012-05-23 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

> Personally, I would factor out the code for Popen.communicate() in to a > 
> Communicator class which wraps a Popen object and has a method
>
>communicate(input, timeout=None) -> (bytes_written, output, error)

How would this differ from the normal communicate()?

It seems like there are two different ideas for why people want an 
"asynchronous subprocess":

One is that they want to use communicate() but not be limited by memory issues.
I think a good API for this case is an asyncore style API or like the one from 
the patch in issue1260171.

Another use case is for an expect-type interface where you read and write based 
on a timeout or some kind of delimiter like a newline.

These should probably be addressed independently.

See also issue10482.

--

___
Python tracker 
<http://bugs.python.org/issue1191964>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1191964] asynchronous Subprocess

2012-05-22 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue1191964>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1191964] asynchronous Subprocess

2012-05-22 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
assignee: astrand -> 

___
Python tracker 
<http://bugs.python.org/issue1191964>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1260171] subprocess: more general (non-buffering) communication

2012-05-22 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Closed issue14872 as a duplicate of this.

--
assignee: astrand -> 
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue1260171>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14872] subprocess is not safe from deadlocks

2012-05-22 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

See also issue1260171.

Closing as a duplicate of that.

--
resolution:  -> duplicate
stage:  -> committed/rejected
status: open -> closed
superseder:  -> subprocess: more general (non-buffering) communication
type:  -> enhancement

___
Python tracker 
<http://bugs.python.org/issue14872>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14872] subprocess is not safe from deadlocks

2012-05-21 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Well if you're *certain* that the process is only using one stream, then you 
can just use read/write on that stream.

If not, it probably means you have to use either threads or select/poll.

This is a known issue with subprocess; there are a few proposals on the tracker 
about this. See issue1191964 for example.

--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue14872>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14443] Distutils test_bdist_rpm failure

2012-05-20 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

The attached patch fixed the test for me on Fedora 16.

It was necessary for the `define` to be after the -ba switch.

I don't know why this wouldn't work on RHEL6 then...

--
keywords: +patch
Added file: http://bugs.python.org/file25650/distutils.patch

___
Python tracker 
<http://bugs.python.org/issue14443>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12304] expose signalfd(2) in the signal module

2012-05-20 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Patch seems good (although it doesn't apply cleanly).

Why do you not provide a structure to decode the bytes? I thought relying on 
ctypes in the stdlib was not advised...

--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue12304>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13031] small speed-up for tarfile.py when unzipping tarballs

2012-05-17 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Nice work, thanks!

--
assignee: lars.gustaebel -> rosslagerwall
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue13031>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13031] small speed-up for tarfile.py when unzipping tarballs

2012-05-16 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue13031>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14584] Add gzip support to xmlrpc.server

2012-05-16 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
resolution:  -> invalid
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue14584>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14626] os module: use keyword-only arguments for dir_fd and nofollow to reduce function count

2012-05-16 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue14626>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14584] Add gzip support to xmlrpc.server

2012-05-15 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

The server encodes the response if the length of the response exceeds 
self.encode_threshold, 1400 (presumably there's no point in compression if the 
data fits in the MTU anyway).

--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue14584>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12081] Remove distributed copy of libffi

2012-04-14 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

In any case, it should be OK to remove libffi_arm_wince?

Is WinCE supported?

--

___
Python tracker 
<http://bugs.python.org/issue12081>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14527] How to link with an external libffi?

2012-04-07 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

If it is in a non-standard location, try setting the environment variables:

LDFLAGS linker flags, e.g. -L if you have libraries in a 
nonstandard directory 
CPPFLAGS(Objective) C/C++ preprocessor flags, e.g. -I if you 
have headers in a nonstandard directory 

--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue14527>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14467] Avoid exotic documentation in the devguide

2012-04-01 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

I'm happy to remove the bit about *installing* autoconf altogether.

Do you think the Autoconf section (about regenerating configure) should stay 
where it is or be moved somewhere else?

--

___
Python tracker 
<http://bugs.python.org/issue14467>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14443] Distutils test failure

2012-03-31 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

The first bad revision is:  
changeset:   72818:27a36b05caed
branch:  3.2
user:Éric Araujo 
date:Sat Oct 08 00:34:13 2011 +0200
summary: Fix distutils byte-compilation to comply with PEP 3147 (#11254).


Cheers

--

___
Python tracker 
<http://bugs.python.org/issue14443>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14442] test_smtplib.py lacks "import errno"

2012-03-29 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

> Thanks Ross.  I don't think this is worth a news item, even though the
> bug was shipped in an alpha.  If someone disagrees please add one.

I did add it to the [Tests] section in 9c2b710da3c7. Hardly worth it, but ...

--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue14442>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14443] Distutils test failure

2012-03-29 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

The output of running rpmbuild from bash:
"""
$ rpmbuild
RPM version 4.9.1.2
Copyright (C) 1998-2002 - Red Hat, Inc.
This program may be freely redistributed under the terms of the GNU GPL

Usage: rpmbuild [-v?] [-bp] [-bc] [-bi] [-bl] [-ba] [-bb] [-bs] [-tp]
[-tc] [-ti] [-ta] [-tb] [-ts] [--rebuild] [--recompile]
[--buildroot=DIRECTORY] [--clean] [--nobuild] [--nodeps]
[--nodirtokens] [--rmsource] [--rmspec] [--short-circuit]
[--target=CPU-VENDOR-OS] [-D|--define 'MACRO EXPR'] [-E|--eval 'EXPR']
[--macros=] [--nodigest] [--nosignature]
[--rcfile=] [-r|--root ROOT] [--dbpath=DIRECTORY]
[--querytags] [--showrc] [--quiet] [-v|--verbose] [--version]
[-?|--help] [--usage] [--with=] [--without=]
[--buildpolicy=] [--sign]
"""

--

___
Python tracker 
<http://bugs.python.org/issue14443>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14443] Distutils test failure

2012-03-29 Thread Ross Lagerwall

New submission from Ross Lagerwall :

On an up to date Fedora 16:

== CPython 3.3.0a1+ (default:d528b2d2+, Mar 29 2012, 18:04:26) [GCC 4.6.3 
20120306 (Red Hat 4.6.3-2)]
==   Linux-3.3.0-4.fc16.x86_64-x86_64-with-fedora-16-Verne little-endian
==   /home/ross/src/cpythondev/temp/build/test_python_21786
Testing with flags: sys.flags(debug=0, inspect=0, interactive=0, optimize=0, 
dont_write_bytecode=0, no_user_site=0, no_site=0, ignore_environment=0, 
verbose=0, bytes_warning=0, quiet=0, hash_randomization=1)
[1/1] test_distutils
test_byte_compile (distutils.tests.test_install_lib.InstallLibTestCase) ... ok
test_dont_write_bytecode (distutils.tests.test_install_lib.InstallLibTestCase) 
... ok
test_finalize_options (distutils.tests.test_install_lib.InstallLibTestCase) ... 
ok
test_get_inputs (distutils.tests.test_install_lib.InstallLibTestCase) ... ok
test_get_outputs (distutils.tests.test_install_lib.InstallLibTestCase) ... ok
test_no_compiler (distutils.tests.test_msvc9compiler.msvc9compilerTestCase) ... 
skipped 'These tests are only for win32'
test_reg_class (distutils.tests.test_msvc9compiler.msvc9compilerTestCase) ... 
skipped 'These tests are only for win32'
test_remove_entire_manifest 
(distutils.tests.test_msvc9compiler.msvc9compilerTestCase) ... skipped 'These 
tests are only for win32'
test_remove_visual_c_ref 
(distutils.tests.test_msvc9compiler.msvc9compilerTestCase) ... skipped 'These 
tests are only for win32'
test_nt_quote_args (distutils.tests.test_spawn.SpawnTestCase) ... ok
test_spawn (distutils.tests.test_spawn.SpawnTestCase) ... ok
test_announce (distutils.tests.test_dist.DistributionTestCase) ... ok
test_command_packages_cmdline (distutils.tests.test_dist.DistributionTestCase) 
... ok
test_command_packages_configfile 
(distutils.tests.test_dist.DistributionTestCase) ... ok
test_command_packages_unspecified 
(distutils.tests.test_dist.DistributionTestCase) ... ok
test_empty_options (distutils.tests.test_dist.DistributionTestCase) ... ok
test_finalize_options (distutils.tests.test_dist.DistributionTestCase) ... ok
test_get_command_packages (distutils.tests.test_dist.DistributionTestCase) ... 
ok
test_classifier (distutils.tests.test_dist.MetadataTestCase) ... ok
test_custom_pydistutils (distutils.tests.test_dist.MetadataTestCase) ... ok
test_download_url (distutils.tests.test_dist.MetadataTestCase) ... ok
test_fix_help_options (distutils.tests.test_dist.MetadataTestCase) ... ok
test_long_description (distutils.tests.test_dist.MetadataTestCase) ... ok
test_obsoletes (distutils.tests.test_dist.MetadataTestCase) ... ok
test_obsoletes_illegal (distutils.tests.test_dist.MetadataTestCase) ... ok
test_provides (distutils.tests.test_dist.MetadataTestCase) ... ok
test_provides_illegal (distutils.tests.test_dist.MetadataTestCase) ... ok
test_requires (distutils.tests.test_dist.MetadataTestCase) ... ok
test_requires_illegal (distutils.tests.test_dist.MetadataTestCase) ... ok
test_show_help (distutils.tests.test_dist.MetadataTestCase) ... ok
test_simple_metadata (distutils.tests.test_dist.MetadataTestCase) ... ok
test_simple_run (distutils.tests.test_install_headers.InstallHeadersTestCase) 
... ok
test_finalize_options (distutils.tests.test_upload.uploadTestCase) ... ok
test_saved_password (distutils.tests.test_upload.uploadTestCase) ... ok
test_server_empty_registration (distutils.tests.test_upload.uploadTestCase) ... 
ok
test_server_registration (distutils.tests.test_upload.uploadTestCase) ... ok
test_upload (distutils.tests.test_upload.uploadTestCase) ... ok
test_build_ext (distutils.tests.test_build_ext.BuildExtTestCase) ... ok
test_check_extensions_list (distutils.tests.test_build_ext.BuildExtTestCase) 
... ok
test_compiler_option (distutils.tests.test_build_ext.BuildExtTestCase) ... ok
test_deployment_target_default 
(distutils.tests.test_build_ext.BuildExtTestCase) ... skipped 'test only 
relevant for MacOSX'
test_deployment_target_higher_ok 
(distutils.tests.test_build_ext.BuildExtTestCase) ... skipped 'test only 
relevant for MacOSX'
test_deployment_target_too_low 
(distutils.tests.test_build_ext.BuildExtTestCase) ... skipped 'test only 
relevant for MacOSX'
test_ext_fullpath (distutils.tests.test_build_ext.BuildExtTestCase) ... ok
test_finalize_options (distutils.tests.test_build_ext.BuildExtTestCase) ... ok
test_get_outputs (distutils.tests.test_build_ext.BuildExtTestCase) ... ok
test_get_source_files (distutils.tests.test_build_ext.BuildExtTestCase) ... ok
test_optional_extension (distutils.tests.test_build_ext.BuildExtTestCase) ... ok
test_solaris_enable_shared (distutils.tests.test_build_ext.BuildExtTestCase) 
... ok
test_user_site (distutils.tests.test_build_ext.BuildExtTestCase) ... ok
test_build (distutils.tests.test_build_scripts.BuildScriptsTestCase) ... ok
test_default_settings (distutils.tests.test_build_scripts.BuildScriptsTestCase) 
... ok
test_version_int (distutils.

[issue14432] Bug in generator if the generator in created in a C thread

2012-03-28 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Here's the patch ;-)

--
keywords: +patch
nosy: +rosslagerwall
Added file: http://bugs.python.org/file25055/generator.patch

___
Python tracker 
<http://bugs.python.org/issue14432>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14359] _posixsubprocess.o compilation error on CentOS 5.8

2012-03-19 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Thanks!

--
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue14359>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7997] http://www.python.org/dev/faq/ doesn't seem to explain how to regenerate "configure"

2012-03-18 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
assignee:  -> rosslagerwall
nosy: +rosslagerwall
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed
type:  -> enhancement

___
Python tracker 
<http://bugs.python.org/issue7997>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14358] test_os failing with errno 61: No Data Available

2012-03-18 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Perhaps any errors that occur during supports_extended_attributes should cause 
it to just return false?

--
nosy: +benjamin.peterson, rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue14358>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8963] test_urllibnet failure

2012-03-11 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

I tested the code from msg107484 on Fedora 16 with no change in locale.

Probably OK to close?

--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue8963>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14229] On KeyboardInterrupt, the exit code should mirror the signal number

2012-03-09 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue14229>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14127] os.stat and os.utime: allow preserving exact metadata

2012-02-26 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue14127>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14079] Problems with recent test_subprocess changes

2012-02-22 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Cool, thanks for reporting and debugging the issue :-)

--

___
Python tracker 
<http://bugs.python.org/issue14079>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14079] Problems with recent test_subprocess changes

2012-02-21 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

This was hopefully fixed in e5a94b56d6bc.

Was it one of the buildbots that was failing?

--

___
Python tracker 
<http://bugs.python.org/issue14079>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14000] Subprocess stdin.flush does not flush

2012-02-13 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

This appears to be a buffering issue with the tr program. Replace with ["cat", 
"-"] and it works whether the close() is in or not.

To fix this, you need to open up the child process so that it is connected to a 
tty. man 4 pts if you want to investigate this further.

--
nosy: +rosslagerwall
resolution:  -> invalid
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue14000>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14001] Python v2.7.2 / v3.2.2 (SimpleXMLRPCServer): DoS (excessive CPU usage) by processing malformed XMLRPC / HTTP POST request

2012-02-13 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue14001>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13981] time.sleep() should use nanosleep() if available

2012-02-09 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue13981>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13964] os.utimensat() and os.futimes() should accept Decimal, drop os.futimens()

2012-02-07 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue13964>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10487] http.server doesn't process Status header from CGI scripts

2012-02-05 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue10487>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10482] subprocess and deadlock avoidance

2012-02-05 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue10482>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12157] join method of multiprocessing Pool object hangs if iterable argument of pool.map is empty

2012-02-04 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue12157>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13937] multiprocessing.ThreadPool.join() blocks indefinitely.

2012-02-03 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue13937>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13817] deadlock in subprocess while running several threads using Popen

2012-01-29 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue13817>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13893] Make CGIHTTPServer capable of redirects (and status other than 200)

2012-01-27 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue13893>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13876] Sporadic failure in test_socket

2012-01-26 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue13876>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13846] Add time.monotonic() function

2012-01-23 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue13846>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13845] Use GetSystemTimeAsFileTime() to get a resolution of 100 ns on Windows

2012-01-23 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue13845>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8052] subprocess close_fds behavior should only close open fds

2012-01-15 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

FreeBSD has a /dev/fd as well as a procfs (deprecated AFAIK).
However, both may not be mounted so a patch would *need* to at least fallback 
to the current functionality.

--

___
Python tracker 
<http://bugs.python.org/issue8052>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13788] os.closerange optimization

2012-01-14 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Thanks for the patch.

However, this cannot as far as I understand be used for the subprocess 
implementation due to the limitation of what can be called after a fork() and 
before an exec().

Take a look at #8052 for some more discussion of this.

--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue13788>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13779] os.walk: bottom-up

2012-01-13 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue13779>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13777] socket: communicating with Mac OS X KEXT controls

2012-01-12 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +ned.deily, ronaldoussoren

___
Python tracker 
<http://bugs.python.org/issue13777>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13757] os.fdlistdir() should not close the file descriptor given in argument

2012-01-10 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

The reason I made it like that was that it seemed "closer" to the fdopendir() 
function which steals the fd for internal use.

However, I agree that it makes more sense to dup() it.

Patch looks good.

--

___
Python tracker 
<http://bugs.python.org/issue13757>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13734] Add a generic directory walker method to avoid symlink attacks

2012-01-08 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

> I'm currently leaning towards the simple 4-tuple approach

I would also take that approach. It seems simplest to me.

--

___
Python tracker 
<http://bugs.python.org/issue13734>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13739] os.fdlistdir() is not idempotent

2012-01-08 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

> I see two options:
> 1. rewind the directory stream in fdlistdir()
> 2. document this
> 
> Here's a patch for option 1.

Yeah, looks good.

--

___
Python tracker 
<http://bugs.python.org/issue13739>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12364] Deadlock in test_concurrent_futures

2012-01-08 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Thanks!

--
assignee:  -> rosslagerwall
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed
type:  -> behavior

___
Python tracker 
<http://bugs.python.org/issue12364>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4489] shutil.rmtree is vulnerable to a symlink attack

2012-01-07 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
dependencies: +Add a generic directory walker method to avoid symlink attacks

___
Python tracker 
<http://bugs.python.org/issue4489>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13734] Add a generic directory walker method to avoid symlink attacks

2012-01-07 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

> Has there already been done any work? Ross mentioned he wanted to take a stab?

Unfortunately, I'm rather busy at the moment but when I get some free time and 
if no one else wants to work on it then I'll take a look.

--

___
Python tracker 
<http://bugs.python.org/issue13734>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13713] Regression for http.client read()

2012-01-04 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

The patch looks right and seems to fix the issue. Thanks :-)

--

___
Python tracker 
<http://bugs.python.org/issue13713>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13713] Regression for http.client read()

2012-01-04 Thread Ross Lagerwall

New submission from Ross Lagerwall :

806cfe39f729 introduced a regression for http.client read(len).

To see this:
$ ./python test.py
$ wget http://archives.fedoraproject.org/pub/archive/fedora/linux/core/1/SRPMS/
$ diff index.html index2.html

This is a difference in the files (which there shouldn't be).

The change which introduced the problem was:
changeset:   73875:806cfe39f729
user:Antoine Pitrou 
date:Tue Dec 06 22:33:57 2011 +0100
summary: Issue #13464: Add a readinto() method to http.client.HTTPResponse.

--
components: Library (Lib)
files: test.py
messages: 150615
nosy: orsenthil, pitrou, rosslagerwall
priority: normal
severity: normal
stage: needs patch
status: open
title: Regression for http.client read()
type: behavior
versions: Python 3.3
Added file: http://bugs.python.org/file24138/test.py

___
Python tracker 
<http://bugs.python.org/issue13713>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12364] Deadlock in test_concurrent_futures

2012-01-02 Thread Ross Lagerwall

Changes by Ross Lagerwall :


Added file: http://bugs.python.org/file24129/itest.py

___
Python tracker 
<http://bugs.python.org/issue12364>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12364] Deadlock in test_concurrent_futures

2012-01-02 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Retrieving the result of a future after the executor has been shut down can 
cause a hang.

It seems like this regression was introduced in a76257a99636. This regression 
exists only for ProcessPoolExecutor.

The problem is that even if there are pending work items, the processes are 
still signaled to shut down leaving the pending work items permanently 
unfinished. The patch simply removes the call to shut down the processes when 
there are pending work items.

Attached is a patch.

--
keywords: +patch
nosy: +rosslagerwall
Added file: http://bugs.python.org/file24128/issue.patch

___
Python tracker 
<http://bugs.python.org/issue12364>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13609] Add "os.get_terminal_size()" function

2012-01-02 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

I'll try & investigate Solaris a bit...

Also, what should be the default terminal size?

Gnome-terminal and xterm seem to default to 80x24, not 80x25.

--

___
Python tracker 
<http://bugs.python.org/issue13609>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13609] Add "os.get_terminal_size()" function

2012-01-02 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Nice patch :-)

I think the two function approach works well.

Since you have already checked that termsize is not NULL, Py_DECREF can be used 
instead of Py_CLEAR.

Would it not be better to use sys.__stdout__ instead of 1 in the documentation 
and to use STDOUT_FILENO instead of 1 in the code?

A brief google suggested that Solaris requires sys/termios.h for TIOCGWINSZ. 
Perhaps also only define TERMSIZE_USE_IOCTL if TIOCGWINSZ is defined.
Like so:
#if defined(HAVE_SYS_IOCTL_H)
#include 
#if defined(TIOCGWINSZ)
#define TERMSIZE_USE_IOCTL
#else
#define TERMSIZE_USE_NOTIMPLEMENTED
#endif
#elif defined(HAVE_CONIO_H)
#include 
#include 
#define TERMSIZE_USE_CONIO
#else
#define TERMSIZE_USE_NOTIMPLEMENTED
#endif

(didn't check the windows parts)

--

___
Python tracker 
<http://bugs.python.org/issue13609>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13694] asynchronous connect in asyncore.dispatcher does not set addr

2012-01-02 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue13694>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13684] httplib tunnel infinite loop

2012-01-02 Thread Ross Lagerwall

Changes by Ross Lagerwall :


--
nosy: +rosslagerwall

___
Python tracker 
<http://bugs.python.org/issue13684>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11006] warnings with subprocess and pipe2

2011-12-21 Thread Ross Lagerwall

Ross Lagerwall  added the comment:

Removed the warnings.

Thanks.

--
assignee:  -> rosslagerwall
nosy: +rosslagerwall
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed
versions: +Python 3.3

___
Python tracker 
<http://bugs.python.org/issue11006>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   3   4   >