[issue44328] time.monotonic() should use a different clock source on Windows

2021-06-12 Thread STINNER Victor
STINNER Victor added the comment: > To reduce the adverse effects of this frequency offset error, recent versions > of Windows, particularly Windows 8, use multiple hardware timers to detect > the frequency offset and compensate for it to the extent possible. This > calibra

[issue38323] asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x)

2021-06-12 Thread STINNER Victor
STINNER Victor added the comment: > I think this is a good idea. MultiLoopChildWatcher could use setwakeupfd with > some no-op callback just to wakeup the loop. A no-op doesn't solve the issue. It doesn't wake up the event loop. There are only two options to wake up the event loop: *

[issue44328] time.monotonic() should use a different clock source on Windows

2021-06-12 Thread STINNER Victor
STINNER Victor added the comment: Changing is clock is a tricky. There are many things to consider: * Is it really monotonic in all cases? * Does it have a better resolution than the previous clock? * Corner cases: does it include time spent in time.sleep() and while the system is suspended

[issue44396] pegen _PyParser_ASTFromFile(): Use-After-Free in syntaxerror()

2021-06-11 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +gvanrossum, lys.nikolaou, pablogsal title: Use-After-Free -> pegen _PyParser_ASTFromFile(): Use-After-Free in syntaxerror() ___ Python tracker <https://bugs.python.org/issu

[issue44394] [security] CVE-2013-0340 "Billion Laughs" fixed in Expat >=2.4.0: Updated to vendoed copy to expat 2.4.1

2021-06-11 Thread STINNER Victor
New submission from STINNER Victor : Our vendored copy of Modules/expat/ should be updated to Expat 2.4.1 to retrieve the fix for the security vulnerabily CVE-2013-0340 "Billion Laughs": https://blog.hartwork.org/posts/cve-2013-0340-billion-laughs-fixed-in-expat-2-4-0/

[issue44378] Py_IS_TYPE(): cast discards ‘const’ qualifier from pointer target type

2021-06-11 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44359] test_ftplib fails as "env changes" if a socket operation times out in a thread: TimeoutError is not catched

2021-06-11 Thread STINNER Victor
STINNER Victor added the comment: Another example on PPC64LE Fedora Stable LTO 3.10: https://buildbot.python.org/all/#/builders/644/builds/98 0:00:38 load avg: 7.51 [ 78/427/1] test_ftplib failed (env changed) -- running: test_signal (39.0 sec), test_nntplib (35.2 sec) Warning -- Uncaught

[issue44378] Py_IS_TYPE(): cast discards ‘const’ qualifier from pointer target type

2021-06-11 Thread STINNER Victor
STINNER Victor added the comment: New changeset 304dfec8d3c0763734ea8b5fa2af1d9e1ce69ffa by Victor Stinner in branch 'main': bpo-44378: Fix a compiler warning in Py_IS_TYPE() (GH-26644) https://github.com/python/cpython/commit/304dfec8d3c0763734ea8b5fa2af1d9e1ce69ffa

[issue39573] [C API] Make PyObject an opaque structure in the limited C API

2021-06-10 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-44378: "Py_IS_TYPE(): cast discards ‘const’ qualifier from pointer target type". If Py_TYPE() is converted again to a static inline function which takes a "const PyObject*" type, Py_IS_TYPE() can be modified again at t

[issue44378] Py_IS_TYPE(): cast discards ‘const’ qualifier from pointer target type

2021-06-10 Thread STINNER Victor
STINNER Victor added the comment: Comment from my PR: // bpo-44378: Don't use Py_TYPE() since Py_TYPE() requires a non-const // object. By the way, I wrote a change in Python 3.11 to convert Py_TYPE() macro into a static inline function which accepts a *const* PyObject pointer ("

[issue44378] Py_IS_TYPE(): cast discards ‘const’ qualifier from pointer target type

2021-06-10 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +25230 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26644 ___ Python tracker <https://bugs.python.org/issu

[issue44378] Py_IS_TYPE(): cast discards ‘const’ qualifier from pointer target type

2021-06-10 Thread STINNER Victor
New submission from STINNER Victor : The following change introduced a compiler warning: commit c5cb077ab3c88394b7ac8ed4e746bd31b53e39f1 Author: Victor Stinner Date: Tue Sep 22 12:42:28 2020 +0200 Py_IS_TYPE() macro uses Py_TYPE() (GH-22341) Steps to Reproduce: 1. dnf install -y

[issue44360] test_compile killed by SIGKILL on AMD64 Ubuntu 3.x (Linux OOM Killer)

2021-06-09 Thread STINNER Victor
STINNER Victor added the comment: > Yes, this was related to the Linux OOM Killer. Oh ok. Maybe you should give more memory to your worker, or you should spawn less jobs in parallel (-j1 instead of -j2). Or you should disable other services which eat memory. How much memory does it h

[issue44112] [buildbot] test_asyncio hangs (killed after 3 hours) on Refleak buildbots

2021-06-09 Thread STINNER Victor
STINNER Victor added the comment: > https://github.com/python/buildmaster-config/commit/9e0c812694d6fa599b4c8890045ed006fe7c1f6b aarch64 Fedora Rawhide Refleaks 3.8: https://buildbot.python.org/all/#/builders/401/builds/47 This change worked as expected: buildbot now uses a timeout o

[issue44360] test_compile killed by SIGKILL on AMD64 Ubuntu 3.x

2021-06-09 Thread STINNER Victor
STINNER Victor added the comment: Oh right, exit code -9 means killed by SIGKILL, it doesn't not mean killed SIGSEGV. Sorry about the confusion. How can a signal be killed by SIGKILL? Can it be related to Linux OOM Killer? Senthil: Would you mind to have a look at the server logs to see

[issue44357] Add math.cbrt() function: Cube Root

2021-06-09 Thread STINNER Victor
STINNER Victor added the comment: I didn't know the "cbrt" function name. It seems like it exists in the libc, but also in numpy. So it's a good idea to reuse this name ;-) numpy.cbrt(): Return the cube-root of an array, element-wise. https://numpy.org/doc/stable/reference

[issue44360] test_compile segfault on AMD64 Ubuntu 3.x

2021-06-09 Thread STINNER Victor
STINNER Victor added the comment: > I don't think that's a segfault. That seems that the process was killed no? > Also, the buildbot is green so this is not happening in the latest builds * (1) 0:01:12, test_compile child process was killed by signal -9 * (2) 0

[issue44358] AMD64 RHEL8 LTO + PGO 3.x build failed with: /usr/bin/ld: Dwarf Error: Offset (2487097600) greater than or equal to .debug_str size (571933).

2021-06-09 Thread STINNER Victor
STINNER Victor added the comment: I reported the compiler bug to RHEL: https://bugzilla.redhat.com/show_bug.cgi?id=1969775 -- ___ Python tracker <https://bugs.python.org/issue44

[issue44358] AMD64 RHEL8 LTO + PGO 3.x build failed with: /usr/bin/ld: Dwarf Error: Offset (2487097600) greater than or equal to .debug_str size (571933).

2021-06-09 Thread STINNER Victor
STINNER Victor added the comment: On OFTC #gcc, I'm told that it can this known issue fixed in 2018: https://sourceware.org/bugzilla/show_bug.cgi?id=23425 -- ___ Python tracker <https://bugs.python.org/issue44

[issue44361] test_smtpnet failed with SMTPServerDisconnected on x86 Gentoo Non-Debug with X 3.10

2021-06-09 Thread STINNER Victor
New submission from STINNER Victor : x86 Gentoo Non-Debug with X 3.10: https://buildbot.python.org/all/#/builders/698/builds/112 This buildbot worker has Internet connection issues, so my concern is only how test_smtpnet handles Internet issues. The two tests which fail use

[issue44348] test_exceptions.ExceptionTests.test_recursion_in_except_handler stack overflow on Windows debug builds

2021-06-09 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-44360 "test_compile segfault on AMD64 Ubuntu 3.x". -- ___ Python tracker <https://bugs.python.o

[issue44360] test_compile segfault on AMD64 Ubuntu 3.x

2021-06-09 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-44348 "test_exceptions.ExceptionTests.test_recursion_in_except_handler stack overflow on Windows debug builds". -- ___ Python tracker <https://bugs.python.o

[issue44360] test_compile segfault on AMD64 Ubuntu 3.x

2021-06-09 Thread STINNER Victor
New submission from STINNER Victor : test_compile and test_multiprocessing_forkserver crashed with segfault (SIGSEGV) on AMD64 Ubuntu 3.x: https://buildbot.python.org/all/#/builders/708/builds/31 It *seems* like test_compile.test_stack_overflow() crashed, but the log is not reliable so I

[issue44359] test_ftplib fails as "env changes" if a socket operation times out in a thread: TimeoutError is not catched

2021-06-09 Thread STINNER Victor
New submission from STINNER Victor : test_ftplib fails with "env changed" if a socket operation times out in a thread (in the "dummy FTP server"). Example on AMD64 Fedora Rawhide LTO 3.10: https://buildbot.python.org/all/#/builders/653/builds/95 0:02:41 load avg: 8.20 [39

[issue44358] AMD64 RHEL8 LTO + PGO 3.x build failed with: /usr/bin/ld: Dwarf Error: Offset (2487097600) greater than or equal to .debug_str size (571933).

2021-06-09 Thread STINNER Victor
New submission from STINNER Victor : On RHEL8, gcc (GCC) 8.4.1 20200928 (Red Hat 8.4.1-1) fails to build Python with LTO+PGO: the linker fails with "Dwarf Error". On ~200 builds, the linker error only occurred once (build 279) :-( It sounds really hard to reproduce. I sugges

[issue42213] Get rid of cyclic GC hack in sqlite3.Connection and sqlite3.Cache

2021-06-07 Thread STINNER Victor
STINNER Victor added the comment: I like the new code, thanks for these enhancements Erlend ;-) -- ___ Python tracker <https://bugs.python.org/issue42

[issue39573] [C API] Make PyObject an opaque structure in the limited C API

2021-06-07 Thread STINNER Victor
STINNER Victor added the comment: Ken Jin: Please open a separated issue for test_exceptions.test_recursion_in_except_handler(). It's not directly related to marking PyObject opaque, as William Pickard explained. See my notes on the stack size and stack overflow on a recursion error

[issue43933] Regression in python3.10 with traceback frame having lineno of -1

2021-06-07 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-44297. -- nosy: +vstinner ___ Python tracker <https://bugs.python.org/issue43933> ___ ___ Python-bugs-list mailin

[issue44112] [buildbot] test_asyncio hangs (killed after 3 hours) on Refleak buildbots

2021-06-04 Thread STINNER Victor
STINNER Victor added the comment: I bet that this issue is simply a duplicate of bpo-38323, since I can still (easily) reproduce it locally. I fixed the buildbot configuration, so if the bug happens again on Refleak buildbots, at least we should know which test method hangs. If it's

[issue44312] test_asyncio leaked [1533, 1531, 1533] references, sum=4597

2021-06-04 Thread STINNER Victor
STINNER Victor added the comment: > This is caused by: https://bugs.python.org/issue43693 You reverted the change: https://bugs.python.org/issue43693#msg395105 Can this issue be closed in this case? -- ___ Python tracker <https://bugs.pyth

[issue38323] asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x)

2021-06-04 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +25127 pull_request: https://github.com/python/cpython/pull/26536 ___ Python tracker <https://bugs.python.org/issue38

[issue38323] asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x)

2021-06-04 Thread STINNER Victor
STINNER Victor added the comment: When I reproduce test_cancel_make_subprocess_transport_exec() hang, the problem is that the C signal handler is called with SIGCHLD when the child process completes, but the Python signal handler is not called. Python is "blocked" in a selec

[issue44308] Raw Strings lack parody

2021-06-04 Thread STINNER Victor
STINNER Victor added the comment: I close the issue. Glad that you found a solution to your issue. -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44112] [buildbot] test_asyncio hangs (killed after 3 hours) on Refleak buildbots

2021-06-04 Thread STINNER Victor
STINNER Victor added the comment: Pablo: > Extending the bot time was done so we can use faulthandler to identify the > test, because buildbot was cancelling the whole build before that :) Right. I increased buildbot timeout to check if buildbots hang because of bpo-38323 or if it's

[issue38323] asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x)

2021-06-04 Thread STINNER Victor
STINNER Victor added the comment: This issue is not solved. I can still reproduce the hang using: ./python -m test test_asyncio -m SubprocessMultiLoopWatcherTests -v -F -j20 --timeout=30.0 Example with test_cancel_make_subprocess_transport_exec: $ ./python -m test test_asyncio -m

[issue43921] test_ssl: test_wrong_cert_tls13() and test_pha_required_nocert() fail randomly on Windows

2021-06-04 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker <https://bugs.python.org/issue43921> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43921] test_ssl: test_wrong_cert_tls13() and test_pha_required_nocert() fail randomly on Windows

2021-06-04 Thread STINNER Victor
STINNER Victor added the comment: Christian: I mostly care about buildbots. I cannot reproduce the issue in 3.9. If it's not broken, I don't want to touch the code :-) For GH-26520, I explained that I don't want to backport it (it's only in main). Moreover, you asked for automated backports

[issue44308] Raw Strings lack parody

2021-06-04 Thread STINNER Victor
STINNER Victor added the comment: You can use br"\n" to get 2 bytes: b"\\" and b"n". IMO it's the best practice, to use raw strings for regular expressions. Converting a regular string to a raw string sounds like a bad idea. --

[issue43921] test_ssl: test_wrong_cert_tls13() and test_pha_required_nocert() fail randomly on Windows

2021-06-03 Thread STINNER Victor
Change by STINNER Victor : -- priority: deferred blocker -> ___ Python tracker <https://bugs.python.org/issue43921> ___ ___ Python-bugs-list mailing list Un

[issue43921] test_ssl: test_wrong_cert_tls13() and test_pha_required_nocert() fail randomly on Windows

2021-06-03 Thread STINNER Victor
STINNER Victor added the comment: Ok, test_wrong_cert_tls13() and test_pha_required_nocert() of test_ssl should now be more reliable on Windows. I consider that the initial issue is now fixed and I close the issue. -- components: +SSL, Tests resolution: -> fixed stage: patch rev

[issue43921] test_ssl: test_wrong_cert_tls13() and test_pha_required_nocert() fail randomly on Windows

2021-06-03 Thread STINNER Victor
STINNER Victor added the comment: New changeset d2ab15f5376aa06ed120164f1b84bb40adbdd068 by Miss Islington (bot) in branch '3.10': bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows (GH-26502) (GH-26518) https://github.com/python/cpython/commit

[issue43921] test_ssl: test_wrong_cert_tls13() and test_pha_required_nocert() fail randomly on Windows

2021-06-03 Thread STINNER Victor
STINNER Victor added the comment: New changeset 5c2191df9a21a3b3d49dd0711b8d2b92591ce82b by Victor Stinner in branch 'main': bpo-43921: Cleanup test_ssl.test_wrong_cert_tls13() (GH-26520) https://github.com/python/cpython/commit/5c2191df9a21a3b3d49dd0711b8d2b92591ce82b

[issue39573] [C API] Make PyObject an opaque structure in the limited C API

2021-06-03 Thread STINNER Victor
STINNER Victor added the comment: New changeset f3fa63ec75fdbb4a08a10957a5c631bf0c4a5970 by Victor Stinner in branch 'main': bpo-39573: Py_TYPE becomes a static inline function (GH-26493) https://github.com/python/cpython/commit/f3fa63ec75fdbb4a08a10957a5c631bf0c4a5970

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-06-03 Thread STINNER Victor
STINNER Victor added the comment: New changeset 84d80f5f30b1f545083c70a7d4e1e79ab75f9fa6 by Erlend Egeberg Aasland in branch '3.10': [3.10] bpo-42972: Track sqlite3 statement objects (GH-26475) (GH-26515) https://github.com/python/cpython/commit/84d80f5f30b1f545083c70a7d4e1e79ab75f9fa6

[issue43921] test_ssl: test_wrong_cert_tls13() and test_pha_required_nocert() fail randomly on Windows

2021-06-03 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +25114 pull_request: https://github.com/python/cpython/pull/26520 ___ Python tracker <https://bugs.python.org/issue43

[issue44301] Is there a way to provide destructor for module written using C API?

2021-06-03 Thread STINNER Victor
STINNER Victor added the comment: Hi, you should use the multiphase initialization API which has clear and free functions. https://www.python.org/dev/peps/pep-0489/#the-proposal See for example the source code of the Modules/_abc.c extension. -- nosy: +vstinner

[issue43921] test_ssl: test_wrong_cert_tls13() and test_pha_required_nocert() fail randomly on Windows

2021-06-03 Thread STINNER Victor
STINNER Victor added the comment: New changeset ea0210fa8ccca769896847f25fc6fadfe9a717bc by Victor Stinner in branch 'main': bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows (GH-26502) https://github.com/python/cpython/commit/ea0210fa8ccca769896847f25fc6fadfe9a717bc

[issue44290] x86-64 macOS 3.x buildbot build failed with: No such file or directory: '/Users/buildbot/buildarea/3.x.billenstein-macos/build/target/include/python3.11d/pyconfig.h'

2021-06-03 Thread STINNER Victor
STINNER Victor added the comment: Well, as soon as the buildbot worker is green, it works for me :-D -- ___ Python tracker <https://bugs.python.org/issue44

[issue42213] Get rid of cyclic GC hack in sqlite3.Connection and sqlite3.Cache

2021-06-03 Thread STINNER Victor
STINNER Victor added the comment: New changeset 82ad22a97d4b5d7134424f12bd6a61167db7f4f8 by Erlend Egeberg Aasland in branch 'main': bpo-42213: Check connection in sqlite3.Connection.__enter__ (GH-26512) https://github.com/python/cpython/commit/82ad22a97d4b5d7134424f12bd6a61167db7f4f8

[issue44290] x86-64 macOS 3.x buildbot build failed with: No such file or directory: '/Users/buildbot/buildarea/3.x.billenstein-macos/build/target/include/python3.11d/pyconfig.h'

2021-06-03 Thread STINNER Victor
STINNER Victor added the comment: "So, I'd been trying various things before the master restart (...) I'll let this bake, seems pretty strange changing the interpreter running the buildbot would matter - everything else should be the same however." If you can, try to stop you

[issue37224] [subinterpreters] test__xxsubinterpreters fails randomly

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: Recent test_still_running() failure on AMD64 Windows8.1 Refleaks 3.10: https://buildbot.python.org/all/#/builders/638/builds/19 1:22:17 load avg: 3.00 [393/427/2] test__xxsubinterpreters failed -- running: test_pydoc (9 min 7 sec), test_venv (2 min 54 sec

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: The 12 latest build on https://buildbot.python.org/all/#/builders/464 are green (success). Can this issue be closed now? We can reopen it later if the issue strikes back. -- ___ Python tracker <ht

[issue44290] x86-64 macOS 3.x buildbot build failed with: No such file or directory: '/Users/buildbot/buildarea/3.x.billenstein-macos/build/target/include/python3.11d/pyconfig.h'

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: The 2 latest builds are green (success), so I close the issue. https://buildbot.python.org/all/#/builders/366 Thanks for the help! -- resolution: -> out of date stage: -> resolved status: open -&g

[issue44229] test_ssl: test_get_server_certificate() and test_msg_callback_deadlock_bpo43577() fail randomly on the macOS CI

2021-06-02 Thread STINNER Victor
Change by STINNER Victor : -- title: Intermittent connection errors in ssl tests on macOS CI -> test_ssl: test_get_server_certificate() and test_msg_callback_deadlock_bpo43577() fail randomly on the macOS CI ___ Python tracker <

[issue44288] unittest: _is_relevant_tb_level() fails because tb.tb_frame.f_globals=None

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: Oops, I wanted to ping Mark Shannon, not Mark Dickinson. -- nosy: +Mark.Shannon -mark.dickinson ___ Python tracker <https://bugs.python.org/issue44

[issue44297] Frame with -1 line number

2021-06-02 Thread STINNER Victor
New submission from STINNER Victor : While debugging https://bugs.python.org/issue43921 on Windows, I got a traceback with a single frame and the frame line number is -1. It looks like a Python 3.11 regression. Mark, Guido: can it be related to recent optimization work done in the main

[issue43921] test_ssl: test_wrong_cert_tls13() and test_pha_required_nocert() fail randomly on Windows

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: In Python 3.9, test_pha_required_nocert() looks more strict, it requires read() to fail with the 'tlsv13 alert certificate required' error message: # receive alert with self.assertRaisesRegex( ssl.SSLError

[issue43921] test_ssl: test_wrong_cert_tls13() and test_pha_required_nocert() fail randomly on Windows

2021-06-02 Thread STINNER Victor
Change by STINNER Victor : -- title: test_ssl fails on Windows buildbots -> test_ssl: test_wrong_cert_tls13() and test_pha_required_nocert() fail randomly on Windows ___ Python tracker <https://bugs.python.org/issu

[issue43921] test_ssl fails on Windows buildbots

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: See my comparison of read() and write() errors on Linux vs Windows: https://github.com/python/cpython/pull/26501#issuecomment-853489167 I wrote PR 26502 to fix test_wrong_cert_tls13() on Windows (currently, the test is skipped). On Linux, read() always

[issue43921] test_ssl fails on Windows buildbots

2021-06-02 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +25098 pull_request: https://github.com/python/cpython/pull/26502 ___ Python tracker <https://bugs.python.org/issue43

[issue43921] test_ssl fails on Windows buildbots

2021-06-02 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +25097 pull_request: https://github.com/python/cpython/pull/26501 ___ Python tracker <https://bugs.python.org/issue43

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 9c89d62073fa0bcfe68e59add5b55fbcbf7672ab by Miss Islington (bot) in branch '3.10': bpo-44282: Fix occasional test_incremental_editing failures on buildbots (GH-26491) (GH-26499) https://github.com/python/cpython/commit

[issue44290] x86-64 macOS 3.x buildbot build failed with: No such file or directory: '/Users/buildbot/buildarea/3.x.billenstein-macos/build/target/include/python3.11d/pyconfig.h'

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: > Hmm, I just tried to restart it from the builbot page but the build request > is just sitting there ATM. > https://buildbot.python.org/all/#/builders/366 Not sure what happened. I restarted the buildbot server manually. I cancelled the old man

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset adef445dc34685648bd0ea1c125df2ef143912ed by Tal Einat in branch 'main': bpo-44282: Fix occasional test_incremental_editing failures on buildbots (GH-26491) https://github.com/python/cpython/commit/adef445dc34685648bd0ea1c125df2ef143912ed

[issue44285] Coverity scan: Modules/getpath.c. "calculate_open_pyenv" allocates memory that is stored into "env_file".

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: Thanks Charalampos, it's now fixed in 3.9, 3.10 and main branches. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44285] Coverity scan: Modules/getpath.c. "calculate_open_pyenv" allocates memory that is stored into "env_file".

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 85b587a38dcf5d0ef1e275510001e22425d65977 by Miss Islington (bot) in branch '3.9': bpo-44285: getpath.c: Assert that env_file is NULL during an error check (GH-26486) (GH-26496) https://github.com/python/cpython/commit

[issue39573] [C API] Make PyObject an opaque structure in the limited C API

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: Most projects broken by Py_TYPE and Py_SIZE changes have been fixed since last year. I succeeded to use my new pythoncapi_compat project on multiple C extensions. So I propose again to convert Py_TYPE and Py_SIZE macros to static inline functions: https

[issue39573] [C API] Make PyObject an opaque structure in the limited C API

2021-06-02 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +25089 pull_request: https://github.com/python/cpython/pull/26493 ___ Python tracker <https://bugs.python.org/issue39

[issue43921] test_ssl fails on Windows buildbots

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 320eaa7f42b413cd5e5436ec92d4dc5ba150395f by Victor Stinner in branch 'main': bpo-43921: Fix test_ssl.test_pha_required_nocert() (GH-26489) https://github.com/python/cpython/commit/320eaa7f42b413cd5e5436ec92d4dc5ba150395f

[issue44290] x86-64 macOS 3.x buildbot build failed with: No such file or directory: '/Users/buildbot/buildarea/3.x.billenstein-macos/build/target/include/python3.11d/pyconfig.h'

2021-06-02 Thread STINNER Victor
New submission from STINNER Victor : x86-64 macOS 3.x: https://buildbot.python.org/all/#/builders/366/builds/322 The build 322 is the first error. Build 320 was fine, 321 failed with "retry lost connection test (retry)". (...) gcc -c -Wno-unused-result -Wsign-compare -g -O0 -Wal

[issue43921] test_ssl fails on Windows buildbots

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: > FAIL: test_pha_required_nocert (test.test_ssl.TestPostHandshakeAuth) When this bug occurs, s.recv(1024) returns an empty byte string (b''). I wrote PR 26489 to handle this case. -- ___ Python tracker <

[issue43921] test_ssl fails on Windows buildbots

2021-06-02 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +25085 pull_request: https://github.com/python/cpython/pull/26489 ___ Python tracker <https://bugs.python.org/issue43

[issue44112] [buildbot] test_asyncio hangs (killed after 3 hours) on Refleak buildbots

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: > Refleak buildbots should get a longer timeout for the "test" step. I changed buildbot Test step timeout from 3 hours to 4 hours: * https://github.com/python/buildmaster-config/commit/9e0c812694d6fa599b4c8890045ed006fe7c1f6b * https://gith

[issue44288] unittest: _is_relevant_tb_level() fails because tb.tb_frame.f_globals=None

2021-06-02 Thread STINNER Victor
New submission from STINNER Victor : Sometimes, when a test fails in the main branch, unittest fails with the following error: ... File "C:\vstinner\python\main\lib\unittest\result.py", line 205, in _is_relevant_tb_level return '__unittest' in tb.tb_frame.f_globals TypeError

[issue43921] test_ssl fails on Windows buildbots

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: On the main branch, I can reproduce test_pha_required_nocert() failure: vstinner@DESKTOP-DK7VBIL C:\vstinner\python\main>python -m test test_ssl -u all -v -F -j5 -m test_pha_required_nocert test_pha_required_nocert (test.test_ssl.TestPostHandshakeA

[issue44287] test_asyncio: test_popen() failed on AMD64 Windows8.1 Refleaks 3.9

2021-06-02 Thread STINNER Victor
New submission from STINNER Victor : AMD64 Windows8.1 Refleaks 3.9: https://buildbot.python.org/all/#/builders/6/builds/31 2:16:22 load avg: 7.33 [364/425/2] test_asyncio crashed (Exit code 1) -- running: test_decimal (2 min 33 sec), test_dbm (2 min 53 sec), test_bufio (18 min 18 sec

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: Buildbots are very unstable these days. I propose to revert the change to give more time to IDLE developers to investigate the issue, and to be able to identify other regressions on buildbots. https://pythondev.readthedocs.io/ci.html#revert-on-fail I

[issue41611] IDLE: problems with completions on Mac

2021-06-02 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +vstinner nosy_count: 7.0 -> 8.0 pull_requests: +25083 pull_request: https://github.com/python/cpython/pull/26487 ___ Python tracker <https://bugs.python.org/issu

[issue44285] Coverity scan: Modules/getpath.c. "calculate_open_pyenv" allocates memory that is stored into "env_file".

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: I still plan to rewrite getpath.c C file in Python: https://bugs.python.org/issue42260 But it's an incompatible change and a low priority for me. -- nosy: +vstinner versions: -Python 3.8 ___ Python tracker

[issue44263] Better explain the GC contract for PyType_FromSpecWithBases

2021-06-01 Thread STINNER Victor
STINNER Victor added the comment: I made sure that it's no longer possible to create a type with Py_TPFLAGS_HAVE_GC flag set but with no traverse function (tp_traverse=NULL). I close again the issue. -- components: +C API, Interpreter Core resolution: -> fixed stage: patch rev

[issue44263] Better explain the GC contract for PyType_FromSpecWithBases

2021-06-01 Thread STINNER Victor
STINNER Victor added the comment: New changeset ee7637596d8de25f54261bbeabc602d31e74f482 by Victor Stinner in branch 'main': bpo-44263: Py_TPFLAGS_HAVE_GC requires tp_traverse (GH-26463) https://github.com/python/cpython/commit/ee7637596d8de25f54261bbeabc602d31e74f482

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-06-01 Thread STINNER Victor
STINNER Victor added the comment: New changeset fffa0f92adaaed0bcb3907d982506f78925e9052 by Erlend Egeberg Aasland in branch 'main': bpo-42972: Track sqlite3 statement objects (GH-26475) https://github.com/python/cpython/commit/fffa0f92adaaed0bcb3907d982506f78925e9052

[issue44263] Better explain the GC contract for PyType_FromSpecWithBases

2021-05-31 Thread STINNER Victor
STINNER Victor added the comment: New changeset 142e5c5445c019542246d93fe2f9e195d3131686 by Victor Stinner in branch 'main': bpo-44263: Fix _decimal and _testcapi GC protocol (GH-26464) https://github.com/python/cpython/commit/142e5c5445c019542246d93fe2f9e195d3131686

[issue44263] Better explain the GC contract for PyType_FromSpecWithBases

2021-05-31 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +25059 pull_request: https://github.com/python/cpython/pull/26464 ___ Python tracker <https://bugs.python.org/issue44

[issue44263] Better explain the GC contract for PyType_FromSpecWithBases

2021-05-31 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +25058 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/26463 ___ Python tracker <https://bugs.python.org/issu

[issue44263] Better explain the GC contract for PyType_FromSpecWithBases

2021-05-31 Thread STINNER Victor
STINNER Victor added the comment: I reopen the issue. I would prefer to change PyType_FromSpecWithBases() to raise an error if a type has the Py_TPFLAGS_HAVE_GC flag but its tp_traverse function is NULL. Oops, the Python stdlib has more types than only _ssl.SSLError with this error

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-31 Thread STINNER Victor
STINNER Victor added the comment: New changeset ff359d735f1a60878975d1c5751bfd2361e84067 by Miss Islington (bot) in branch '3.10': bpo-42972: Fix sqlite3 traverse/clear functions (GH-26452) (GH-26461) https://github.com/python/cpython/commit/ff359d735f1a60878975d1c5751bfd2361e84067

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-31 Thread STINNER Victor
STINNER Victor added the comment: New changeset d1124b09e8251061dc040cbd396f35ae57783f4a by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fix sqlite3 traverse/clear functions (GH-26452) https://github.com/python/cpython/commit/d1124b09e8251061dc040cbd396f35ae57783f4a

[issue11871] test_default_timeout() of test_threading.BarrierTests failure: BrokenBarrierError

2021-05-31 Thread STINNER Victor
Change by STINNER Victor : -- status: closed -> open ___ Python tracker <https://bugs.python.org/issue11871> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue11871] test_default_timeout() of test_threading.BarrierTests failure: BrokenBarrierError

2021-05-31 Thread STINNER Victor
STINNER Victor added the comment: 10 years ago, the issue is not solved. Recent failure on AMD64 Windows8.1 Refleaks PR buildbot: https://buildbot.python.org/all/#/builders/470/builds/45 The issue started to make the buildbot fail since I added a threading.excepthook in libregrtest. 0:58

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-31 Thread STINNER Victor
STINNER Victor added the comment: New changeset 4b20f2574d412f4c4a5b1ab799d8e71a5dd3b766 by Hai Shi in branch 'main': bpo-42972: Fully implement GC protocol for xxlimited (GH-26451) https://github.com/python/cpython/commit/4b20f2574d412f4c4a5b1ab799d8e71a5dd3b766

[issue44252] test_ssl and test_httplib.HTTPSTest crash randomly with "Windows fatal exception: access violation" on Windows

2021-05-28 Thread STINNER Victor
STINNER Victor added the comment: For me, there are different issues: * PyType_FromSpec() must fail if a type is declared with Py_TPFLAGS_HAVE_GC but its tp_traverse function is NULL. * _ssl.SSLError must implement the tp_traverse slot Moreover, in debug mode, PyObject_GC_Track() calls

[issue44252] test_ssl and test_httplib.HTTPSTest crash randomly with "Windows fatal exception: access violation" on Windows

2021-05-28 Thread STINNER Victor
STINNER Victor added the comment: I remove Mark from the issue. I may open later a different issue for tb_frame.f_globals=None, but it's unrelated to this bug. I can reproduce the issue with a small hack to make GC collections make likely: diff --git a/Lib/site.py b/Lib/site.py index

[issue44252] test_ssl and test_httplib.HTTPSTest crash randomly with "Windows fatal exception: access violation" on Windows

2021-05-28 Thread STINNER Victor
STINNER Victor added the comment: Oh, I forgot to mention that I saw the "TypeError: argument of type 'NoneType' is not iterable" error on the main branch, not on the 3.10 branch. -- ___ Python tracker <https://bugs.python.o

[issue44252] test_ssl and test_httplib.HTTPSTest crash randomly with "Windows fatal exception: access violation" on Windows

2021-05-28 Thread STINNER Victor
STINNER Victor added the comment: Maybe the problem is related to Python frames. I think Mark Shannon made changes related to frames recently in 3.10 and main branches. It's strange that I got such error: File "C:\vstinner\python\main\lib\unittest\result.py"

[issue44252] test_ssl and test_httplib.HTTPSTest crash randomly with "Windows fatal exception: access violation" on Windows

2021-05-28 Thread STINNER Victor
STINNER Victor added the comment: Oh, test_ssl also crashed on Linux on the 3.10 branch, commit 0d399516320d8dfce4453037338659cef3a2adf4. AMD64 Fedora Stable 3.10 https://buildbot.python.org/all/#/builders/659/builds/70 test.pythoninfo: ssl.HAS_SNI: True ssl.OPENSSL_VERSION: OpenSSL 1.1.1k

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-28 Thread STINNER Victor
STINNER Victor added the comment: New changeset 490b638e63558013b71dbfba6e47cb9e6d80c911 by Ken Jin in branch 'main': bpo-42972: Fix GC assertion error in _winapi by untracking Overlapped earlier (GH(26429) https://github.com/python/cpython/commit/490b638e63558013b71dbfba6e47cb9e6d80c911

[issue44252] test_ssl and test_httplib.HTTPSTest crash randomly with "Windows fatal exception: access violation" on Windows

2021-05-28 Thread STINNER Victor
STINNER Victor added the comment: Ken Jin: "Sorry, I introduced the test_httplib regression on Windows with GH-26381 commit 0fa282c55f1a45765340cb24ed65c90ffe2aa405. I made a second PR GH-26429 to fix it." That would help to fix the issue, sadly the crash is earlier to you

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-28 Thread STINNER Victor
STINNER Victor added the comment: I'm not fully satified by the overlapped_dealloc() implementation neither. There is an unpleasant code path for Windows XP but it's no longer needed in Python 3.11. I would prefer to always call PyObject_GC_UnTrack() and call it earlier. See the dicsussion

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-28 Thread STINNER Victor
STINNER Victor added the comment: I'm not fully satisfied by the implementation of the two LRU types in functools. See the discussion in these two PRs: https://github.com/python/cpython/pull/26363 https://github.com/python/cpython/pull/26423 The _lru_list_elem doesnt implement the GC

  1   2   3   4   5   6   7   8   9   10   >