[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules
Sean Rodman added the comment: Is there anything else I can do for this? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19614] support.temp_cwd should use support.rmtree
Sean Rodman added the comment: Thank you for reviewing it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19614 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules
Sean Rodman added the comment: Here is a working patch for python 2.7. all it does is lowercase the module name, but once I did that and clicked the link it worked correctly. -- keywords: +patch Added file: http://bugs.python.org/file34233/issue16484.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules
Sean Rodman added the comment: Note: It doesn't change the actual module name. Just how it is represented in the link. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules
Sean Rodman added the comment: Here is the patch for python 3.2. It implements the same fix that the 2.7 patch does. -- Added file: http://bugs.python.org/file34234/issue16484_python3.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules
Changes by Sean Rodman srodman7...@gmail.com: Removed file: http://bugs.python.org/file34234/issue16484_python3.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules
Changes by Sean Rodman srodman7...@gmail.com: Removed file: http://bugs.python.org/file34233/issue16484.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules
Sean Rodman added the comment: Sorry guys, I missed a place I needed to add the lower() fuction to the module.__name__. Here is a fixed patch for python2.7. -- Added file: http://bugs.python.org/file34236/issue16484_python2.7.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules
Changes by Sean Rodman srodman7...@gmail.com: Added file: http://bugs.python.org/file34238/issue16484_python3.3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules
Sean Rodman added the comment: Here are the python3.2 and python3.3 patches. Please let me know if there is anything I need to change on these. -- Added file: http://bugs.python.org/file34237/issue16484_python3.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] Improve doc for csv.DictReader 'fieldnames' parameter
Sean Rodman added the comment: Is there anything else that should be added to this patch? I don't mean to bug you guys just want to make sure that everything is right with it so that if and or when it is applied it will apply without any problems. Also, if there is anything else I should change I am definitely open to changing anything that is needed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20146] UserDict module docs link is obsolete
Sean Rodman added the comment: Hey drunax, I would like to create a patch for this and upload, but I don't see the link you are talking about. Is it in the documentation or is it in the file UserDict.py? -- nosy: +sean.rodman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20146 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19614] support.temp_cwd should use support.rmtree
Sean Rodman added the comment: Hey r.david.murray, so should this change be made in the test? -- nosy: +sean.rodman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19614 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19614] support.temp_cwd should use support.rmtree
Sean Rodman added the comment: I don't see where temp_cwd uses shutil.rmtree, but I do see where temp_dir uses shutil.rmtree. Here is a patch to change that to support.rmtree. If I am way off base on this patch please let me know and I will change it to fix whatever needs to be fixed. I want to contribute to python as much as I can so I will do anything to get this fixed that is necessary. Please let me know what you think. -- keywords: +patch Added file: http://bugs.python.org/file34218/issue19614.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19614 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules
Sean Rodman added the comment: I could try to create the patch for pydoc if you would like for me to. -- nosy: +sean.rodman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules
Sean Rodman added the comment: To display my ignorance, I have run the pydoc command listed in the original message but I can't actually see where it lists the url. Or even where it has a link. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Sean Rodman added the comment: I just realized that my two last updates on this ticket could be sort of confusing. So here is what I did for the 2.7 patch. First I copied the wording that I used for the 3.3/4 patch and then I created a relative link using the syntax `sequence collections.html`_ because I couldn't find a way to get the :ref: syntax to work correctly. I have applied this patch to the 2.7 branch and compiled the html documentation. When I tested it the link does work correctly. It goes to the collections page of the documentation. If you have time could you review the patch for 2.7 for me? (The patch is named DictReader_DictWriter_python2_NewWording.patch.) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Sean Rodman added the comment: Great! Thank you for the reference name. I have changed the patch to use a ref link. Here is the new patch. -- Added file: http://bugs.python.org/file34155/DictReader_DictWriter_python2_ref.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Changes by Sean Rodman srodman7...@gmail.com: Removed file: http://bugs.python.org/file34141/DictReader_DictWriter_python2_NewWording.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Sean Rodman added the comment: Here is a patch for DictReader that adds a mod link to the sequence abstract as requested. Please review this if you could and let me know what you think. Note: This patch is for python 3 and if you like how I have done it on here I will go ahead and create a patch that covers python 2 as well. -- Added file: http://bugs.python.org/file34135/DictReader_python3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Changes by Sean Rodman srodman7...@gmail.com: Removed file: http://bugs.python.org/file34109/DictReader_DictWriter_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Changes by Sean Rodman srodman7...@gmail.com: Removed file: http://bugs.python.org/file34135/DictReader_python3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Sean Rodman added the comment: Ok, I have take the approach I used with the original patch and applied it to this one, listing that fieldnames is a sequence. Then, I added a link to the collections abstract on that instance of the word sequence. I did this for both DictReader and DictWriter as I did in the original patch. Would this be what you think is needed? -- Added file: http://bugs.python.org/file34136/DictReader_DictWriter_python3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Changes by Sean Rodman srodman7...@gmail.com: Removed file: http://bugs.python.org/file34136/DictReader_DictWriter_python3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Sean Rodman added the comment: What about if I put The *fieldnames* parameter is a :mod:`sequence collections.abc` whose elements are associated with the fields of the input data in order. These elements become the keys of the resulting dictionary. It contains all of the information that you have but it feels more to the point when you separate it as two sentences. The attached patch reflect these changes. -- Added file: http://bugs.python.org/file34139/DictReader_DictWriter_python3_NewWording.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Sean Rodman added the comment: Here is the equivalent 2.7 patch. I used a relative link with the format `sequence collections.html`_ in order to link to the collections page. I tried to use the reference syntax but I could find the subsection that I needed to reference in the documentation. If you would like for me to go that route I don't mind trying to figure it out, this is just the way I was able to get the documentation compiling and working correctly. -- Added file: http://bugs.python.org/file34141/DictReader_DictWriter_python2_NewWording.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Sean Rodman added the comment: That is supposed to say I couldn't find the subsection that I needed to reference in the documentation. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Sean Rodman added the comment: It looks like you are right. I have updated the patch to reflect that it could be a list or a tuple. -- Added file: http://bugs.python.org/file34109/DictReader_DictWriter_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Changes by Sean Rodman srodman7...@gmail.com: Removed file: http://bugs.python.org/file34084/DictReader_DictWriter.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Sean Rodman added the comment: I am new to contributing to python, and I would like to take a shot a creating a patch for this. -- nosy: +sean.rodman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20628] csv.DictReader
Sean Rodman added the comment: I have created a patch for this documentation issue. Could you please review this for me and tell me what you think? -- keywords: +patch Added file: http://bugs.python.org/file34084/DictReader_DictWriter.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20628 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
