[issue17519] unittest should not try to run abstract classes

2021-04-01 Thread Stephen Thorne
Stephen Thorne added the comment: I have done some experimentation here and thought through this feature request. The concept we are trying to deliver is: "I would like to share functionality between test classes, by having an abstract parent, with concrete leaves" The metaclass a

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

2012-08-19 Thread Stephen Thorne
Stephen Thorne added the comment: Please see attached new patch, based on review comments. -- Added file: http://bugs.python.org/file26894/zipimport-issue14905-2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905

[issue14826] urllib2.urlopen fails to load URL

2012-07-08 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: Here's a followup patch that fixes the trunk build for me. This will unbreak the builds as well as fixing this bug, but it should be investigated why URLopener calls to_bytes() and Request does not. Ideally this interface should

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

2012-07-07 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: Here is a patch that synthesises the directory names at the point where file names are read in. The unit test now passes, and has had the expected failure removed. Patch collaboration with Diarmuid Bourke diarmuidbou...@gmail.com

[issue11319] Command line option -t (and -tt) does not work for a particular case

2012-07-07 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: In discussion with GvR, we've decided we're not interested in intentionally rejecting code that is valid for tab width values between 1 and 8 inclusive. Thanks for the bug report! -- nosy: +jerub

[issue1508475] transparent gzip compression in urllib

2012-07-07 Thread Stephen Thorne
Changes by Stephen Thorne step...@thorne.id.au: -- nosy: +jerub ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1508475 ___ ___ Python-bugs-list

[issue14988] _elementtree: Raise ImportError when importing of pyexpat fails

2012-07-07 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: With the attached patch, with python3.3(trunk) I instead get: ./python.exe -c 'import _elementtree' Traceback (most recent call last): File string, line 1, in module File frozen importlib._bootstrap, line 1294, in _find_and_load

[issue14826] urllib2.urlopen fails to load URL

2012-07-07 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: Here is a patch that uses the same quoting logic in urllib.request.Request.__init__ as is used by urllib.request.URLopener.open() -- keywords: +patch nosy: +jerub versions: +Python 3.3 -Python 2.7 Added file: http://bugs.python.org

[issue11104] distutils sdist ignores MANIFEST

2012-02-03 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: Yep - 2.7.2 was released 11th June 2011, the fix was committed Aug 1st 2011. So it won't be in the current 2.7 release. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue11104] distutils sdist ignores MANIFEST

2011-06-25 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: √Čric mentioned that i should check that this behaviour matches the documentation. I have gone and looked for all instances of MANIFEST in the documentation and found one place which was inconsistent. I've added the doc patch to the patch

[issue10510] distutils upload/register should use CRLF in HTTP requests

2011-06-25 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: I'm having a look at this ticket now. It looks like this can be rewritten to use common code, and it would probably be good to use the 'email' module for creating the MIME segements properly. -- nosy: +jerub

[issue10510] distutils upload/register should use CRLF in HTTP requests

2011-06-25 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: Okay, I looked at this, then I ran into str/byte type problems with the email module. Will wait until 'email' is sorted out before I consider a ticket like this one again. -- ___ Python tracker

[issue11104] distutils sdist ignores MANIFEST

2011-06-24 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: I have 2 patches, with tests, that applies on python2.7 and the python3 series of branches, attached this ticket. I have also got a signed contributor agreement lodged with the PSF. Can I please have someone either apply my patches

[issue11104] distutils sdist ignores MANIFEST

2011-06-24 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: Oh! I didn't see any notification that there was a review done. Thanks, I'll attend to that. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11104

[issue11104] distutils sdist ignores MANIFEST

2011-06-24 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: This patch is an updated patch that fixes the things noted in the review from eric.araujo. -- Added file: http://bugs.python.org/file22437/manifest-respect-3 ___ Python tracker rep

[issue11104] distutils sdist ignores MANIFEST

2011-06-24 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: Updated the patch to address the 'why not use .strip()' question. I used .rstrip('\r\n') on the basis that filenames may have leading or trailing spaces, and if you need that, you need to be able to specify that in a MANIFEST

[issue11104] distutils sdist ignores MANIFEST

2011-06-04 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: I've taken the sdist.patch and wrote some tests for it. The resulting patch is attached as 'manifest-respect.patch'. -- nosy: +jerub Added file: http://bugs.python.org/file22242/manifest-respect.patch

[issue11104] distutils sdist ignores MANIFEST

2011-06-04 Thread Stephen Thorne
Stephen Thorne step...@thorne.id.au added the comment: This patch is tested against the 3.1 and default branches, the previous patch attached was against the 2.7 branch. -- Added file: http://bugs.python.org/file22243/manifest-respect-3.patch