[issue44687] io.BufferedReader:peek() closes underlying file, breaking peek/read expectations

2021-09-23 Thread Steve Dower


Steve Dower  added the comment:

Seems like it would be better to not check the file open/closed state on 
peek/read when there is still buffered data?

--
nosy: +steve.dower

___
Python tracker 
<https://bugs.python.org/issue44687>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15870] PyType_FromSpec should take metaclass as an argument

2021-09-23 Thread Steve Dower


Steve Dower  added the comment:

Passing the metaclass as a slot seems like the right idea for this API, though 
I recall there being some concern about the API (IIRC, mixing function pointers 
and data pointers doesn't work on some platforms?) that mean it'll be 
deprecated in the future.

--
nosy: +steve.dower

___
Python tracker 
<https://bugs.python.org/issue15870>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45244] pip not installed with fresh python3.8.10 installation

2021-09-23 Thread Steve Dower


Steve Dower  added the comment:

Can you attach the log files stored in your %TEMP% as a zip file? They should 
all start with "Python".

Be aware that they may contain personal information, such as usernames or 
machine names. Feel free to scrub those first if necessary.

--
nosy: +steve.dower

___
Python tracker 
<https://bugs.python.org/issue45244>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45272] 'os.path' should not be a frozen module

2021-09-23 Thread Steve Dower


New submission from Steve Dower :

I noticed that Python/frozen.c includes posixpath as 'os.path'.

This is not correct, and shouldn't be necessary anyway, because os.path is just 
an attribute in "os" and not a concrete module (see Lib/os.py#L95 for the bit 
that makes it importable, and Lib/os.py#L61 and Lib/os.py#L81 for the imports).

--
assignee: eric.snow
messages: 402506
nosy: eric.snow, steve.dower
priority: normal
severity: normal
stage: needs patch
status: open
title: 'os.path' should not be a frozen module
type: behavior
versions: Python 3.11

___
Python tracker 
<https://bugs.python.org/issue45272>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45213] Frozen modules are looked up using a linear search.

2021-09-23 Thread Steve Dower


Steve Dower  added the comment:

Could we add a compile-time requirement (most likely checked in tests, rather 
than at build) that _PyImport_FrozenModules be sorted? Then we can at least 
bail out of the loop early, and one day someone could make it a binary search.

--
nosy: +steve.dower

___
Python tracker 
<https://bugs.python.org/issue45213>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45256] Remove the usage of the C stack in Python to Python calls

2021-09-23 Thread Steve Dower


Steve Dower  added the comment:

I fully support implementing the core idea of Stackless Python :)

I spent a whole EuroPython a couple of years back discussing the idea with 
(apparently) everyone except Mark.

Though I wouldn't like to lose the ability to extract the Python stack by 
inspecting native memory alone. That is very useful for debugging, particularly 
when you've only got a crash dump. So provided all the code objects are only an 
indirection or two away from a local (or better yet, parameter) value, it 
should be fine.

--
nosy: +steve.dower

___
Python tracker 
<https://bugs.python.org/issue45256>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45271] Add a 'find' method (a'la str) to list

2021-09-23 Thread Steve Dower


Steve Dower  added the comment:

Strings are already special in that str.index() and str.find() both find 
substrings, while list.index() only finds a single element.

If .find() also searched for a substring of the list, I think this could be 
helpful. Even more so if it used an efficient algorithm (bearing in mind that 
the arbitrary comparisons between elements - something else that doesn't exist 
in strings - would make this complicated).

This is probably something to bring up on the python-ideas mailing list first, 
anyway. Symmetry is not a sufficient reason in itself to add new APIs - often 
the asymmetry exists because the "missing" one is only there for 
legacy/compatibility reasons, not because it is a good API.

--
nosy: +steve.dower

___
Python tracker 
<https://bugs.python.org/issue45271>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40503] PEP 615: Add zoneinfo module

2021-09-21 Thread Steve Dower


Steve Dower  added the comment:

We'd need to implement some form of data store for values on Windows, which 
currently are not compiled in anywhere, and it would need a substitution syntax 
to be updated at runtime.

We're talking a big feature now, and you'd end up having just as much code on 
your side to make it work.

The only justification that'd make sense on our side is if we were going to 
bundle the tzdata file with the Windows installer, which doesn't affect you at 
all, apart from us then having an existing path listed that you'd want to 
override still. And even then, we'd probably preinstall the tzdata package 
which already overrides the path, and so there'd be no changes necessary to 
sysconfig and so we wouldn't touch it anyway.

--

___
Python tracker 
<https://bugs.python.org/issue40503>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40503] PEP 615: Add zoneinfo module

2021-09-21 Thread Steve Dower


Steve Dower  added the comment:

I meant I don't think we want that path upstream, and you should keep it as 
your own patch.

We don't have a "share" directory as part of CPython, but this would codify it. 
That would then conflict with your use of it in conda-forge.

It also makes sysconfig non-deterministic, which is going to be problematic 
against some other efforts around being able to treat it as static data to make 
native module compilation easier, as well as more generally something that 
often leads to security vulnerabilities and is best avoided.

So on balance, I think we will reject that patch.

--

___
Python tracker 
<https://bugs.python.org/issue40503>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45176] Many regtest failures on Windows with non-ASCII account name

2021-09-21 Thread Steve Dower


Steve Dower  added the comment:

> I've already installed for all users, just not into the default "C:\Program 
> Files\", but instead "C:\Programs\Python\"

Ah yes, that indeed rules out my first suspicion.

> Fixing tests is not enough, because it is often an issue of scripts which 
> write paths to the stdout.

Sure, but the ones currently failing here are ours, so we are the ones who need 
to fix them :) And they all seem to be in our test suite.

Fixing the tests doesn't make all the problems go away, just the specific ones 
we are responsible for on this issue.

--

___
Python tracker 
<https://bugs.python.org/issue45176>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45257] Compiling 3.8 branch on Windows attempts to use incompatible libffi version

2021-09-21 Thread Steve Dower


Steve Dower  added the comment:

Yes, unfortunately the external build was not referencing a tag in those 
sources but a branch, so when the newer version was pushed they picked it up.

We fixed the pin in 
https://github.com/python/cpython/commit/8c3a10e58b12608c3759fee684e7aa399facae2a
 You should only need the get_externals.bat change.

--

___
Python tracker 
<https://bugs.python.org/issue45257>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45237] Python subprocess not honoring append mode for stdout on Windows

2021-09-20 Thread Steve Dower


Steve Dower  added the comment:

> This change has been discussed, but I don't know whether or not it's just a 
> pipe dream

Still a bit of a pipe dream, but I'll add this issue as something that would be 
fixed by it (to stack up against the list of things that would be broken...)

--

___
Python tracker 
<https://bugs.python.org/issue45237>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44848] Upgrade macOS and Windows installers to use SQLite 3.36.0

2021-09-20 Thread Steve Dower


Steve Dower  added the comment:


New changeset 5846c9b71ee9277fe866b1bdee4cc6702323fe7e by Erlend Egeberg 
Aasland in branch 'main':
bpo-44848: Update Windows installer to use SQLite 3.36.0 (GH-27622)
https://github.com/python/cpython/commit/5846c9b71ee9277fe866b1bdee4cc6702323fe7e


--

___
Python tracker 
<https://bugs.python.org/issue44848>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45176] Many regtest failures on Windows with non-ASCII account name

2021-09-20 Thread Steve Dower


Steve Dower  added the comment:

I'd guess that these tests are assuming that sys.executable contains only ASCII 
characters. All the tests run in a non-ASCII working directory, so it's only 
the runtime that is not tested propersy here.

The easiest way for Ming Hua to test this is to install for all users (into 
Program Files), and run tests with the same user account.

If that's the case, we probably have to just go through the tests and make them 
Unicode-aware.

--

___
Python tracker 
<https://bugs.python.org/issue45176>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40503] PEP 615: Add zoneinfo module

2021-09-20 Thread Steve Dower


Steve Dower  added the comment:

That looks like a relocatable path anyway, which means you wouldn't want to 
compile it into the binary. Your patch to select a default value at runtime is 
probably better.

The compile-time option is meant for a system directory.

--

___
Python tracker 
<https://bugs.python.org/issue40503>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45055] Fresh build on Windows fails the first time for zlib.c

2021-09-20 Thread Steve Dower


Steve Dower  added the comment:


New changeset ef9e22b253253615098d22cb49141a2a1024ee3c by Steve Dower in branch 
'main':
bpo-45055: Add retry when downloading externals on Windows (GH-28399)
https://github.com/python/cpython/commit/ef9e22b253253615098d22cb49141a2a1024ee3c


--

___
Python tracker 
<https://bugs.python.org/issue45055>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45013] os.path.isfile fails on path exactly 260 Chars long in Windows

2021-09-16 Thread Steve Dower


Change by Steve Dower :


--
resolution:  -> third party
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue45013>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

2021-09-16 Thread Steve Dower


Steve Dower  added the comment:

I think the PR is basically ready, unfortunately it's stuck behind a CI issue 
we only just fixed, and needs to merge from main before it'll clear.

Posting here once CI is green will get attention faster than on GitHub.

--
versions: +Python 3.11 -Python 3.6, Python 3.7, Python 3.8

___
Python tracker 
<https://bugs.python.org/issue42627>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45055] Fresh build on Windows fails the first time for zlib.c

2021-09-16 Thread Steve Dower


Change by Steve Dower :


--
keywords: +patch
pull_requests: +26813
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/28399

___
Python tracker 
<https://bugs.python.org/issue45055>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44848] Upgrade macOS and Windows installers to use SQLite 3.36.0

2021-09-16 Thread Steve Dower


Steve Dower  added the comment:

I (finally) posted the updated SQLite sources to the repo, so PR 27622 should 
build now. (I also retriggered CI)

That said, it *might* need to merge from main again to take a fix for a 
CI-blocking issue.

--

___
Python tracker 
<https://bugs.python.org/issue44848>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45120] Windows cp encodings "UNDEFINED" entries update

2021-09-16 Thread Steve Dower


Steve Dower  added the comment:

Thanks for the PR.

Just wanted to acknowledge that we've seen it. Unfortunately, I'm not feeling 
confident to take this change right now - encodings are a real minefield, and 
we need to think through the implications. It's been a while since I've done 
that, so could take some time.

Unless one of the other people who have spent time working on this comes in and 
says they've thought it through and this is the best approach. In which case 
I'll happily trust them :)

--
nosy: +eryksun, serhiy.storchaka

___
Python tracker 
<https://bugs.python.org/issue45120>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

2021-09-16 Thread Steve Dower


Change by Steve Dower :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue45220>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

2021-09-16 Thread Steve Dower


Steve Dower  added the comment:


New changeset f4b94b1f57827083990272b5f282aa1493ae2bf4 by Steve Dower in branch 
'main':
bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when 
building (GH-28393)
https://github.com/python/cpython/commit/f4b94b1f57827083990272b5f282aa1493ae2bf4


--

___
Python tracker 
<https://bugs.python.org/issue45220>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

2021-09-16 Thread Steve Dower


Change by Steve Dower :


--
keywords: +patch
pull_requests: +26805
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/28393

___
Python tracker 
<https://bugs.python.org/issue45220>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

2021-09-16 Thread Steve Dower


Steve Dower  added the comment:

> C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\winnt.h

This appears to be the Windows 11 preview SDK, so most likely it's a bug in 
that. We'll obviously need some logic to not automatically upgrade to this SDK 
on build.

--

___
Python tracker 
<https://bugs.python.org/issue45220>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

2021-09-16 Thread Steve Dower


Steve Dower  added the comment:

The build order change was not backported (and should not be), so it's 
unrelated to the failures on 3.9 and 3.10.

More likely this is either a problematic compiler update, or some additional 
data leaking into the build information (e.g. I could see this happening if 
someone added a UTF-8 copyright symbol somewhere instead of an escaped version).

--

___
Python tracker 
<https://bugs.python.org/issue45220>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-16 Thread Steve Dower


Steve Dower  added the comment:

I agree with Raymond. Let's stop throwing more code at this until we've figured 
out what's going on and revert the change for now.

--

___
Python tracker 
<https://bugs.python.org/issue45116>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45188] De-couple the Windows builds from freezing modules.

2021-09-15 Thread Steve Dower


Steve Dower  added the comment:

Should be able to, yeah. Though I didn't test that.

--

___
Python tracker 
<https://bugs.python.org/issue45188>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45188] De-couple the Windows builds from freezing modules.

2021-09-15 Thread Steve Dower


Steve Dower  added the comment:


New changeset 09b4ad11f323f8702cde795e345b75e0fbb1a9a5 by Steve Dower in branch 
'main':
bpo-45188: Windows now regenerates frozen modules at the start of build instead 
of late (GH-28322)
https://github.com/python/cpython/commit/09b4ad11f323f8702cde795e345b75e0fbb1a9a5


--

___
Python tracker 
<https://bugs.python.org/issue45188>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45188] De-couple the Windows builds from freezing modules.

2021-09-13 Thread Steve Dower


Change by Steve Dower :


--
keywords: +patch
pull_requests: +26731
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/28322

___
Python tracker 
<https://bugs.python.org/issue45188>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45188] De-couple the Windows builds from freezing modules.

2021-09-13 Thread Steve Dower


Steve Dower  added the comment:

Only thing I'd add is that you should just be able to list the required .c 
files in _freeze_module.vcxproj (formerly known as freeze_importlib.vcxproj) 
rather than depending on pythoncore.vcxproj.

That will generate twice as many .obj files for those modules (which is fine, 
just takes a little more time at build), and will force everything to be 
regenerated if you modify them, but that's an expected part of having part of 
the interpreter depend upon itself.

--
components: +Windows
nosy: +paul.moore, tim.golden, zach.ware

___
Python tracker 
<https://bugs.python.org/issue45188>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31100] unable to open python on Windows

2021-09-09 Thread Steve Dower


Steve Dower  added the comment:

At this point, this isn't a helpful bug report anymore.

--
resolution:  -> out of date
stage:  -> resolved
status: pending -> closed

___
Python tracker 
<https://bugs.python.org/issue31100>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45151] Logger library with task scheduler

2021-09-09 Thread Steve Dower


Steve Dower  added the comment:

Also, can you include your full task definition? There are a lot of options 
there which could cause it to launch in a different working directory (which 
will mess with your relative paths) or as a different user (which could mess 
with whether you can import your libraries).

I think it's possible to export the task definition as XML. Copy/pasting that 
here will be fine (not as an attachment, please, we just need to read it).

It's also difficult to collect standard output, so you may want to try adding 
something like "sys.stdout = sys.stderr = open(r'C:\Users\Public\Public 
Documents\log.txt', 'w')" to try and collect any output that you may be 
missing. The full path to the file is important, and it will need to be 
somewhere that most accounts can write.

--

___
Python tracker 
<https://bugs.python.org/issue45151>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45022] Update libffi to 3.4.2

2021-09-09 Thread Steve Dower


Steve Dower  added the comment:

Going to just decide that we won't backport the update. If a big enough 
security issue is found we can consider it, but it would have to justify the 
potential-but-unlikely breaking change for users who are relying on the name of 
the DLL.

--
resolution:  -> fixed
stage: backport needed -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue45022>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39570] Python 3.7.3 Crash on msilib actions

2021-09-07 Thread Steve Dower


Steve Dower  added the comment:

Yep, this is malware. Don't download the file.

If this is a CPython issue that you want fixed, please provide a script to 
generate the MSI.

--
resolution:  -> rejected
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39570>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45116] Performance regression 3.10b1 and later on Windows

2021-09-07 Thread Steve Dower


Steve Dower  added the comment:

> I'm not sure if PGO builds are reproducible, since there is a training step 
> which requires to run a non-deterministic workload (the Python test suite 
> which is somehow randomized by I/O timings and other stuffs).

I'm 99% sure it's a tracing PGO rather than sampling, so provided everything 
runs in the same order and follows the same codepaths, wall-clock timings 
shouldn't have a significant effect.

Without looking at the generated code, it may be more effective to try and 
force the functions called from the macro to never be inlined. The optimiser 
may be missing that the calls are uncommon, and trying to inline them first, 
then deciding that the whole merged function is too big to inline in places 
where it would be useful.

There's also no particular reason we need to use these tests as the profile, 
it's just that nobody has taken the time to come up with anything better. I'd 
rather see us invest time in generating a good profile rather than trying to 
hand-optimise inlining. (Though the test suite is good in many ways, because it 
makes sure all the extension modules are covered. We definitely want as close 
to full code coverage as we can get, at least for happy paths, but may need 
more eval loop in the profile if that's what needs help.)

--

___
Python tracker 
<https://bugs.python.org/issue45116>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45022] Update libffi to 3.4.2

2021-09-07 Thread Steve Dower


Steve Dower  added the comment:


New changeset 4dc4300c686f543d504ab6fa9fe600eaf11bb695 by giovanniwijaya in 
branch 'main':
bpo-45022: Fix libffi DLL name in Windows installer sources (GH-28203)
https://github.com/python/cpython/commit/4dc4300c686f543d504ab6fa9fe600eaf11bb695


--

___
Python tracker 
<https://bugs.python.org/issue45022>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29232] Quiet Install

2021-09-06 Thread Steve Dower


Steve Dower  added the comment:

The underlying issue is known and tracked by issue25166

--
resolution:  -> out of date
stage:  -> resolved
status: open -> closed
superseder:  -> Windows All Users installation places uninstaller in user 
profile

___
Python tracker 
<https://bugs.python.org/issue29232>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44348] test_exceptions.ExceptionTests.test_recursion_in_except_handler stack overflow on Windows debug builds

2021-09-06 Thread Steve Dower


Steve Dower  added the comment:

It should also be possible to reduce the stack size of each frame. We've done 
that before, because there were multiple temporary buffers allocated on the 
stack that were trivially moved into functions. I bet we can also reduce the 
number of indirections, as last time I had to investigate a native stack we 
seem to have bloated up to 6-7 C frames for each Python frame.

Failing that, I'd rather have an option to build with higher stack size just 
for tests (or users who care that much - my experience is that people tend to 
care more about many Python processes rather than high recursion). That only 
affects python[w][_uwp].exe.

We could also add a threading API to allow creating new threads with larger 
stack size. That would allow us to write tests that can do it, and also enable 
users who may run into it. I'd prefer Windows just be able to expand the stack 
better at runtime, but the reserved address space apparently wins the 
back-compat argument.

--

___
Python tracker 
<https://bugs.python.org/issue44348>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45052] WithProcessesTestSharedMemory.test_shared_memory_basics fails on Windows

2021-09-06 Thread Steve Dower


Steve Dower  added the comment:

The test fix looks good to me. That resolves this issue, yes? The other work is 
going on elsewhere?

--
nosy:  -miss-islington

___
Python tracker 
<https://bugs.python.org/issue45052>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45052] WithProcessesTestSharedMemory.test_shared_memory_basics fails on Windows

2021-09-06 Thread Steve Dower


Steve Dower  added the comment:


New changeset 19871fce3b74fc3f37e334a999e00d0ef65a8f1e by Nikita Sobolev in 
branch 'main':
bpo-45052: Unskips a failing `test_shared_memory_basics` test (GH-28182)
https://github.com/python/cpython/commit/19871fce3b74fc3f37e334a999e00d0ef65a8f1e


--

___
Python tracker 
<https://bugs.python.org/issue45052>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45115] Windows: enable compiler optimizations when building Python in debug mode

2021-09-06 Thread Steve Dower


Steve Dower  added the comment:

I strongly disagree. If CI needs to be faster, please just change the CI 
configuration. If contributors have to wait a few minutes longer, they can wait 
- they'll save that time in local compilations.

Local debugging absolutely relies on debug builds. You'd be destroying the 
workflow of most Windows-based developers with this change. It's not worth it.

--

___
Python tracker 
<https://bugs.python.org/issue45115>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45022] Update libffi to 3.4.2

2021-09-03 Thread Steve Dower


Steve Dower  added the comment:

So on one hand, this change applies cleanly and it appears nothing needs to 
change to adopt the newer version.

On the other hand, because the libffi DLL has a different name, it changes the 
layout on disk. I know we don't do that (except in exceptional circumstances) 
after beta, but perhaps this one is safe enough? We certainly don't "support" 
directly accessing the libffi DLL, but it still could break users (if, for 
example, they load another native module that implicitly used the older libffi 
and would now fail to load when it's missing).

Any thoughts?

--
stage: patch review -> backport needed

___
Python tracker 
<https://bugs.python.org/issue45022>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45022] Update libffi to 3.4.2

2021-09-03 Thread Steve Dower


Steve Dower  added the comment:


New changeset 6f8bc464e006f672d1aeafbfd7c774a40215dab2 by Steve Dower in branch 
'main':
bpo-45022: Update libffi to 3.4.2 in Windows build (GH-28146)
https://github.com/python/cpython/commit/6f8bc464e006f672d1aeafbfd7c774a40215dab2


--

___
Python tracker 
<https://bugs.python.org/issue45022>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45022] Update libffi to 3.4.2

2021-09-03 Thread Steve Dower


Change by Steve Dower :


--
pull_requests: +26585
pull_request: https://github.com/python/cpython/pull/28146

___
Python tracker 
<https://bugs.python.org/issue45022>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45079] 3.8.11 and 3.8.12 missing Windows artifacts, only tarballs - build system failed?

2021-09-02 Thread Steve Dower


Steve Dower  added the comment:

The build for Windows is mostly automated, but it's triggered and monitored by 
hand. The build steps are all in the source repo, and the builds themselves are 
public at https://dev.azure.com/Python/cpython/_build?definitionId=21, but I'm 
the only core dev with access to the code signing certificate, so the only one 
who can trigger an official Windows release.

More importantly though is that we stop validating all the dependencies (e.g. 
OpenSSL) against security-fix only releases. These are optional dependencies 
from the POV of CPython, but required for a binary release. Maintaining support 
for them isn't free, so dropping the binary releases means we can focus on our 
active releases, rather than on regularly reintegrating other people's 
projects. Otherwise we'd have to do a new release every time 
OpenSSL/libffi/Tk/Tcl/Sqlite3/etc. fixed a security issue. *That's* the cost we 
avoid by not releasing binaries, even though the cost of the build itself is 
pretty low these days.

--

___
Python tracker 
<https://bugs.python.org/issue45079>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45055] Fresh build on Windows fails the first time for zlib.c

2021-09-02 Thread Steve Dower


Steve Dower  added the comment:

I use git worktree as well (it's great for backporting - I have all the release 
branches checked out all the time), but it likely means that you are regularly 
downloading and extracting these files.

So whatever app is keeping the file handle open is probably doing it reliably 
for one of the files, which is why you'll hit it each time. Once it's been 
copied into place, you won't see it again. And once we have the retry logic in 
the script then you won't see it the first time either.

This should be an easy project, though not trivial to test.

--
keywords: +easy

___
Python tracker 
<https://bugs.python.org/issue45055>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45079] 3.8.11 and 3.8.12 missing Windows artifacts, only tarballs - build system failed?

2021-09-02 Thread Steve Dower


Steve Dower  added the comment:

As the human "build bot" in question, yes, I do get tired :)

--

___
Python tracker 
<https://bugs.python.org/issue45079>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45055] Fresh build on Windows fails the first time for zlib.c

2021-08-31 Thread Steve Dower


Steve Dower  added the comment:

This looks like a typical "lingering open handle" issue, though I can't tell 
whether it's in the destination or the source.

Probably just needs a bit of retry logic (personally I'd be fine putting in 
CPython itself, though that doesn't help this build which is using an 
already-released version). So get_externals.py needs it.

It's certainly not reliably reproducible or the CI system would be on the floor 
;) This runs on every build

--
nosy: +eryksun

___
Python tracker 
<https://bugs.python.org/issue45055>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45007] OpenSSL 1.1.1l is released

2021-08-27 Thread Steve Dower


Change by Steve Dower :


--
keywords: +patch
pull_requests: +26451
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/28009

___
Python tracker 
<https://bugs.python.org/issue45007>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45022] Update libffi to 3.4.2

2021-08-27 Thread Steve Dower


Steve Dower  added the comment:

Realised that 3.8 needs the change to ensure it keeps using the same build of 
libffi. Obviously it won't be getting the new one (and since the new one is 
apparently a new API version, it may not even go into 3.10).

--

___
Python tracker 
<https://bugs.python.org/issue45022>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45022] Update libffi to 3.4.2

2021-08-27 Thread Steve Dower


Change by Steve Dower :


--
pull_requests: +26444
pull_request: https://github.com/python/cpython/pull/28001

___
Python tracker 
<https://bugs.python.org/issue45022>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45022] Update libffi to 3.4.2

2021-08-26 Thread Steve Dower


Steve Dower  added the comment:


New changeset 969ae7f7356584e30667b4e490ffa2ffa1810429 by Steve Dower in branch 
'main':
bpo-45022: Pin current libffi build to fixed version in preparation for 
upcoming update (GH-27982)
https://github.com/python/cpython/commit/969ae7f7356584e30667b4e490ffa2ffa1810429


--

___
Python tracker 
<https://bugs.python.org/issue45022>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45022] Update libffi to 3.4.2

2021-08-26 Thread Steve Dower


Steve Dower  added the comment:

This first PR is just to avoid accidentally upgrading old builds. Otherwise, as 
soon as I push the new build into the cpython-bin-deps repository, it'll take 
precedence.

This one needs backporting into 3.10 and 3.9, but should be a no-op.

--

___
Python tracker 
<https://bugs.python.org/issue45022>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45022] Update libffi to 3.4.2

2021-08-26 Thread Steve Dower


Change by Steve Dower :


--
keywords: +patch
pull_requests: +26430
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/27982

___
Python tracker 
<https://bugs.python.org/issue45022>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45022] Update libffi to 3.4.2

2021-08-26 Thread Steve Dower


New submission from Steve Dower :

libffi is doing releases again! We're a few versions behind, so should pull in 
the latest. https://github.com/libffi/libffi/

Adding RMs for opinions on backporting, and Ned in case this impacts the macOS 
build.

--
components: Build, Windows, ctypes
messages: 400382
nosy: lukasz.langa, ned.deily, pablogsal, paul.moore, steve.dower, tim.golden, 
zach.ware
priority: normal
severity: normal
stage: needs patch
status: open
title: Update libffi to 3.4.2
type: behavior
versions: Python 3.10, Python 3.11, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue45022>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45007] OpenSSL 1.1.1l is released

2021-08-26 Thread Steve Dower


Steve Dower  added the comment:

The new build and tags for Windows are up.

--

___
Python tracker 
<https://bugs.python.org/issue45007>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44381] Allow enabling control flow guard in Windows build

2021-08-25 Thread Steve Dower


Steve Dower  added the comment:

That looks to me like no impact at all, which is great to see!

--

___
Python tracker 
<https://bugs.python.org/issue44381>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-24 Thread Steve Dower


Steve Dower  added the comment:

Removing environment variables is "known" to be unreliable - another reason I 
don't like modifying them from an installer. It's meant to remove the item from 
the list based on value, so if anything has changed then it's not a huge 
surprise it will fail.

I'm more inclined to think that the "[~]:" prefix might be up to something. I 
forget exactly what it means, but if it's not all resolving to an empty string, 
it might concatenate fine but then mess up the removal?

--

___
Python tracker 
<https://bugs.python.org/issue44934>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-23 Thread Steve Dower


Steve Dower  added the comment:

I don't think we upload the artifact from the MSI builds, sorry.

If Visual Studio has an option for the older version of .NET, then yeah, 
that'll do it. But because it was an OS component, you may have to do it 
through the OS dialog in the link I posted.

GitHub will get the CLA update soon enough. It's always a little slower - bpo 
is the canonical source.

--

___
Python tracker 
<https://bugs.python.org/issue44934>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-23 Thread Steve Dower


Steve Dower  added the comment:

Oh I remember this one. The Wix toolset still requires .NET 3.5, which you have 
to install manually these days. Because it's being launched as a console app, 
the UI never gets triggered.

I thought we had this in the devguide already... but maybe not (or not 
prominently enough). Might be worth trying to add some detection for it - 
hopefully a new version of Wix will move to newer .NET too.

See 
https://docs.microsoft.com/en-us/dotnet/framework/install/dotnet-35-windows-10 
for install instructions. It should work after that. The CI build succeeded, 
but it'll need manual testing.

--

___
Python tracker 
<https://bugs.python.org/issue44934>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-23 Thread Steve Dower


Steve Dower  added the comment:

> I think you could also test this out by going to my fork ...

Good point, and I can't trigger a build on your fork.

This seems okay to me.

--

___
Python tracker 
<https://bugs.python.org/issue44972>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-23 Thread Steve Dower


Steve Dower  added the comment:

I kicked off the build on the PR so we can see what errors it finds. Nothing 
jumps out as obviously wrong in the changes, but it only takes one missing 
reference to a file to break it all.

If you want to share the errors from your test machine, copy-pasting all the 
output into a text file and attaching it here is best.

--

___
Python tracker 
<https://bugs.python.org/issue44934>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-23 Thread Steve Dower


Steve Dower  added the comment:

> first-time contributors need a maintainer to approve the workflows for their 
> PRs

This is an important security consideration, so I'd rather not go and change it.

On the main request, provided the workflow_dispatch is only triggerable by 
non-contributors in their own fork (without any of our tokens/etc.) then it's 
fine by me. If it allows anyone to trigger CI builds against the main repo, I'd 
rather not.

--

___
Python tracker 
<https://bugs.python.org/issue44972>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-20 Thread Steve Dower


Steve Dower  added the comment:

That branch looks like you're on the right track. The build scripts in 
Tools/msi should Just Work, so I'd be interested to see the error you get.

You can also submit it as a PR and the MSI will be built automatically.

One thing I noticed is updating the name of the "Add Python to PATH" 
option, which I'd rather keep as "Add" since we won't have both options 
in the UI. The word "Prepend" is quite obscure jargon, and for the range 
of users we have it isn't fair to expect them to know it (or to break 
all of the guidance out there explaining that checkbox already).

--

___
Python tracker 
<https://bugs.python.org/issue44934>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-20 Thread Steve Dower


Steve Dower  added the comment:

The logic is probably simplest if you clone the Tools/msi/path project entirely 
as pathappend. That will technically allow people to both prepend and append if 
they set both flags, but I think it's okay to say "don't do that", especially 
if AppendPath is only a command line option.

Per-component or optional features are complicated and best avoided if we can. 
For a simple on-off like this, a whole MSI is actually the simplest way to 
manage it.

--

___
Python tracker 
<https://bugs.python.org/issue44934>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-19 Thread Steve Dower


Steve Dower  added the comment:

> why is this confusion not written here

>From https://docs.python.org/3/using/windows.html#configuring-python

> While the installer provides an option to configure the PATH and PATHEXT 
> variables for you, this is only reliable for a single, system-wide 
> installation. If you regularly use multiple versions of Python, consider 
> using the Python Launcher for Windows.

Now, that isn't *exactly* the issue in the original post, but the warning is 
present.

> If you do software deployment in a company you will only have one version so 
> having more than one version is not the point.

Unfortunately not true. It's been a while since I had actual data on this, but 
last time I did the *majority* had 2 versions installed, and 3-5 versions were 
all more likely than only a single one. So handling multiple versions matters.

> What i have seen now is if you uninstall Python it is not cleaning up the 
> path variable.

We do the best we can by using the native Windows support for installing 
environment variables. It sometimes doesn't work if you (or another installer) 
has modified the variable since you installed Python, or if you've updated it 
yourself. That's out of our control - we can't do a better job than the OS.

> if you make append path optional available like prepend everybody can choose

Contributions are welcome. We aren't paid to implement features - we volunteer 
to manage contributions, so if you'd really like this to be in the installer, 
feel free to go for it. (Last time the installer was modified we had most 
trouble making the UI not break, but it's probably not too hard if this was a 
command-line only.)

--
stage:  -> needs patch
type: behavior -> enhancement
versions: +Python 3.11 -Python 3.9

___
Python tracker 
<https://bugs.python.org/issue44934>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-17 Thread Steve Dower


Steve Dower  added the comment:

Prepending is used because it makes the most recently installed version of 
Python the "active" one. It also ensures that a deliberate install is going to 
override any applications that may have put their own copy on PATH 
(deliberately or otherwise). There's no real mechanism for managing multiple 
Python entries on PATH, so it just works out better to prepend and let the 
latest install win.

However, we also disable this option by default because it can lead to 
confusion like what you've experienced. The best option here is to leave it 
disabled and update PATH yourself (or use "py.exe" which is always on PATH), 
since you've got the best awareness of your environment.

--

___
Python tracker 
<https://bugs.python.org/issue44934>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35203] Windows Installer Ignores Launcher Installer Options Where The Python Launcher Is Already Present

2021-08-16 Thread Steve Dower


Steve Dower  added the comment:

Timothy - are you able to share your install logs? Look for all log files 
starting with "Python" in your %TEMP% directory.

We definitely do not (and without an installer rewrite, cannot) support 
simultaneous per-user and per-machine installs of the same version.

If you're just looking for the latest version for your own use, you may prefer 
to get it from the Windows Store instead. That one is per-user, won't interfere 
with other installs, and will give you global "python/python3/pip/pip3/etc." 
commands.

--

___
Python tracker 
<https://bugs.python.org/issue35203>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44906] Crash on deep call stack under Windows

2021-08-13 Thread Steve Dower


Steve Dower  added the comment:

I get stack overflows all the way back to 3.7, so it's probably not anything 
new. But our stack overflow detection is clearly not going to catch this case. 
It's really only set up for a direct call within Python code, but this is going 
through many more steps.

Best thing you can do as a user is run it with "python -X faulthandler ..." to 
see the error. Perhaps we can handle the stack overflow ourselves and print a 
message suggesting that option, but unfortunately this problem doesn't have a 
generic solution :( The assumption is that you have a known recursion limit for 
your application, and as a scripting engine, we don't. Decoupling from the C 
stack is the best hope.

--

___
Python tracker 
<https://bugs.python.org/issue44906>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44906] Crash on deep call stack under Windows

2021-08-13 Thread Steve Dower


Steve Dower  added the comment:

I guess we've got a new path through the interpreter loop that takes more stack 
space than before and isn't part of our existing recursion tests.

It's probably somewhere in the vector call changes. Capturing the stack at 
overflow point should show us - I'll see if I can get it easily from the repro.

--
components: +Interpreter Core

___
Python tracker 
<https://bugs.python.org/issue44906>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39658] Include user scripts folder to PATH on Windows

2021-08-10 Thread Steve Dower


Steve Dower  added the comment:

Seems reasonable, contributions welcome.

I think it is not possible to add it as part of a per-machine install, since 
there's no way to specify a user folder in the system key (environment 
variables are not expanded as you might assume).

--
versions: +Python 3.11

___
Python tracker 
<https://bugs.python.org/issue39658>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44844] The command line of launching Edge on Linux hangs

2021-08-05 Thread Steve Dower


Steve Dower  added the comment:

Adding a new browser should be pretty easy, and it seems like that's all that 
is needed here. It has to go into a few places though to support each platform, 
and unfortunately it's only good for 3.11, and not any of the existing releases.

--
keywords: +easy, newcomer friendly
nosy: +steve.dower
versions: +Python 3.11 -Python 3.7

___
Python tracker 
<https://bugs.python.org/issue44844>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44835] What does "Python for Windows will still be Python for DOS" mean?

2021-08-05 Thread Steve Dower


Steve Dower  added the comment:

Yep, it's just a thank you and acknowledgement that was in the installer, so I 
brought it forward.

However, we removed it a couple of versions ago (with Mark's permission). So 
it's certainly not an issue that needs to be addressed now ;)

--

___
Python tracker 
<https://bugs.python.org/issue44835>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44479] Windows build doesn't regenerate some files

2021-07-29 Thread Steve Dower


Change by Steve Dower :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue44479>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44479] Windows build doesn't regenerate some files

2021-07-29 Thread Steve Dower


Steve Dower  added the comment:


New changeset 0b984d19547c2c16203e9ab2b2959fbabcde by Steve Dower in branch 
'3.10':
bpo-44479: Do not regenerate files during a PGO build as it will invalidate the 
profile. (GH-27462)
https://github.com/python/cpython/commit/0b984d19547c2c16203e9ab2b2959fbabcde


--

___
Python tracker 
<https://bugs.python.org/issue44479>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44479] Windows build doesn't regenerate some files

2021-07-29 Thread Steve Dower


Change by Steve Dower :


--
pull_requests: +25985
pull_request: https://github.com/python/cpython/pull/27462

___
Python tracker 
<https://bugs.python.org/issue44479>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44479] Windows build doesn't regenerate some files

2021-07-29 Thread Steve Dower


Steve Dower  added the comment:


New changeset 3edec5d142365f2340865b4f12652e6aa627818a by Steve Dower in branch 
'main':
bpo-44479: Do not regenerate files during a PGO build as it will invalidate the 
profile. (GH-27460)
https://github.com/python/cpython/commit/3edec5d142365f2340865b4f12652e6aa627818a


--

___
Python tracker 
<https://bugs.python.org/issue44479>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44762] getpass.getpass on Windows fallback detection is bad

2021-07-29 Thread Steve Dower


Steve Dower  added the comment:

> I suppose checking the file type in io._WindowsConsoleIO.isatty() could be 
> useful in case the file descriptor gets reassigned to a non-console file 
> (e.g. via os.close or os.dup2).

Pretty sure we currently don't support these anyway. WindowsConsoleIO doesn't 
actually use the standard file descriptors for stdin/out/err - it creates new 
ones based on the real handles just in case a caller requests them. In my 
opinion, correctness of "write to console" outweighs correctness of "manually 
close the console FD and wait for a new one with the same number to be opened" 
;)

If we have WindowsConsoleIO as the type, it shouldn't be possible for it to 
refer to any kind of file other than the console or it would be a FileIO. If 
that's no longer true, we should fix that first. WindowsConsoleIO.isatty ought 
to be "return True".

--

___
Python tracker 
<https://bugs.python.org/issue44762>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44479] Windows build doesn't regenerate some files

2021-07-29 Thread Steve Dower


Change by Steve Dower :


--
pull_requests: +25983
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/27460

___
Python tracker 
<https://bugs.python.org/issue44479>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40263] ValueError exception on _winapi.WaitForMultipleObjects

2021-07-28 Thread Steve Dower


Steve Dower  added the comment:


New changeset 899e37b202c8b096d55e2e3c300c9759ebfe7f7a by Miss Islington (bot) 
in branch '3.9':
bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObjects_impl 
(GH-19501)
https://github.com/python/cpython/commit/899e37b202c8b096d55e2e3c300c9759ebfe7f7a


--

___
Python tracker 
<https://bugs.python.org/issue40263>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44762] getpass.getpass on Windows fallback detection is bad

2021-07-28 Thread Steve Dower


Steve Dower  added the comment:

We could also provide a better check in WindowsConsoleIO.isatty, since that 
should have already handled most of the previous checks (I wouldn't want to do 
a typecheck in getpass, though). But yeah, this seems like "sys.stdin and 
sys.stdin.isatty()" is the right condition.

--

___
Python tracker 
<https://bugs.python.org/issue44762>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40263] ValueError exception on _winapi.WaitForMultipleObjects

2021-07-28 Thread Steve Dower


Steve Dower  added the comment:

Fixed, better late than never.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue40263>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40263] ValueError exception on _winapi.WaitForMultipleObjects

2021-07-28 Thread Steve Dower


Steve Dower  added the comment:


New changeset 92b5dc780db968f6277f42cb06926dddb7475dc6 by Ray Donnelly in 
branch 'main':
bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObjects_impl 
(GH-19501)
https://github.com/python/cpython/commit/92b5dc780db968f6277f42cb06926dddb7475dc6


--

___
Python tracker 
<https://bugs.python.org/issue40263>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44070] __file__ is now fully qualified in 3.8 and 3.9

2021-07-27 Thread Steve Dower


Steve Dower  added the comment:

> do you know what the correct usage of importlib.util.spec_from_file_location 
> is to match importlib.import_module ?

Maybe I'm misreading your example, but isn't the correct usage here to pass an 
absolute location= argument? Or are you suggesting that spec_from_file_location 
should also make it absolute (in 3.10 and later, since this change has already 
been reverted in 3.8-9).

--

___
Python tracker 
<https://bugs.python.org/issue44070>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44479] Windows build doesn't regenerate some files

2021-07-27 Thread Steve Dower


Steve Dower  added the comment:

> Would it be OK to run python in externals folder instead ?

No, because it needs to freeze with the current build. However, we should 
definitely not regenerate anything when "$(Configuration) == 'PGUpdate'". 
Checking that in regen.targets should prevent the issue.

--
resolution: fixed -> 
status: closed -> open

___
Python tracker 
<https://bugs.python.org/issue44479>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44681] time.sleep(0.001) not working properly

2021-07-27 Thread Steve Dower


Steve Dower  added the comment:

> Maybe it would be useful to implement something like this in time.sleep() 
> itself, but I don't know whether the need in a few cases warrants the 
> increased complexity and cost in general.

It certainly wouldn't be worth the power and CPU usage impact that people would 
inevitable get tricked into causing ("why is Python always using 100% of my 
CPU!?").

So as long as I'm around, feel free to consider that idea rejected ;) We'll 
improve the resolution of sleep when the operating system does.

--

___
Python tracker 
<https://bugs.python.org/issue44681>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44572] Calls to platform._syscmd_ver() dependent functions consume STDIN

2021-07-14 Thread Steve Dower


Steve Dower  added the comment:

Thanks for the contribution!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue44572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44572] Calls to platform._syscmd_ver() dependent functions consume STDIN

2021-07-14 Thread Steve Dower


Steve Dower  added the comment:


New changeset 5fc784e28ab9cd02c30395d1973ff825b787efa2 by Miss Islington (bot) 
in branch '3.9':
bpo-44572: On Windows, disconnect STDIN in platform._syscmd_ver() to prevent 
erroneous STDIN consumption (GH-27092)
https://github.com/python/cpython/commit/5fc784e28ab9cd02c30395d1973ff825b787efa2


--

___
Python tracker 
<https://bugs.python.org/issue44572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44634] Version is duplicated in name of app in list of installed apps

2021-07-14 Thread Steve Dower


Steve Dower  added the comment:

Apart from the duplication, is there some reason why this is a problem?

The name is used in a number of other places where the version number is very 
helpful. I'm not sure we can separate the variables in WiX.

--

___
Python tracker 
<https://bugs.python.org/issue44634>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33125] Windows 10 ARM64 platform support

2021-07-14 Thread Steve Dower


Steve Dower  added the comment:

I'm sure it will help, but official support will continue to be blocked by 
availability of CI/CD systems for first- and third-party packages/testing.

--

___
Python tracker 
<https://bugs.python.org/issue33125>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44572] Calls to platform._syscmd_ver() dependent functions consume STDIN

2021-07-13 Thread Steve Dower


Steve Dower  added the comment:


New changeset 0ee0a740e12ec8568aafa033aa6bb08b265afe26 by Konstantin-Glukhov in 
branch 'main':
bpo-44572: On Windows, disconnect STDIN in platform._syscmd_ver() to prevent 
erroneous STDIN consumption (GH-27092)
https://github.com/python/cpython/commit/0ee0a740e12ec8568aafa033aa6bb08b265afe26


--

___
Python tracker 
<https://bugs.python.org/issue44572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44602] Issue with get_build_version in msvc9compiler.py in distutils

2021-07-13 Thread Steve Dower


Steve Dower  added the comment:

msvc9compiler.py has been deprecated ever since _msvccompiler.py was 
introduced, so no code should be using it (it was always internal anyway).

And now all of distutils is also deprecated, so you probably need to report 
this to the setuptools project at https://github.com/pypa/setuptools so they 
can fix it in their embedded copy of distutils.

--
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue44602>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44582] Accelerate mimetypes.init on Windows

2021-07-08 Thread Steve Dower


Steve Dower  added the comment:

Dropping the 3.9 backport. Pretty sure it only needs a clinic regen, but it's 
also not worth the risk of changed behaviour.

We could consider it again after 3.10 has shipped if people really want it (and 
can help validate it).

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.9

___
Python tracker 
<https://bugs.python.org/issue44582>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44582] Accelerate mimetypes.init on Windows

2021-07-08 Thread Steve Dower


Steve Dower  added the comment:


New changeset bbf2fb6c7ae78f40483606f467739a58cd747270 by Steve Dower in branch 
'main':
bpo-44582: Accelerate mimetypes.init on Windows with a native accelerator 
(GH-27059)
https://github.com/python/cpython/commit/bbf2fb6c7ae78f40483606f467739a58cd747270


--

___
Python tracker 
<https://bugs.python.org/issue44582>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44575] Windows installer prohibits different patches for the same version

2021-07-07 Thread Steve Dower

Steve Dower  added the comment:

Huh, interesting that the email reply is identical to the one above from 
Константин, but the email I received had no reference to bpo in it...

Okay, consider my reply above identical to the one I sent off list :)

--

___
Python tracker 
<https://bugs.python.org/issue44575>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44575] Windows installer prohibits different patches for the same version

2021-07-07 Thread Steve Dower


Steve Dower  added the comment:

Some quotes from my reply to an off-list email that may be useful for other 
people who encounter this issue:

---

Apps that use Python-based plugins we can't make Just Work - it's up to the 
host application to work with Python installs (or to bundle its own, which is 
easier on Windows). We're happy to help the people who can fix it on their side 
if you know who to work with.

Rather than developing our own installer, it's actually less effort to use the 
standard Windows Installer service to manage installs, and that's the system 
with the restrictions. Coding something from scratch that supports the 
equivalent upgrade/repair/uninstall mechanisms would be considerably more work, 
and we'd end up basically reimplementing it or end up regularly recommending 
people try and delete everything by hand.

We also support the newer Windows MSIX format via the Store, because that's 
even less work and is a better experience for most users. Unfortunately, it's 
even further away from what you want. If your preferences are so strong, you 
may need to do your own builds and manually put them where you need. The Nuget 
packages will let you skip the compile step, and the regular ones will let you 
also skip the "put them where you need" step.

--

___
Python tracker 
<https://bugs.python.org/issue44575>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44582] Accelerate mimetypes.init on Windows

2021-07-07 Thread Steve Dower


Steve Dower  added the comment:

mimetypes doesn't _really_ support clearing, but `python.exe -m timeit "import 
mimetypes as M; M.types_map.clear(); M.init()"` is pretty close.

Without the accelerator: 133ms
With the accelerator: 27.8ms

--

___
Python tracker 
<https://bugs.python.org/issue44582>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44582] Accelerate mimetypes.init on Windows

2021-07-07 Thread Steve Dower


Steve Dower  added the comment:

It's only a rough benchmark, but my timings for `python -c "import mimetypes; 
mimetypes.init()` were ~200ms without the accelerator and ~100ms with the 
accelerator.

Since that includes all of startup, it's actually a better than 50% reduction 
for mimetypes.init(). I'm happy to take that without questioning precisely how 
much better it is ;)

--

___
Python tracker 
<https://bugs.python.org/issue44582>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44582] Accelerate mimetypes.init on Windows

2021-07-07 Thread Steve Dower


Change by Steve Dower :


--
components: +Windows
nosy: +paul.moore, tim.golden, zach.ware

___
Python tracker 
<https://bugs.python.org/issue44582>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   3   4   5   6   7   8   9   10   >