Sunny K added the comment:
Hi Stefan,
There is a comment at the top in structseq.c
/* Fields with this name have only a field index, not a field name.
They are only allowed for indices n_visible_fields. */
char *PyStructSequence_UnnamedField = unnamed field;
This is the definition
Changes by Sunny K sunfin...@gmail.com:
Removed file: http://bugs.python.org/file31844/myfirst.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1185124
Sunny K added the comment:
Hi Victor, can you give this another look?
--
versions: +Python 3.5 -Python 2.7, Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1185124
Sunny K added the comment:
Hi Stefan,
I've added a new patch which only adds _fields, combining parts from my earlier
patch and Andrew's (his patch does not account for visible unnamed fields).
--
Added file: http://bugs.python.org/file35367/structseq_fields.patch
Changes by Sunny K sunfin...@gmail.com:
--
nosy: +sunfinite
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21555
___
___
Python-bugs-list mailing
Sunny K added the comment:
New patch for 3.4 adds the following:
1. _fields
2. _replace()
3. _asdict()
4. eval(repr(s)) == s
Now the issues:
1. _asdict() returns a normal dictionary. I don't know if this is what
is required.
2. Both _asdict() and _replace() assume that unnamed visible
Changes by Sunny K sunfin...@gmail.com:
Removed file: http://bugs.python.org/file32265/structseq.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11698
Sunny K added the comment:
The previous patch had a wrong mapping between keys and values. The
current implementation of repr means that duplicated keys will be
present when invisible fields are included. See points 2 and 3 in
http://bugs.python.org/issue1820#msg202330 for more explanation.
I
Sunny K added the comment:
Oops, the correct issue for improving the repr is issue11698.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1820
Changes by Sunny K sunfin...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file32314/test_sysconfig.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19340
Changes by Sunny K sunfin...@gmail.com:
--
nosy: +tarek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19340
___
___
Python-bugs-list mailing list
Sunny K added the comment:
I took a shot at this. Build is successful and imports happen. Tests are ok
except test_sysconfig, and that is because of sys.prefix being set to '/'. I've
raised issue19340 for that.
About the patch, i'm not sure how to completely test for false
positives(joinpath
New submission from Sunny K:
While working on issue7757, i noticed that test_srcdir fails when python is
built with prefix .
This is because in Lib/sysconfig.py, _safe_realpath() is called on srcdir which
normalises //lib to /lib. In the test case, it is compared directly to the
output
Sunny K added the comment:
This issue is present in 3.4 too.
Added patch for 3.4.
--
keywords: +patch
nosy: +sunfinite
versions: +Python 3.4
Added file: http://bugs.python.org/file32258/pydoc.patch
___
Python tracker rep...@bugs.python.org
http
Sunny K added the comment:
Added patch for 3.4.
The patch demarcates the output by adding a {...} around the dictionary
portion. Please let me know if this is the right format or if not required at
all. It is a simple change.
--
nosy: +sunfinite
Added file: http://bugs.python.org
15 matches
Mail list logo
