Taras Lyapun added the comment:
Andrew, do you mean that Christian Heimes last snippet working on Android?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16353
Taras Lyapun added the comment:
Updated patch.
Moved function to os and used Christian Heimes implementation.
Updated doc, and test.
Also renamed function to get_shell.
Test passes on mac os and windows.
--
Added file: http://bugs.python.org/file27897/issue16353.diff
Taras Lyapun added the comment:
Updated patch in regards to Christian Heimes remark.
--
Added file: http://bugs.python.org/file27898/issue16353.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16353
Taras Lyapun added the comment:
Hello!
I don't understand issue - FileHandler is a subclass of StreamHandler, so you
can use terminator for FileHandler instances in the same way as for
StreamHandler instances.
--
nosy: +lyapun
___
Python tracker
Taras Lyapun added the comment:
Diff with implementation, test and doc.
--
keywords: +patch
nosy: +lyapun
Added file: http://bugs.python.org/file27849/issue16353.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16353
Taras Lyapun added the comment:
Added comments to patch
--
nosy: +lyapun
Added file: http://bugs.python.org/file27850/issue16284_with_comments.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16284
Taras Lyapun added the comment:
Deleted code, docs, tests, and tests related stuff (like mocks). Test passes.
--
keywords: +patch
nosy: +lyapun
Added file: http://bugs.python.org/file27852/issue15641.diff
___
Python tracker rep...@bugs.python.org
Taras Lyapun added the comment:
I would to prefer *get_default_shell* as function name (it's a bit shorter).
Hm... I'm not sure, because someone can imagine that function returns some
object or something like this... 'path' indicates that function returns
something like string.
Also please
