[issue46885] Ensure PEP 663 changes are reverted from 3.11

Change by Thomas Wouters : -- nosy: +twouters ___ Python tracker <https://bugs.python.org/issue46885> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46150] test_pathlib assumes "fakeuser" does not exist as user

New submission from Thomas Wouters : test_pathlib contains, in PosixPathTest.test_expanduser, a check that expanduser on a nonexistent user will raise RuntimeError. Leaving aside the question why that's a RuntimeError (which is probably too late to fix anyway), the test performs this check

[issue46083] PyUnicode_FSConverter() has confusing reference semantics

New submission from Thomas Wouters : The PyUnicode_FSConverter function has confusing reference semantics, and confusing documentation. https://docs.python.org/3/c-api/unicode.html#c.PyUnicode_FSConverter says the output argument "must be a PyBytesObject* which must be released

[issue45822] Py_CompileString does not respect the coding cookie with the new parser if flags are empty

Thomas Wouters added the comment: Py_CompileString() in Python 3.9 and later, using the PEG parser, appears to no longer honours source encoding cookies. A reduced test case: #include "Python.h" #include const char *src = ( "# -*- coding: Latin-1 -*-\n&quo

[issue29941] Confusion between asserts and Py_DEBUG

Change by Thomas Wouters : -- stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue29941> ___ ___ Python-bugs-list

[issue45434] [C API] Clean-up the Python.h header file

Thomas Wouters added the comment: Victor, what's the benefit of doing this work? Are there real problems this fixes? I'm worried about the churn in third-party extensions, examples, tutorials, etc, especially for audiences that upon seeing a compiler error won't immediately realise

[issue26153] PyImport_GetModuleDict: no module dictionary! when `__del__` triggers a warning

Thomas Wouters added the comment: This was fixed back in 2018, in fact. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44698] Undefined behaviour in Objects/complexobject.c's complex_pow

Change by Thomas Wouters : -- keywords: +patch pull_requests: +25823 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27278 ___ Python tracker <https://bugs.python.org/issu

[issue44698] Undefined behaviour in Objects/complexobject.c's complex_pow

New submission from Thomas Wouters : Objects/complexobject.c's complex_pow uses undefined behaviour, by casting a float of unknown magnitude to a long: int_exponent = (long)exponent.real; At Google we build with clang and -fsanitize=float-cast-overflow by default, which catches

[issue44184] crash on windows invoking flake8

Thomas Wouters added the comment: New changeset 0b4704973dbef712d05bdd62349bb4244f545430 by Miss Islington (bot) in branch '3.9': bpo-44184: Apply GH-26274 to the non-GC-type branch of subtype_dealloc (GH-27165) (GH-27175) https://github.com/python/cpython/commit

[issue44184] crash on windows invoking flake8

Change by Thomas Wouters : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44184] crash on windows invoking flake8

Thomas Wouters added the comment: Fix extended to the other branch (and backported to 3.10), and both parts backported to 3.9. I don't think it counts as a security issue, so not backporting to 3.8. -- ___ Python tracker <https://bugs.python.

[issue44184] crash on windows invoking flake8

Thomas Wouters added the comment: New changeset 6aa59c68dc7910c0675ad23c1f9d88edfb81dfcb by Miss Islington (bot) in branch '3.10': bpo-44184: Apply GH-26274 to the non-GC-type branch of subtype_dealloc (GH-27165) (GH-27174) https://github.com/python/cpython/commit

[issue44184] crash on windows invoking flake8

Thomas Wouters added the comment: New changeset 074e7659f208051b6b973f7fdb654dd22b93aaa2 by T. Wouters in branch 'main': bpo-44184: Apply GH-26274 to the non-GC-type branch of subtype_dealloc (GH-27165) https://github.com/python/cpython/commit/074e7659f208051b6b973f7fdb654dd22b93aaa2

[issue44184] crash on windows invoking flake8

Change by Thomas Wouters : -- pull_requests: +25701 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/27165 ___ Python tracker <https://bugs.python.org/issu

[issue44184] crash on windows invoking flake8

Thomas Wouters added the comment: Reopening this issue, as there is another branch (for non-GC heaptypes) earlier in subtype_dealloc that I believe suffers from the same problem. Actually triggering the error in a test has been difficult because as far as I can tell it relies on garbage

[issue44630] Assertion failure in csv module

Change by Thomas Wouters : -- keywords: +patch pull_requests: +25670 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27127 ___ Python tracker <https://bugs.python.org/issu

[issue44630] Assertion failure in csv module

New submission from Thomas Wouters : The csv module has some incorrect exception handling when dealing with dialect objects that are not csv.Dialect subclasses (or that otherwise raise errors when accessing the dialect attributes): >>> csv.reader([], dialect=None) python: ../.

[issue42443] Provide Thread creation hook support

Change by Thomas Wouters : -- nosy: +gregory.p.smith, twouters ___ Python tracker <https://bugs.python.org/issue42443> ___ ___ Python-bugs-list mailing list Unsub

[issue40503] PEP 615: Add zoneinfo module

Thomas Wouters added the comment: The normal way to do this (for make/autoconf) is to add a --with-tzpath argument to configure.ac, and a make variable to pass it to the compilation of anything that needs it. You can then access it from Python code with sysconfig.get_config_var

[issue28367] Add more standard baud rate constants to "termios"

Thomas Wouters added the comment: New changeset 7dc72b8d4f2c9d1eed20f314fd6425eab66cbc89 by T. Wouters (Anthony Shaw) in branch 'master': bpo-28367: Add additional baud rates for termios (GH-13142) https://github.com/python/cpython/commit/7dc72b8d4f2c9d1eed20f314fd6425eab66cbc89

[issue28367] Add more standard baud rate constants to "termios"

Change by Thomas Wouters : -- stage: patch review -> resolved status: open -> closed versions: +Python 3.9 -Python 3.7 ___ Python tracker <https://bugs.python.org/i

[issue38532] Missing decrefs in the _ctypes module

Change by Thomas Wouters : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue38532> ___ ___ Pyth

[issue38532] Missing decrefs in the _ctypes module

Thomas Wouters added the comment: New changeset aa3efea9c5f4d25afc3fa4cfd5e6d789943893c9 by T. Wouters (Miss Islington (bot)) in branch '3.8': bpo-38532: Add missing decrefs in PyCFuncPtr_FromDll() (GH-17811) https://github.com/python/cpython/commit/aa3efea9c5f4d25afc3fa4cfd5e6d789943893c9

[issue38532] Missing decrefs in the _ctypes module

Thomas Wouters added the comment: New changeset e02ab59fdffa0bb841182c30ef1355c89578d945 by T. Wouters (Zackery Spytz) in branch 'master': bpo-38532: Add missing decrefs in PyCFuncPtr_FromDll() (GH-16857) https://github.com/python/cpython/commit/e02ab59fdffa0bb841182c30ef1355c89578d945

[issue38823] Improve stdlib module initialization error handling.

Thomas Wouters added the comment: New changeset 54b32c987146123f2237f0e21b1d02b1c1ebdf6f by T. Wouters (Brandt Bucher) in branch 'master': bpo-38823: Clean up refleak in fcntl module initialization. (GH-17236) https://github.com/python/cpython/commit/54b32c987146123f2237f0e21b1d02b1c1ebdf6f

[issue38392] Ensure that objects entering the GC are valid

Thomas Wouters added the comment: I'm pretty sure you meant nascheme, not nnorwitz. -- nosy: +nascheme, twouters -nnorwitz ___ Python tracker <https://bugs.python.org/issue38

[issue38376] ./configure --with-assertions generates a broken build

Thomas Wouters added the comment: The problem is _PyUnicode_CheckConsistency switched from being only defined when Py_DEBUG is set, to being defined unconditionally. That was a good change, but it made the API-compatibility hack of #defining _PyUnicode_CheckConsistency in Include

[issue38376] ./configure --with-assertions generates a broken build

Change by Thomas Wouters : -- keywords: +patch pull_requests: +16183 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16594 ___ Python tracker <https://bugs.python.org/issu

[issue36046] subprocess: add user, group and extra_groups parameters

Thomas Wouters added the comment: As mentioned in the code review for Victor's fix, it feels like the big conditional on the use of self._posix_spawn in Popen._execute_child should perhaps be pulled into _posix_spawn, or at least refactored so it's closer to _posix_spawn, with some

[issue36046] subprocess: add user, group and extra_groups parameters

Thomas Wouters added the comment: New changeset faca8553425c231d867dcabf6a69a9dd21118b6c by T. Wouters (Victor Stinner) in branch 'master': bpo-36046: posix_spawn() doesn't support uid/gid (GH-16384) https://github.com/python/cpython/commit/faca8553425c231d867dcabf6a69a9dd21118b6c

[issue36046] support dropping privileges when running subprocesses

Thomas Wouters added the comment: New changeset 693aa80a434590ea7dcd35c000209e53d01b9425 by T. Wouters (Gregory P. Smith) in branch 'master': bpo-36046: Fix buildbot failures (GH-16091) https://github.com/python/cpython/commit/693aa80a434590ea7dcd35c000209e53d01b9425 -- nosy

[issue38075] Make random module PEP-384 compatible

Thomas Wouters added the comment: New changeset 04f0bbfbedf8d2bb69b012f853de6648b1a9f27f by T. Wouters (Dino Viehland) in branch 'master': bpo-38075: Port _randommodule.c to PEP-384 (GH-15798) https://github.com/python/cpython/commit/04f0bbfbedf8d2bb69b012f853de6648b1a9f27f -- nosy

[issue38115] Invalid bytecode offsets in co_lnotab

Thomas Wouters added the comment: Setting Py_SIZE of the bytes object is possible, but gross and not how you're supposed to operate on bytes. I'm also not entirely convinced lnotab isn't reused in ways it shouldn't. The peephole optimizer already does gross things and is tied very

[issue38115] Invalid bytecode offsets in co_lnotab

Change by Thomas Wouters : -- keywords: +patch pull_requests: +15701 pull_request: https://github.com/python/cpython/pull/16079 ___ Python tracker <https://bugs.python.org/issue38

[issue38135] Depth first search in compile.c creates wrong BB order for certain CFG.

Change by Thomas Wouters : -- pull_requests: +15672 pull_request: https://github.com/python/cpython/pull/16050 ___ Python tracker <https://bugs.python.org/issue38

[issue38115] Invalid bytecode offsets in co_lnotab

Thomas Wouters added the comment: As mentioned in the PR (GH-15970), I don't think we should fix this bug. We can, but it involves replacing PyCode_Optimize() (which is public but undocumented, with confusing refcount effects) with a stub, and very careful surgery on the code

[issue34001] LibreSSL does not tolerate setting minimum_version greater than maximum_version

Thomas Wouters added the comment: New changeset c9bc49c5f6e26a7c958307c2ac338951a7534d9a by T. Wouters (Christian Heimes) in branch 'master': bpo-34001: Fix test_ssl with LibreSSL (GH-13783) https://github.com/python/cpython/commit/c9bc49c5f6e26a7c958307c2ac338951a7534d9a -- nosy

[issue37885] venv: Don't produce unbound variable warning on deactivate

Thomas Wouters added the comment: Thanks, fix merged. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37885] venv: Don't produce unbound variable warning on deactivate

Thomas Wouters added the comment: New changeset d126fbddc960afd93ff070bc34209be256152943 by T. Wouters (Miss Islington (bot)) in branch '3.7': bpo-37885: venv: Don't produce unbound variable warning on deactivate (GH-15974) https://github.com/python/cpython/commit

[issue37885] venv: Don't produce unbound variable warning on deactivate

Thomas Wouters added the comment: New changeset 63eefc35674ec12ab4d00af4feaf21de4cb1c91c by T. Wouters (Miss Islington (bot)) in branch '3.8': bpo-37885: venv: Don't produce unbound variable warning on deactivate (GH-15973) https://github.com/python/cpython/commit

[issue37885] venv: Don't produce unbound variable warning on deactivate

Thomas Wouters added the comment: New changeset 5209e586b7cac9a43b2c44349a26b1b0af06ead3 by T. Wouters (Daniel Abrahamsson) in branch 'master': bpo-37885: venv: Don't produce unbound variable warning on deactivate (GH-15330) https://github.com/python/cpython/commit

[issue38115] Invalid bytecode offsets in co_lnotab

Change by Thomas Wouters : -- pull_requests: +15603 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15970 ___ Python tracker <https://bugs.python.org/issu

[issue38115] Invalid bytecode offsets in co_lnotab

Thomas Wouters added the comment: There's also a bug where the optimizer may bail out on optimizing a code object *after* updating the lnotab (the last 'goto exitUnchanged' in Python/peephole.c). That bug has existed since Python 3.6, but it's not clear to me how much this actually affects

[issue38115] Invalid bytecode offsets in co_lnotab

New submission from Thomas Wouters : The peephole optimizer in Python 2.7 and later (and probably a *lot* earlier) has a bug where if the optimizer entirely optimizes away the last line(s) of a function, the lnotab references invalid bytecode offsets: >>> def f(cond1, cond2): ...

[issue37424] subprocess.run timeout does not function if shell=True and capture_output=True

Thomas Wouters added the comment: New changeset 580d2782f70f8e0bed7ec20abb03d740cb83b5da by T. Wouters (Gregory P. Smith) in branch 'master': bpo-37424: Avoid a hang in subprocess.run timeout output capture (GH-14490) https://github.com/python/cpython/commit

[issue28494] is_zipfile false positives

Thomas Wouters added the comment: New changeset 3f4db4a0bab073b768fae958e93288bd5d24eadd by T. Wouters (Gregory P. Smith) in branch 'master': bpo-28494: Test existing zipfile working behavior. (GH-15853) https://github.com/python/cpython/commit/3f4db4a0bab073b768fae958e93288bd5d24eadd

[issue36253] Use after free in ctypes test suite

Thomas Wouters added the comment: New changeset a9b6033179b64b985394ad351501089a6a94fc9d by T. Wouters (Ben Harper) in branch 'master': bpo-36253: Remove use after free reference in ctypes test suite (GH-12257) https://github.com/python/cpython/commit/a9b6033179b64b985394ad351501089a6a94fc9d

[issue37619] update_one_slot() should not ignore wrapper descriptors for wrong type

Thomas Wouters added the comment: I don't think this should be backported to 3.7 at this point; if you disagree feel free to reopen the bug. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracke

[issue37619] update_one_slot() should not ignore wrapper descriptors for wrong type

Thomas Wouters added the comment: New changeset eb1bc48c74f4f8af88b5276729f9652201e46324 by T. Wouters (Miss Islington (bot)) in branch '3.8': bpo-37619: update_one_slot() should not ignore wrapper descriptors for wrong type (GH-15838) https://github.com/python/cpython/commit

[issue37619] update_one_slot() should not ignore wrapper descriptors for wrong type

Thomas Wouters added the comment: New changeset 57ea33560662e0f20a3b0334bb20065771edf4da by T. Wouters (Jeroen Demeyer) in branch 'master': bpo-37619: update_one_slot() should not ignore wrapper descriptors for wrong type (GH-14836) https://github.com/python/cpython/commit

[issue38068] clean up configure logic for gettimeofday

Thomas Wouters added the comment: New changeset f1c19031fd5f4cf6faad539e30796b42954527db by T. Wouters (Benjamin Peterson) in branch 'master': bpo-38068: Clean up gettimeofday configure logic. (GH-15775) https://github.com/python/cpython/commit/f1c19031fd5f4cf6faad539e30796b42954527db

[issue38072] Make grp module PEP-384 compatible

New submission from Thomas Wouters : New changeset 40a5313edfc18173d136bb5e19495880934b7d83 by T. Wouters (Dino Viehland) in branch 'master': bpo-38072: PEP-384 grpmodule (GH-15788) https://github.com/python/cpython/commit/40a5313edfc18173d136bb5e19495880934b7d83 -- nosy: +twouters

[issue38071] Make termios PEP-384 compatible

New submission from Thomas Wouters : New changeset bd0c7a12d9e28ce74bfc16244d7694aca906838c by T. Wouters (Dino Viehland) in branch 'master': bpo-38071: Make termios PEP-384 compatible (GH-15785) https://github.com/python/cpython/commit/bd0c7a12d9e28ce74bfc16244d7694aca906838c

[issue38074] Make zlib PEP-384 compatible

Thomas Wouters added the comment: New changeset a1ffad07195b8b976f8c371a92028240946d4e76 by T. Wouters (Dino Viehland) in branch 'master': bpo-38074: Make zlib extension module PEP-384 compatible (GH-15792) https://github.com/python/cpython/commit/a1ffad07195b8b976f8c371a92028240946d4e76

[issue38076] Make struct module PEP-384 compatible

Thomas Wouters added the comment: New changeset 4f384af067d05b16a554bfd976934fca9f87a1cf by T. Wouters (Dino Viehland) in branch 'master': bpo-38076: Make struct module PEP-384 compatible (#15805) https://github.com/python/cpython/commit/4f384af067d05b16a554bfd976934fca9f87a1cf

[issue38083] Minor improvements in asdl_c.py and Python-ast.c

Thomas Wouters added the comment: This doesn't feel like a change that's worth backporting to 3.8 at this point. Do you agree? Is there anything left to do for this bug? -- ___ Python tracker <https://bugs.python.org/issue38

[issue38083] Minor improvements in asdl_c.py and Python-ast.c

Thomas Wouters added the comment: New changeset 43c9731334470573209464b7f67914d386457efc by T. Wouters (Serhiy Storchaka) in branch 'master': bpo-38083: Minor improvements in asdl_c.py and Python-ast.c. (GH-15824) https://github.com/python/cpython/commit

[issue33418] Memory leaks in functions

Thomas Wouters added the comment: New changeset ccaea525885e41c5f1e566bb68698847faaa82ca by T. Wouters (Victor Stinner) in branch '3.8': Revert "bpo-33418: Add tp_clear for function object (GH-8058)" (GH-15826) https://github.com/python/cpython/commit/ccaea525885e41c5f1e566bb686988

[issue37840] bytearray_getitem() handles negative index incorrectly

Thomas Wouters added the comment: New changeset 92709a263e9cec0bc646ccc1ea051fc528800d8d by T. Wouters (Sergey Fedoseev) in branch 'master': bpo-37840: Fix handling of negative indices in bytearray_getitem() (GH-15250) https://github.com/python/cpython/commit

[issue36279] os.wait3() leaks some uninitialized stack when no processes exist

Thomas Wouters added the comment: New changeset 682107cf458578ee6bd92b7cc6862113034a4fad by T. Wouters (Zackery Spytz) in branch 'master': bpo-36279: Ensure os.wait3() rusage is initialized (GH-15111) https://github.com/python/cpython/commit/682107cf458578ee6bd92b7cc6862113034a4fad

[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

Thomas Wouters added the comment: New changeset 3cbc23aa229bc5ec04845053df78eae5f54e0497 by T. Wouters (Greg Price) in branch 'master': bpo-37758: Cut always-constant conditionals on sys.maxunicode. (GH-15302) https://github.com/python/cpython/commit/3cbc23aa229bc5ec04845053df78eae5f54e0497

[issue37589] Missing dependences in the Makefile

Change by Thomas Wouters : -- assignee: -> twouters resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python

[issue37589] Missing dependences in the Makefile

Change by Thomas Wouters : -- pull_requests: +15422 pull_request: https://github.com/python/cpython/pull/15769 ___ Python tracker <https://bugs.python.org/issue37

[issue37589] Missing dependences in the Makefile

Thomas Wouters added the comment: New changeset b4612f5d54aced5bc37f1b85bf50b4cafa2480f0 by T. Wouters in branch 'master': bpo-37589: Add a few missing dependencies on .h files in the Makefile. (GH-15757) https://github.com/python/cpython/commit/b4612f5d54aced5bc37f1b85bf50b4cafa2480f0

[issue37589] Missing dependences in the Makefile

Change by Thomas Wouters : -- keywords: +patch pull_requests: +15410 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15757 ___ Python tracker <https://bugs.python.org/issu

[issue36149] use of uninitialised memory in cPickle.

Change by Thomas Wouters : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36149] use of uninitialised memory in cPickle.

Thomas Wouters added the comment: New changeset d9bf7f4198871132714cfe7d702baaa02206e9f1 by T. Wouters in branch '2.7': [2.7] bpo-36149 Fix potential use of uninitialized memory in cPickle (#12105) https://github.com/python/cpython/commit/d9bf7f4198871132714cfe7d702baaa02206e9f1

[issue36161] Use thread-safe functions instead of unsafe ones (crypt, ttyname)

Thomas Wouters added the comment: Ah, looks like I missed crypt_r getting added in 3.7. Sorry about that. Yes, the error handling would be a behaviour change, a keyword argument may be a good solution. As it is, crypt() returns None, throwing away the *reason* for the failure (which

[issue36161] Use thread-safe functions instead of unsafe ones (crypt, ttyname)

New submission from Thomas Wouters : (good first issue, I think.) CPython currently uses a few functions that are thread-unsafe where thread-safe version exist, at least in glibc (crypt() and ttyname(), at least). This isn't an issue when looking at CPython in isolation because these calls

[issue36149] use of uninitialised memory in cPickle.

Change by Thomas Wouters : -- keywords: +patch pull_requests: +12112 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue36149> ___ ___ Py

[issue36149] use of uninitialised memory in cPickle.

New submission from Thomas Wouters : There is a bug in cPickle that makes it use uninitialised memory when reading a truncated pickle from a file (an actual C FILE*, not just any file-like object). Using MemorySanitizer: % ./python Python 2.7.15 (default, redacted, redacted

[issue31752] Assertion failure in timedelta() in case of bad __divmod__

Thomas Wouters added the comment: This patch includes assertions that are easily triggered from user code: https://bugs.python.org/issue35021 -- nosy: +twouters ___ Python tracker <https://bugs.python.org/issue31

[issue35021] Assertion failures in datetimemodule.c.

New submission from Thomas Wouters : The fix for issue #31752 (changeset 5ef883b096895a84123760859f0f34ad37bf2277 for 2.7, as I ran into this while upgrading to 2.7.15) includes assertions that are easily triggered from user code: >>> import datetime, numpy >>> datetime

[issue32591] Deprecate sys.set_coroutine_wrapper and replace it with more focused API(s)

Thomas Wouters added the comment: New changeset 500a419a7a68c32650717b213f0f5ab0461bb16b by T. Wouters in branch '3.6': [3.6] bpo-32591: fix abort in _PyErr_WarnUnawaitedCoroutine during shutdown (GH-5337) (#6536) https://github.com/python/cpython/commit

[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

Change by Thomas Wouters <tho...@python.org>: -- nosy: +ned.deily priority: normal -> release blocker ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue26153] PyImport_GetModuleDict: no module dictionary! when `__del__` triggers a warning

Change by Thomas Wouters <tho...@python.org>: -- pull_requests: +6232 ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue26153> ___ _

[issue32591] Deprecate sys.set_coroutine_wrapper and replace it with more focused API(s)

Change by Thomas Wouters <tho...@python.org>: -- pull_requests: +6231 ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32591> ___ _

[issue26153] PyImport_GetModuleDict: no module dictionary! when `__del__` triggers a warning

Change by Thomas Wouters <tho...@python.org>: -- pull_requests: +6213 stage: -> patch review ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue26153] PyImport_GetModuleDict: no module dictionary! when `__del__` triggers a warning

Thomas Wouters <tho...@python.org> added the comment: Looks like this was fixed in 3.7 by checking PyThreadState_GET()->interp->modules before trying to use it. That leaves the crash in 3.6 and earlier, though. -- stage: patch review -> ___

[issue26153] PyImport_GetModuleDict: no module dictionary! when `__del__` triggers a warning

Change by Thomas Wouters <tho...@python.org>: -- keywords: +patch pull_requests: +6211 stage: -> patch review ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue26153] PyImport_GetModuleDict: no module dictionary! when `__del__` triggers a warning

Thomas Wouters <tho...@python.org> added the comment: We ran into this at work, with Python 3.6, where it involved extension types with a reference to files, with the (open) files being deallocated during interpreter exit and raising ResourceWarnings because of that. I tried to

[issue32973] Importing the same extension module under multiple names breaks non-reinitialisable extension modules

Thomas Wouters <tho...@python.org> added the comment: Re: Petr: we can't expect extension module authors to retroactively fix released modules. We can't even expect everyone to fix this for future releases; moving away from globals (which may not be specific to the Python extension

[issue32973] Importing the same extension module under multiple names breaks non-reinitialisable extension modules

New submission from Thomas Wouters <tho...@python.org>: This is a continuation, of sorts, of issue16421; adding most of that issue's audience to the noisy list. When importing the same extension module under multiple names that share the same basename, Python 3 will call the ext

[issue32959] zipimport fails when the ZIP archive contains more than 65535 files

Thomas Wouters <tho...@python.org> added the comment: FWIW, yes, this is because zipimport doesn't support ZIP64, and doesn't even flag it as an error when the ZIP requires it. Instead it skips files; the ZIP64 format works by setting the fields that would overflow to the maximum

[issue32430] Simplify Modules/Setup{,.dist,.local}

Thomas Wouters <tho...@python.org> added the comment: We do use Setup/Setup.local at Google (and have for many years now), and I find it very useful. (FWIW, the 'we would use' comment in msg294174 was about the new '*disabled*' feature, not about Setup files in general.) Avoiding

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters <tho...@python.org>: -- pull_requests: +1829 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29941> ___ _

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters <tho...@python.org>: -- pull_requests: +1821 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29941> ___ _

[issue20210] Provide configure options to enable/disable Python modules and extensions

Thomas Wouters added the comment: This feature would also be nice to have for Python at Google: we want builds to be as reproducible as possible, avoid third-party libraries even when they are available on the build system, and avoid certain extension modules in any form. We currently delete

[issue11470] Flag inappropriate uses of callable class attributes

Changes by Thomas Wouters <tho...@python.org>: -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker <rep...@bugs.python.org> <http://bu

[issue17411] Build failures with non-NDEBUG, non-Py_DEBUG builds.

Changes by Thomas Wouters <tho...@python.org>: -- resolution: -> out of date ___ Python tracker <rep...@bugs.python.org> <http://bugs.pyt

[issue17411] Build failures with non-NDEBUG, non-Py_DEBUG builds.

Changes by Thomas Wouters <tho...@python.org>: -- stage: -> resolved status: open -> closed ___ Python tracker <rep...@bugs.python.org> <http://bugs.

[issue11410] Use GCC visibility attrs in PyAPI_*

Changes by Thomas Wouters <tho...@python.org>: -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker <rep...@bugs.python.org> <http://bu

[issue29094] Regression in zipfile writing in 2.7.13

Thomas Wouters added the comment: Well, what should the zipfile module do when you open a broken zipfile for appending in the first place? :) There are many ways in which it could be broken. I don't think a zipfile with incorrect offsets should be treated any differently. (I don't know *how

[issue29094] Regression in zipfile writing in 2.7.13

Thomas Wouters added the comment: ... and yes, the changes to issue 26293 should be reverted; the changes attached to this issue merely revert part of issue 26293's changes. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.p

[issue29094] Regression in zipfile writing in 2.7.13

Thomas Wouters added the comment: The spec isn't very explicit about it, yes, but it does say this: 4.4.16 relative offset of local header: (4 bytes) This is the offset from the start of the first disk on which this file appears, to where the local header should be found

[issue29094] Regression in zipfile writing in 2.7.13

Thomas Wouters added the comment: For the record, this new behaviour is wrong. It's not immediately obvious from the ZIP spec, but offsets have to be from the start of the file, not the archive, or ZIP64 can't work. And yes, that means you can't blindly concatenate ZIP files to other files

[issue30169] test_multiprocessing_spawn crashed on AMD64 Windows8.1 Non-Debug 3.x buildbot

Thomas Wouters added the comment: Eh, commit a00c3fd12d421e41b769debd7df717d17b0deed5 wasn't supposed to affect any behaviour in release builds, just in non-debug builds *with asserts enabled*, and only in making them build. (There is a bug in that commit that was fixed right after, commit

[issue29941] Confusion between asserts and Py_DEBUG

Thomas Wouters added the comment: PR #980 adds a configure flag (--with-assertions), defaulting to the old behaviour (no assertions by default, except when --with-pydebug is passed). I would like to backport that to (at least) 3.6 so that we can set up a buildbot with it, to prevent

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters <tho...@python.org>: -- pull_requests: +1153 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29941> ___ _

  1   2   3   >