[issue43648] Remove redundant datefmt option in logging file config

2021-03-29 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue43648>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43334] venv does not install libpython

2021-03-15 Thread Vinay Sajip


Vinay Sajip  added the comment:

This is not a bug - venvs are primarily *run*-time (as opposed to 
development-time) environments, into which you install pre-built Python 
packages (including ones with C extensions). Can you give a specific example 
where creating a venv and installing packages into it leads to a problem due to 
libpython.XXX being unavailable, with a series of steps to reproduce? If not, 
this issue will need to be closed.

--
status: open -> pending

___
Python tracker 
<https://bugs.python.org/issue43334>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43344] RotatingFileHandler breaks file type associations

2021-03-03 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue43344>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43344] RotatingFileHandler breaks file type associations

2021-03-02 Thread Vinay Sajip


Vinay Sajip  added the comment:

I'll add to the cookbook recipe with this real-world example, when I get a 
chance.

--

___
Python tracker 
<https://bugs.python.org/issue43344>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43344] RotatingFileHandler breaks file type associations

2021-03-02 Thread Vinay Sajip


Vinay Sajip  added the comment:

> Thanks Vinay, I was able to do this

Glad to hear it, Kevin. That namer is exactly what I had in my mind's eye ;-)

So shall I close the issue?

--

___
Python tracker 
<https://bugs.python.org/issue43344>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43353] Document that logging.getLevelName() can return a numeric value.

2021-03-01 Thread Vinay Sajip


Vinay Sajip  added the comment:

Sure, I'll look at a PR that mentions the other usage above the "changed in 
3.4" section.

--

___
Python tracker 
<https://bugs.python.org/issue43353>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43344] RotatingFileHandler breaks file type associations

2021-03-01 Thread Vinay Sajip


Vinay Sajip  added the comment:

As per the documentation at

https://docs.python.org/3/library/logging.handlers.html#logging.handlers.BaseRotatingHandler.namer

You can set the handler's "namer" attribute to a callable that returns a 
computed name for the rotated file - this can be computed as per your 
requirements. The cookbook also has an entry about this:

https://docs.python.org/3/howto/logging-cookbook.html#using-a-rotator-and-namer-to-customize-log-rotation-processing

--

___
Python tracker 
<https://bugs.python.org/issue43344>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43107] RotatingFileHandler with multi processes creates too small backup files

2021-02-05 Thread Vinay Sajip


Vinay Sajip  added the comment:

This is not a bug. See

https://docs.python.org/3/howto/logging-cookbook.html#logging-to-a-single-file-from-multiple-processes

You should use SocketHandler or QueueHandler to deal with a situation where 
multiple processes log to files (whether rotating or not).

--
nosy: +vinay.sajip
resolution:  -> not a bug
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue43107>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38780] SysLogHandler crash atexit

2021-01-06 Thread Vinay Sajip


Vinay Sajip  added the comment:

> As far as I know, this only happens during shutdown. During shutdown it has 
> already removed the attribute as part of the teardown process. In this case 
> adding the attribute at the begining will do no good.

Certainly, that's true - there are a number of issues that get laid at 
logging's door because of interpreter shutdown sometimes intersecting with 
asyncio, threads and error handling using logging to report, which then fails 
in turn because of inconsistent interpreter state during shutdown. That would 
then perhaps be a "wontfix" or "cantfix" because there is no good solution. But 
the missing socket attribute in SysLogHandler might cause other problems in the 
future - I'm just saying that the approach you suggested is, to me, preferable 
to the NullSocket approach to deal with a similar issue in this area.

--

___
Python tracker 
<https://bugs.python.org/issue38780>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38780] SysLogHandler crash atexit

2021-01-06 Thread Vinay Sajip


Vinay Sajip  added the comment:

TBH as I said in the now-closed PR, using a NullSocket seems overkill. As 
mentioned in msg359594, it seems to make more sense to assign a socket 
attribute to None early in the constructor. If an error occurs during socket 
creation, the socket attribute will remain at None. When closing, just ensure 
the socket attribute isn't None before trying to close it. This mirrors what 
SocketHandler does.

--

___
Python tracker 
<https://bugs.python.org/issue38780>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42842] module 'logging' has not attribute 'handlers'

2021-01-06 Thread Vinay Sajip


Vinay Sajip  added the comment:

This is not a bug - this is how it is supposed to work. The handlers module 
isn't automatically loaded; you have to import it. The basic handlers 
(NullHandler, StreamHandler, FileHandler) are in the logging module - 
additional handlers are in logging.handlers.

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue42842>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42314] Incorrect documentation entry for venv

2020-11-11 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue42314>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42314] Incorrect documentation entry for venv

2020-11-10 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset f8bea0a44d718296a249bdb766b8dbc92f38e8df by Zackery Spytz in 
branch '3.9':
[3.9] bpo-4bpo-42314: Fix the documentation for venv --upgrade-deps (GH-22113) 
(GH-23232)
https://github.com/python/cpython/commit/f8bea0a44d718296a249bdb766b8dbc92f38e8df


--
nosy: +vinay.sajip

___
Python tracker 
<https://bugs.python.org/issue42314>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42203] Unexpected behaviour NameError: name 'open' is not defined

2020-10-31 Thread Vinay Sajip


Vinay Sajip  added the comment:

> Should this be closed and pushed back to fixing logging?

It's not particularly a logging issue, though it can surface in logging because 
that's a mechanism to notify users about stuff. After all, most parts of the 
stdlib would expect open() to always be available. ISTM it's more a case of 
shutdown behaviour and user expectations relating to that. Users should be able 
to avoid any logging by calling logging.shutdown(), which can be done during a 
controlled process shutdown in user code.

--

___
Python tracker 
<https://bugs.python.org/issue42203>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42011] Documentation for logging.Filter.filter reports the wrong return type

2020-10-16 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue42011>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42011] Documentation for logging.Filter.filter reports the wrong return type

2020-10-16 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset dff9161821032acfd2588d42d88511ebdbabaaf3 by Miss Skeleton (bot) 
in branch '3.9':
bpo-42011: Update documentation of logging.Filter.filter() (GH-22692) (GH-22725)
https://github.com/python/cpython/commit/dff9161821032acfd2588d42d88511ebdbabaaf3


--

___
Python tracker 
<https://bugs.python.org/issue42011>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42011] Documentation for logging.Filter.filter reports the wrong return type

2020-10-16 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset 8f7eab788aedcf1a23ef9be767e1b3502a6bbd5c by Miss Skeleton (bot) 
in branch '3.8':
bpo-42011: Update documentation of logging.Filter.filter() (GH-22692) (GH-22724)
https://github.com/python/cpython/commit/8f7eab788aedcf1a23ef9be767e1b3502a6bbd5c


--

___
Python tracker 
<https://bugs.python.org/issue42011>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42011] Documentation for logging.Filter.filter reports the wrong return type

2020-10-16 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset e9959c71185d0850c84e3aba0301fbc238f194a9 by Necdet Can Atesman in 
branch 'master':
bpo-42011: Update documentation of logging.Filter.filter() (GH-22692)
https://github.com/python/cpython/commit/e9959c71185d0850c84e3aba0301fbc238f194a9


--

___
Python tracker 
<https://bugs.python.org/issue42011>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42011] Documentation for logging.Filter.filter reports the wrong return type

2020-10-12 Thread Vinay Sajip


Change by Vinay Sajip :


--
versions:  -Python 3.5, Python 3.6, Python 3.7

___
Python tracker 
<https://bugs.python.org/issue42011>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42011] Documentation for logging.Filter.filter reports the wrong return type

2020-10-12 Thread Vinay Sajip


Vinay Sajip  added the comment:

I agree that the documentation now should use Booleans rather than ints for the 
return type. It's a hangover from the pre-bool days of Python 1.5.2 ...

> P.S. As a side note, the API for filter() is quite counter-intuitive

That depends on if you consider the "filter" operation as "filter in" or 
"filter out", but the documentation is clear on what needs to be returned for a 
particular outcome.

--

___
Python tracker 
<https://bugs.python.org/issue42011>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41739] test_logging: test_race_between_set_target_and_flush() leaks threads (threading_cleanup() failed to cleanup ...)

2020-10-11 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset f5393dc2a0ced7bf670ebc56b5fd10a3eb328d1a by Victor Stinner in 
branch '3.9':
bpo-41739: Fix test_logging.test_race_between_set_target_and_flush() (GH-22655) 
(GH-22656)
https://github.com/python/cpython/commit/f5393dc2a0ced7bf670ebc56b5fd10a3eb328d1a


--
nosy: +vinay.sajip

___
Python tracker 
<https://bugs.python.org/issue41739>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41483] Do not acquire lock in MemoryHandler.flush() if no target defined

2020-10-09 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue41483>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41943] unittest.assertLogs passes unexpectedly

2020-10-05 Thread Vinay Sajip


Change by Vinay Sajip :


--
nosy: +vinay.sajip

___
Python tracker 
<https://bugs.python.org/issue41943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41483] Do not acquire lock in MemoryHandler.flush() if no target defined

2020-10-04 Thread Vinay Sajip


Vinay Sajip  added the comment:

OK, I'll mark as pending and close in a few days if nothing more is heard from 
Kostis.

--
status: open -> pending

___
Python tracker 
<https://bugs.python.org/issue41483>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41898] Any logging causes assertLogs to pass

2020-10-04 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue41898>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41898] Any logging causes assertLogs to pass

2020-10-04 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset faa8c6a8f1fe9c3bac31061e8a59a686b983ebb8 by Miss Skeleton (bot) 
in branch '3.9':
bpo-41898: add caveat on root logger seeing all messages in assertLogs doc 
(GH-22526) (GH-22540)
https://github.com/python/cpython/commit/faa8c6a8f1fe9c3bac31061e8a59a686b983ebb8


--

___
Python tracker 
<https://bugs.python.org/issue41898>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41898] Any logging causes assertLogs to pass

2020-10-04 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset b2611fac05ed391d68f09781903aae7394fab832 by Miss Skeleton (bot) 
in branch '3.8':
bpo-41898: add caveat on root logger seeing all messages in assertLogs doc 
(GH-22526) (GH-22537)
https://github.com/python/cpython/commit/b2611fac05ed391d68f09781903aae7394fab832


--

___
Python tracker 
<https://bugs.python.org/issue41898>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41898] Any logging causes assertLogs to pass

2020-10-04 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset 1ed54435268b285964141fb74d47ceaa33ea79ab by Irit Katriel in 
branch 'master':
bpo-41898: add caveat on root logger seeing all messages in assertLogs doc 
(GH-22526)
https://github.com/python/cpython/commit/1ed54435268b285964141fb74d47ceaa33ea79ab


--
nosy: +vinay.sajip

___
Python tracker 
<https://bugs.python.org/issue41898>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41906] logging.config.dictConfig does not work with callable filters

2020-10-02 Thread Vinay Sajip


Vinay Sajip  added the comment:

You make reasonable points. I won't close this issue, and get to those updates 
when I can/as time allows. Meanwhile, if you or someone else proposes specific 
changes by way of a pull request, I'll look at that too. And thanks for your 
kind words about the logging docs.

--

___
Python tracker 
<https://bugs.python.org/issue41906>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41906] logging.config.dictConfig does not work with callable filters

2020-10-02 Thread Vinay Sajip


Vinay Sajip  added the comment:

The value of the '()' key should be a factory - something that returns a filter 
(either something that has a filter method or a callable). That returned 
callable, or the filter method, will be called with a LogRecord and its return 
value used to determine whether the event should be processed. An example of 
using factories is here:

https://docs.python.org/3/library/logging.config.html#user-defined-objects

In your first example, you're passing the filter where you need to pass the 
factory. If you change it to e.g. return a lambda that does the filtering, it 
should work as expected.

At the moment you can't directly pass a filter callable in the config 
dictionary - only a factory that returns a filter. I'll look at this as a 
possible enhancement.

--
type: behavior -> enhancement
versions: +Python 3.10

___
Python tracker 
<https://bugs.python.org/issue41906>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38989] pip install selects 32 bit wheels for 64 bit python if vcvarsall.bat amd64_x86 in environment

2020-09-29 Thread Vinay Sajip


Vinay Sajip  added the comment:

FYI I'm in the process of updating distlib to add the get_platform() / 
get_host_platform() distinction. The next release should have it.

--
keywords: +3.5regression

___
Python tracker 
<https://bugs.python.org/issue38989>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41782] No f-string in logging.basicConfig()

2020-09-14 Thread Vinay Sajip


Vinay Sajip  added the comment:

It's as Eric said. So I'll close this issue as "not a bug". An additional point 
- by using f-strings, you may be doing unnecessary string formatting - e.g. if 
the event doesn't actually get handled because of logger or handler level or 
filter settings. It's worse if any of the parameters in the f-string are 
expensive to compute, as they would effectively be thrown away if the event 
were not to be handled.

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue41782>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30842] pyenv activate for bash and tcsh

2020-09-13 Thread Vinay Sajip


Vinay Sajip  added the comment:

If no PR is forthcoming for this, I'd like to close this issue as out of date. 
Any objections?

--

___
Python tracker 
<https://bugs.python.org/issue30842>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28499] Logging module documentation needs a rework.

2020-09-13 Thread Vinay Sajip


Vinay Sajip  added the comment:

As there's (AFAIK) been no progress on this, I'd like to close this issue. Any 
objections?

--

___
Python tracker 
<https://bugs.python.org/issue28499>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12174] Multiprocessing logging levels unclear

2020-09-13 Thread Vinay Sajip


Vinay Sajip  added the comment:

I'd like to close this issue as out of date - anyone object?

--

___
Python tracker 
<https://bugs.python.org/issue12174>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22256] pyvenv should display a progress indicator while creating an environment

2020-09-13 Thread Vinay Sajip


Vinay Sajip  added the comment:

Can we close this? I guess this enhancement is no longer needed.

--

___
Python tracker 
<https://bugs.python.org/issue22256>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19968] Python does not play well with 'stow'.

2020-09-13 Thread Vinay Sajip


Vinay Sajip  added the comment:

Closing, as the OP said "Since I can work around it easily enough, I'm set for 
now."

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue19968>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40352] SocketHandler silently drops log messages on re-connect

2020-09-13 Thread Vinay Sajip


Vinay Sajip  added the comment:

@Oleg In the interests of clarity, can you please give more detail about the 
network topology and sequence of events in your use case? Where the machine 
with the SocketHandler is, where the socket server is that it's sending to, 
where the TCP balancer comes into it, what exactly the timeout is for, and what 
is the precise cause of the socket errors {e.g. whether a failure occurs after 
a connection has been made and some events have been successfully logged - if 
so, what exactly causes the failure)?

--

___
Python tracker 
<https://bugs.python.org/issue40352>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33239] tempfile module: functions with the 'buffering' option are incorrectly documented

2020-09-13 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue33239>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33239] tempfile module: functions with the 'buffering' option are incorrectly documented

2020-09-13 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset c978be283db768743d995f04414c65439a632bdd by Miss Islington (bot) 
in branch '3.9':
bpo-33239: Fix default value of 'buffering' parameter in docs of tempfile.* 
functions (GH-21763) (GH-5)
https://github.com/python/cpython/commit/c978be283db768743d995f04414c65439a632bdd


--

___
Python tracker 
<https://bugs.python.org/issue33239>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33239] tempfile module: functions with the 'buffering' option are incorrectly documented

2020-09-13 Thread Vinay Sajip


Change by Vinay Sajip :


--
versions:  -Python 3.7

___
Python tracker 
<https://bugs.python.org/issue33239>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33239] tempfile module: functions with the 'buffering' option are incorrectly documented

2020-09-13 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset bf50b0e80a8a0d651af2f953b662eeadd27c7c93 by Miss Islington (bot) 
in branch '3.8':
bpo-33239: Fix default value of 'buffering' parameter in docs of tempfile.* 
functions (GH-21763) (GH-6)
https://github.com/python/cpython/commit/bf50b0e80a8a0d651af2f953b662eeadd27c7c93


--
nosy: +vinay.sajip

___
Python tracker 
<https://bugs.python.org/issue33239>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33239] tempfile module: functions with the 'buffering' option are incorrectly documented

2020-09-13 Thread Vinay Sajip


Change by Vinay Sajip :


--
versions: +Python 3.10, Python 3.9 -Python 3.4, Python 3.5, Python 3.6

___
Python tracker 
<https://bugs.python.org/issue33239>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35328] Set a environment variable for venv prompt

2020-09-09 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue35328>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40300] logging.Formatter crashes when default_msec_format is None.

2020-09-09 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue40300>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38762] Logging displays wrong "processName" if "sys.modules" is cleared in child process

2020-09-09 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue38762>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38762] Logging displays wrong "processName" if "sys.modules" is cleared in child process

2020-09-08 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset 3fd69991f47a6672c510fafd76bf183f17ac52ec by Irit Katriel in 
branch 'master':
bpo-38762: Extend logging.test_multiprocessing to cover missing cases. 
(GH-22142)
https://github.com/python/cpython/commit/3fd69991f47a6672c510fafd76bf183f17ac52ec


--

___
Python tracker 
<https://bugs.python.org/issue38762>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41704] logging module needs some form of introspection or debugging support

2020-09-03 Thread Vinay Sajip


Vinay Sajip  added the comment:

> if any author of any module that you use changes the global logger 
> configuration

This is an anti-pattern - any library module which does this should have a bug 
report raised about it. Only applications should change the logging 
configuration. Can you share which libraries are causing this type of problem 
for you?

I'm not sure emitting a message using the logging machinery itself would work 
as expected, as under the changed configuration the dispatch of logging 
messages might not work as you expect.

Why does setting breakpoints on logging.basicConfig, logging.config.fileConfig 
and logging.config.dictConfig not work for your use case?

--

___
Python tracker 
<https://bugs.python.org/issue41704>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38762] Logging displays wrong "processName" if "sys.modules" is cleared in child process

2020-09-03 Thread Vinay Sajip


Vinay Sajip  added the comment:

See also bpo-8200, which relates to the way the code is currently.

--

___
Python tracker 
<https://bugs.python.org/issue38762>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40352] SocketHandler silently drops log messages on re-connect

2020-09-02 Thread Vinay Sajip


Vinay Sajip  added the comment:

> It is enough to reopen the socket and send the current message again.

A common reason for connection failure in SocketHandler is the other end going 
offline for some reason. The offline period can often be measured in seconds to 
hours, or even longer. The current strategy is to retry connection, but on the 
next logging call, and with an exponential backoff.

Otherwise, if the remote end goes down and you keep retrying to connect on the 
same call, the handler would keep trying to connect and failing, and this could 
slow things down.

--

___
Python tracker 
<https://bugs.python.org/issue40352>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40352] SocketHandler silently drops log messages on re-connect

2020-09-01 Thread Vinay Sajip


Vinay Sajip  added the comment:

> But when we use TCP it is expected that log messages will not be lost.

I wouldn't go that far: logging is not a primary program function (i.e. the 
library or application should work exactly the same if logging were to be 
disabled). For the situation where you absolutely don't want to lose messages 
(apparently not that common a case - the relevant code is over 15 years old, 
and I can't remember this coming up before), you could either subclass 
SocketHandler to buffer messages, or use e.g. a MemoryHandler in conjunction 
with a SocketHandler.

--

___
Python tracker 
<https://bugs.python.org/issue40352>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38628] Issue with ctypes in AIX

2020-08-16 Thread Vinay Sajip


Vinay Sajip  added the comment:

> Implementing a work-around solely based on x64 ABI is not correct.

But AFAIK the test_array_in_struct test passes on AIX and exercises the 
workaround - why does it work if the workaround is faulty? If OTOH the test is 
faulty, could you update it with code that fails on AIX, as I suggested earlier?

--

___
Python tracker 
<https://bugs.python.org/issue38628>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41503] Race between setTarget and flush in logging.handlers.MemoryHandler

2020-08-16 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue41503>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41503] Race between setTarget and flush in logging.handlers.MemoryHandler

2020-08-16 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset 2353d77fad7ed9d11d8a4d66b5dd1306cdb94125 by Irit Katriel in 
branch 'master':
bpo-41503: Fix race between setTarget and flush in 
logging.handlers.MemoryHandler (GH-21765)
https://github.com/python/cpython/commit/2353d77fad7ed9d11d8a4d66b5dd1306cdb94125


--

___
Python tracker 
<https://bugs.python.org/issue41503>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38628] Issue with ctypes in AIX

2020-08-16 Thread Vinay Sajip


Vinay Sajip  added the comment:

> an array definition in a structure is always part of the struct itself and is 
> never a pointer

True, but a problem only arises in practice when passing by value in registers. 
It's still an open libffi issue that doesn't look like it's going to be solved 
any time soon, hence the attempted workaround in ctypes.

https://github.com/libffi/libffi/issues/33

--

___
Python tracker 
<https://bugs.python.org/issue38628>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38628] Issue with ctypes in AIX

2020-08-15 Thread Vinay Sajip


Vinay Sajip  added the comment:

> stgdict.c currently includes a target-specific work-around for small 
> structures that is not restricted to the one target (x64) affected. What's 
> the best way to proceed?

I think more data is needed to determine the best way to proceed. The original 
failure was for x64, but other targets may be affected too if structs below a 
certain size, when passed by value, are passed in registers - libffi would have 
incomplete information about how to pass the struct correctly, as arrays are 
normally encoded as pointers in libffi. Do we know for particular targets what 
the struct size limits are for passing by value in registers? If so, we could 
set the MAX_STRUCT_SIZE according to target.

I would suggest adding a test to Lib/ctypes/test/test_structures.py in the 
test_array_in_struct method (or an analogous test_38628 method), to get it to 
fail - rather than using the OP's MemchrArgsHack. Then any patches to the 
stgdict.c code would have to pass that test on all architectures. But, noting 
that test_array_in_struct passes 16-byte structures by value to a C function to 
verify correct passing of the struct - if these tests aren't failing on AIX 
now, how come? That test was failing on x64 before the stgdict.c patch was 
added, and started working afterwards. Unfortunately I don't have an AIX 
environment I can try things in :-(

--

___
Python tracker 
<https://bugs.python.org/issue38628>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

2020-07-31 Thread Vinay Sajip


Vinay Sajip  added the comment:

Thanks for the PR. I reviewed it and requested changes about 3 weeks ago - you 
should have received a notification from GitHub when that happened.

--

___
Python tracker 
<https://bugs.python.org/issue41177>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35328] Set a environment variable for venv prompt

2020-07-28 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset c82dda1e08c4b74ca24f88d6a549d93108c319cf by Zackery Spytz in 
branch 'master':
bpo-35328: Set VIRTUAL_ENV_PROMPT at venv activation (GH-21587)
https://github.com/python/cpython/commit/c82dda1e08c4b74ca24f88d6a549d93108c319cf


--

___
Python tracker 
<https://bugs.python.org/issue35328>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41381] Google chat handler in Logging module

2020-07-24 Thread Vinay Sajip


Vinay Sajip  added the comment:

Agreed that a library on PyPI is the appropriate way to resolve this.

--
stage:  -> resolved
status: pending -> closed

___
Python tracker 
<https://bugs.python.org/issue41381>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40275] test.support has way too many imports

2020-07-12 Thread Vinay Sajip


Change by Vinay Sajip :


--
nosy:  -vinay.sajip

___
Python tracker 
<https://bugs.python.org/issue40275>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

2020-07-06 Thread Vinay Sajip


Vinay Sajip  added the comment:

OK, seems like a reasonable use case. I haven't looked at the PR yet, as it 
still has a "CLA not signed" label, and I normally wait until the CLA is signed 
before looking more closely at PRs.

--

___
Python tracker 
<https://bugs.python.org/issue41177>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

2020-07-06 Thread Vinay Sajip


Vinay Sajip  added the comment:

> If it is not goal

I don't have a goal to make these part of a documented API. OP, can you share a 
use case where you need to iterate over these internal structures?

--

___
Python tracker 
<https://bugs.python.org/issue41177>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

2020-07-04 Thread Vinay Sajip


Vinay Sajip  added the comment:

> I think the other issue here is that the ConvertingX classes aren't 
> documented apart from comments in the code where they are defined.

That's deliberate - they're considered an internal implementation detail.

--

___
Python tracker 
<https://bugs.python.org/issue41177>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39385] Add an assertNoLogs context manager to unittest TestCase

2020-07-01 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39385>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39385] Add an assertNoLogs context manager to unittest TestCase

2020-07-01 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset 6b34d7b51e33fcb21b8827d927474ce9ed1f605c by Kit Choi in branch 
'master':
bpo-39385: Add an assertNoLogs context manager to unittest.TestCase (GH-18067)
https://github.com/python/cpython/commit/6b34d7b51e33fcb21b8827d927474ce9ed1f605c


--
nosy: +vinay.sajip

___
Python tracker 
<https://bugs.python.org/issue39385>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

2020-07-01 Thread Vinay Sajip


Vinay Sajip  added the comment:

This is a change in behaviour, so probably needs to be added to future versions 
only.

--
nosy: +vinay.sajip
versions: +Python 3.10 -Python 3.7

___
Python tracker 
<https://bugs.python.org/issue41177>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40884] Added defaults parameter for logging.Formatter

2020-06-29 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue40884>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41154] test_pkgutil:test_name_resolution fails on some platforms

2020-06-29 Thread Vinay Sajip

Vinay Sajip  added the comment:

The problem appears to be in importlib. I put in a breakpoint in the test just 
before it tries to import the module é. (At this point it has successfully 
imported a module called वमस in an earlier loop iteration.)

Then, in a different terminal console, I cd'd to the test directory and tried 
the import directly:
$ ls -l
total 0
drwxr-xr-x  3   x  102 29 Jun 17:55 é
drwxr-xr-x  4   x  136 29 Jun 17:55 वमस
$ ~/projects/cpython/python.exe
Python 3.10.0a0 (heads/master:a3ad95d, Jun 29 2020, 17:50:09)
[Clang 8.0.0 (clang-800.0.42.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import वमस
>>> import é
Traceback (most recent call last):
  File "", line 1, in 
ModuleNotFoundError: No module named 'é'

So for some reason, importlib is failing to import the é module. (The 
é/__init__.py is a zero-byte file.)

Adding Brett to nosy.

--
nosy: +brett.cannon

___
Python tracker 
<https://bugs.python.org/issue41154>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40836] logging.fatal() and logging.Logger.fatal() should raise a DeprecationWarning

2020-06-03 Thread Vinay Sajip


Vinay Sajip  added the comment:

Yes, they could have a docstring indicating that it is better to use 
critical(). Feel free to update the PR along that line.

--

___
Python tracker 
<https://bugs.python.org/issue40836>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40836] logging.fatal() and logging.Logger.fatal() should raise a DeprecationWarning

2020-05-31 Thread Vinay Sajip


Vinay Sajip  added the comment:

Well, I'm not planning to actually deprecate and then remove them - as they're 
not documented, it's unlikely that new code will use them, and there's no 
particular reason to break old code that happens to use them.

--
nosy: +vinay.sajip

___
Python tracker 
<https://bugs.python.org/issue40836>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40275] test.support has way too many imports

2020-04-19 Thread Vinay Sajip


Vinay Sajip  added the comment:

What is the practical impact on the time taken for test runs? How much does the 
total time for a test run reduce as a result of refactoring test.support to 
minimise imports?

--
nosy: +vinay.sajip

___
Python tracker 
<https://bugs.python.org/issue40275>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40300] logging.Formatter crashes when default_msec_format is None.

2020-04-17 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset 06a35542aad15666cace307d841a95e33f3cbee6 by Mariusz Felisiak in 
branch 'master':
bpo-40300: Allow empty logging.Formatter.default_msec_format. (GH-19551)
https://github.com/python/cpython/commit/06a35542aad15666cace307d841a95e33f3cbee6


--

___
Python tracker 
<https://bugs.python.org/issue40300>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39656] shebanged scripts can escape from `venv` depending on how it was created

2020-03-19 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39656>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39656] shebanged scripts can escape from `venv` depending on how it was created

2020-03-17 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset 58ec58a42bece5b2804b178c7a6a7e67328465db by Anthony Sottile in 
branch 'master':
bpo-39656: Ensure `bin/python3.#` is always present in virtual environments on 
POSIX (GH-19030)
https://github.com/python/cpython/commit/58ec58a42bece5b2804b178c7a6a7e67328465db


--
nosy: +vinay.sajip

___
Python tracker 
<https://bugs.python.org/issue39656>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39577] venv --prompt argument is ignored

2020-03-12 Thread Vinay Sajip


Vinay Sajip  added the comment:

> My question at this stage is, where is this "Prompt" variable set?

If you mean the VIRTUAL_ENV variable, it's set in one of the activation scripts 
for the venv. In any case, this doesn't look it it's a problem with venv code, 
more to do with your local environment. So I'll close this issue.

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39577>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39938] RotatingFileHandler does not support any mode other than 'a'.

2020-03-12 Thread Vinay Sajip


Vinay Sajip  added the comment:

> supplying a mode to append bytes is not supported

That is correct, log files supported by standard library handlers are text 
files using some supported encoding. If you need to store arbitrary bytes 
directly in a log file, feel free to write your own handlers to do it.

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39938>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39893] Add set_terminate() to logging

2020-03-09 Thread Vinay Sajip


Vinay Sajip  added the comment:

There's no need for a method to do this. You can do any of:

1. Set the terminator attribute to whatever you need in logging.StreamHandler 
(if all code you ever use must use a different terminator).

2. Set it in individual instances of StreamHandler.

3. Set it in a subclass of StreamHandler which you then use instead of 
StreamHandler.

Since only a few cases will want a different terminator, there's no need to add 
a special mechanism to override it, when you can just use an assignment 
statement.

--
resolution:  -> rejected
stage:  -> resolved
status: open -> closed
versions:  -Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 
<https://bugs.python.org/issue39893>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39826] logging HTTPHandler does not support proxy

2020-03-04 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9

___
Python tracker 
<https://bugs.python.org/issue39826>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39826] logging HTTPHandler does not support proxy

2020-03-04 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset 22a9a546ff3bf2a63d77ca1e5494e758bc59132f by l0rb in branch 
'master':
bpo-39826: add getConnection() hook to logging HTTPHandler (GH-18745)
https://github.com/python/cpython/commit/22a9a546ff3bf2a63d77ca1e5494e758bc59132f


--
nosy: +vinay.sajip

___
Python tracker 
<https://bugs.python.org/issue39826>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12915] Add inspect.locate and inspect.resolve

2020-02-28 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset 4f17c5cd9a1ec50fe8de7ef68c39220a01a862cb by Vinay Sajip in branch 
'master':
bpo-12915: Improve Unicode support for package names and attributes. (GH-18517)
https://github.com/python/cpython/commit/4f17c5cd9a1ec50fe8de7ef68c39220a01a862cb


--

___
Python tracker 
<https://bugs.python.org/issue12915>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39589] Logging QueueListener should support context manager

2020-02-20 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> not a bug
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39589>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39589] Logging QueueListener should support context manager

2020-02-19 Thread Vinay Sajip


Vinay Sajip  added the comment:

See my comments on the PR. I think this issue and the PR should be closed.

--

___
Python tracker 
<https://bugs.python.org/issue39589>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39540] Logging docs don't address the creation of multiple loggers when a hierarchy is provided

2020-02-19 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39540>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12915] Add inspect.locate and inspect.resolve

2020-02-17 Thread Vinay Sajip


Vinay Sajip  added the comment:

> I'm not sure how to design the regex.

Did you not look at the PR I added to address this (Unicode chars), with a 
regex change? I added you as a reviewer.

--

___
Python tracker 
<https://bugs.python.org/issue12915>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39633] venv does not include python. symlink by default

2020-02-16 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed
type:  -> behavior

___
Python tracker 
<https://bugs.python.org/issue39633>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12915] Add inspect.locate and inspect.resolve

2020-02-15 Thread Vinay Sajip


Change by Vinay Sajip :


--
pull_requests: +17895
pull_request: https://github.com/python/cpython/pull/18517

___
Python tracker 
<https://bugs.python.org/issue12915>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39633] venv does not include python. symlink by default

2020-02-15 Thread Vinay Sajip


Vinay Sajip  added the comment:

In general, people should be working in venvs. That means that libraries should 
assume they are being installed into venvs. Therefore makefiles should be 
invoking plain "python" rather than "pythonX.Y", as they can never be sure 
which exact interpreter they're running under (you might have a newer one than 
the one in the Makefile - that shouldn't fail). Why not raise this as an issue 
with these projects?

--

___
Python tracker 
<https://bugs.python.org/issue39633>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12915] Add inspect.locate and inspect.resolve

2020-02-15 Thread Vinay Sajip


Vinay Sajip  added the comment:

To be more precise, one could use

^(?!\d)(\w+)(\.(?!\d)(\w+))* for _DOTTED_WORDS and use the re.U flag when 
compiling the pattern. That should match any packages where segments start with 
a letter and continue with alphanumerics. Do you agree?

--

___
Python tracker 
<https://bugs.python.org/issue12915>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12915] Add inspect.locate and inspect.resolve

2020-02-15 Thread Vinay Sajip


Vinay Sajip  added the comment:

> The regex looks too strict. Python 3 accepts non-ASCII module names.

Would adding the re.U flag be enough, or are you thinking of other 
possibilities?

--

___
Python tracker 
<https://bugs.python.org/issue12915>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39633] venv does not include python. symlink by default

2020-02-15 Thread Vinay Sajip


Vinay Sajip  added the comment:

Except that if there's a global other pythonX.Y of the different version, that 
would get run ... potentially even more confusing.

--

___
Python tracker 
<https://bugs.python.org/issue39633>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39633] venv does not include python. symlink by default

2020-02-14 Thread Vinay Sajip


Vinay Sajip  added the comment:

When a venv is activated, only one Python interpreter is active - whichever one 
the venv was created with. Why would you want to invoke it with `pythonX.Y` 
when `python` would do? I don't think that this is something people generally 
do - this has never come up before AFAIK. What if you invoked it with the wrong 
values of X.Y?

--

___
Python tracker 
<https://bugs.python.org/issue39633>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39618] logger.exception with default message

2020-02-14 Thread Vinay Sajip


Vinay Sajip  added the comment:

Sorry, I don't think this change is a good idea. It's not clear what the value 
is in logging exceptions with no message.

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39618>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12915] Add inspect.locate and inspect.resolve

2020-02-14 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9 -Python 3.5

___
Python tracker 
<https://bugs.python.org/issue12915>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12915] Add inspect.locate and inspect.resolve

2020-02-14 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset 1ed61617a4a6632905ad6a0b440cd2cafb8b6414 by Vinay Sajip in branch 
'master':
bpo-12915: Add pkgutil.resolve_name (GH-18310)
https://github.com/python/cpython/commit/1ed61617a4a6632905ad6a0b440cd2cafb8b6414


--

___
Python tracker 
<https://bugs.python.org/issue12915>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39577] venv --prompt argument is ignored

2020-02-10 Thread Vinay Sajip


Vinay Sajip  added the comment:

> Am I misunderstanding the behaviour of the prompt argument?

You can see from Karthikeyan's post how it's supposed to work, and how it does 
work in his example. It may be that something else is overwriting the prompt in 
your environment - we can't tell without knowing what's in your .bashrc, 
.profile etc.

--

___
Python tracker 
<https://bugs.python.org/issue39577>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39505] redundant ‘/’ in $env:VIRTUAL_ENV when use venv in powershell

2020-02-05 Thread Vinay Sajip


Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39505>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39505] redundant ‘/’ in $env:VIRTUAL_ENV when use venv in powershell

2020-02-05 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset 927d3aab1c7874b5705fcc8269ea608315434e66 by Miss Islington (bot) 
in branch '3.8':
bpo-39505: delete the redundant '/' in $env:VIRTUAL_ENV (GH-18290) (GH-18359)
https://github.com/python/cpython/commit/927d3aab1c7874b5705fcc8269ea608315434e66


--

___
Python tracker 
<https://bugs.python.org/issue39505>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39505] redundant ‘/’ in $env:VIRTUAL_ENV when use venv in powershell

2020-02-05 Thread Vinay Sajip


Vinay Sajip  added the comment:


New changeset 787b6d548c250f36df6d3f3179f60d754c8aa5e3 by schwarzichet in 
branch 'master':
bpo-39505: delete the redundant '/' in $env:VIRTUAL_ENV (GH-18290)
https://github.com/python/cpython/commit/787b6d548c250f36df6d3f3179f60d754c8aa5e3


--

___
Python tracker 
<https://bugs.python.org/issue39505>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39540] Logging docs don't address the creation of multiple loggers when a hierarchy is provided

2020-02-03 Thread Vinay Sajip


Vinay Sajip  added the comment:

That's an internal detail. In fact loggers aren't created for all loggers in 
the hierarchy - PlaceHolder objects are created internally for hierarchy 
ancestors, and converted to loggers if needed. The printout from your linked 
Stack Overflow question shows this.

This is not documented because it's internal implementation detail. How the 
dotted-name hierarchy works is documented.

--

___
Python tracker 
<https://bugs.python.org/issue39540>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12915] Add inspect.locate and inspect.resolve

2020-02-02 Thread Vinay Sajip


Change by Vinay Sajip :


--
pull_requests: +17686
pull_request: https://github.com/python/cpython/pull/18310

___
Python tracker 
<https://bugs.python.org/issue12915>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   3   4   5   6   7   8   9   10   >