[issue35456] asyncio.Task.set_result() and set_exception() missing docstrings (and Liskov sub. principle)

2018-12-10 Thread Yahya Abou Imran
New submission from Yahya Abou Imran : In asyncio.Task help: | set_exception(self, exception, /) | Mark the future done and set an exception. | | If the future is already done when this method is called, raises | InvalidStateError. | | set_result(self, result

[issue32471] Add an UML class diagram to the collections.abc module documentation

2018-01-25 Thread Yahya Abou Imran
Yahya Abou Imran <yahya-abou-im...@protonmail.com> added the comment: I succeed in submitting a PR and building the doc locally. But there is a little problem of consistency with the abstract methods: in some classes, the inherited one are mentioned (Collection, Sequence, M

[issue32621] Problem of consistence in collection.abc documentation

2018-01-25 Thread Yahya Abou Imran
Yahya Abou Imran <yahya-abou-im...@protonmail.com> added the comment: There is another one: Reversible list __reversed__ in the abstract method but inherits __iter__ from Iterable. So there is definitely an inconsistency... -- ___ Python t

[issue32621] Problem of consistence in collection.abc documentation

2018-01-22 Thread Yahya Abou Imran
New submission from Yahya Abou Imran <yahya-abou-im...@protonmail.com>: Opened after https://github.com/python/cpython/pull/5270 was closed. Here: https://docs.python.org/3/library/collections.abc.html Some abstract methods are inherited from a superclass. Most of the time th

[issue32472] Mention of __await__ missing in Coroutine Abstract Methods

2018-01-22 Thread Yahya Abou Imran
Change by Yahya Abou Imran <yahya-abou-im...@protonmail.com>: -- keywords: +patch pull_requests: +5114 stage: -> patch review ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue32467] dict_values isn't considered a Collection nor a Container

2018-01-11 Thread Yahya Abou Imran
Yahya Abou Imran <yahya-abou-im...@protonmail.com> added the comment: Perfect for me. I was about to submit about the same patch as yours after your acceptation; but it's better that way, it's your module! Thanks Raymond. -- ___ Python tracke

[issue32471] Add an UML class diagram to the collections.abc module documentation

2018-01-07 Thread Yahya Abou Imran
Change by Yahya Abou Imran <yahya-abou-im...@protonmail.com>: -- keywords: +patch pull_requests: +4994 stage: -> patch review ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue32471] Add an UML class diagram to the collections.abc module documentation

2018-01-07 Thread Yahya Abou Imran
Yahya Abou Imran <yahya-abou-im...@protonmail.com> added the comment: I have generated SVG files. Here is the rest of the ABCs present in the module: https://gitlab.com/yahya-abou-imran/collections-abc-uml/blob/master/plantuml/other_collections.svg And here is the full version with al

[issue32449] MappingView must inherit from Collection instead of Sized

2018-01-03 Thread Yahya Abou Imran
Yahya Abou Imran <yahya-abou-im...@protonmail.com> added the comment: I'm sorry, It's already done... https://bugs.python.org/issue32467 -- ___ Python tracker <rep...@bugs.python.org> <https://bugs.python

[issue32473] Readibility of ABCMeta._dump_registry()

2018-01-03 Thread Yahya Abou Imran
Change by Yahya Abou Imran <yahya-abou-im...@protonmail.com>: -- keywords: +patch pull_requests: +4963 stage: -> patch review ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue32473] Readibility of ABCMeta._dump_registry()

2017-12-31 Thread Yahya Abou Imran
New submission from Yahya Abou Imran <yahya-abou-im...@protonmail.com>: >From python-ideas: https://mail.python.org/pipermail/python-ideas/2017-December/048504.html In python 2.7, ABCs's caches and registries are sets. But in python 3.6 they are WeakSet. In consequence, t

[issue32472] Mention of __await__ missing in Coroutine Abstract Methods

2017-12-31 Thread Yahya Abou Imran
New submission from Yahya Abou Imran <yahya-abou-im...@protonmail.com>: In the collections.abc documentation: https://docs.python.org/3/library/collections.abc.html __await__() doesn't appear in the abstract methods of Coroutine, we see only send() and throw(). But since Coroutine i

[issue32471] Add an UML class diagram to the collections.abc module documentation

2017-12-31 Thread Yahya Abou Imran
Yahya Abou Imran <yahya-abou-im...@protonmail.com> added the comment: Here is the .puml -- Added file: https://bugs.python.org/file47358/base.puml ___ Python tracker <rep...@bugs.python.org> <https://bugs.python

[issue32471] Add an UML class diagram to the collections.abc module documentation

2017-12-31 Thread Yahya Abou Imran
New submission from Yahya Abou Imran <yahya-abou-im...@protonmail.com>: >From python-ideas: >https://mail.python.org/pipermail/python-ideas/2017-December/048492.html In this page of the documentation: https://docs.python.org/3/library/collections.abc.html The table could

[issue32467] dict_values isn't considered a Collection nor a Container

2017-12-31 Thread Yahya Abou Imran
New submission from Yahya Abou Imran <yahya-abou-im...@protonmail.com>: a `dict_values` instance behaves like a Collection (a Sized Iterable Container): >>> values = {1: 'one', 2: 'two'}.values() >>> 'two' in values True >>> 'three' in values False >>>

[issue32449] MappingView must inherit from Collection instead of Sized

2017-12-31 Thread Yahya Abou Imran
Yahya Abou Imran <yahya-abou-im...@protonmail.com> added the comment: Hmm... Okay, I understand. So the only objection I have left, it's that ValuesView isn't passing the is instance of Collection test whereas it should, since he has the full behavior of one. It could be passed

[issue32449] MappingView must inherit from Collection instead of Sized

2017-12-29 Thread Yahya Abou Imran
Yahya Abou Imran <yahya-abou-im...@protonmail.com> added the comment: And I just saw that Raymon Hettinger made it inherting from Sized: https://github.com/python/cpython/blame/master/Lib/_collections_abc.py#L694 So I we were to ahve his o

[issue32449] MappingView must inherit from Collection instead of Sized

2017-12-29 Thread Yahya Abou Imran
Yahya Abou Imran <yahya-abou-im...@protonmail.com> added the comment: https://mail.python.org/pipermail/python-ideas/2017-December/048489.html Guido is waiting for objection on this... I have absolutly no idea why this decision was made. These tests (ttps://github.com/python/cpython

[issue32449] MappingView must inherit from Collection instead of Sized

2017-12-29 Thread Yahya Abou Imran
Yahya Abou Imran <yahya-abou-im...@protonmail.com> added the comment: Quoting my own post on python-ideas: After I generate an UML diagram from collections.abc, I found very strange that MappingView inherit from Sized instead of Collection (new in python 3.6). Yes, MappingView only

[issue32449] MappingView must inherit from Collection instead of Sized

2017-12-29 Thread Yahya Abou Imran
New submission from Yahya Abou Imran <yahya-abou-im...@protonmail.com>: Quoting my own post on python-ideas: After I generate an UML diagram from collections.abc, I found very strange that MappingView inherit from Sized instead of Collection (new in python 3.6). Yes, MappingView only