[issue30841] Fix a variable shadowing warning in Python-ast.c

2017-08-01 Thread Yuan Chao Chou
Changes by Yuan Chao Chou : -- title: A shadowing variable naming emitted for Python-ast.c -> Fix a variable shadowing warning in Python-ast.c ___ Python tracker <http://bugs.python.org/issu

[issue30841] A shadowing variable naming emitted for Python-ast.c

2017-07-25 Thread Yuan Chao Chou
Yuan Chao Chou added the comment: This can be repro by setting -Wshadow-compatible-local when using gcc to compile Python-ast.c. An example on my machine: ➜ cpython git:(69c0db5050) ✗ gcc-7 -Wshadow-compatible-local -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3

[issue30841] A shadowing variable naming emitted for Python-ast.c

2017-07-03 Thread Yuan Chao Chou
Changes by Yuan Chao Chou : -- pull_requests: +2619 ___ Python tracker <http://bugs.python.org/issue30841> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30841] A shadowing variable naming emitted for Python-ast.c

2017-07-03 Thread Yuan Chao Chou
Changes by Yuan Chao Chou : -- pull_requests: +2618 ___ Python tracker <http://bugs.python.org/issue30841> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30841] A shadowing variable naming emitted for Python-ast.c

2017-07-03 Thread Yuan Chao Chou
Changes by Yuan Chao Chou : -- pull_requests: +2617 ___ Python tracker <http://bugs.python.org/issue30841> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30841] A shadowing variable naming emitted for Python-ast.c

2017-07-03 Thread Yuan Chao Chou
New submission from Yuan Chao Chou: When Parser/asdl_c.py is composing the content of Python/Python-ast.c, it uses "value" to name the variables in inner blocks, which can shadow the variables named the same in outer blocks. It would be a good practice to avoid the shadowing naming