[issue32835] Add documention mentioning that Cygwin isn't fully compatible
Diana added the comment: Hi, I've created a pull request for pep 11. https://github.com/python/peps/pull/2065 -- nosy: +DonnaDia ___ Python tracker <https://bugs.python.org/issue32835> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20803] doc: clarify that struct.pack_into writes 0x00 for pad bytes
Change by Diana : -- keywords: +patch pull_requests: +26493 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28047 ___ Python tracker <https://bugs.python.org/issue20803> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20803] doc: clarify that struct.pack_into writes 0x00 for pad bytes
Diana added the comment: I'm working on this -- nosy: +DonnaDia ___ Python tracker <https://bugs.python.org/issue20803> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24888] FileNotFoundException raised by subprocess.call
Change by Diana : -- keywords: +patch pull_requests: +26464 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28018 ___ Python tracker <https://bugs.python.org/issue24888> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24388] Python readline module crashes in history_get on FreeBSD with libedit
Change by Diana : -- nosy: +DonnaDia nosy_count: 3.0 -> 4.0 pull_requests: +26463 pull_request: https://github.com/python/cpython/pull/28018 ___ Python tracker <https://bugs.python.org/issue24388> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24888] FileNotFoundException raised by subprocess.call
Diana added the comment: Hi, I will work on this. I will create a pull request within 3 days. -- nosy: +DonnaDia ___ Python tracker <https://bugs.python.org/issue24888> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44925] [docs] Confusing deprecation notice for typing.IO
Change by Diana : -- keywords: +patch pull_requests: +26446 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28004 ___ Python tracker <https://bugs.python.org/issue44925> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44925] [docs] Confusing deprecation notice for typing.IO
Diana added the comment: Hi, I can handle this. I will provide a pull request within 3 days. -- nosy: +DonnaDia ___ Python tracker <https://bugs.python.org/issue44925> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33426] [doc] Behavior of os.path.join does not match documentation
Change by Diana : -- keywords: +patch pull_requests: +26445 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28003 ___ Python tracker <https://bugs.python.org/issue33426> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33426] [doc] Behavior of os.path.join does not match documentation
Diana added the comment: Hi, I'm working on it. I will provide the pull request within 3 days. -- nosy: +DonnaDia ___ Python tracker <https://bugs.python.org/issue33426> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34804] Repetition of 'for example' in documentation
Diana added the comment: I will handle it. I will send a pull request within 3 days. -- nosy: +DonnaDia ___ Python tracker <https://bugs.python.org/issue34804> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30274] Rename 'name' to 'fullname' argument to ExtensionFileLoader
Diana Van Straaten added the comment: I want to work on it. -- nosy: +zemlya3018 ___ Python tracker <https://bugs.python.org/issue30274> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31657] unit test for optimization levels does not cover __debug__ case
Change by diana <diana.joan.cla...@gmail.com>: -- keywords: +patch pull_requests: +3827 stage: -> patch review ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue31657> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31657] unit test for optimization levels does not cover __debug__ case
New submission from diana <diana.joan.cla...@gmail.com>:
There are currently three supported optimization levels (0, 1, and 2). Briefly
summarized, they do the following.
0: no optimizations
1: remove assert statements and __debug__ blocks
2: remove docstrings, assert statements, and __debug__ blocks
The current compile() tests for optimization levels in Lib/test/test_builtin.py
covers the assert and docstring cases, but it doesn't test that __debug__ code
blocks are included or excluded based on the optimization level.
For example, if you change Python/compile.c to always include __debug__ blocks
regardless of the optimization level, the existing compile() tests will
continue to pass.
$ git diff Python/compile.c
diff --git a/Python/compile.c b/Python/compile.c
index 280ddc39e3..d65df098bb 100644
--- a/Python/compile.c
+++ b/Python/compile.c
@@ -4143,7 +4143,7 @@ expr_constant(struct compiler *c, expr_ty e)
/* optimize away names that can't be reassigned */
id = PyUnicode_AsUTF8(e->v.Name.id);
if (id && strcmp(id, "__debug__") == 0)
-return !c->c_optimize;
+return 1;
return -1;
case NameConstant_kind: {
PyObject *o = e->v.NameConstant.value;
--
messages: 303465
nosy: diana
priority: normal
severity: normal
status: open
title: unit test for optimization levels does not cover __debug__ case
type: enhancement
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31657>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2506] Add mechanism to disable optimizations
Changes by diana <diana.joan.cla...@gmail.com>: -- nosy: +diana ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue2506> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25711] Rewrite zipimport from scratch
Changes by diana <diana.joan.cla...@gmail.com>: -- nosy: +diana ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue25711> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22174] property doc fixes
diana added the comment: This whitespace? Or did you mean something else? class C: def __init__(self): self._x = None def getx(self): return self._x def setx(self, value): self._x = value def delx(self): del self._x x = property(getx, setx, delx, I'm the 'x' property.) versus: class C: def __init__(self): self._x = None def getx(self): return self._x def setx(self, value): self._x = value def delx(self): del self._x x = property(getx, setx, delx, I'm the 'x' property.) I added it to be consistent with the rest of the code snippets in the property docs. For example: class C: def __init__(self): self._x = None @property def x(self): I'm the 'x' property. return self._x @x.setter def x(self, value): self._x = value @x.deleter def x(self): del self._x Of the three code snippets in the property docs, that first one is the only one that doesn't have whitespace between the methods. That first code snippet also has inconsistent whitespace within itself (__init__ vs the rest of methods). Anyhoo, that was my reasoning, but that's largely beside the point. I will happily drop it and leave it as-is. What really prompted me to submit a patch was this paragraph: If given, doc will be the docstring of the property attribute. Otherwise, the property will copy fget‘s docstring (if it exists). This makes it possible to create read-only properties easily using property() as a decorator: I now understand the original intent, but I don't think it's clear as-is. I also find it a bit odd that 'fget', 'fset', 'fdel' are all defined in the first sentence of the docs, but 'doc' isn't. It then launches into an example that uses 'doc' (still as of yet undefined), before defining 'doc' later on in the read-only properties part. I'll think on it a bit some more -- feel free to close this in the mean time. It's been this way for a better part of a decade, so perhaps it's just me ;) Cheers, --diana -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22174] property doc fixes
New submission from diana: The property docs are a bit funky. https://docs.python.org/3/library/functions.html#property 1) docstrings have zero to do with making a read-only property. It currently says: If given, doc will be the docstring of the property attribute. Otherwise, the property will copy fget‘s docstring (if it exists). This makes it possible to create read-only properties easily using property() as a decorator: 2) The 'then' in this sentence is awkward (and incorrect English). If then c is an instance of C, c.x will invoke the getter, c.x = value will invoke the setter and del c.x the deleter. 3) This sentence is missing a beginning. turns the voltage() method into a “getter” for a read-only attribute with the same name. 4) This sentence has an extra comma (after del'ing): fget is a function for getting an attribute value, likewise fset is a function for setting, and fdel a function for del’ing, an attribute. Attached is a patch with minimal changes to the property docs, addressing the above four issues. Okay, that's not entirely true -- I did add an example usage because the current docs don't actually show using a property attribute. p = Parrot() p.voltage 10 I've also attached an after screenshot of the docs in case it helps with review. Cheers, --diana -- assignee: docs@python components: Documentation files: property_docs.patch keywords: patch messages: 225086 nosy: diana, docs@python priority: normal severity: normal status: open title: property doc fixes versions: Python 3.5 Added file: http://bugs.python.org/file36318/property_docs.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22174] property doc fixes
Changes by diana diana.joan.cla...@gmail.com: Added file: http://bugs.python.org/file36319/Screen Shot 2014-08-08 at 4.44.07 PM.png ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21582] use support.captured_stdx context managers - test_asyncore
diana added the comment: I removed some of the from imports and used support.x instead for consistency. support was already being imported, and many of the things imported from support were already using support.x. I just made them all the same. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21582 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21582] use the support.catpured_stdout/stderr context managers - test_asyncore
New submission from diana: Updated test_asyncore to use the support.catpured_stdout/stderr context managers rather than try/finally blocks. -- components: Tests files: use_support_captured_test_asyncore.patch keywords: patch messages: 219162 nosy: diana priority: normal severity: normal status: open title: use the support.catpured_stdout/stderr context managers - test_asyncore versions: Python 3.5 Added file: http://bugs.python.org/file35370/use_support_captured_test_asyncore.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21582 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21582] use support.catpured context managers - test_asyncore
Changes by diana diana.joan.cla...@gmail.com: -- title: use the support.catpured_stdout/stderr context managers - test_asyncore - use support.catpured context managers - test_asyncore ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21582 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21583] use support.catpured_stderr context manager - test_logging
New submission from diana: - Updated test_asyncore to use the support.catpured_stderr context manager - Removed unused imports -- components: Tests files: use_support_captured_stderr_test_logging.patch keywords: patch messages: 219165 nosy: diana priority: normal severity: normal status: open title: use support.catpured_stderr context manager - test_logging versions: Python 3.5 Added file: http://bugs.python.org/file35371/use_support_captured_stderr_test_logging.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21583 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21583] use support.catpured_stderr context manager - test_logging
diana added the comment: oops, typo: - Updated test_logging (not test_asyncore) to use the support.catpured_stderr context manager -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21583 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21355] shallow defaults to true, not 1 [filecmp.cmp]
New submission from Diana Clarke: A minor correction to the filecmp.cmp doc string. 'defaults to 1' - 'defaults to True' While shallow used to default to 1 years ago, it now defaults to True. def cmp(f1, f2, shallow=True): PS. I know this diff is annoyingly trivial, but I'm using it to learn the process. Thanks, --diana -- components: Library (Lib) files: shallow_defaults_to_true_not_1.patch keywords: patch messages: 217192 nosy: diana priority: normal severity: normal status: open title: shallow defaults to true, not 1 [filecmp.cmp] type: behavior versions: Python 3.5 Added file: http://bugs.python.org/file35044/shallow_defaults_to_true_not_1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21355 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21355] Shallow defaults to True, not 1 [filecmp.cmp]
Changes by diana diana.joan.cla...@gmail.com: -- title: shallow defaults to true, not 1 [filecmp.cmp] - Shallow defaults to True, not 1 [filecmp.cmp] ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21355 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21357] Increase filecmp test coverage from 63% to 76%
New submission from diana: - Increase filecmp test coverage from 63% to 76% - I left the testing style as-is, though it could probably be modernized. - I did not attempt to add coverage for 'funny_files', 'subdirs', etc, next pass perhaps. - Before: diana$ ./python.exe ../coveragepy report --show-missing Name Stmts Miss Cover Missing --- Lib/filecmp 163 6163% 64, 80, 126, 130, 159-161, 164-166, 172, 174, 178-180, 190-194, 197-199, 203-224, 227-230, 233-236, 246, 293-302, 305 - After: diana$ ./python.exe ../coveragepy report --show-missing Name Stmts Miss Cover Missing --- Lib/filecmp 163 3976% 64, 80, 126, 130, 159-161, 164-166, 172, 174, 178-180, 192-194, 197-199, 217-218, 220-221, 223-224, 229-230, 235-236, 246, 293-302, 305 Thoughts? Thanks! -- components: Library (Lib) files: increase_filecmp_test_coverage.patch keywords: patch messages: 217201 nosy: diana priority: normal severity: normal status: open title: Increase filecmp test coverage from 63% to 76% type: behavior versions: Python 3.5 Added file: http://bugs.python.org/file35045/increase_filecmp_test_coverage.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21357 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21357] Increase filecmp test coverage from 63% to 76%
Changes by diana diana.joan.cla...@gmail.com: Added file: http://bugs.python.org/file35046/increase_filecmp_test_coverage_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21357 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21357] Increase filecmp test coverage from 63% to 76%
Changes by diana diana.joan.cla...@gmail.com: Removed file: http://bugs.python.org/file35046/increase_filecmp_test_coverage_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21357 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21357] Increase filecmp test coverage from 63% to 76%
diana added the comment: Nice, the support.catpured_stdout() context manager is much better. I've added a new patch with that change: increase_filecmp_test_coverage__updated_to_use_context_manager.patch Thanks for reviewing this, Benjamin! PS. I signed the contributor agreement. -- Added file: http://bugs.python.org/file35047/increase_filecmp_test_coverage__updated_to_use_context_manager.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21357 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
