[issue32800] Replace deprecated link to new page on w3c site

2018-02-10 Thread sblondon
Change by sblondon <stephane.blon...@gmail.com>: -- keywords: +patch pull_requests: +5419 stage: needs patch -> patch review ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue32800] Replace deprecated link to new page on w3c site

2018-02-08 Thread sblondon
New submission from sblondon <stephane.blon...@gmail.com>: The documentation about namespace of ElemenTree (https://docs.python.org/3/library/xml.etree.elementtree.html#parsing-xml-with-namespaces) has a link for 'default namespace' to 'https://www.w3.org/TR/2006/REC-xml-names-20

[issue32234] Add context management to mailbox.Mailbox

2017-12-18 Thread sblondon
sblondon <stephane.blon...@gmail.com> added the comment: If the access is read-only, the lock is not required [1]. However, I agree it does not worth to be more complex (changing the signature of the subclass or adding another context manager for the lock). I updated the patch and documen

[issue32234] Add context management to mailbox.Mailbox

2017-12-09 Thread sblondon
Change by sblondon <stephane.blon...@gmail.com>: -- keywords: +patch pull_requests: +4673 stage: -> patch review ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue32234] Add context management to mailbox.Mailbox

2017-12-06 Thread sblondon
sblondon <stephane.blon...@gmail.com> added the comment: Currently, the implementation of .close() methods call flush() and unlock() if it's needed. About the ambiguity for the enter call, I think the context manager should provide access to Mailbox, not a lock. If a lock is needed, we

[issue32234] Add context management to mailbox.Mailbox

2017-12-06 Thread sblondon
New submission from sblondon <stephane.blon...@gmail.com>: mailbox.Mailbox has a .close() method that should be called at the end of Mailbox use. I think it would be nice to use Mailbox instances with a 'with' statement so .close() will be called it automatically. So there is no need to