[issue1094] TypeError in poplib.py

2007-09-09 Thread Guido van Rossum 

Changes by Guido van Rossum:


__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1094
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1094] TypeError in poplib.py

2007-09-09 Thread Guido van Rossum 

Guido van Rossum added the comment:

Oops, I accidentally deleted the patch. Here is is again.
Thanks for the patch! I've applied it.
Committed revision 58072.

--
assignee:  - gvanrossum
nosy: +gvanrossum
resolution:  - fixed
status: open - closed

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1094
__--- C:/Python30/Lib/poplib.py~	Mon Sep 03 11:33:24 2007
+++ C:/Python30/Lib/poplib.py	Mon Sep 03 10:43:47 2007
@@ -134,8 +134,8 @@
 resp = self._getresp()
 list = []; octets = 0
 line, o = self._getline()
-while line != '.':
-if line[:2] == '..':
+while line != b'.':
+if line[:2] == b'..':
 o = o-1
 line = line[1:]
 octets = octets + o
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1094] TypeError in poplib.py

2007-09-03 Thread Serge Julien 

New submission from Serge Julien:

In poplib.py, lines 137-138, bytes and str are compared, leading to a
TypeError:

[...]
137while line != '.':
138if line[:2] == '..':
[...]

where type(line) = type 'bytes'

--
components: Library (Lib)
messages: 55617
nosy: serge.julien
severity: normal
status: open
title: TypeError in poplib.py
versions: Python 3.0

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1094
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1094] TypeError in poplib.py

2007-09-03 Thread Serge Julien 

Serge Julien added the comment:

Patch proposal.

Tell me if it's right to submit it here: this is the first patch I submit

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1094
__

poplib.diff
Description: Binary data
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1094] TypeError in poplib.py

2007-09-03 Thread Martin v. Löwis 

Changes by Martin v. Löwis:


--
keywords: +patch

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1094
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com