Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 2035c5ad4239 by Ned Deily in branch 'default':
Issue #14225: Fix Unicode support for curses (#12567) on OS X:
http://hg.python.org/cpython/rev/2035c5ad4239
--
___
Python
Ned Deily n...@acm.org added the comment:
It turns out that the Unicode support introduced by this issue didn't build
correctly on OS X, either silently failing to build (explaining the problem
seen by Nicholas) or causing a compile error (as seen in Issue14225). This
should be working OK
Ned Deily n...@acm.org added the comment:
See also Issue15037 which documents a broken curses.unget_wch and, hence,
test_curses when Python is built with ncurses 5.7 or earlier.
--
___
Python tracker rep...@bugs.python.org
Nicholas Cole nicholas.c...@gmail.com added the comment:
Testing the Python3.3a2 build on OS X - the exception
AttributeError: '_curses.curses window' object has no attribute 'get_wch'
is still being raised. I don't have a Linux build I can easily test with. Is
this a particular problem
STINNER Victor victor.stin...@gmail.com added the comment:
AttributeError: '_curses.curses window' object has no attribute 'get_wch'
is still being raised.
still? Did it work before my last changes?
Unicode functions of the (n)curses library are only available if the Python
curses module
Nicholas Cole nicholas.c...@gmail.com added the comment:
It looks to me as if the documentation in the release candidates for 2.7.3 and
3.2.3 haven't been updated to include the new curses fixes. Is that correct?
--
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
Yes, it was only fixed for 3.3.
--
nosy: +eric.araujo
stage: - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12567
___
Jesús Cea Avión j...@jcea.es added the comment:
Victor, I have these notes I wrote down when I set up the OpenIndiana
buildbots. Maybe can be useful to you: (compiling from source)
* ncurses 5.7: Instalación estándar ./configure --with-shared
--without-normal --enable-widec
STINNER Victor victor.stin...@haypocalc.com added the comment:
I wrote down when I set up the OpenIndiana buildbots
Hum, please use the issue #13552 for curses issues on OpenIndiana/Solaris.
... de funciones: mvwchgat y wchgat
See issues #3786 and #13552 for this problem.
I installed
STINNER Victor victor.stin...@haypocalc.com added the comment:
I am still concerned about the compilation warning in OpenIndiana buildbots
:-(
I'm unable to reproduce the issue in my OpenIndiana VM: the compilaton of the
_curses module fail, not because of Unicode, but because mvwchgat()
STINNER Victor victor.stin...@haypocalc.com added the comment:
The code has been commited. The remaining task is to fix OpenIndiana issues:
see #13552.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12567
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12567
___
Jesús Cea Avión j...@jcea.es added the comment:
I am still concerned about the compilation warning in OpenIndiana buildbots :-(
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12567
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
Compile output on OpenSolaris:
Consider setting $PYTHONHOME to prefix[:exec_prefix]
ld: fatal: file /usr/local/lib/libncursesw.so: wrong ELF class: ELFCLASS32
ld: fatal: file processing errors. No output written to
STINNER Victor victor.stin...@haypocalc.com added the comment:
New changeset bf51e32b2a81 by Victor Stinner in branch 'default':
Issue #13415: test_curses skips unencodable characters
http://hg.python.org/cpython/rev/bf51e32b2a81
(Oops, I copy-pasted the issue number from my previous commit,
STINNER Victor victor.stin...@haypocalc.com added the comment:
New changeset 919259054621 by Victor Stinner in branch 'default':
Issue #13415: Help to locate curses.h when _curses module is linked to ncursesw
http://hg.python.org/cpython/rev/919259054621
(Oops, wrong issue number, again)
STINNER Victor victor.stin...@haypocalc.com added the comment:
This broke several Gentoo buildbots.
setup.py is unable to locate correctly curses.h. I added a hack to always
search in /usr/include/ncursesw/. The hack is needed on Ubuntu 11.10 if you
only have libncursesw5-dev but not
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset c3581ca21a57 by Victor Stinner in branch 'default':
Issue #12567: The curses module uses Unicode functions for Unicode arguments
http://hg.python.org/cpython/rev/c3581ca21a57
--
Antoine Pitrou pit...@free.fr added the comment:
This broke several Gentoo buildbots.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12567
___
Changes by John Feuerstein j...@feurix.com:
--
nosy: +john.feuerstein
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12567
___
___
Python-bugs-list
Changes by Petri Lehtinen pe...@digip.org:
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12567
___
___
Python-bugs-list
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12567
___
___
Python-bugs-list mailing list
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 786668a4fb6b by Victor Stinner in branch 'default':
Issue #12567: Fix curses.unget_wch() tests
http://hg.python.org/cpython/rev/786668a4fb6b
--
___
Python tracker
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset b1e03d10391e by Victor Stinner in branch 'default':
Issue #12567: Add curses.unget_wch() function
http://hg.python.org/cpython/rev/b1e03d10391e
--
___
Python tracker
STINNER Victor victor.stin...@haypocalc.com added the comment:
I'm not sure that it is correct to call nl_langinfo(CODESET) to get the locale
encoding. The LC_CTYPE locale should maybe be set temporary to the current
locale (), as does locale.getpreferredencoding(). Or maybe better,
STINNER Victor victor.stin...@haypocalc.com added the comment:
The LC_CTYPE locale should maybe be set temporary to
the current locale (), as does locale.getpreferredencoding().
See also issue #6203.
--
___
Python tracker rep...@bugs.python.org
STINNER Victor victor.stin...@haypocalc.com added the comment:
what needs to happen for them to move forward?
I would like a review of curses_unicode.patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12567
STINNER Victor victor.stin...@haypocalc.com added the comment:
See also #10570.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12567
___
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset d98b5e0f0862 by Nadeem Vawda in branch 'default':
Fix build error in _curses module when not using libncursesw.
http://hg.python.org/cpython/rev/d98b5e0f0862
--
___
Nadeem Vawda nadeem.va...@gmail.com added the comment:
Following d98b5e0f0862, I have been able to successfully build the curses
module with curses_unicode.patch applied.
--
nosy: +nadeem.vawda
___
Python tracker rep...@bugs.python.org
Nadeem Vawda nadeem.va...@gmail.com added the comment:
Ack sorry, forgot to give context - my machine doesn't have libncursesw,
so the curses module failed to build before that commit (with or without
the patch applied).
--
___
Python tracker
STINNER Victor victor.stin...@haypocalc.com added the comment:
Patch the _curses module to improve Unicode support:
- add an encoding attribute to a window (only visible in C): read the locale
encoding
- encode a character and a character string to the window encoding if the
ncursesw
STINNER Victor victor.stin...@haypocalc.com added the comment:
Using curses_unicode.patch:
- without ncursesw: addch('é') raises an OverflowError because
'é'.encode('UTF-8') is 2 bytes and not 1 byte
- with ncursesw: the charset is displayable character depends on the locale
encoding (e.g.
STINNER Victor victor.stin...@haypocalc.com added the comment:
See also #6755 (curses.get_wch).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12567
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
Oh, by the way: do all platforms have wide character functions? I don't see any
failure on our Python 3.x buildbots, but test_curses is skipped on many
buildbots.
--
___
Python tracker
Nicholas Cole nicholas.c...@gmail.com added the comment:
I think that some platforms do not have wide character support, though I could
be wrong. The FAQ here: http://invisible-island.net/ncurses/ncurses.faq.html
has a list of those that do and those that don't, but I don't know how up to
STINNER Victor victor.stin...@haypocalc.com added the comment:
by the way: do all platforms have wide character functions?
See msg140408 and msg140409: Antoine Pitrou (OS=Mageia 1) and some buildbots
don't have get_wch().
--
___
Python tracker
New submission from STINNER Victor victor.stin...@haypocalc.com:
curses functions accepting strings encode implicitly character strings to
UTF-8. This is wrong. We should add a function to set the encoding (see issue
#6745) or use the wide character C functions. I don't think that UTF-8 is the
STINNER Victor victor.stin...@haypocalc.com added the comment:
getkey.patch fixes window.getkey(): use get_wch() instead of getch() to handle
correctly non-ASCII characters. I tested with the key é (U+00E9) with
ISO-8859-1 and UTF-8 locale encoding: getkey() gives the expected result (but
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12567
___
40 matches
Mail list logo
