Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 21c33aa2178b by Éric Araujo in branch 'default':
Fix missing imports in setup scripts generated by packaging (#13205).
http://hg.python.org/cpython/rev/21c33aa2178b
--
nosy: +python-dev
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 5949563b9f1c by Éric Araujo in branch 'default':
Fix missing imports in generated setup scripts (#13205).
http://hg.python.org/distutils2/rev/5949563b9f1c
New changeset eb845a9a00b7 by Éric Araujo in branch
Éric Araujo mer...@netwok.org added the comment:
As you can see in my commit, I made more changes to the code and simplified the
tests. subprocess is definitely the way to test script functionality, it’s
much cleaner than monkey-patching sys.argv; we even have higher-level helpers
to do that
Éric Araujo mer...@netwok.org added the comment:
Excellent, thanks! I’ll move the tests into the existing test_run.py file.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13205
___
Éric Araujo mer...@netwok.org added the comment:
Thanks! I haven’t tested generate-setup for some time. It would be great to
add a regression test for this. Would you like to do it? To mock user input,
just copy the Inputs class from test_command_register. If not, I will do it.
David Barnett davidbarne...@gmail.com added the comment:
Sure, I can give it a go. I'll probably have a chance sometime today.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13205
___
David Barnett davidbarne...@gmail.com added the comment:
Regression tests. Not positive that subprocess is the best approach for running
these, but it seems to work.
In the process of writing tests, I discovered another missing import for
PackagingFileError when there's no setup.cfg.
New submission from David Barnett davidbarne...@gmail.com:
The setup.py file currently generated by pysetup generate-setup fails to
import the codecs module, and also uses a split_multiline function from
distutils2/utils.py that's undefined in the setup script.
--
assignee: tarek
