[issue13209] Refactor code using unicode_encode_call_errorhandler() in unicodeobject.c
STINNER Victor added the comment: I tried to factorize the code, but it is too complex. Each encoder handles errors differently. The most tricky is charmap: it reencodes the result of the error handler for non-ASCII characters. I'm not happy with the current situtation, but I don't see how to factorize easily the code, so I prefer to leave it unchanged. I close the issue. -- resolution: - wont fix status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13209 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13209] Refactor code using unicode_encode_call_errorhandler() in unicodeobject.c
New submission from STINNER Victor victor.stin...@haypocalc.com: It's difficult to use unicode_encode_call_errorhandler() because the caller has to: - resize the output buffer (and check for integer overflow on the new size) - handle bytes and str for the replacement string: PyUnicode_EncodeDecimal() doesn't support bytes for example - encode replacement str: some encoders uses ASCII, unicode_encode_ucs1() uses Latin1, PyUnicode_EncodeCharmap() uses a recursive call (without check for infinite loop!), ... ; and raise a UnicodeEncodeError if the encoding fails It would be nice to factorize this code. I plan this implement this refactoring, it's just a reminder for me :-) -- components: Unicode messages: 145801 nosy: haypo priority: normal severity: normal status: open title: Refactor code using unicode_encode_call_errorhandler() in unicodeobject.c versions: Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13209 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13209] Refactor code using unicode_encode_call_errorhandler() in unicodeobject.c
Ezio Melotti ezio.melo...@gmail.com added the comment: +1 -- nosy: +ezio.melotti stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13209 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
