[issue16113] Add SHA-3 and SHAKE (Keccak) support

Michał Górny added the comment: Christian, since the code is now integrated in Python 3.6+ (with some bugfixes AFAICS), could you consider updating your bitbucket package to match it? It would be helpful as a backport package for older Python versions. -- nosy: +mgorny

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Roundup Robot added the comment: New changeset e5871ffe9ac0 by Christian Heimes in branch 'default': Issue #16113: SHA3: allocate extra memory for lane extraction and check return value of PyModule_Create() https://hg.python.org/cpython/rev/e5871ffe9ac0 --

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Changes by Christian Heimes : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Roundup Robot added the comment: New changeset ddc95a9bc2e0 by Christian Heimes in branch 'default': Issue #16113: one more C90 violation in big endian code. https://hg.python.org/cpython/rev/ddc95a9bc2e0 -- ___ Python tracker

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Christian Heimes added the comment: A buildbot is complaining about strict aliasing: In file included from /buildbot/buildarea/3.x.ware-gentoo-x86.installed/build/Modules/_sha3/sha3module.c:113:0:

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Roundup Robot added the comment: New changeset 68df416e94ba by Christian Heimes in branch 'default': Issue #16113: take 2 on big endian machines. https://hg.python.org/cpython/rev/68df416e94ba -- ___ Python tracker

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Roundup Robot added the comment: New changeset e8884dcace9f by Christian Heimes in branch 'default': Issue #16113: compile the module on Windows, too. https://hg.python.org/cpython/rev/e8884dcace9f -- ___ Python tracker

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Roundup Robot added the comment: New changeset 4971ca2960c7 by Christian Heimes in branch 'default': Issue #16113: KeccakP-1600-opt64 does not support big endian platforms yet. https://hg.python.org/cpython/rev/4971ca2960c7 -- ___ Python tracker

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Changes by Christian Heimes : -- stage: patch review -> commit review ___ Python tracker ___

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Roundup Robot added the comment: New changeset f8700ee4aef0 by Christian Heimes in branch 'default': Issue #16113: Add SHA-3 and SHAKE support to hashlib module. https://hg.python.org/cpython/rev/f8700ee4aef0 -- ___ Python tracker

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Christian Heimes added the comment: The maintenance burden is minimal. All six algorithms are just variants of the same KeccakP-1600 sponge construction with different initialization parameters for rate, capacity, delimiter and output size. SHAKEs have no default output len and another

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Aaron Gallagher added the comment: I'm not sure why one would pick and choose here—SHAKE is part of the NIST SHA-3 standard. -- ___ Python tracker ___

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Donald Stufft added the comment: > I asked a room full of network engineers about SHAKE and not a single one of > them had heard of it Why would a network engineer know about a new variable length hashing algorithm? It's not really within their problem domain. --

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Raymond Hettinger added the comment: > The SHAKEs were low hanging fruits to implement, so I included them. I don't think this is sufficient motivation. Each new API is a permanent maintenance and documentation burden. It is also a burden to every new user seeing the module and trying to

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Christian Heimes added the comment: Patch 3 addresses GPS' code review. -- Added file: http://bugs.python.org/file44176/SHA3-and-SHAKE-support-for-Python-3.patch ___ Python tracker

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Changes by Christian Heimes : -- assignee: christian.heimes -> ___ Python tracker ___ ___

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Gregory P. Smith added the comment: comments added to the code review. -- ___ Python tracker ___ ___

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Christian Heimes added the comment: New patch: - I moved the test vectors out of the repos. They are currently hosted on github. I'll move them to pythontest infra later. -- Added file: http://bugs.python.org/file43107/SHA3-and-SHAKE-support-for-Python-2.patch

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Changes by englabenny : -- nosy: -englabenny ___ Python tracker ___ ___

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Christian Heimes added the comment: Larry, I'm with Gregory. There is no good reason to add SHA3 to Python 2.7. The SHA-2 family is still safe. Besides I'd rather add BLAKE2 to Python 2.7. It's much faster and more versatile than SHA3. Antoine, SHAKEs are XOF (extensible output function).

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Gregory P. Smith added the comment: I'd there any good reason 2.7 needs this? They are available via pypi as extensions. (Read: I vote no) On Sat, May 7, 2016, 3:15 AM Larry Hastings wrote: > > Larry Hastings added the comment: > > Christian: any interest in proposing

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Larry Hastings added the comment: Christian: any interest in proposing this for 2.7? We could ask Benjamin. It could still make 2.7.11--rc1 should be tagged in about a month. -- ___ Python tracker

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Antoine Pitrou added the comment: Is there any guidance or recommendation on how to use the SHAKE variants? -- ___ Python tracker ___

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Christian Heimes added the comment: This patch implements SHA-3 and SHAKE for Python 3.6. The algorithm is provided by a slightly modified copy of the Keccak Code Package. I had to replace C++ comments and perform some minor cleanups. -- stage: needs patch -> patch review Added file:

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Changes by Christian Heimes : -- hgrepos: -152 ___ Python tracker ___ ___ Python-bugs-list

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Christian Heimes added the comment: The authors of Keccak have released a new version of the Keccak Code Package, http://keccak.noekeon.org/reorganized_code.html . The new package makes it much easier to integrate Keccak in Python. I'm working on a new patch with SHA3 and SHAKE support.