[issue16620] Avoid using private function glob.glob1() in msi module and tools

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Roundup Robot added the comment: New changeset 652a50208e89 by Serhiy Storchaka in branch '3.5': Issue #16620: Fixed AttributeError in msilib.Directory.glob(). https://hg.python.org/cpython/rev/652a50208e89 New changeset 158ae15f5809 by Serhiy Storchaka in branch '2.7': Issue #16620: Fixed

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Changes by Serhiy Storchaka : -- assignee: loewis -> serhiy.storchaka ___ Python tracker ___

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Serhiy Storchaka added the comment: For now there is only one place left that uses glob1(). Here is a patch that inlines glob1() in that place. -- components: -Demos and Tools, Windows stage: needs patch -> patch review versions: +Python 3.6 -Python 3.5 Added file:

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Serhiy Storchaka added the comment: The patch for issue25596 removes glob1(), so we should get rid of its usage. -- priority: low -> normal ___ Python tracker

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: +steve.dower ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16620 ___ ___

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Raymond Hettinger added the comment: Martin, this patch touches some of your code. Do you care to take a look at it? -- assignee: - loewis nosy: +loewis, rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16620

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Mark Lawrence added the comment: Just a reminder that there are comments on Rietveld. -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16620

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Serhiy Storchaka added the comment: I have added some comments on Rietveld. Note that glob.glob() and glob.glob1() returns different filenames. The first returns full paths and the second returns bare filenames without a directory path. Workarounding this may require more in-depth changes to

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Changes by Berker Peksag berker.pek...@gmail.com: -- keywords: +patch nosy: +berker.peksag Added file: http://bugs.python.org/file29263/issue16620.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16620

[issue16620] Avoid using private function glob.glob1() in msi module and tools

New submission from Serhiy Storchaka: Private function glob.glob1() used in Lib/msilib and Tools/msi to prevent unexpected globbing in parent directory name. ``glob.glob1(dirname, pattern)`` should be replaced by ``glob.glob(os.path.join(fnmatch.escape(dirname), pattern)`` in external code.

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Changes by Serhiy Storchaka storch...@gmail.com: -- dependencies: +Add a function to escape metacharacters in glob/fnmatch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16620 ___