[issue1682942] ConfigParser support for alt delimiters

Georg Brandl ge...@python.org added the comment: Looks good to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1682942 ___ ___

[issue1682942] ConfigParser support for alt delimiters

Éric Araujo mer...@netwok.org added the comment: I made some minor remarks on rietveld, it seems they’re saved but no email has come here. -- nosy: +merwok ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1682942

[issue1682942] ConfigParser support for alt delimiters

Éric Araujo mer...@netwok.org added the comment: Ah, the tracker does not know the address I use for Google, sorry. My comments are visible on Rietveld. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1682942

[issue1682942] ConfigParser support for alt delimiters

Changes by Łukasz Langa luk...@langa.pl: Removed file: http://bugs.python.org/file18219/issue1682942.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1682942 ___

[issue1682942] ConfigParser support for alt delimiters

Łukasz Langa luk...@langa.pl added the comment: New patch after review by Éric Araujo. The difference between the last one and the current is cosmetic: --- Lib/configparser.py 2010-07-27 11:36:51.0 +0200 +++ Lib/configparser.py.2 2010-07-28 13:05:39.0 +0200 @@ -117,3

[issue1682942] ConfigParser support for alt delimiters

Éric Araujo mer...@netwok.org added the comment: I advised putting a blankline between the first line of a docstring and the rest of it, not between the docstring and the body of the function. Re. prefix, Wordnet is more precise than Collins here: “an affix that is added in front of the

[issue1682942] ConfigParser support for alt delimiters

Georg Brandl ge...@python.org added the comment: Committed an extensively edited patch in r83202. Thanks all! -- resolution: - accepted status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1682942

[issue1682942] ConfigParser support for alt delimiters

Changes by Łukasz Langa luk...@langa.pl: Removed file: http://bugs.python.org/file18216/issue1682942.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1682942 ___

[issue1682942] ConfigParser support for alt delimiters

Łukasz Langa luk...@langa.pl added the comment: Updated the patch after review by Brian Curtin and Alexander Belopolsky. All remarks addressed, I think it's ready for inclusion. -- Added file: http://bugs.python.org/file18219/issue1682942.diff ___

[issue1682942] ConfigParser support for alt delimiters

Michael Foord mich...@voidspace.org.uk added the comment: This would change the format of config files that configparser supports. Should there be some discussion of this on python-dev first? The patch for the docs is against the latex docs, so definitely needs updating. -- nosy:

[issue1682942] ConfigParser support for alt delimiters

Changes by Brian Curtin cur...@acm.org: -- nosy: +brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1682942 ___ ___ Python-bugs-list

[issue1682942] ConfigParser support for alt delimiters

Łukasz Langa luk...@langa.pl added the comment: The original patch was of no use because didn't let users specify multicharacter delimiters and comment delimiters. The main goal behind the implementation was making monstrosities like the Samba configuration file work. This is why a sample

[issue1682942] ConfigParser support for alt delimiters

Changes by Łukasz Langa luk...@langa.pl: -- nosy: +georg.brandl Added file: http://bugs.python.org/file18215/cfgparser.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1682942 ___

[issue1682942] ConfigParser support for alt delimiters

Changes by Łukasz Langa luk...@langa.pl: Removed file: http://bugs.python.org/file18214/issue1682942.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1682942 ___

[issue1682942] ConfigParser support for alt delimiters

Łukasz Langa luk...@langa.pl added the comment: Updated the patch after review by Georg Brandl. This version includes documentation updates as well. -- Added file: http://bugs.python.org/file18216/issue1682942.diff ___ Python tracker

[issue1682942] ConfigParser support for alt delimiters

Brian Curtin cur...@acm.org added the comment: I uploaded the current patch to Rietveld and reviewed it there, CC'ed Łukasz. http://codereview.appspot.com/1848051/show is the link. I only gave the tests a once-over since they failed for not having the test file Łukasz meant to include. I'll

[issue1682942] ConfigParser support for alt delimiters

Mark Lawrence breamore...@yahoo.co.uk added the comment: Łukasz please attach your patch and I'll run with it, while you're at it could you also provide a unit test patch for #5412, thanks. -- ___ Python tracker rep...@bugs.python.org

[issue1682942] ConfigParser support for alt delimiters

Łukasz Langa luk...@langa.pl added the comment: Part of the patch has already been independently implemented (support for custom `dict_type`s). As for the custom delimiters the patch is somewhat incomplete. Let's take for instance delimiting by space characters (e.g. `delimiters = ( , )`).

[issue1682942] ConfigParser support for alt delimiters

Mark Lawrence breamore...@yahoo.co.uk added the comment: Could the patch be reworked for 3.2? -- nosy: +BreamoreBoy versions: +Python 3.2 -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1682942

[issue1682942] ConfigParser support for alt delimiters

Tres Seaver tsea...@agendaless.com added the comment: I'm afraid the patch no longer applies cleanly to the trunk, although at least updating the docs should be easier now that they are converted to ReStructuredText. The tests in the patch for the new feature seem sensible. -- nosy:

[issue1682942] ConfigParser support for alt delimiters

Changes by Daniel Diniz aja...@gmail.com: -- stage: - patch review type: - feature request versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1682942 ___