[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Nick Coghlan]

Nick Coghlan  added the comment:

Just noting for the record that the reason a new warning wasn't needed here is 
because there is already a general "No compatibility guarantees" warning for 
the entire test package: https://docs.python.org/3/library/test.html

Thanks for getting this resolved!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Stéphane Wirtel]

Change by Stéphane Wirtel :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9 -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:


New changeset 92777d5e5aed1753bafe07265dbe98b2d271815b by Stéphane Wirtel 
(Joannah Nanjekye) in branch 'master':
bpo-18578: Rename and document test.bytecode_helper as 
test.support.bytecode_helper (GH-15168)
https://github.com/python/cpython/commit/92777d5e5aed1753bafe07265dbe98b2d271815b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:

Other discussion with Zach, and at the end, there is no problem to merge your 
PR.

Thank you for your contribution

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:

I wanted to merge the PR of Joannah but I have a question, are you sure that 
there is nobody using this module. Maybe we could add a warning when a user 
tries to use the module/function with a DeprecationWarning.

Could we have a wrapper raising the warning when we call it and redirect to the 
new function?

Thank you

--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Joannah Nanjekye]

Change by Joannah Nanjekye :


--
pull_requests: +14900
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15168

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Cheryl Sabella]

Cheryl Sabella  added the comment:

@seydou, would you be interested in making a GitHub pull request for your patch?

--
assignee:  -> docs@python
components: +Documentation, Tests
nosy: +cheryl.sabella, docs@python
stage:  -> needs patch
type:  -> enhancement
versions: +Python 3.8 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Nick Coghlan]

Changes by Nick Coghlan :


--
assignee: ncoghlan -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Nick Coghlan]

Changes by Nick Coghlan :


--
assignee:  -> ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Seydou Dia]

Seydou Dia added the comment:

I have a hard time figuring out what exactly BytecodeTestCase methods actually 
do. Thus the documentation is not probably accurate.

--
keywords: +patch
Added file: http://bugs.python.org/file31247/issue-18578.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Seydou Dia]

Seydou Dia added the comment:

I am working on a patch.

--
nosy: +seydou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Nick Coghlan]

Changes by Nick Coghlan :


--
assignee: ncoghlan -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

[Nick Coghlan]

New submission from Nick Coghlan:

test.bytecode_helper provides various utilities for sensibly testing bytecode 
generation. It isn't easy for CPython developers to discover, since it isn't 
documented and the file is mixed in with actual tests in the main test 
directory.

As discussed in #15494, it should be:

1. Moved from Lib/test/ to Lib/test/support (and imports in tests adjusted 
accordingly)
2. Documented in Doc/library/test.rst

This change only affects the default branch (since test.bytecode_helper is new 
in 3.4)

--
assignee: ncoghlan
messages: 193821
nosy: ncoghlan
priority: normal
severity: normal
status: open
title: Rename and document test.bytecode_helper as test.support.bytecode_helper
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com