[issue18819] tarfile fills devmajor and devminor fields even for non-devices

Change by Ethan Furman : -- resolution: -> fixed stage: test needed -> resolved status: open -> closed ___ Python tracker ___ ___

[issue18819] tarfile fills devmajor and devminor fields even for non-devices

Ethan Furman added the comment: New changeset 674935b8caf33e47c78f1b8e197b1b77a04992d2 by William Chargin in branch 'master': bpo-18819: tarfile: only set device fields for device files (GH-18080) https://github.com/python/cpython/commit/674935b8caf33e47c78f1b8e197b1b77a04992d2 --

[issue18819] tarfile fills devmajor and devminor fields even for non-devices

William Chargin added the comment: My pleasure. Is there anything else that you need from me to close this out? It looks like the PR is approved and in an “awaiting merge” state, but I don’t have access to merge it. -- ___ Python tracker

[issue18819] tarfile fills devmajor and devminor fields even for non-devices

Ethan Furman added the comment: Thanks for moving this issue forward, William! -- assignee: -> ethan.furman stage: patch review -> test needed ___ Python tracker ___

[issue18819] tarfile fills devmajor and devminor fields even for non-devices

Change by Ned Deily : -- nosy: +ethan.furman versions: -Python 2.7, Python 3.3, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8 ___ Python tracker ___

[issue18819] tarfile fills devmajor and devminor fields even for non-devices

William Chargin added the comment: I've just independently run into this and sent a patch as a pull request. Happily, once this is fixed, the output of `tarfile` is bit-for-bit compatible with the output of GNU `tar(1)`. PR: -- nosy:

[issue18819] tarfile fills devmajor and devminor fields even for non-devices

Change by William Chargin : -- versions: +Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker ___ ___

[issue18819] tarfile fills devmajor and devminor fields even for non-devices

Change by William Chargin : -- pull_requests: +17472 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18080 ___ Python tracker ___

[issue18819] tarfile fills devmajor and devminor fields even for non-devices

Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +lars.gustaebel versions: -Python 2.6, Python 3.1, Python 3.2, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18819 ___

[issue18819] tarfile fills devmajor and devminor fields even for non-devices

New submission from Nuutti Kotivuori: when tarfile generates a tar, it uses TarInfo objects which are packed to the binary format. This packing uses itn format for filling the devmajor and devminor fields of the tar file entry, with a default value of zero. The field length is 8 characters,