[issue19683] test_minidom has many empty tests

Change by karl : -- pull_requests: +22980 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/24152 ___ Python tracker ___

[issue19683] test_minidom has many empty tests

karl added the comment: Ah no. They ARE used through defproperty and minicompat.py get = getattr(klass, ("_get_" + name)) -- ___ Python tracker ___

[issue19683] test_minidom has many empty tests

karl added the comment: These methods are not used anywhere in the code. https://github.com/python/cpython/blob/5c30145afb6053998e3518befff638d207047f00/Lib/xml/dom/minidom.py#L71-L80 What was the purpose when they were created… hmm maybe blame would give clue. Ah they were added a long

[issue19683] test_minidom has many empty tests

karl added the comment: @zach.ware @r.david.murray I'm going through the source currently. I see that the test file is using: class MinidomTest(unittest.TestCase): def confirm(self, test, testname = "Test"): self.assertTrue(test, testname) Is there a specific reason to use

[issue19683] test_minidom has many empty tests

Change by Mark Dickinson : -- nosy: -mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19683] test_minidom has many empty tests

karl added the comment: err… Errata on my previous comment. """ Simple implementation of the Level 1 DOM. Namespaces and other minor Level 2 features are also supported. """ https://github.com/python/cpython/blob/c65119d5bfded03f80a9805889391b66fa7bf551/Lib/xml/dom/minidom.py#L1-L3

[issue19683] test_minidom has many empty tests

karl added the comment: @zach.ware @r.david.murray So I was looking at that issue. There is a lot of work. I had a couple of questions, because there are different categories # Empty tests for existing functions. This seems to be straightforward as they would complete the module.

[issue19683] test_minidom has many empty tests

Roundup Robot added the comment: New changeset fed468670866 by Mark Dickinson in branch '2.7': Issue #19683: Add __closure__ and other missing attributes to function docs. http://hg.python.org/cpython/rev/fed468670866 -- ___ Python tracker

[issue19683] test_minidom has many empty tests

Mark Dickinson added the comment: Whoops; wrong issue number. That commit message was for issue 19863. -- nosy: +mark.dickinson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683 ___

[issue19683] test_minidom has many empty tests

Zachary Ware added the comment: Some refactoring of the tests is certainly acceptable. If there are some tests that can be merged together, it is fine to do so; also for removing ones that don't make any sense (it's not like they've ever tested anything anyway :)). We don't have anyone

[issue19683] test_minidom has many empty tests

Julian Gindi added the comment: Modernizing these tests will be a decent undertaking but seems important. I'll go a head and try to fix these up further. Thanks for the guidance and motivation on this one :) -- ___ Python tracker

[issue19683] test_minidom has many empty tests

Julian Gindi added the comment: So, it seems that there are many seemingly redundant tests and many tests whose intentions are unclear. I think this might be better suited for someone who has more experience with the xml minidom module. I have uploaded the work I have done but it is not

[issue19683] test_minidom has many empty tests

Roundup Robot added the comment: New changeset 2737c0e7ba71 by Zachary Ware in branch '2.7': Issue #19683: Removed empty tests from test_minidom. http://hg.python.org/cpython/rev/2737c0e7ba71 New changeset 5e510117b71a by Zachary Ware in branch '3.3': Issue #19683: Removed empty tests from

[issue19683] test_minidom has many empty tests

Zachary Ware added the comment: Thanks for the removal patch, Ajitesh! Julian, are you still working on implementing the tests on default? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683

[issue19683] test_minidom has many empty tests

Julian Gindi added the comment: I have not started yet, wasn't completely sure of the status of this. I'll get going filling in those tests to the best of my ability. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683

[issue19683] test_minidom has many empty tests

Zachary Ware added the comment: Alright, sounds good. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683 ___ ___ Python-bugs-list mailing list

[issue19683] test_minidom has many empty tests

Changes by Zachary Ware zachary.w...@gmail.com: -- versions: +Python 3.4 -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683 ___ ___

[issue19683] test_minidom has many empty tests

Julian Gindi added the comment: I agree that they should be implemented. I'll fill them in and submit a patch in a day or so. -- nosy: +Julian.Gindi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683

[issue19683] test_minidom has many empty tests

Serhiy Storchaka added the comment: Rather than removing these empty tests it will be better implement them. Otherwise we can accidentally break the code. I see a lot of empty tests on 3.x. -- nosy: +serhiy.storchaka ___ Python tracker

[issue19683] test_minidom has many empty tests

R. David Murray added the comment: On tip it would indeed be better to implement them. The deletion is only for the released branches. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683

[issue19683] test_minidom has many empty tests

Ajitesh Gupta added the comment: I have attached a patch. I deleted all the empty tests. -- keywords: +patch nosy: +ajitesh.gupta Added file: http://bugs.python.org/file32901/issue19683.patch ___ Python tracker rep...@bugs.python.org

[issue19683] test_minidom has many empty tests

New submission from Zachary Ware: Many of the tests in test_minidom on 2.7 are empty, that is they are defined as def testSomeFunction(self): pass. I've marked this issue as easy since I suspect a lot of the tests can be either backported from 3.x, or removed if they don't exist in 3.x.

[issue19683] test_minidom has many empty tests

R. David Murray added the comment: Well, we generally don't backport tests unless we are fixing related bugs. I think this should be left alone. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683

[issue19683] test_minidom has many empty tests

Zachary Ware added the comment: In that case, the empty tests should be removed, since they currently report success on doing nothing. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683