Martin Panter added the comment:
I think it might be better to leave the platform-specific details in the full
Popen description, not under Frequently Used Arguments. I suggest to use
20344_4.patch:
* Move existing pointer to Popen constructor details up to top of section
* Explain the
Martin Panter added the comment:
Actually David I didn’t notice your suggested wording
https://bugs.python.org/issue20344#msg214364 before. Adding that last
sentence, pointing to the full description of the Popen constructor, would be
fine.
My complaint about mentioning “iterable” is that
R. David Murray added the comment:
Can you suggest a better phrasing that is still succinct? (Maybe just 'appear
to be executed' would make it accurate enough?) But, that's why there needs to
be a reference of *some* sort to the full explanation.
I'm not sure what the issue is with
Martin Panter added the comment:
“Only the first element . . . will be executed on Unix” is a bit simplistic.
The behaviour is already described more fully in the “shell” documentation
under https://docs.python.org/dev/library/subprocess.html#subprocess.Popen.
Also, “args” is allowed to be a
Tobias Klausmann added the comment:
Hi!
On Tue, 25 Mar 2014, Tuomas Savolainen wrote:
Created a patch that adds notice of using shell=True and iterable to the
documentation. Please do comment if the formatting is wrong (this my first
documentation patch).
I'd use articles, i.e. and a
R. David Murray added the comment:
Also, the see below sentence is missing.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20344
___
___
Tuomas Savolainen added the comment:
Corrected the spelling of the patch.
--
Added file: http://bugs.python.org/file34635/20344_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20344
Tuomas Savolainen added the comment:
Created a patch that adds notice of using shell=True and iterable to the
documentation. Please do comment if the formatting is wrong (this my first
documentation patch).
--
Added file: http://bugs.python.org/file34619/documentation20344.patch
Tuomas Savolainen added the comment:
Made a patch that throws exception as suggested:
3- Make check_output() throw an Exception if the first argument is a list and
shell=True
--
keywords: +patch
nosy: +Tuomas.Savolainen
Added file: http://bugs.python.org/file34543/issue20344.patch
R. David Murray added the comment:
Thanks Tuomas, but we don't have any consensus that that kind of change will be
accepted. It's just my opinion that it should be...and if it was, it would
have to start with a deprecation, not raising an exception.
What we need as a patch for this issue is
New submission from Tobias Klausmann:
The subprocess docs state that the first argument can be either a string or an
iterable that contains the program and arguments to run. It also points out
that using shell=True allows for shell constructs. It does not mention a
subtlety that is introduced
R. David Murray added the comment:
This was discussed in issue 6760. There I advocated (and still advocate)
option (3). Unfortunately it looks like our doc update in that issue actually
*lost* the documentation for your option (2) that used to be there, though it
wasn't exactly clear what
12 matches
Mail list logo
