[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Changes by Donald Stufft : -- pull_requests: +958 ___ Python tracker ___ ___

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Zachary Ware added the comment: Thanks for the patch again :). The last idea you mentioned sounds somewhat interesting, please open a new issue for it if you'd like to pursue it. -- ___ Python tracker

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Roundup Robot added the comment: New changeset c4eb211fb38b by Zachary Ware in branch 'default': Closes #21124, #28337: Call PyType_Ready on unpackiter_type. https://hg.python.org/cpython/rev/c4eb211fb38b -- resolution: -> fixed stage: -> resolved status: open -> closed

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Masayuki Yamamoto added the comment: unpack_iterator type has not been registered into _struct module. And all users get only unpack_iterator object from function returning iterator. The object iterating doesn't need reference to type. Therefore, I think issue finish by PyType_Ready fix

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Zachary Ware added the comment: Do we not have a unit test for that? -- ___ Python tracker ___ ___

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Masayuki Yamamoto added the comment: I wrote a patch to add the unpackiter_type initialization into PyInit__struct function. I has confirmed solve #28337 on ubuntu x86 16.04. -- nosy: +masamoto Added file: http://bugs.python.org/file44929/PyType_Ready-unpackiter_type.patch

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Serhiy Storchaka added the comment: PyType_Ready() should be called for unpackiter_type. See also issue26906. -- nosy: +serhiy.storchaka resolution: fixed -> stage: resolved -> status: closed -> open ___ Python tracker

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Zachary Ware added the comment: For future reference, having a patch attached to the issue does not mean the issue is fixed, and it should not be closed. -- nosy: +zach.ware stage: -> resolved type: -> compile error versions: +Python 3.7 -Python 3.4

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Roundup Robot added the comment: New changeset 3bde312ae936 by Zachary Ware in branch 'default': Issue #21124: Fix building _struct on Cygwin. https://hg.python.org/cpython/rev/3bde312ae936 -- nosy: +python-dev ___ Python tracker

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

dellair jie added the comment: Fixed with the patch. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21124 ___

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

dellair jie added the comment: Hello masamoto, The patch you provided works quite well. The build passed and Python calls are successfully. Please let me know what else you need me to test in order to have the patch accepted or else feel free to close it with Resolution Fixed. Thanks, Dellair

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Masayuki Yamamoto added the comment: I have solved about compiling _struct module too. I have no authority of this issues, So please close of issues. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21124

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Changes by Masayuki Yamamoto light2happy@gmail.com: -- nosy: -masamoto ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21124 ___ ___

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Changes by Ned Deily n...@acm.org: -- nosy: -ned.deily resolution: duplicate - stage: committed/rejected - superseder: Add Mingw recognition to pyport.h to allow building extensions - ___ Python tracker rep...@bugs.python.org

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

dellair jie added the comment: Neil, It doesn't look like a duplicate of Issue6672. The one in Issue6672 was for Mingw, all the patches simply added __MINGW32__ to __CYGWIN__ build structure. While my issue is, the build failed with _struct.c on Cygwin. So the module is recognized, just

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Masayuki Yamamoto added the comment: I wrote a patch file. In other extention module source codes, global variable PyTypeObject has initialized to using PyVarObject_HEAD_INIT(NULL, 0). And so, as with other modules, I tried to edit and compiling _struct.c in Cygwin 1.7.28. The module compiling

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

dellair jie added the comment: Yamamoto, Thanks, the patch you offered did make the _struct error disappeared. I will do a bit more testing. Dellair -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21124

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

Ned Deily added the comment: This looks like a duplicate of Issue6672. -- components: +Build nosy: +ned.deily resolution: - duplicate stage: - committed/rejected status: open - pending superseder: - Add Mingw recognition to pyport.h to allow building extensions title: Compilation