[issue21566] make use of the new default socket.listen() backlog argument
Yury Selivanov added the comment: Guys, when you update asyncio code, please make sure you sync your changes with its upstream here: https://code.google.com/p/tulip/ to avoid commits like this 5f001ad90373 The goal is to have single source base for 3.4 and 3.5 in cpython repo and for 3.3 in tulip repo, to simplify syncing updates between them. -- nosy: +yselivanov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21566] make use of the new default socket.listen() backlog argument
Roundup Robot added the comment: New changeset f7643c893587 by Charles-François Natali in branch 'default': Issue #21566: Make use of socket.listen() default backlog. http://hg.python.org/cpython/rev/f7643c893587 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21566] make use of the new default socket.listen() backlog argument
Charles-François Natali added the comment: Committed, thanks for the reviews (I only updated one call to socket.listen(), inside multiprocessing, the rest is in the test suite). -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21566] make use of the new default socket.listen() backlog argument
New submission from Charles-François Natali: Follow-up to issue #21455: we can now update the stdlib to rely on the default socket listen backlog, instead of having a bazillion different values (which range from 1 to 100!). -- components: Library (Lib) files: use_socket_listen_backlog.diff keywords: needs review, patch messages: 219005 nosy: haypo, neologix, pitrou, sbt priority: normal severity: normal stage: patch review status: open title: make use of the new default socket.listen() backlog argument type: enhancement versions: Python 3.5 Added file: http://bugs.python.org/file35332/use_socket_listen_backlog.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21566] make use of the new default socket.listen() backlog argument
Antoine Pitrou added the comment: This looks fine to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21566] make use of the new default socket.listen() backlog argument
STINNER Victor added the comment: Maybe we should keep listen(1) in some cases. For socketpair() of asyncio.windows_utils, it makes sense to use sock.listen(1) since we expect exactly one request from one client. The listening socket is closed just after sock.accept(). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21566] make use of the new default socket.listen() backlog argument
Charles-François Natali added the comment: Maybe we should keep listen(1) in some cases. For socketpair() of asyncio.windows_utils, it makes sense to use sock.listen(1) since we expect exactly one request from one client. The listening socket is closed just after sock.accept(). Yeah, I thought about that, but almost all operating systems don't strictly respect the backlog, they always increase it a bit, so this wouldn't change much. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
