[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Ned Deily]

Ned Deily  added the comment:


New changeset 2a405598bbccbc42710dc5ecf3d44c8de4c16582 by Ned Deily (Abhilash 
Raj) in branch '3.7':
[3.7] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper 
parsing of URLs (GH-15685)" (GH-16724) (GH-16727)
https://github.com/python/cpython/commit/2a405598bbccbc42710dc5ecf3d44c8de4c16582


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[STINNER Victor]

Change by STINNER Victor :


--
nosy:  -vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[miss-islington]

miss-islington  added the comment:


New changeset 164bee296ab1f87cc05566b39ee8fb9fb64b3e5a by Miss Islington (bot) 
(Abhilash Raj) in branch '3.7':
[3.7] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper 
parsing of URLs (GH-15685)" (GH-16724) (GH-16727)
https://github.com/python/cpython/commit/164bee296ab1f87cc05566b39ee8fb9fb64b3e5a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Abhilash Raj]

Abhilash Raj  added the comment:


New changeset 5a638a805503131f4a9cc2bbc5944611295c1500 by Abhilash Raj in 
branch '3.8':
[3.8] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper 
parsing of URLs" (GH-16724) (GH-16728)
https://github.com/python/cpython/commit/5a638a805503131f4a9cc2bbc5944611295c1500


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Abhilash Raj]

Abhilash Raj  added the comment:

I am going to re-open this since the fixes were reverted in all the branches.

--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Abhilash Raj]

Change by Abhilash Raj :


--
pull_requests: +16310
pull_request: https://github.com/python/cpython/pull/16728

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Abhilash Raj]

Change by Abhilash Raj :


--
pull_requests: +16307
pull_request: https://github.com/python/cpython/pull/16727

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[miss-islington]

Change by miss-islington :


--
pull_requests: +16305
pull_request: https://github.com/python/cpython/pull/16725

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[miss-islington]

miss-islington  added the comment:


New changeset 19a3d873005e5730eeabdc394c961e93f2ec02f0 by Miss Islington (bot) 
(Abhilash Raj) in branch 'master':
bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing 
of URLs (GH-15522)" (GH-16724)
https://github.com/python/cpython/commit/19a3d873005e5730eeabdc394c961e93f2ec02f0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Abhilash Raj]

Change by Abhilash Raj :


--
pull_requests: +16303
pull_request: https://github.com/python/cpython/pull/16724

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Ned Deily]

Ned Deily  added the comment:

This change introduces a potential 3.7 regression; see Issue38449.

--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Dong-hee Na]

Change by Dong-hee Na :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Dong-hee Na]

Change by Dong-hee Na :


--
stage: patch review -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Dong-hee Na]

Dong-hee Na  added the comment:

Great! I will close bpo-35939 also.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Abhilash Raj]

Abhilash Raj  added the comment:

I think so, yes.

Also, while you are at it, can you also close bpo-35939 with a comment that 
points to this issue and the right PR for the fix?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Dong-hee Na]

Dong-hee Na  added the comment:

@vstinner(my mentor) @maxking
Now this issue is solved.
I'd like to close this issue. Is it okay?

--
nosy: +maxking, vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[miss-islington]

miss-islington  added the comment:


New changeset 8873bff2871078e9f23e6c7d942d3a8edbd0921f by Miss Islington (bot) 
(Dong-hee Na) in branch '3.7':
[3.7] bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs 
(GH-15522) (GH-15687)
https://github.com/python/cpython/commit/8873bff2871078e9f23e6c7d942d3a8edbd0921f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[miss-islington]

miss-islington  added the comment:


New changeset 6d7a786d2e4b48a6b50614e042ace9ff996f0238 by Miss Islington (bot) 
in branch '3.8':
bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs 
(GH-15522)
https://github.com/python/cpython/commit/6d7a786d2e4b48a6b50614e042ace9ff996f0238


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Dong-hee Na]

Change by Dong-hee Na :


--
pull_requests: +15345
pull_request: https://github.com/python/cpython/pull/15687

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[miss-islington]

Change by miss-islington :


--
pull_requests: +15343
pull_request: https://github.com/python/cpython/pull/15685

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[miss-islington]

miss-islington  added the comment:


New changeset 87bd2071c756188b6cd577889fb1682831142ceb by Miss Islington (bot) 
(Dong-hee Na) in branch 'master':
bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs 
(GH-15522)
https://github.com/python/cpython/commit/87bd2071c756188b6cd577889fb1682831142ceb


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Dong-hee Na]

Change by Dong-hee Na :


--
pull_requests: +15206
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15522

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Dong-hee Na]

Change by Dong-hee Na :


--
versions: +Python 3.7, Python 3.8 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Dong-hee Na]

Dong-hee Na  added the comment:

The proposed patch I mentioned on bpo-35939 also solve the above situation.

Python 3.8.0a1+ (heads/bpo-12317:96d37dbcd2, Feb  8 2019, 12:03:40)
[Clang 9.1.0 (clang-902.0.39.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import mimetypes
>>> mimetypes.guess_type("http://example.com;)
(None, None)
>>> mimetypes.guess_type("example.com")
('application/x-msdownload', None)
>>>

I've also added the unit tests of mimetypes-host.patch. It works well.
I think that we close this issue also when the bpo-35939 is closed.

Thanks alot!

--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

[Martin Panter]

Change by Martin Panter :


--
dependencies: +Remove urllib.parse._splittype from mimetypes.guess_type

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22347] mimetypes.guess_type(//example.com) misinterprets host name as file name

[Martin Panter]

New submission from Martin Panter:

The documentation says that guess_type() takes a URL, but:

 mimetypes.guess_type(http://example.com;)
('application/x-msdownload', None)

I suspect the MS download is a reference to *.com files (like DOS's 
command.com). My current workaround is to strip out the host name from the URL, 
since I cannot imagine it would be useful for determining the content type. I 
am also stripping the fragment part. An argument could probably be made for 
stripping the “;parameters” and “?query” parts as well.

 # Workaround for mimetypes.guess_type(//example.com)
... # interpreting host name as file name
... url = urlparse(http://example.com;)
 url = net.url_replace(url, netloc=, fragment=)
 url
'http://'
 mimetypes.guess_type(url, strict=False)
(None, None)

--
components: Library (Lib)
messages: 226467
nosy: vadmium
priority: normal
severity: normal
status: open
title: mimetypes.guess_type(//example.com) misinterprets host name as file 
name
type: behavior
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22347
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com