[issue23319] Missing SWAP_INT in I_set_sw

[Meador Inge]

Meador Inge added the comment:

Thanks for committing this Victor.  The patch looked good to me too.  Sorry for 
not getting around to update the tracker.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23319] Missing SWAP_INT in I_set_sw

[Roundup Robot]

Roundup Robot added the comment:

New changeset 12b353f76447 by Victor Stinner in branch '2.7':
Issue #23319: Add Matthieu Gautier to Misc/ACKS
https://hg.python.org/cpython/rev/12b353f76447

New changeset 3caa68f55e3e by Victor Stinner in branch '3.4':
Issue #23319: Add Matthieu Gautier to Misc/ACKS
https://hg.python.org/cpython/rev/3caa68f55e3e

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23319] Missing SWAP_INT in I_set_sw

[STINNER Victor]

STINNER Victor added the comment:

Thanks for your report, patch and unit test Matthieu. I rewrote the unit test 
because your layout was too complex for my little brain :-) I also write a unit 
test for little endian. I applied your fix to Python 2.7, 3.4, 3.5 and 3.6.

--
nosy: +haypo
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23319] Missing SWAP_INT in I_set_sw

[Roundup Robot]

Roundup Robot added the comment:

New changeset 88f2c4f12b56 by Victor Stinner in branch '2.7':
Issue #23319: Fix ctypes.BigEndianStructure, swap correctly bytes. Patch
https://hg.python.org/cpython/rev/88f2c4f12b56

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23319] Missing SWAP_INT in I_set_sw

[Roundup Robot]

Roundup Robot added the comment:

New changeset 935ae7f001e3 by Victor Stinner in branch '3.4':
Issue #23319: Fix ctypes.BigEndianStructure, swap correctly bytes. Patch
https://hg.python.org/cpython/rev/935ae7f001e3

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23319] Missing SWAP_INT in I_set_sw

[Matthieu Gautier]

Matthieu Gautier added the comment:

The bug is also present in Python 2.7.

Is it possible to backport this fix ?

--
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23319] Missing SWAP_INT in I_set_sw

[Meador Inge]

Meador Inge added the comment:

I will review this today.

--
assignee:  -> meador.inge
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23319] Missing SWAP_INT in I_set_sw

[Matthieu Gautier]

Changes by Matthieu Gautier :


--
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23319] Missing SWAP_INT in I_set_sw

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +amaury.forgeotdarc, belopolsky, meador.inge

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23319] Missing SWAP_INT in I_set_sw

[Matthieu Gautier]

Matthieu Gautier added the comment:

A little ping.

With a new patch integrating the unit test.

--
Added file: http://bugs.python.org/file39800/ctypes_swap_uint_unittest.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23319] Missing SWAP_INT in I_set_sw

[Matthieu Gautier]

New submission from Matthieu Gautier:

I_set_sw function is missing a SWAP_INT.

This leads to wrong set of bitfield value.

Here is a script to reproduce:

--
from ctypes import *

class HEADER(BigEndianStructure):
   _fields_ = ( ('pad', c_uint32, 16),
('v1', c_uint32, 4),
('v2', c_uint32, 12)
  )

b = bytearray(4)
header = HEADER.from_buffer(b)

header.type = 1
assert b == b'\x00\x00\x10\x00'

header.mode = 0x234
assert b == b'\x00\x00\x12\x34'
--

--
components: ctypes
files: ctypes_swap_uint.patch
keywords: patch
messages: 234682
nosy: mgautierfr
priority: normal
severity: normal
status: open
title: Missing SWAP_INT in I_set_sw
type: behavior
versions: Python 3.4
Added file: http://bugs.python.org/file37856/ctypes_swap_uint.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com