[issue24241] webbrowser default browser detection and/or public API for _trylist.

[Berker Peksag]

Change by Berker Peksag :


--
pull_requests:  -1099

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[STINNER Victor]

STINNER Victor  added the comment:

It seems like this issue introduced a regression: bpo-33693.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +1099

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[Nick Coghlan]

Nick Coghlan added the comment:


New changeset e3ce69522ffd7c0354d6e70d18f42bce325ed97e by Nick Coghlan (David 
Steele) in branch 'master':
bpo-24241: Improve preferred webbrowser handling (#85)
https://github.com/python/cpython/commit/e3ce69522ffd7c0354d6e70d18f42bce325ed97e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[Nick Coghlan]

Nick Coghlan added the comment:


New changeset 56a8eccc43c66ae51c5a6bfc89635b1998fd419e by Nick Coghlan in 
branch 'master':
bpo-24241: Add dedicated webbrowser.register test case (#288)
https://github.com/python/cpython/commit/56a8eccc43c66ae51c5a6bfc89635b1998fd419e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[Berker Peksag]

Berker Peksag added the comment:


New changeset 370f7a956cef5895c93ca5a53fc26b04df973aaf by Berker Peksag in 
branch 'master':
bpo-24241: Add versionchanged directive to the documentation (#342)
https://github.com/python/cpython/commit/370f7a956cef5895c93ca5a53fc26b04df973aaf


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[Berker Peksag]

Changes by Berker Peksag :


--
pull_requests: +296

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[Nick Coghlan]

Nick Coghlan added the comment:

Second PR merged with the missing test case.

--
stage: test needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[Nick Coghlan]

Changes by Nick Coghlan :


--
pull_requests: +258

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[Nick Coghlan]

Changes by Nick Coghlan :


--
assignee:  -> ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[Nick Coghlan]

Nick Coghlan added the comment:

After merging this, I belatedly realised that codecov's complaint about the 
lack of code coverage for the diff was actually valid: now that "preferred" is 
a public API, it should have a cross-platform test case.

That should be a fairly straightforward test to write, as it can just use an 
arbitrary string, and then poke around in _tryorder directly to make sure it is 
updated as expected - it doesn't need to use a valid browser reference.

--
stage: resolved -> test needed
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[Nick Coghlan]

Nick Coghlan added the comment:

To summarise the changes that were made during the PR review, here's the 
eventual commit message for the merged PR:


 bpo-24241: Improve preferred webbrowser handling (#85)

- Add 'preferred' argument to webbrowser.register
- Use xdg-settings to specify preferred X browser

The first change replaces the existing undocumented tri-state
'try_order' parameter with the documented boolean keyword-only
'preferred' parameter. Setting it to True places the browser at the
front of the list, preferring it as the return to a subsequent get() call.

The second change adds a private `_os_preferred_browser` setting
and then uses that to make the default browser reported by
`xdg-settings` first in the try list when running under X (or
another environment that sets the `DISPLAY` variable).
This avoids the problem where the first entry in the tryorder
queue otherwise defaults to xdg-open, which doesn't support
the "new window" option.


--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[Nick Coghlan]

Changes by Nick Coghlan :


--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[David Steele]

David Steele added the comment:

Jaysinh,

Thanks for the feedback. I'm adding the documentation now.

As I noted in github, I'm not sure what the preferred exception handling would 
be for xdg-settings.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[Jaysinh shukla]

Jaysinh shukla added the comment:

Hello David,
I hope you are still working on https://github.com/python/cpython/pull/85 I 
tried to add few suggestions. Please write back on any confusions. Thanks!

--
nosy: +jaysinh.shukla

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[David Steele]

Changes by David Steele :


--
pull_requests: +123

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[David Steele]

David Steele added the comment:

See https://github.com/python/cpython/pull/85

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[David Steele]

David Steele added the comment:

Patch attached, to sort the desktop default browser to the top of _tryorder.

--
keywords: +patch
Added file: http://bugs.python.org/file39940/preferredbrowser.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24241
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[David Steele]

David Steele added the comment:

On Tue, May 19, 2015 at 10:19 AM, R. David Murray
rep...@bugs.python.org wrote:
...
 Would you like to propose a patch?

My preferred solution would be a bit intrusive - check for and use
xdg-settings or gi.repository.Gio to identify the default browser, and
match the result against the type list. I'm not sure that would get
approval, nor am I sure of the best standard-library-compliant way to
go about it.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24241
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24241] webbrowser default browser detection and/or public API for _trylist.

[R. David Murray]

R. David Murray added the comment:

Any change is going to be an enhancement, so it will only go in 3.6 (at this 
point...beta/feature freeze for 3.5 is this weekend).

Would you like to propose a patch?

--
nosy: +r.david.murray
stage:  - needs patch
title: webbrowser (very often) doesn't support the 'new' parameter - 
webbrowser default browser detection and/or public API for _trylist.
type: behavior - enhancement
versions: +Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24241
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com