[issue24306] Backport py.exe to 3.4

[Roundup Robot]

Roundup Robot added the comment:

New changeset 6181476b5534 by Steve Dower in branch '3.4':
Issue #24306: Sets component ID for launcher to match 3.5 and later to avoid 
downgrading.
https://hg.python.org/cpython/rev/6181476b5534

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24306] Backport py.exe to 3.4

[Steve Dower]

Changes by Steve Dower :


--
assignee:  -> steve.dower
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24306] Backport py.exe to 3.4

[Steve Dower]

Steve Dower added the comment:

So with the 3.5 launcher being installed all-users by default, the attached 
patch is a good option.

I'm not able to build 3.4 entirely, but I made the modification to the MSI 
directly and it works fine, so I intend to go ahead and apply it (with some 
extra line wrapping for formatting purposes) before 3.4.4

Unfortunately, I believe upgrades from 3.4.3 to 3.4.4 may remove the 3.5 
launcher and then replace it with the 3.4 one. Unfortunately, there's no way to 
prevent this. Subsequently repairing or installing 3.5 should bring back the 
newer one.

Martin - any concerns here?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24306] Backport py.exe to 3.4

[Steve Dower]

Steve Dower added the comment:

Attached a patch to set the component IDs in the 3.4 installer to match the 
ones we're using for 3.5 and later. This should prevent downgrading of the 
launcher in future releases, though it's not strictly the right way to do 
this. (Nosied Martin in case he wants to weigh in on this.) (The right way is 
to have a separate MSI with a matching upgrade code, which is not feasible for 
3.4.)

Unfortunately, it won't help when 3.5 is installed per-user (the default), but 
there's nothing we can do there short of backporting the launcher changes, 
probably selectively to avoid the fixes for the VC10-14 change. (Nosied Larry 
to see if he wants to approve this.)

--
keywords: +patch
nosy: +larry, loewis
Added file: http://bugs.python.org/file39750/24306_1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24306
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24306] Backport py.exe to 3.4

[Larry Hastings]

Larry Hastings added the comment:

Last installed wins isn't perfect, but at least it's predictable.

Is it possible to make the 3.4 installer detect that 3.5+ is installed and not 
install the launcher?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24306
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24306] Backport py.exe to 3.4

[Mark Lawrence]

Mark Lawrence added the comment:

I don't see removing the launcher as an option.  So how about do the backport 
and make certain it's well documented in the release notes and here 
https://docs.python.org/3/using/windows.html ?  If anyone has a better idea 
feel free to fire away.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24306
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24306] Backport py.exe to 3.4

[Steve Dower]

New submission from Steve Dower:

For 3.5 32-bit installs we register in a different key to avoid collisions with 
64-bit installs, but now the 3.4 launcher can't find us.

If you have installed 3.4 for all users (likely) and then install 3.5 
just-for-me (also likely), then you'll continue to get the 3.4 launcher, and 
there's no way to avoid this because there's no option to omit it.

I think we should backport the launcher to 3.4 so that the next 3.4 release 
will be able to also work with 3.5.

Thoughts?

--
components: Windows
messages: 244226
nosy: steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Backport py.exe to 3.4
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24306
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24306] Backport py.exe to 3.4

[Steve Dower]

Steve Dower added the comment:

I didn't mention it initially, but the harm it can do is overriding newer 
versions. The 3.5 and later installers have proper versioning built in, but I 
don't think that's possible with the 3.4 installer as well (due to MSI 
limitations, not any deficiency of the previous authoring).

Of course, we're already in a place where last installed wins, so the only 
other option is to remove the launcher from 3.4 (or all installers...) and 
require a separate installation.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24306
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24306] Backport py.exe to 3.4

[Mark Lawrence]

Mark Lawrence added the comment:

Can it actually do any harm?  It certainly appears to remove the potential for 
a lot of bug reports from a lot of frustrated users, myself included.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24306
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com