[issue24972] IDLE: revisit text highlighting for inactive windows on win32

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
assignee:  -> terry.reedy
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24972] IDLE: revisit text highlighting for inactive windows on win32

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2445750029df by Terry Jan Reedy in branch '3.4':
Issue #24972: Inactive selection background now matches active selection
https://hg.python.org/cpython/rev/2445750029df

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24972] IDLE: revisit text highlighting for inactive windows on win32

[Roundup Robot]

Roundup Robot added the comment:

New changeset 45955adc2ed2 by Terry Jan Reedy in branch '2.7':
Issue #24972: New option is only valid in tk 8.5+.
https://hg.python.org/cpython/rev/45955adc2ed2

New changeset 460e6e6fb09a by Terry Jan Reedy in branch '3.4':
Issue #24972: New option is only valid in tk 8.5+.
https://hg.python.org/cpython/rev/460e6e6fb09a

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24972] IDLE: revisit text highlighting for inactive windows on win32

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4b3356f1a261 by Terry Jan Reedy in branch '2.7':
Issue #24972: Inactive selection background now matches active selection
https://hg.python.org/cpython/rev/4b3356f1a261

New changeset 70c01dd35100 by Terry Jan Reedy in branch '3.4':
Issue #24972: Inactive selection background now matches active selection
https://hg.python.org/cpython/rev/70c01dd35100

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24972] IDLE: revisit text highlighting for inactive windows on win32

[Terry J. Reedy]

Terry J. Reedy added the comment:

I first testing the workaround by selecting text and then clicking on another 
window, and the highlight stayed.  I commented out 
"self._highlight_workaround()", quit, started again, tested again, and the 
highlight disappeared.  I added the new line above, retested, and the 
hightlight stayed.

Debugger source highlighting again does not work for me on Win7 in any 
installed or repository version, before or after the patch. See #25254. The 
patch does immediately fix at least part of the find issue. I will review them 
later.

While the report above implies that I committed to 3.4 and merged forward, 
there is a screw-up in the repository that prevented merging, so I backed out 
the 3.4 patch before pushing.  So only 2.7 is patched and this issue is not 
done.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24972] IDLE: revisit text highlighting for inactive windows on win32

[Terry J. Reedy]

Terry J. Reedy added the comment:

I verified that inactiveselectbackground exists and starts as ''.  Since it 
should match the active selectbackground on all systems, as set by the current 
theme. I will try adding a line where selection colors are set: 
EditorWindow.ResetColorizer:
self.text.config(
...
selectforeground=select_colors['foreground'],
selectbackground=select_colors['background'],
inactiveselectbackground=select_colors['background']
)
I believe this is the only place where this is needed.  The select colors are 
used for a different widget in TreeWidget. The use in ParenMatch for 'paren' 
tag should be temporary.

We will need to reconsider the 'found' highlight and the select versus found 
usage after this change.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24972] IDLE: revisit text highlighting for inactive windows on win32

[Mark Roseman]

Mark Roseman added the comment:

See inactiveselection.patch. This addresses the original bug of the debugger 
not highlighting the correct line, and also various issues with the find 
windows not highlighting the selection they have found, e.g. #22179, #18590

--
keywords: +patch
Added file: http://bugs.python.org/file40396/inactiveselection.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24972] IDLE: revisit text highlighting for inactive windows on win32

[Terry J. Reedy]

Terry J. Reedy added the comment:

Rather than copying the nosy list from an old issue, which likely contains 
people no longer interested, better to announce a followup on the old issue.

I am not sure what you want me to try out.  If it is a code change, please 
upload a patch.  If it is a user action, please specify.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24972] IDLE: revisit text highlighting for inactive windows on win32

[Mark Roseman]

New submission from Mark Roseman:

This is a followup to #14146

I don't think this is actually a Tk bug. The text widget supports an 
"inactiveselectbackground" option which controls the background color of the 
selection when the window is not active. On Win32, this is defined as empty 
(i.e. no highlighting).

This option is new in Tk 8.5. I don't believe that Tk 8.4 displayed the 
selection differently for active and inactive windows, hence why the problem 
never showed up until 8.5. 

It seems that if running 8.5, setting this widget option to the desired color 
would then remove the need for the _highlight_workaround() in EditorWindow.py.  

Can someone else besides me try this out please?

--
components: IDLE
messages: 249422
nosy: Rich.Rauenzahn, Todd.Rovito, dzabel, loewis, markroseman, roger.serwy, 
terry.reedy
priority: normal
severity: normal
status: open
title: IDLE: revisit text highlighting for inactive windows on win32
versions: Python 2.7, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com