[issue25266] mako benchmark not working in Python 3.6

[Antoine Pitrou]

Antoine Pitrou added the comment:

Thanks, Brett and Florin!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25266] mako benchmark not working in Python 3.6

[Roundup Robot]

Roundup Robot added the comment:

New changeset 85edb638dce6 by Brett Cannon in branch 'default':
Issue #25266: the mako benchmark does not work in Python 3.6.
https://hg.python.org/benchmarks/rev/85edb638dce6

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25266] mako benchmark not working in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

Thanks for the patch!

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25266] mako benchmark not working in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

Sorry about that. Confusion of last name with Claudiu Popa from pylint.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25266] mako benchmark not working in Python 3.6

[Florin Papa]

Florin Papa added the comment:

It's OK. I just saw one of Claudiu Popa's issues and figured we have similar 
last names.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25266] mako benchmark not working in Python 3.6

[Florin Papa]

Florin Papa added the comment:

No problem. The name is Florin Papa :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25266] mako benchmark not working in Python 3.6

[STINNER Victor]

STINNER Victor added the comment:

Hum, it would be nice to patch the mako benchmark to replace 
inspect.getargspec() with inspect.signature() (available since Python 3.3).

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25266] mako benchmark not working in Python 3.6

[Florin Papa]

New submission from Florin Papa:

Hi All,

My name is Florin Papa and I work in the Server Languages Optimizations Team at 
Intel Corporation.

I would like to submit a patch that deprecates the mako benchmark for Python 
3.6 and above. The mako benchmark uses inspect.getargspec(), which is 
deprecated and was removed in Python 3.6. Therefore, it crashes with the 
message "AttributeError: module 'inspect' has no attribute 'getargspec'" when 
using the latest version of Python on the default branch.

The patch limits the version range of the mako benchmark to Python 3.5 and 
below.

To apply the patch please follow these steps:

hg clone https://hg.python.org/benchmarks
cd benchmarks/
copy mako_deprecation.patch to the current directory
hg import --no-commit mako_deprecation.patch
 
Regards,
Florin

--
components: Benchmarks
files: mako_deprecation.patch
keywords: patch
messages: 251844
nosy: brett.cannon, florin.papa, pitrou
priority: normal
severity: normal
status: open
title: mako benchmark not working in Python 3.6
type: crash
versions: Python 3.6
Added file: http://bugs.python.org/file40618/mako_deprecation.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25266] mako benchmark not working in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

We should also see if Mako 1.0.2 uses inspect.getargspec() and create a mako2 
benchmark that does the right thing.

As for Victor's suggestion to simply change the code, we have historically 
avoided modifying library code that we use in a benchmark as it changes 
performance and thus invalidates past measurements for comparison purposes. At 
worst we can duplicate the code, make the change, and still create a new 
benchmark.

--
assignee:  -> brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25266] mako benchmark not working in Python 3.6

[Florin Papa]

Florin Papa added the comment:

There is already a mako_v2 benchmark in the Grand Unified Python Benchmarks, 
which does not use inspect.getargspec() and does not crash when using Python 
3.6.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com