[issue25624] shutil.make_archive makes invalid directory entries

Changes by Serhiy Storchaka : -- status: open -> closed ___ Python tracker ___ ___

[issue25624] shutil.make_archive makes invalid directory entries

Larry Hastings added the comment: Like I said--no. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue25624] shutil.make_archive makes invalid directory entries

Changes by Serhiy Storchaka : -- status: closed -> open ___ Python tracker ___ ___

[issue25624] shutil.make_archive makes invalid directory entries

Serhiy Storchaka added the comment: Larry, is this fix included in 3.5.1? -- ___ Python tracker ___ ___

[issue25624] shutil.make_archive makes invalid directory entries

Serhiy Storchaka added the comment: Larry, I think this patch is enough important to go into 3.5.1 final. It fixes a regression in common operation. -- ___ Python tracker

[issue25624] shutil.make_archive makes invalid directory entries

Serhiy Storchaka added the comment: Thank you Benjamin. -- resolution: -> fixed stage: test needed -> resolved status: open -> closed ___ Python tracker

[issue25624] shutil.make_archive makes invalid directory entries

Larry Hastings added the comment: This change didn't make it into 3.5.1. It will be released with 3.5.2. I've already updated the Misc/NEWS entry. -- ___ Python tracker

[issue25624] shutil.make_archive makes invalid directory entries

Roundup Robot added the comment: New changeset 43208b0f2535 by Benjamin Peterson in branch '2.7': Issue #25624: ZipFile now always writes a ZIP_STORED header for directory entries. Patch by Dingyuan Wang. https://hg.python.org/cpython/rev/43208b0f2535 --

[issue25624] shutil.make_archive makes invalid directory entries

Roundup Robot added the comment: New changeset e7d1df56f70b by Serhiy Storchaka in branch '3.4': Issue #25624: ZipFile now always writes a ZIP_STORED header for directory https://hg.python.org/cpython/rev/e7d1df56f70b New changeset 0f8d426e0d0c by Serhiy Storchaka in branch '3.5': Issue #25624:

[issue25624] shutil.make_archive makes invalid directory entries

Serhiy Storchaka added the comment: Thank you for your contribution Dingyuan. Benjamin, I think this fix should be in 2.7.11. It was a regression in 2.7.11 that had made shutil.make_archive() unusable with the zip format. -- nosy: +benjamin.peterson, larry priority: normal -> release

[issue25624] shutil.make_archive makes invalid directory entries

Dingyuan Wang added the comment: Yes, patching zipfile is enough. I wrote a test using `unzip -t` to check the zip. ZipFile.testzip can't detect this kind of error because zlib.decompressobj(-15) will decode b'' to b'' without errors. -- Added file:

[issue25624] shutil.make_archive makes invalid directory entries

Serhiy Storchaka added the comment: Could you add a test Dingyuan? You can take test_zipfile_vs_zip in test_shutil as an example. The patch changes both shutil and zipfile. Aren't only changes to zipfile needed? -- stage: needs patch -> test needed

[issue25624] shutil.make_archive makes invalid directory entries

Dingyuan Wang added the comment: $ mkdir foo; touch foo/a.txt; python3 -c "import shutil; shutil.make_archive('foo', 'zip', base_dir='foo')"; unzip -t foo.zip Archive: foo.zip testing: foo/ error: invalid compressed data to inflate testing: foo/a.txt

[issue25624] shutil.make_archive makes invalid directory entries

New submission from Dingyuan Wang: The _make_zipfile in shutil uses ZIP_DEFLATED compression by default, and the fix introduced by #24982 adds directory entries. In zipfile.ZipFile.write, directories is added as 0 file_size, 0 compress_size, regardless of the compression method. Deflate will

[issue25624] shutil.make_archive makes invalid directory entries

Serhiy Storchaka added the comment: Do you want to provide a patch? -- assignee: -> serhiy.storchaka keywords: +easy stage: -> needs patch ___ Python tracker

[issue25624] shutil.make_archive makes invalid directory entries

SilentGhost added the comment: Can you provide a test? -- nosy: +SilentGhost, serhiy.storchaka, tarek versions: +Python 3.6 ___ Python tracker ___

[issue25624] shutil.make_archive makes invalid directory entries

Dingyuan Wang added the comment: My patch for this. -- keywords: +patch Added file: http://bugs.python.org/file41039/storedirectory.patch ___ Python tracker