[issue25844] Pylauncher, launcher.c: Assigning NULL to a pointer instead of testing against NULL

Roundup Robot added the comment: New changeset 48b3cac0dbcd by Vinay Sajip in branch '3.4': Fixes #25844: Corrected =/== typo potentially leading to crash in launcher. https://hg.python.org/cpython/rev/48b3cac0dbcd -- ___ Python tracker

[issue25844] Pylauncher, launcher.c: Assigning NULL to a pointer instead of testing against NULL

Serhiy Storchaka added the comment: To the fix for this bug we have to provoke the unsufficient memory error just at this point. This is unlikely worth. Thank you Alexander for your reports. -- nosy: +serhiy.storchaka resolution: -> fixed stage: test needed -> resolved status: open

[issue25844] Pylauncher, launcher.c: Assigning NULL to a pointer instead of testing against NULL

Roundup Robot added the comment: New changeset 5015440beec2 by Vinay Sajip in branch '3.4': Fixes #25844: Corrected =/== typo potentially leading to crash in launcher. https://hg.python.org/cpython/rev/5015440beec2 New changeset 9552fcd303fd by Vinay Sajip in branch '3.5': Fixes #25844:

[issue25844] Pylauncher, launcher.c: Assigning NULL to a pointer instead of testing against NULL

Changes by Brett Cannon : -- stage: -> test needed versions: +Python 3.5, Python 3.6 ___ Python tracker ___

[issue25844] Pylauncher, launcher.c: Assigning NULL to a pointer instead of testing against NULL

New submission from Alexander Riccio: I found this while writing up a separate bug (CPython doesn't use static analysis!). In PC/launcher.c, get_env has a bug: /* Large environment variable. Accept some leakage */ wchar_t *buf2 = (wchar_t*)malloc(sizeof(wchar_t) * (result+1));

[issue25844] Pylauncher, launcher.c: Assigning NULL to a pointer instead of testing against NULL

Changes by Alexander Riccio : -- type: -> crash ___ Python tracker ___ ___