[issue26959] pickle: respect dispatch for functions again

Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue26959] pickle: respect dispatch for functions again

Serhiy Storchaka added the comment: Is saving global an atomic operation? Falling back to using reduce can be not safe if some data was written during saving global. That also might make error messages less helpful. Is not founding a function the only cause of PicklingError? Raising and

[issue26959] pickle: respect dispatch for functions again

Vsevolod Velichko added the comment: Hi, any progress here? -- ___ Python tracker ___ ___ Python-bugs-list

[issue26959] pickle: respect dispatch for functions again

Vsevolod Velichko added the comment: I was trying to avoid additional imports in the test. But your point of view seems more reasonable, so I reupload the fixed patch. -- Added file: http://bugs.python.org/file42751/function_pickle.patch ___ Python

[issue26959] pickle: respect dispatch for functions again

Hrvoje Nikšić added the comment: You can simplify pickle_lambda in the test by using marshal.dumps(code_obj) and marshal.loads(code_obj) to dump and load the code object without going through its entire guts. It would be a shame to have to change a pickle test just because some detail of the

[issue26959] pickle: respect dispatch for functions again

Changes by SilentGhost : -- nosy: +alexandre.vassalotti, pitrou stage: -> patch review ___ Python tracker ___

[issue26959] pickle: respect dispatch for functions again

New submission from Vsevolod Velichko: The commit [2] removed support for handling unpicklable functions with copyreg override from cpickle due to lack of the same feature in pickle. This patch restores that feature and adds the support of it to pickle. [1] Original discussion: