[issue27418] Tools/importbench/importbench.py is broken

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27418] Tools/importbench/importbench.py is broken

[Roundup Robot]

Roundup Robot added the comment:

New changeset ba4548916f05 by Serhiy Storchaka in branch '3.5':
Issue #27418: Fixed Tools/importbench/importbench.py.
https://hg.python.org/cpython/rev/ba4548916f05

New changeset c2e898813409 by Serhiy Storchaka in branch 'default':
Issue #27418: Fixed Tools/importbench/importbench.py.
https://hg.python.org/cpython/rev/c2e898813409

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27418] Tools/importbench/importbench.py is broken

[Brett Cannon]

Brett Cannon added the comment:

I don't see anything obviously wrong with it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27418] Tools/importbench/importbench.py is broken

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Following patch seems fixes importbench.

--
keywords: +patch
stage:  -> patch review
Added file: http://bugs.python.org/file43583/importbench.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27418] Tools/importbench/importbench.py is broken

[Brett Cannon]

Brett Cannon added the comment:

Feel free to do whatever you need/want to with the benchmark. I originally 
created it when switching __import__ to importlib to prove that it didn't 
impact performance.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27418] Tools/importbench/importbench.py is broken

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Just now I'm writing a patch for optimizing __import__. Maybe importbench would 
be helpful.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27418] Tools/importbench/importbench.py is broken

[Brett Cannon]

Brett Cannon added the comment:

If you don't have any use for it I say just delete the benchmark.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27418] Tools/importbench/importbench.py is broken

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

$ ./python Tools/importbench/importbench.py
Traceback (most recent call last):
  File "Tools/importbench/importbench.py", line 8, in 
from test.test_importlib.source import util as source_util
ImportError: cannot import name 'util'

--
components: Demos and Tools
messages: 269539
nosy: brett.cannon, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Tools/importbench/importbench.py is broken
type: behavior
versions: Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com