[issue27621] Finish IDLE Query dialog appearance and behavior.

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions: +Python 3.10 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Terry J. Reedy]

Terry J. Reedy added the comment:

#24812 specifically talks about Mac standards.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Terry J. Reedy]

Terry J. Reedy added the comment:

There is still Serhiy's original issue about moving  default with 
focus, plus possible appearance changes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Roundup Robot]

Roundup Robot added the comment:

New changeset f0e86b60de5f by Terry Jan Reedy in branch 'default':
Issue #27621: Put query response validation error messages in query box
https://hg.python.org/cpython/rev/f0e86b60de5f

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Terry J. Reedy]

Terry J. Reedy added the comment:

Actually, the query test failure is posted to #27380

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Terry J. Reedy]

Terry J. Reedy added the comment:

See #27714 for more on the test failure.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Mark Roseman]

Mark Roseman added the comment:

Looks great Terry - thanks. Only nit is that test_click_help_source fails on 
Mac, courtesy a leading 'file://' added in the last few lines of path_ok

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Terry J. Reedy]

Terry J. Reedy added the comment:

I changed showerror from widget to query function, added a second error label 
to Help Source, adjusted validation functions, and rewrote tests.  I also made 
keypad enter work on all systems (it already works in Search and I use it 
often).  I want to look at spacing in a separate pass.

--
Added file: http://bugs.python.org/file43998/query2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Mark Roseman]

Mark Roseman added the comment:

Thanks Terry! I'd be good if you want to put a width back on the buttons, but 
I'd suggest "width=6" rather than using 8 as it was before.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Terry J. Reedy]

Terry J. Reedy added the comment:

The file has the correct format for review, applies cleanly, and tests pass.  
The relief is gone (easy).  The buttons are no longer symmetrical; this looks 
'wrong' to me.  (My reaction might be different if the widget was much wider, 
so the buttons were clearly right-justified rather than looking like their 
placement had a bug.)  This results from using 3 columns instead of 2.  I want 
to try the latter.   I will switch error messages to the widget, see what 
happens, and deal with needed test changes.  I will post before committing so 
you can test on Mac first.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Mark Roseman]

Mark Roseman added the comment:

I've attached query.patch, which does the cosmetic and layout changes, and adds 
a couple Mac-specific things. I've added the inline error message widget but 
don't use it yet (as this will involve changes to the subclasses and the tests, 
given errors will show up when the dialog is running, not after).

Given I'm a bit rusty at this, would appreciate if someone could check this out 
and make sure I did things correctly. :-)

--
Added file: http://bugs.python.org/file43966/query.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Mark Roseman]

Mark Roseman added the comment:

Just to follow up, both Windows and Linux the 'correct' behaviour seems to be 
that space or return activates the button with the current focus. Mac behaves 
differently in that return key always activates default button even if focus is 
on another button (and normally on Mac, buttons don't get focus).

I'll put together a patch that cleans up the layout and does the error label in 
dialog thing.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Terry J. Reedy]

Terry J. Reedy added the comment:

Serhiy: I believe Notepad, Wordpad, Libre Office Write behave as you describe.  
But there are differences in details. So I don't consider issue closed, but it 
is low priority to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Terry J. Reedy]

Terry J. Reedy added the comment:

Background: For Open Module, the old commondialog did not have the asymmetrical 
drop shadow.  That is an unintentional addition (from a frame?) and I don't 
like it.  Perhaps we should use grid instead.  Rows 0 and 1 for the initial 
label and entry, with columnspan 2, rows 8 and 9 for error message and buttons. 
 This leaves room for insertion of path message, path entry, and browse button. 
 Patch welcome.

A definite yes for error label in widget.  I dislike the popup.  Begone!  
Should a blank label reserve space or should it be inserted as needed, making 
box expand.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Mark Roseman]

Mark Roseman added the comment:

Serhiy, the tk_dialog has been superseded by tk_messageBox, and does not 
reflect current platform standards.  I just tried tk_messageBox on the Mac, 
which always activates the default button if you press 'return', even if 
another button has the focus. I expect Windows and X11 are different, and will 
check that out when I get a chance.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

In Tk widgets tk_dialog and tk_messageBox (corresponding Tkinter widgets 
dialog.Dialog and messagebox.Message) pressing Return invokes focused button. 
The comment in tk_dialog implementation:

# 4. Create a binding for  on the dialog if there is a
# default button.
# Convention also dictates that if the keyboard focus moves among the
# the buttons that the  binding affects the button with the focus.

I expected the same behavior in IDLE Query dialog. If this behavior considered 
outdated, I'm nice to close this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Mark Roseman]

Mark Roseman added the comment:

Terry, thanks for the TkDocs correction.

As you'll note from the attached dlgonmac.png, there's a bit of tweaking needed 
with regard to geometry management etc. to get the background right.

Now that ttk is ok (so to speak), would you be open to some patches that fix 
this up, a bit more akin to what you see in the 'query dialog' subsection if 
you scroll down a bit in http://www.tkdocs.com/tutorial/idle.html#idledialogs

Separately, would you be open to a patch changing things to use the "inline" 
error handling illustrated on the goto line dialog on that page (i.e. showing 
error message in query dialog in red vs. popping up an alert)?

Older code for that can be found here btw: 
https://github.com/roseman/idle/blob/master/querydialog.py

--
Added file: http://bugs.python.org/file43940/dlgonmac.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Terry J. Reedy]

Terry J. Reedy added the comment:

I meant to direct the focus ring fix here instead #27620.  To me, this issue is 
done, at least for now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27621] Finish IDLE Query dialog appearance and behavior.

[Terry J. Reedy]

Terry J. Reedy added the comment:

I am not trying to re-invent the wheel.  I am trying to bring IDLE up to 
uniform standards.  In particular, make all dialogs usable from the keyboard.  
The config dialog is the worst. See #27620, the master issue.

For a two button messagebox, I went back to 3.5.2, which still uses the 
commondialog box.  It has the default button marked as such.   always 
does the default action.  always cancels.   moves the focus, but 
does not affect the above.   enters ' ' in text entry and 'clicks' 
buttons.  So this is at least 'a' Windows standard, as well as 'a' Mac standard.

The search dialogs act the same. The space behavior built-in to the TK widgets, 
at least on Windows. I presume this is a class binding.  The dialogs have no 
platform specific code, so they are also the defacto IDLE standard.

Serhiy, it is definitely a tk convention, and I presume more universal than 
that, that the 'default ring' always indicate what button/action is invoked by 
.  If the default moved with the focus, the default ring should move 
also.  I am not inclined to do that without a strong reason.

The button default ring is controlled by the 'default' option" 'active' = 
visible, 'normal' = possible, 'disabled' = not possible.  (From the tk docs.  
The NMT reference is useless here.) I will add "default='active'" for the Ok 
button.

(Mark: "default=1", suggested on http://www.tkdocs.com/widgets/button.html, is 
a nasty bug.  "_tkinter.TclError: bad default "1": must be normal, active, or 
disabled".)

--
title:  incorrectly works in IDLE Query dialogs -> Finish IDLE Query 
dialog appearance and behavior.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com