[issue27621] Finish IDLE Query dialog appearance and behavior.

Change by Terry J. Reedy : -- versions: +Python 3.10 -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27621] Finish IDLE Query dialog appearance and behavior.

Terry J. Reedy added the comment: #24812 specifically talks about Mac standards. -- ___ Python tracker ___

[issue27621] Finish IDLE Query dialog appearance and behavior.

Terry J. Reedy added the comment: There is still Serhiy's original issue about moving default with focus, plus possible appearance changes. -- ___ Python tracker

[issue27621] Finish IDLE Query dialog appearance and behavior.

Roundup Robot added the comment: New changeset f0e86b60de5f by Terry Jan Reedy in branch 'default': Issue #27621: Put query response validation error messages in query box https://hg.python.org/cpython/rev/f0e86b60de5f -- nosy: +python-dev ___ Python

[issue27621] Finish IDLE Query dialog appearance and behavior.

Terry J. Reedy added the comment: Actually, the query test failure is posted to #27380 -- ___ Python tracker ___

[issue27621] Finish IDLE Query dialog appearance and behavior.

Terry J. Reedy added the comment: See #27714 for more on the test failure. -- ___ Python tracker ___ ___

[issue27621] Finish IDLE Query dialog appearance and behavior.

Mark Roseman added the comment: Looks great Terry - thanks. Only nit is that test_click_help_source fails on Mac, courtesy a leading 'file://' added in the last few lines of path_ok -- ___ Python tracker

[issue27621] Finish IDLE Query dialog appearance and behavior.

Terry J. Reedy added the comment: I changed showerror from widget to query function, added a second error label to Help Source, adjusted validation functions, and rewrote tests. I also made keypad enter work on all systems (it already works in Search and I use it often). I want to look at

[issue27621] Finish IDLE Query dialog appearance and behavior.

Mark Roseman added the comment: Thanks Terry! I'd be good if you want to put a width back on the buttons, but I'd suggest "width=6" rather than using 8 as it was before. -- ___ Python tracker

[issue27621] Finish IDLE Query dialog appearance and behavior.

Terry J. Reedy added the comment: The file has the correct format for review, applies cleanly, and tests pass. The relief is gone (easy). The buttons are no longer symmetrical; this looks 'wrong' to me. (My reaction might be different if the widget was much wider, so the buttons were

[issue27621] Finish IDLE Query dialog appearance and behavior.

Mark Roseman added the comment: I've attached query.patch, which does the cosmetic and layout changes, and adds a couple Mac-specific things. I've added the inline error message widget but don't use it yet (as this will involve changes to the subclasses and the tests, given errors will show

[issue27621] Finish IDLE Query dialog appearance and behavior.

Mark Roseman added the comment: Just to follow up, both Windows and Linux the 'correct' behaviour seems to be that space or return activates the button with the current focus. Mac behaves differently in that return key always activates default button even if focus is on another button (and

[issue27621] Finish IDLE Query dialog appearance and behavior.

Terry J. Reedy added the comment: Serhiy: I believe Notepad, Wordpad, Libre Office Write behave as you describe. But there are differences in details. So I don't consider issue closed, but it is low priority to me. -- ___ Python tracker

[issue27621] Finish IDLE Query dialog appearance and behavior.

Terry J. Reedy added the comment: Background: For Open Module, the old commondialog did not have the asymmetrical drop shadow. That is an unintentional addition (from a frame?) and I don't like it. Perhaps we should use grid instead. Rows 0 and 1 for the initial label and entry, with

[issue27621] Finish IDLE Query dialog appearance and behavior.

Mark Roseman added the comment: Serhiy, the tk_dialog has been superseded by tk_messageBox, and does not reflect current platform standards. I just tried tk_messageBox on the Mac, which always activates the default button if you press 'return', even if another button has the focus. I expect

[issue27621] Finish IDLE Query dialog appearance and behavior.

Serhiy Storchaka added the comment: In Tk widgets tk_dialog and tk_messageBox (corresponding Tkinter widgets dialog.Dialog and messagebox.Message) pressing Return invokes focused button. The comment in tk_dialog implementation: # 4. Create a binding for on the dialog if there is a #

[issue27621] Finish IDLE Query dialog appearance and behavior.

Mark Roseman added the comment: Terry, thanks for the TkDocs correction. As you'll note from the attached dlgonmac.png, there's a bit of tweaking needed with regard to geometry management etc. to get the background right. Now that ttk is ok (so to speak), would you be open to some patches

[issue27621] Finish IDLE Query dialog appearance and behavior.

Terry J. Reedy added the comment: I meant to direct the focus ring fix here instead #27620. To me, this issue is done, at least for now. -- ___ Python tracker

[issue27621] Finish IDLE Query dialog appearance and behavior.

Terry J. Reedy added the comment: I am not trying to re-invent the wheel. I am trying to bring IDLE up to uniform standards. In particular, make all dialogs usable from the keyboard. The config dialog is the worst. See #27620, the master issue. For a two button messagebox, I went back to