[issue28111] geometric_mean can raise OverflowError for large input length

Mark Dickinson added the comment: Thanks, @Irit. Yes, this is about a different version of geometric_mean that didn't end up making it into any release. -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker

[issue28111] geometric_mean can raise OverflowError for large input length

Irit Katriel added the comment: I can't reproduce this now (tried on mac and windows): >>> statistics.geometric_mean([0.7 for _ in range(5000)]) 0.7 The current geometric_mean was added in PR12638. Is this issue about a previous version? -- nosy: +iritkatriel

[issue28111] geometric_mean can raise OverflowError for large input length

Changes by Steven D'Aprano : -- versions: -Python 3.6 ___ Python tracker ___ ___

[issue28111] geometric_mean can raise OverflowError for large input length

Mark Dickinson added the comment: Whoops; that patch was incomplete (it was missing the change to the geometric_mean function itself). Here's an updated patch. -- Added file: http://bugs.python.org/file44946/geometric_mean_long_input_v2.py ___

[issue28111] geometric_mean can raise OverflowError for large input length

Mark Dickinson added the comment: And here's the actual patch. :-) -- Added file: http://bugs.python.org/file44944/geometric_mean_long_input.py ___ Python tracker

[issue28111] geometric_mean can raise OverflowError for large input length

Changes by Mark Dickinson : -- versions: +Python 3.7 ___ Python tracker ___ ___

[issue28111] geometric_mean can raise OverflowError for large input length

Mark Dickinson added the comment: The attached patch provides a fix, and is based partly on Tim Peters' suggestions and code from the issue 27761 discussion. It needs tests. For convenience, it includes the fix for #28327, since it needs the `_frexp_gen` function added there. --

[issue28111] geometric_mean can raise OverflowError for large input length

Changes by Mark Dickinson : -- title: geometric_mean can raise OverflowError when checking for inf -> geometric_mean can raise OverflowError for large input length ___ Python tracker